belt 0.3.39 → 0.3.40

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e529a712ad25eb12761d155d77b9a62f4342858c9b2272713edd0eef36ce7b6c
-  data.tar.gz: e1e38c997a9bcfc0f454315915412cc4911cd832771cb389e8733b64d082fac9
+  metadata.gz: 848174ed726800ea7e2a60b16a43714e558bf8adae32017a195a4ef0982cff11
+  data.tar.gz: 3d71874ef9d72422b72059e768de032b07caeb9b719bfaaf307d5d4d634b48ee
 SHA512:
-  metadata.gz: 4f2dbd95f0dfe51d250baeed09aa65d0704fbe783b67054b61f8eb6d46519c1fc0ebad6c641db6a5bd76fe75acd2f7a74a60abca16589b4e89da1dcb1d796bc2
-  data.tar.gz: 462ba513dc663920b9cdd8af7fe12632d541c99f14234e8b43c4dd6e706de16995852a72781f38a572e3aa92f78111e304a924e92e8e03eb791a80209163df2b
+  metadata.gz: f431f7d645a3e94cdbf799f0d6fdd44a817491fd991da85b3bce7df95e760359638b1eeb528b39f3dc33edc51a324f4d0a4627152e0e4c025749020b3549ab91
+  data.tar.gz: 59fc7c275194d8ac49c4f69a0eb0109dcdf516eb1f6f597d5c7a9a5f0e16046d2d0dd6c88920c94c58735e643a0e231b3ce331fa919a7bc1d240c91ecb710c2f

data/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## 0.3.40
+
+### Breaking Change
+
+- **Rails-style `{id}` for member routes**: Member routes (show, update, destroy)
+  now use `{id}` instead of `{singular_id}`. This matches Rails conventions where
+  the resource being operated on uses `:id`, and only parent resources use prefixed
+  names like `:project_id`.
+
+  Before:
+  ```
+  GET  /projects/{project_id}
+  GET  /projects/{project_id}/epics/{epic_id}
+  ```
+
+  After:
+  ```
+  GET  /projects/{id}
+  GET  /projects/{project_id}/epics/{id}
+  ```
+
+  Parent resources in nested routes still use `{singular_id}` (e.g., `{project_id}`,
+  `{epic_id}` when they are parents of nested resources).
+
 ## 0.3.39
 
 ### Enhancement

data/lib/belt/route_dsl.rb

@@ -251,7 +251,8 @@ module Belt
       end
     end
 
-    def add_nested_resource_routes(resource_name, param_name, resource_options, actions)
+    def add_nested_resource_routes(resource_name, _param_name, resource_options, actions)
+      # Member routes (show/update/destroy) use {id}, not {singular_id} — Rails convention
       if actions.include?(:index)
         @gateway.send(:add_route, :get, "#{@prefix}/#{resource_name}",
                       resolve_request_model_for(resource_options, :index))
@@ -261,16 +262,16 @@ module Belt
                       resolve_request_model_for(resource_options, :create))
       end
       if actions.include?(:show)
-        @gateway.send(:add_route, :get, "#{@prefix}/#{resource_name}/{#{param_name}}",
+        @gateway.send(:add_route, :get, "#{@prefix}/#{resource_name}/{id}",
                       resolve_request_model_for(resource_options, :show))
       end
       if actions.include?(:update)
-        @gateway.send(:add_route, :put, "#{@prefix}/#{resource_name}/{#{param_name}}",
+        @gateway.send(:add_route, :put, "#{@prefix}/#{resource_name}/{id}",
                       resolve_request_model_for(resource_options, :update))
       end
       return unless actions.include?(:destroy)
 
-      @gateway.send(:add_route, :delete, "#{@prefix}/#{resource_name}/{#{param_name}}",
+      @gateway.send(:add_route, :delete, "#{@prefix}/#{resource_name}/{id}",
                     resolve_request_model_for(resource_options, :destroy))
     end
 
@@ -496,7 +497,8 @@ module Belt
       options.merge(tables: [resource_name.to_sym])
     end
 
-    def add_resource_routes(resource_name, param_name, resource_options, actions)
+    def add_resource_routes(resource_name, _param_name, resource_options, actions)
+      # Member routes (show/update/destroy) use {id}, not {singular_id} — Rails convention
       if actions.include?(:index)
         add_route(:get, "/#{resource_name}",
                   resolve_request_model_for(resource_options, :index))
@@ -506,16 +508,16 @@ module Belt
                   resolve_request_model_for(resource_options, :create))
       end
       if actions.include?(:show)
-        add_route(:get, "/#{resource_name}/{#{param_name}}",
+        add_route(:get, "/#{resource_name}/{id}",
                   resolve_request_model_for(resource_options, :show))
       end
       if actions.include?(:update)
-        add_route(:put, "/#{resource_name}/{#{param_name}}",
+        add_route(:put, "/#{resource_name}/{id}",
                   resolve_request_model_for(resource_options, :update))
       end
       return unless actions.include?(:destroy)
 
-      add_route(:delete, "/#{resource_name}/{#{param_name}}", resolve_request_model_for(resource_options, :destroy))
+      add_route(:delete, "/#{resource_name}/{id}", resolve_request_model_for(resource_options, :destroy))
     end
 
     def resolve_request_model_for(options, action)
@@ -797,7 +799,8 @@ module Belt
         end
       end
 
-      def add_scoped_resource_routes(resource_name, param_name, resource_options, actions)
+      def add_scoped_resource_routes(resource_name, _param_name, resource_options, actions)
+        # Member routes (show/update/destroy) use {id}, not {singular_id} — Rails convention
         if actions.include?(:index)
           @gateway.send(:add_route, :get, build_path("/#{resource_name}"),
                         resolve_request_model_for(resource_options, :index))
@@ -807,16 +810,16 @@ module Belt
                         resolve_request_model_for(resource_options, :create))
         end
         if actions.include?(:show)
-          @gateway.send(:add_route, :get, build_path("/#{resource_name}/{#{param_name}}"),
+          @gateway.send(:add_route, :get, build_path("/#{resource_name}/{id}"),
                         resolve_request_model_for(resource_options, :show))
         end
         if actions.include?(:update)
-          @gateway.send(:add_route, :put, build_path("/#{resource_name}/{#{param_name}}"),
+          @gateway.send(:add_route, :put, build_path("/#{resource_name}/{id}"),
                         resolve_request_model_for(resource_options, :update))
         end
         return unless actions.include?(:destroy)
 
-        @gateway.send(:add_route, :delete, build_path("/#{resource_name}/{#{param_name}}"),
+        @gateway.send(:add_route, :delete, build_path("/#{resource_name}/{id}"),
                       resolve_request_model_for(resource_options, :destroy))
       end
 

data/lib/belt/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Belt
-  VERSION = '0.3.39'
+  VERSION = '0.3.40'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: belt
 version: !ruby/object:Gem::Version
-  version: 0.3.39
+  version: 0.3.40
 platform: ruby
 authors:
 - Stowzilla