belt 0.2.8 → 0.2.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ad9e95cd921b5bf91ffd28544086a895e49ce04a59e4a6b62d64cb9b1ec7bd1
-  data.tar.gz: 7e8795bcfc4e7941f5bd6b426a509ada6dd8d931c39b2af777e0725e8a78e021
+  metadata.gz: 4a550043d0d16c901e656de4a9d89a0f473d77778121e2b27fb8791f3edf74d4
+  data.tar.gz: f9404b6e69d725650ee612af06b96917886d2856fca14955bb99cb9555811dcd
 SHA512:
-  metadata.gz: d228ac8ae6a440aa17c56b5ab16e48ebda349666b5b22d08456d5c99df4a66f47461031d48d049f81cd8c9d6253d9aa410e8ffa25a45998296ec5c3af524a651
-  data.tar.gz: 943b4993668f4c3be7ede7ff7dda63f7e4682906af122632fba1fe3ef66b257ee3970d93383dfe7fbd8df1d88a4852f1cbdaca37f2beac8db26ad0c995d75230
+  metadata.gz: e719bed32a829bf952c22885d63a1415ea292c3b1770a7f7bdb398ef874a5182a1b8208654e2672d6d7fcccbb4b2e9f24a82186708ed3982d9ca7ec94d9bedbf
+  data.tar.gz: 32fa436e2a97b5d3597af8d2afcfb8657c5de91f12a01b551d8368be97a80fdfd544e5b6b711a930ff741c1e8228d393088893700f13c719b454b59e01c3d6a0

data/CHANGELOG.md

@@ -1,5 +1,92 @@
 # Changelog
 
+## 0.2.10
+
+### Quiet `belt new` (with optional verbose)
+
+`belt new` prints a short phase summary by default (skeleton, environments, frontend,
+bundle, state bucket) instead of every path plus AWS/npm noise.
+
+Use `-v` / `--verbose` for Rails-style per-file `create` lines when you want the
+inventory. Nested generators skip their own next-steps banners; the final success
+block still owns next steps. State-bucket setup stays non-interactive either way.
+
+### State bucket naming (global uniqueness)
+
+S3 bucket names are a **global** namespace across all AWS accounts. The previous default
+`belt-terraform-state` only works for the first account that creates it — everyone else
+hits "owned by a different AWS account".
+
+**Fix:** shared bucket is still one-per-account (all apps share it), but the name is now:
+
+```
+belt-terraform-state-<account_id>
+```
+
+- Still one bucket for all belt apps in an account (state key: `<app>/<env>/terraform.tfstate`)
+- `--bucket` still overrides when you want a custom name
+- `belt setup state` rewrites `backend.tf` with the resolved name
+- Existing installs that already own `belt-terraform-state` can keep using `--bucket belt-terraform-state`
+
+### Implicit responses (Rails-style assigns)
+
+Controllers can set instance variables and skip the explicit `success_response` call:
+
+```ruby
+def index
+  @posts = Post.all
+end
+
+def show
+  @post = Post.find(params[:id])
+end
+```
+
+Belt auto-builds `success_response({ posts: [...] })` / `{ post: {...} }` from assigns set
+during the action. Serialization:
+
+- Models → `to_h` (ActiveItem already defines this)
+- `ActiveItem::Relation` / Enumerable → map each record via `to_h`
+- Nested hashes/arrays recurse
+
+Explicit `success_response` / `error_response` / `html_response` / `render` / `head` still win
+when returned. Rescue handlers still use `error_response`.
+
+### Default format (`:json` / `:html`)
+
+```ruby
+# App-wide (lambda/config/environment.rb)
+Belt.configure do |c|
+  c.default_format = :json   # default — API first
+end
+
+# Per-controller override (inherits down the chain)
+class PagesController < ApplicationController
+  self.default_format = :html
+end
+```
+
+| `default_format` | Implicit response (no explicit helper) |
+|---|---|
+| `:json` (default) | `success_response` from assigns |
+| `:html` | `render` template `views/<controller>/<action>.html.erb` (missing → `TemplateNotFound`) |
+
+### Symbol status codes, `head`, `response_status`
+
+```ruby
+success_response({ post: post.to_h }, :created)   # 201
+error_response("Nope", :unprocessable_entity)     # 422
+head :no_content                                  # 204 empty body
+head :created                                     # 201 empty body
+
+def create
+  @post = Post.create!(...)
+  response_status :created   # 201 + implicit assigns body
+end
+```
+
+Bare integers still work. Symbols match the Rack/Rails names (`:created`, `:not_found`, …).
+
 ## 0.3.0
 
 ### Pre-Deploy Backups

data/README.md

@@ -71,24 +71,31 @@ require "belt"
 class PostsController < BeltController::Base
   before_action :authenticate!
 
+  # Implicit response: assigns become the JSON body
+  # → { "posts": [ { "id": "...", "title": "..." }, ... ] }
   def index
-    posts = Post.where(user_id: current_user_id, index: "UserIndex")
-    success_response(posts.map(&:attributes))
+    @posts = Post.where(user_id: current_user_id, index: "UserIndex")
   end
 
   def show
-    post = Post.find(params["id"])
-    success_response(post.attributes)
+    @post = Post.find(params["id"])
   end
 
+  # Implicit body + non-200 status
   def create
     attrs = params.require(:post).permit(:title, :body).to_h
-    post = Post.create!(attrs.merge(user_id: current_user_id))
-    success_response(post.attributes, 201)
+    @post = Post.create!(attrs.merge(user_id: current_user_id))
+    response_status :created
+  end
+
+  def destroy
+    Post.find(params["id"]).destroy
+    head :no_content
   end
 end
 ```
 
+
 ### 4. Lambda entry point
 
 Use `Belt::LambdaHandler` to get automatic observability, CORS preflight handling, and error wrapping:
@@ -199,9 +206,42 @@ end
 
 ```ruby
 success_response({ id: "123", name: "Example" })       # 200 JSON with CORS
-success_response({ id: "123" }, 201)                    # 201 Created
-error_response("Not found", 404)                        # 404 JSON error
+success_response({ id: "123" }, :created)               # 201 Created (symbol or int)
+error_response("Not found", :not_found)                 # 404 JSON error
+error_response("Nope", :unprocessable_entity)           # 422
 html_response("<h1>Hello</h1>")                         # 200 HTML with CORS
+head :no_content                                        # 204 empty body
+head :created                                           # 201 empty body
+```
+
+### Default format (API vs HTML)
+
+```ruby
+# App-wide — typically in lambda/config/environment.rb
+Belt.configure do |config|
+  config.default_format = :json   # default
+end
+
+# Per-controller override
+class PagesController < ApplicationController
+  self.default_format = :html
+end
+```
+
+- **`:json`** (default): action assigns → `success_response({ posts: [...] })`
+- **`:html`**: action assigns stay on the controller; Belt implicitly `render`s
+  `views/<controller>/<action>.html.erb`. Missing template raises `Belt::TemplateNotFound`
+  (no silent JSON fallback).
+- Explicit helpers always win: `success_response`, `error_response`, `html_response`,
+  `render`, `head`.
+
+### Non-200 with implicit assigns
+
+```ruby
+def create
+  @post = Post.create!(...)
+  response_status :created   # → 201 + { post: {...} }
+end
 ```
 
 ## Controller Discovery

data/lib/belt/action_router.rb

@@ -165,7 +165,7 @@ module Belt
     def error_response(message, status_code, event = nil)
       origin = Belt::Helpers::CorsOrigin.resolve_origin(Belt::Helpers::CorsOrigin.origin_from_event(event))
       headers = {
-        'Access-Control-Allow-Headers' => 'Content-Type,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token',
+        'Access-Control-Allow-Headers' => 'Content-Type,Accept,X-Amz-Date,Authorization,X-Api-Key,X-Amz-Security-Token',
         'Access-Control-Allow-Methods' => 'GET,POST,PUT,DELETE,PATCH,OPTIONS',
         'Content-Type' => 'application/json'
       }

data/lib/belt/assets/welcome.css

@@ -1,82 +1,136 @@
 * { margin: 0; padding: 0; box-sizing: border-box; }
+html, body {
+  height: 100%;
+}
 body {
   font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, sans-serif;
-  background: #f8f9fa;
+  background: #0b1220;
   color: #2d3748;
   min-height: 100vh;
+  overflow: hidden;
 }
 
-/* Hero section — full width background image */
+/* Hero fills the viewport — all content lives in the overlay (no scroll) */
 .hero {
   position: relative;
   width: 100%;
+  height: 100vh;
   overflow: hidden;
 }
 .hero-bg {
   width: 100%;
-  height: auto;
+  height: 100%;
+  object-fit: cover;
+  /* Pin the logo / sky — crop hills at the bottom if the viewport is short */
+  object-position: top center;
   display: block;
 }
 .overlay {
   position: absolute;
-  top: 35%;
+  top: 50%;
   left: 50%;
   transform: translate(-50%, -50%);
-  padding: 2rem 3rem;
-  background: rgba(255, 255, 255, 0.50);
-  backdrop-filter: blur(6px);
-  -webkit-backdrop-filter: blur(6px);
-  border-radius: 12px;
+  padding: 1.35rem 1.6rem 1.25rem;
+  background: rgba(255, 255, 255, 0.55);
+  backdrop-filter: blur(8px);
+  -webkit-backdrop-filter: blur(8px);
+  border-radius: 14px;
   text-align: center;
-  max-width: 600px;
-  width: 90%;
-  box-shadow: 0 4px 20px rgba(0, 0, 0, 0.1);
+  max-width: 560px;
+  width: min(92vw, 560px);
+  max-height: min(92vh, 620px);
+  overflow: auto;
+  box-shadow: 0 8px 32px rgba(0, 0, 0, 0.18);
 }
 .overlay h1 {
-  font-size: 2.2rem;
+  font-size: 1.85rem;
   font-weight: 700;
   color: #2d3748;
-  margin-bottom: 0.4rem;
+  margin-bottom: 0.3rem;
+  line-height: 1.2;
 }
 .overlay .subtitle {
-  font-size: 1.1rem;
+  font-size: 0.95rem;
   color: #4a5568;
+  line-height: 1.4;
 }
 
-/* Content below the hero */
-.container {
-  max-width: 700px;
-  margin: 0 auto;
-  padding: 2rem;
-}
+/* Stack + next steps sit inside the white card */
 .stack-check {
   display: flex;
   align-items: center;
   justify-content: center;
-  gap: 0.75rem;
-  margin-bottom: 2rem;
+  gap: 0.4rem;
+  margin: 1rem 0 0.85rem;
   flex-wrap: wrap;
 }
 .check-item {
   display: flex;
   align-items: center;
-  gap: 0.4rem;
-  padding: 0.5rem 1rem;
+  gap: 0.35rem;
+  padding: 0.35rem 0.7rem;
   border-radius: 8px;
   font-weight: 500;
+  font-size: 0.88rem;
 }
 .check-pass {
-  background: rgba(39, 174, 96, 0.1);
-  border: 1px solid rgba(39, 174, 96, 0.3);
+  background: rgba(39, 174, 96, 0.12);
+  border: 1px solid rgba(39, 174, 96, 0.35);
   color: #1e8449;
 }
+/* Optional / empty DynamoDB — not an error, just not in use yet */
+.check-neutral {
+  background: rgba(113, 128, 150, 0.1);
+  border: 1px solid rgba(113, 128, 150, 0.28);
+  color: #4a5568;
+}
 .check-warn {
   background: rgba(243, 156, 18, 0.1);
   border: 1px solid rgba(243, 156, 18, 0.3);
   color: #d68910;
 }
-.icon { font-size: 1.1rem; }
-.arrow { color: #718096; font-size: 1.2rem; }
+.icon { font-size: 1rem; }
+.arrow { color: #718096; font-size: 1.05rem; }
+
+.next-steps {
+  text-align: left;
+  border-top: 1px solid rgba(45, 55, 72, 0.12);
+  padding-top: 0.75rem;
+  margin-top: 0.15rem;
+}
+.next-steps h2 {
+  font-size: 0.92rem;
+  margin-bottom: 0.45rem;
+  color: #2d3748;
+  text-align: left;
+}
+.next-steps ol {
+  padding-left: 1.2rem;
+  margin: 0;
+}
+.next-steps li {
+  margin-bottom: 0.4rem;
+  color: #4a5568;
+  line-height: 1.4;
+  font-size: 0.88rem;
+}
+.next-steps li:last-child { margin-bottom: 0; }
+.next-steps code,
+.info code {
+  background: rgba(99, 45, 145, 0.1);
+  padding: 0.12rem 0.35rem;
+  border-radius: 4px;
+  color: #632d91;
+  font-size: 0.78rem;
+  word-break: break-word;
+}
+
+/* Legacy blocks (local server welcome, older layouts) */
+.container {
+  max-width: 700px;
+  margin: 0 auto;
+  padding: 2rem;
+}
 .info {
   background: #ffffff;
   border: 1px solid #e2e8f0;
@@ -87,26 +141,44 @@ body {
 .info p { margin-bottom: 0.5rem; color: #4a5568; }
 .info p:last-child { margin-bottom: 0; }
 .info strong { color: #2d3748; }
-.info code {
-  background: rgba(99, 45, 145, 0.08);
-  padding: 0.15rem 0.4rem;
+.dynamodb-hint {
+  text-align: center;
+  margin: 0.5rem 0;
+  color: #4a5568;
+  font-size: 0.9rem;
+  line-height: 1.45;
+}
+.dynamodb-hint code {
+  background: rgba(99, 45, 145, 0.1);
+  padding: 0.12rem 0.35rem;
   border-radius: 4px;
   color: #632d91;
-  font-size: 0.85rem;
+  font-size: 0.8rem;
+  word-break: break-word;
 }
-.next-steps {
-  background: #ffffff;
-  border: 1px solid #e2e8f0;
-  border-radius: 12px;
-  padding: 1.5rem;
+.footer-note {
+  margin-top: 0.75rem;
+  padding-top: 0.65rem;
+  border-top: 1px solid rgba(45, 55, 72, 0.1);
+  font-size: 0.78rem;
+  color: #718096;
+  text-align: center;
 }
-.next-steps h2 { font-size: 1.1rem; margin-bottom: 1rem; color: #2d3748; }
-.next-steps ol { padding-left: 1.5rem; }
-.next-steps li { margin-bottom: 0.6rem; color: #4a5568; line-height: 1.5; }
-.next-steps code {
-  background: rgba(99, 45, 145, 0.08);
-  padding: 0.15rem 0.4rem;
-  border-radius: 4px;
-  color: #632d91;
-  font-size: 0.85rem;
+.footer-note code {
+  background: rgba(45, 55, 72, 0.06);
+  padding: 0.08rem 0.3rem;
+  border-radius: 3px;
+  color: #4a5568;
+}
+
+/* Tiny viewports: shrink type a bit so everything still fits */
+@media (max-height: 640px) {
+  .overlay {
+    padding: 1rem 1.15rem;
+  }
+  .overlay h1 { font-size: 1.5rem; }
+  .overlay .subtitle { font-size: 0.88rem; }
+  .stack-check { margin: 0.7rem 0 0.55rem; }
+  .check-item { padding: 0.28rem 0.55rem; font-size: 0.8rem; }
+  .next-steps li { font-size: 0.82rem; }
 }

data/lib/belt/cli/backup_runner.rb

@@ -14,7 +14,7 @@ module Belt
         @infra_dir = infra_dir
         @app_name = app_name
         @timestamp = Time.now.strftime('%Y%m%d-%H%M%S')
-        @backup_bucket = "#{@app_name}-backups-#{@env}"
+        @backup_bucket = sanitize_bucket_name("#{@app_name}-backups-#{@env}")
         @errors = []
         @summary = []
       end
@@ -41,6 +41,8 @@ module Belt
 
         puts "  📦 Creating backup bucket: #{@backup_bucket}"
 
+        errors_before = @errors.size
+
         run_aws('s3', 'mb', "s3://#{@backup_bucket}", '--region', detect_region)
 
         # Enable versioning
@@ -54,7 +56,11 @@ module Belt
                 '--public-access-block-configuration',
                 'BlockPublicAcls=true,IgnorePublicAcls=true,BlockPublicPolicy=true,RestrictPublicBuckets=true')
 
-        puts '  ✅ Backup bucket created and secured'
+        if @errors.size > errors_before
+          puts '  ⚠️  Backup bucket creation failed (see warnings below)'
+        else
+          puts '  ✅ Backup bucket created and secured'
+        end
       end
 
       # ─── DynamoDB ────────────────────────────────────────────────────
@@ -153,11 +159,11 @@ module Belt
 
       def export_cognito_users(pool_id)
         all_users = []
-        pagination_token = nil
+        next_token = nil
 
         loop do
-          args = ['aws', 'cognito-idp', 'list-users', '--user-pool-id', pool_id, '--max-results', '60']
-          args += ['--pagination-token', pagination_token] if pagination_token
+          args = ['aws', 'cognito-idp', 'list-users', '--user-pool-id', pool_id, '--max-items', '60']
+          args += ['--starting-token', next_token] if next_token
 
           output, status = Open3.capture2(*args)
           break unless status.success?
@@ -165,8 +171,8 @@ module Belt
           data = JSON.parse(output)
           all_users.concat(data['Users'] || [])
 
-          pagination_token = data['PaginationToken']
-          break if pagination_token.nil? || pagination_token.empty?
+          next_token = data['NextToken']
+          break if next_token.nil? || next_token.empty?
 
           puts '    Fetching next page of users...'
         end
@@ -327,69 +333,41 @@ module Belt
         end
       end
 
-      # ─── Terraform Output Resolution ─────────────────────────────────
+      # ─── Table Discovery ──────────────────────────────────────────────
 
       def resolve_table_names
-        @resolve_table_names ||= fetch_table_names_from_terraform
+        @resolve_table_names ||= discover_tables_from_aws
       end
 
-      def fetch_table_names_from_terraform
-        env_dir = File.join(@infra_dir, @env)
-        return [] unless Dir.exist?(env_dir)
-
-        Dir.chdir(env_dir) do
-          names = try_terraform_table_output
-          return names if names
+      def discover_tables_from_aws
+        # List all DynamoDB tables matching the app-env prefix directly from AWS.
+        # This is the source of truth — no Terraform output maintenance required.
+        prefix = "#{@app_name}-#{@env}-"
+        sanitized_prefix = sanitize_bucket_name(prefix)
 
-          fetch_table_names_from_all_outputs
-        end
-      end
-
-      def try_terraform_table_output
-        output, status = Open3.capture2('terraform', 'output', '-json', 'dynamodb_table_names')
-        return nil unless status.success?
-
-        names = begin
-          JSON.parse(output)
-        rescue StandardError
-          nil
+        output, status = Open3.capture2('aws', 'dynamodb', 'list-tables', '--output', 'json')
+        unless status.success?
+          @errors << 'Failed to list DynamoDB tables from AWS'
+          return []
         end
-        names.is_a?(Array) && names.any? ? Array(names) : nil
-      end
-
-      def fetch_table_names_from_all_outputs
-        output, status = Open3.capture2('terraform', 'output', '-json')
-        return [] unless status.success?
 
-        all_outputs = begin
-          JSON.parse(output)
+        all_tables = begin
+          JSON.parse(output)['TableNames'] || []
         rescue StandardError
-          {}
-        end
-
-        # Look for dynamodb_table_names in output
-        if all_outputs['dynamodb_table_names']
-          val = all_outputs['dynamodb_table_names']['value']
-          return Array(val) if val
+          []
         end
 
-        # Try to find any output that looks like table names
-        all_outputs.each do |key, data|
-          next unless key.include?('table')
-
-          val = data['value']
-          return Array(val) if val.is_a?(Array) && val.any?
-        end
-
-        []
+        all_tables.select { |t| t.start_with?(prefix) || t.start_with?(sanitized_prefix) }
       end
 
+      # ─── Terraform Output Resolution ─────────────────────────────────
+
       def resolve_cognito_pool_id
         env_dir = File.join(@infra_dir, @env)
         return nil unless Dir.exist?(env_dir)
 
         Dir.chdir(env_dir) do
-          output, status = Open3.capture2('terraform', 'output', '-json', 'user_pool_id')
+          output, status = Open3.capture2('terraform', 'output', '-json', 'user_pool_id', err: File::NULL)
           if status.success?
             val = begin
               JSON.parse(output)
@@ -400,7 +378,7 @@ module Belt
           end
 
           # Fallback: search all outputs
-          output, status = Open3.capture2('terraform', 'output', '-json')
+          output, status = Open3.capture2('terraform', 'output', '-json', err: File::NULL)
           if status.success?
             all_outputs = begin
               JSON.parse(output)
@@ -477,6 +455,11 @@ module Belt
 
       # ─── Helpers ─────────────────────────────────────────────────────
 
+      def sanitize_bucket_name(name)
+        # S3 bucket names must be DNS-compliant: lowercase, hyphens, no underscores
+        name.tr('_', '-').downcase.gsub(/[^a-z0-9\-.]/, '-').gsub(/-{2,}/, '-')
+      end
+
       def short_table_name(table_name)
         table_name.sub(/\A#{Regexp.escape(@app_name)}-#{Regexp.escape(@env)}-/, '')
       end

data/lib/belt/cli/bucket_security.rb

@@ -71,20 +71,26 @@ module Belt
       def harden_bucket(bucket, audit)
         unless audit[:versioning]
           enable_versioning(bucket)
-          puts '  enable  versioning'
+          say_security '  enable  versioning'
         end
         unless audit[:encryption]
           enable_encryption(bucket)
-          puts '  enable  AES-256 encryption'
+          say_security '  enable  AES-256 encryption'
         end
         unless audit[:public_access_block]
           block_public_access(bucket)
-          puts '  enable  public access block'
+          say_security '  enable  public access block'
         end
         return if audit[:tls_policy]
 
         apply_tls_policy(bucket)
-        puts '  enable  TLS-only bucket policy'
+        say_security '  enable  TLS-only bucket policy'
+      end
+
+      def say_security(message)
+        return if respond_to?(:say, true) && @quiet
+
+        puts message
       end
 
       private