bellman 0.1.0 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a729b18b61a082bb6b7c2614885528357e7f4f7c0b04c8059067b86d4ed18c8e
-  data.tar.gz: 4f6247d06e4a57523b0dfd7ecd33f6502bc82ada83e1e596961cdbbee9c04f88
+  metadata.gz: c65c02d5ddc7dc46aba77a42fc162c5f35b77bba264a990cc5c66580fd5bd397
+  data.tar.gz: 484d19f9b7546a31599afef4184ecff5a9ef43e24bd6dd46294c532a02707815
 SHA512:
-  metadata.gz: 9e515a69379105d8399709472777ef11070c0514cf9f6e1c97a4557cfc2eec9786d3ac666f02a4fe9c8efff00f0bcb2d051de06b4623a923c7e59b9d50338b62
-  data.tar.gz: 0a2dd55ed8d89d9fc43da2db58844a71fa93e699f5536ffb6d36d8aec93ee54a7ceca4bc2e6f56d2446f78616f418af9b8585753cee47ac94fa0430911f0ff12
+  metadata.gz: '03491319b209b2994b3329c12aafa4aba3ea3b09bb3046aff6cfc4d0899797748f591384ddc3b6e2df713a00bc7e6921c1b44ef1aa7e2c64d79d6d8a4bf2e2bb'
+  data.tar.gz: 80961f465408e2880701fc8f41f9a21157fa989da5c6d2231f8c53b891bea76ede01177d464c3eaa3962191a028b16e9168cd1f34e30f0de62abfc02ed435918

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bellman (0.1.0)
+    bellman (0.1.2)
       activerecord (> 4.2.0)
       activesupport (> 4.2.0)
 

data/README.md

@@ -81,6 +81,12 @@ For example, here is a common configuration for when an application uses the Rai
 ```ruby
 Bellman.configure do |config|
   config.default_severity = :error
+
+  # Anything other than :raise will set the severity level to the default
+  # severity if an unkown one is past. By default Bellman will raise an error
+  # so that you can catch your mistakes in development
+  config.on_unknown_severity = :raise  
+  
   config.handlers = [
       {
         id: :log,

data/lib/bellman/bellman.rb

@@ -19,6 +19,7 @@ module Bellman
     # Set the defaults
     config.severities = %i[debug info warn error fatal].freeze
     config.default_severity = :error
+    config.on_unknown_severity = :raise
     config.handlers = [
       {
         id: :log,
@@ -38,12 +39,12 @@ module Bellman
     @handler = Handlers::Handler.new
   end
 
-  def self.handler
-    @handler
-  end
-
-  def self.error_handler(id:)
-    @handler.handlers.find { |hndlr| hndlr[:id] == id.to_sym }
+  def self.handler(id: nil)
+    if id.nil?
+      @handler
+    else
+      @handler.handlers.find { |hndlr| hndlr[:id] == id.to_sym }
+    end
   end
 
   # rubocop:disable Metrics/ParameterLists

data/lib/bellman/handlers/handler.rb

@@ -14,10 +14,8 @@ module Bellman
       # rubocop:disable Metrics/ParameterLists
       def handle(error, severity: :error, trace_id: nil, objects: nil,
                  data: nil, include_backtrace: false, handlers: nil)
-        unless Bellman.config.severities.include?(severity)
-          severity = Bellman.config.default_severity
-        end
 
+        severity = handle_severity(severity)
         handlers = if handlers.present?
                      process_handlers_config(handlers)
                    else
@@ -43,6 +41,16 @@ module Bellman
 
       private
 
+      def handle_severity(severity)
+        return severity if Bellman.config.severities.include?(severity)
+        if Bellman.config.on_unknown_severity != :raise
+          return Bellman.config.default_severity
+        end
+
+        raise "Unknown severity level #{severity}. " \
+              "Must be one of #{Bellman.config.severities}"
+      end
+
       def process_handlers_config(configs)
         configs.map { |config| process_handler_config(config) }
       end
@@ -68,7 +76,7 @@ module Bellman
                                config[:class].new(**config[:params])
                              end
         elsif config[:id]
-          config = Bellman.error_handler(config[:id])
+          config = Bellman.handler(config[:id])
           config[:handler] = if config[:params].blank?
                                config[:class].new
                              else
@@ -88,12 +96,12 @@ module Bellman
 
         case config
         when Symbol
-          handler = Bellman.error_handler(id: config)
+          handler = Bellman.handler(id: config)
           return handler if handler
         when String
           # If the string matches the ID of a handler defined in the Bellman
           # default config, return that.
-          handler = Bellman.error_handler(id: config.to_sym)
+          handler = Bellman.handler(id: config.to_sym)
           return handler if handler
 
           # rubocop:disable Lint/SuppressedException

data/lib/bellman/handlers/sentry.rb

@@ -47,9 +47,23 @@ module Bellman
       private
 
       def set_sentry_context(scope, objects)
-        scope.set_context(
-          objects: objects.map { |object| "#{object.class.name}|#{object.id}" }
-        )
+        # We are organizing the objects by class so that we can send the data
+        # on a per class basis. Note, we cannot just loop over the objects
+        # if we are using the class name as the key since this would mean that
+        # any time there are multiple objects of the same type, we'd only send
+        # the data for the last one as it would overwrite the data.
+        h = {}
+        objects.each do |object|
+          key = object.class.name
+          h[key] = [] unless h.key?(key)
+          h[key] << object
+        end
+
+        h.each do |key, obj_array|
+          scope.set_context(
+            key, { ids: obj_array.map(&:id) }
+          )
+        end
       end
 
       def set_sentry_user_and_tags(scope, data)

data/lib/bellman/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bellman
-  VERSION = '0.1.0'
+  VERSION = '0.1.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bellman
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.2
 platform: ruby
 authors:
 - Patrick R. Schmid