belated 0.5.0 → 0.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f63b50cb41ebaa52127b51ef4a38f70467bd6527d16efb6869965d5b3c9d3bab
-  data.tar.gz: 03ffefae27d2a9f76854b18abad3e2bd46fe3012e987008b5514fd86f699a5ba
+  metadata.gz: 918d89e2f82daa2abdd57976ca18edbf994dcd4c92b4480bf139983f2a51e26d
+  data.tar.gz: 1c684c38e41ba507d048463c4e287802fed0b067f9263702ea9fb3bbc4bfb22c
 SHA512:
-  metadata.gz: 619b6fc1269319b827dcfe48cc84caa951b00bea7fcd4086ebb73ab4ab72c431a3d2b02c2032e02e305913d2613c6b1f67be9c5f1edbd3a2432a0fdec3667c57
-  data.tar.gz: ccbed4ecf9df5627e28929c66287700160f3b9a31dd40b107f186eb1a8fe917cfc80edaa7b756743440d4c643ffa60b93cb06f463b06541929a62639b0fae1fb
+  metadata.gz: 7db6cbabae254f0152bd4a4367de72ad18085c58923dcb0420e20b94dbab0fb713fc00c54031bbe6788363a626d0a2ad315e6690b6cba0849aade14a406cb2f8
+  data.tar.gz: '0578bcaadeac30fa0d4cea61862de5927ca8624364fcb954a5a2f7f57c3cc1871c4fc99cb0730505aeb7e1f81ee0eb24327f5f48ef5aae4bf85fc5d5647baef3'

data/.rubocop.yml

@@ -1,3 +1,4 @@
+require: rubocop-performance
 AllCops:
   TargetRubyVersion: 2.7
   NewCops: enable

data/CHANGELOG.md

@@ -1,7 +1,21 @@
 ## [Unreleased]
 
+## [0.5.4] - 2021-08-14
 
-## [0.5.0] - 2021-08-07
+- Client was using 100% CPU when it had no connection. (on $5 Digital Ocean droplet) Should be fixed now. 
+
+## [0.5.3] - 2021-08-13
+
+- A bit less looping - better performance.
+## [0.5.2] - 2021-08-13
+
+- An error with shutdown handling was fixed.
+
+## [0.5.1] - 2021-08-12
+
+- Requiring byebug in bin file. 😮
+
+## [0.5.0] - 2021-08-011
 
 - Job retries! The jobs now have ids, so you can follow the job and it's retries from the log. 
 - Quite a lot has changed internally, so if you were not using the Belated::Queue class to enqueue your jobs, you will need to update your code.

data/Gemfile

@@ -9,10 +9,10 @@ gem 'rake', '~> 13.0'
 
 gem 'rspec', '~> 3.0'
 
-gem 'rubocop', '~> 1.7'
-
 gem 'database_cleaner-active_record'
 gem 'rails', '>= 6.1.3'
 gem 'rspec-rails'
+gem 'rubocop', '~> 1.7'
+gem 'rubocop-performance', require: false
 gem 'sqlite3'
 gem 'stackprof'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    belated (0.5.0)
+    belated (0.5.4)
       drb
       dry-configurable
 
@@ -169,6 +169,9 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.7.0)
       parser (>= 3.0.1.1)
+    rubocop-performance (1.11.4)
+      rubocop (>= 1.7.0, < 2.0)
+      rubocop-ast (>= 0.4.0)
     ruby-progressbar (1.11.0)
     sprockets (4.0.2)
       concurrent-ruby (~> 1.0)
@@ -200,8 +203,9 @@ DEPENDENCIES
   rspec (~> 3.0)
   rspec-rails
   rubocop (~> 1.7)
+  rubocop-performance
   sqlite3
   stackprof
 
 BUNDLED WITH
-   2.2.17
+   2.2.22

data/README.md

@@ -136,9 +136,15 @@ After checking out the repo, run `bin/setup` to install dependencies. Then, run
 
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
+
+# Possible problems
+
+If you have the port 8788 already in use, you can check the ports in use in Linux with the following command:
+
+    $ sudo lsof -i -P -n | grep LISTEN
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/sampokuokkanen/belated. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/sampokuokkanen/belated/blob/master/CODE_OF_CONDUCT.md).
+Bug reports, questions and pull requests are welcome on GitHub at https://github.com/sampokuokkanen/belated. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/sampokuokkanen/belated/blob/master/CODE_OF_CONDUCT.md).
 
 ## License
 

data/bin/belated

@@ -5,7 +5,6 @@ $TESTING = false
 $LOAD_PATH.unshift File.expand_path("#{File.dirname(__FILE__)}/../lib")
 require 'belated'
 require 'optparse'
-require 'byebug'
 
 OptionParser.new { |opts|
   opts.banner = 'Usage: belated [options]'

data/lib/belated.rb

@@ -91,13 +91,17 @@ class Belated
   def enqueue_future_jobs
     log 'starting future jobs thread'
     loop do
+      sleep 0.1
+      if @@queue.future_jobs.empty?
+        sleep 1
+        next
+      end
       @@queue.future_jobs.each_with_index do |job, i|
         if job.at <= Time.now.utc
           log "Deleting #{@@queue.future_jobs.delete_at(i)} from future jobs"
           @@queue.push(job)
         end
       end
-      sleep 0.01
     end
   end
 

data/lib/belated/client.rb

@@ -26,6 +26,12 @@ class Belated
     def start_banker_thread
       self.banker_thread = Thread.new do
         loop do
+          sleep 0.01
+          unless drb_connected?
+            sleep(10)
+            next
+          end
+
           job = bank.pop
 
           perform(job)
@@ -50,9 +56,16 @@ class Belated
     rescue DRb::DRbConnError
       bank.push(job_wrapper)
       start_banker_thread if banker_thread.nil?
-      banker_thread.wakeup if banker_thread.status == 'sleep'
     end
     alias perform_belated perform
     alias perform_later perform
+
+    private
+
+    def drb_connected?
+      queue.connected?
+    rescue StandardError
+      false
+    end
   end
 end

data/lib/belated/queue.rb

@@ -16,7 +16,8 @@ class Belated
     end
 
     def push(job)
-      if job.at.nil? || job.at <= Time.now.utc
+      if job == :shutdown || job.at.nil? ||
+         job.at <= Time.now.utc
         @queue.push(job)
       else
         @future_jobs << job
@@ -71,6 +72,10 @@ class Belated
       pp File.open(FILE_NAME, 'wb') { |f| f.write(YAML.dump(class_array)) }
     end
 
+    def connected?
+      true
+    end
+
     private
 
     def proc_or_shutdown?(job)

data/lib/belated/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Belated
-  VERSION = '0.5.0'
+  VERSION = '0.5.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: belated
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.4
 platform: ruby
 authors:
 - Sampo Kuokkanen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-08-11 00:00:00.000000000 Z
+date: 2021-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: drb
@@ -109,7 +109,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.22
 signing_key:
 specification_version: 4
 summary: Run background jobs with Belated and dRuby!