beaker 5.2.0 → 5.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d16043faca3a48ef9dd5a7171bf0241dd30fd801029eba8e881fe9d3d8afbef1
-  data.tar.gz: 64bec8b91441d824ad87a112914a5f41b5fe2b48131b9f6d99599b201279b4a3
+  metadata.gz: 9b23a9cf4e69c1cc33d3b64319de5e01485d051f72b307bb4ba3e710bba1b2ee
+  data.tar.gz: 207b9b9829b4e2fed7108ae8c20aedc8da77c52c82ff7bbe44f02e79bc01f97b
 SHA512:
-  metadata.gz: 17f0baf5a669e5ffa2e9f4214dbeb84f0e5fbf4ff80e048243215006aa8e5fc91be5df24e1714f71962a7a1d2e3d4f83c74c987f98a9a8ceff2b9397762b5167
-  data.tar.gz: 2826c21940af588185545f7a4f987600a789a9c646b9fe0d31d9e6d6f4f5eae0573d51591de0943d0dc9077cb0e0f3114291881fc10c6dcd3b54af24ec2425e2
+  metadata.gz: 62d8f5a82f380bcc4d0e19a92d002eafe2a882e1c4dd48b322596b6c002e41efa78722337b26715850caff8b8fb788e8e89979d9fdd2fdcd61554ea755e6f972
+  data.tar.gz: d99dab4be804d55f0434d8a3671e5c6911dba5ad3b6e8b76d0c19a8e09ca4a11dd8463bac3726fc60d4311886325d6e1a2b9dd6bc924e57e8bdfc5303f69b099

data/.github/workflows/release.yml

@@ -18,7 +18,7 @@ jobs:
         env:
           BUNDLE_WITHOUT: release:development:rubocop
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Publish gem to rubygems.org
         run: gem push *.gem
         env:

data/.github/workflows/test.yml

@@ -45,7 +45,7 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Run unit tests
         run: bundle exec rake spec
       - name: Run acceptance tests

data/.rubocop.yml

@@ -1,6 +1,5 @@
 ---
-inherit_from:
-  - .rubocop_todo.yml
+inherit_from: .rubocop_todo.yml
 
 inherit_gem:
   voxpupuli-rubocop: rubocop.yml

data/.rubocop_todo.yml

@@ -1,11 +1,12 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.50.1.
+# `rubocop --auto-gen-config`
+# on 2023-05-30 09:17:22 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 15
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: enums
 Lint/ConstantDefinitionInBlock:
@@ -26,6 +27,7 @@ Lint/ConstantDefinitionInBlock:
     - 'spec/beaker/host/windows/pkg_spec.rb'
     - 'spec/beaker/options/hosts_file_parser_spec.rb'
 
+# Offense count: 17
 # Configuration parameters: AllowComments, AllowEmptyLambdas.
 Lint/EmptyBlock:
   Exclude:
@@ -35,16 +37,19 @@ Lint/EmptyBlock:
     - 'spec/beaker/logger_junit_spec.rb'
     - 'spec/beaker/logger_spec.rb'
 
+# Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Lint/NonAtomicFileOperation:
   Exclude:
     - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
 
+# Offense count: 2
 Lint/RescueException:
   Exclude:
     - 'lib/beaker/dsl/structure.rb'
     - 'lib/beaker/test_suite_result.rb'
 
+# Offense count: 27
 Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'lib/beaker/dsl/helpers/host_helpers.rb'
@@ -55,6 +60,7 @@ Lint/ShadowingOuterLocalVariable:
     - 'lib/beaker/host_prebuilt_steps.rb'
     - 'lib/beaker/perf.rb'
 
+# Offense count: 12
 Lint/UselessAssignment:
   Exclude:
     - 'acceptance/tests/base/dsl/helpers/host_helpers/curl_with_retries_test.rb'
@@ -62,6 +68,29 @@ Lint/UselessAssignment:
     - 'lib/beaker/dsl/helpers/host_helpers.rb'
     - 'lib/beaker/logger_junit.rb'
 
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Minitest/AssertTruthy:
+  Exclude:
+    - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
+    - 'acceptance/tests/base/host/host_test.rb'
+    - 'acceptance/tests/hypervisor/communication_test.rb'
+
+# Offense count: 2
+# Configuration parameters: Severity.
+Minitest/AssertWithExpectedArgument:
+  Exclude:
+    - 'acceptance/tests/base/dsl/helpers/hocon_helpers_test.rb'
+
+# Offense count: 9
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Minitest/RefuteFalse:
+  Exclude:
+    - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
+    - 'acceptance/tests/base/dsl/helpers/host_helpers/check_for_package_test.rb'
+    - 'acceptance/tests/base/host/host_test.rb'
+
+# Offense count: 20
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
@@ -77,6 +106,7 @@ Naming/HeredocDelimiterNaming:
     - 'spec/beaker/host/windows_spec.rb'
     - 'spec/beaker/test_case_spec.rb'
 
+# Offense count: 2
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -84,6 +114,7 @@ Naming/MemoizedInstanceVariableName:
     - 'lib/beaker/host.rb'
     - 'lib/beaker/options/presets.rb'
 
+# Offense count: 4
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:
   Exclude:
@@ -91,11 +122,13 @@ Performance/CollectionLiteralInLoop:
     - 'lib/beaker/dsl/structure.rb'
     - 'lib/beaker/test_suite_result.rb'
 
+# Offense count: 17
 RSpec/AnyInstance:
   Exclude:
     - 'spec/beaker/host/windows/file_spec.rb'
     - 'spec/beaker/subcommand_spec.rb'
 
+# Offense count: 12
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/BeEq:
   Exclude:
@@ -104,15 +137,18 @@ RSpec/BeEq:
     - 'spec/beaker/host/windows/exec_spec.rb'
     - 'spec/beaker/host_spec.rb'
 
+# Offense count: 121
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
+# Offense count: 239
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 44
 
+# Offense count: 27
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/beaker/cli_spec.rb'
@@ -124,6 +160,7 @@ RSpec/ExpectInHook:
     - 'spec/beaker/options/parser_spec.rb'
     - 'spec/beaker/ssh_connection_spec.rb'
 
+# Offense count: 22
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Exclude:
@@ -133,10 +170,12 @@ RSpec/InstanceVariable:
     - 'spec/beaker/dsl/test_tagging_spec.rb'
     - 'spec/beaker/host_prebuilt_steps_spec.rb'
 
+# Offense count: 3
 RSpec/IteratedExpectation:
   Exclude:
     - 'spec/beaker/dsl/helpers/host_helpers_spec.rb'
 
+# Offense count: 12
 RSpec/LeakyConstantDeclaration:
   Exclude:
     - 'spec/beaker/host/freebsd/exec_spec.rb'
@@ -152,19 +191,23 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/beaker/host/windows/pkg_spec.rb'
     - 'spec/beaker/options/hosts_file_parser_spec.rb'
 
+# Offense count: 1
 RSpec/MultipleDescribes:
   Exclude:
     - 'spec/beaker/dsl/test_tagging_spec.rb'
 
+# Offense count: 134
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 17
 
+# Offense count: 500
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
 RSpec/NamedSubject:
   Enabled: false
 
+# Offense count: 42
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
 RSpec/NoExpectationExample:
@@ -175,17 +218,20 @@ RSpec/NoExpectationExample:
     - 'spec/beaker/logger_spec.rb'
     - 'spec/beaker/options/subcommand_options_parser_spec.rb'
 
+# Offense count: 7
 RSpec/RepeatedDescription:
   Exclude:
     - 'spec/beaker/cli_spec.rb'
     - 'spec/beaker/host/unix/exec_spec.rb'
     - 'spec/beaker/host/unix/pkg_spec.rb'
 
+# Offense count: 4
 RSpec/RepeatedExample:
   Exclude:
     - 'spec/beaker/dsl/roles_spec.rb'
     - 'spec/beaker/logger_spec.rb'
 
+# Offense count: 178
 RSpec/SubjectStub:
   Exclude:
     - 'spec/beaker/dsl/assertions_spec.rb'
@@ -202,6 +248,7 @@ RSpec/SubjectStub:
     - 'spec/beaker/host/windows/user_spec.rb'
     - 'spec/beaker/host_prebuilt_steps_spec.rb'
 
+# Offense count: 12
 RSpec/UnspecifiedException:
   Exclude:
     - 'spec/beaker/cli_spec.rb'
@@ -209,15 +256,18 @@ RSpec/UnspecifiedException:
     - 'spec/beaker/host_spec.rb'
     - 'spec/beaker/test_suite_spec.rb'
 
+# Offense count: 86
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
 
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:
   Exclude:
     - 'Rakefile'
 
+# Offense count: 7
 Security/Eval:
   Exclude:
     - 'Rakefile'
@@ -228,10 +278,12 @@ Security/Eval:
     - 'lib/beaker/options/options_file_parser.rb'
     - 'lib/beaker/test_case.rb'
 
+# Offense count: 1
 Security/Open:
   Exclude:
     - 'lib/beaker/dsl/helpers/web_helpers.rb'
 
+# Offense count: 104
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https

data/CHANGELOG.md

@@ -1,63 +1,126 @@
 # Changelog
 
+## [5.3.1](https://github.com/voxpupuli/beaker/tree/5.3.1) (2023-07-26)
+
+**Fixed bugs:**
+
+- Fix Minitest capitalization [\#1819](https://github.com/voxpupuli/beaker/pull/1819) ([mhashizume](https://github.com/mhashizume))
+
+[Full Changelog](https://github.com/voxpupuli/beaker/compare/5.3.0...5.3.1)
+
+## [5.3.0](https://github.com/voxpupuli/beaker/tree/5.3.0) (2023-06-06)
+
+[Full Changelog](https://github.com/voxpupuli/beaker/compare/5.2.0...5.3.0)
+
+**Implemented enhancements:**
+
+- Add bcrypt\_pbkdf to fix ed25519 ssh keys support [\#1810](https://github.com/voxpupuli/beaker/pull/1810) ([jay7x](https://github.com/jay7x))
+
+**Merged pull requests:**
+
+- rubocop: autofix [\#1816](https://github.com/voxpupuli/beaker/pull/1816) ([bastelfreak](https://github.com/bastelfreak))
+- GCG: Add missing faraday dependency [\#1815](https://github.com/voxpupuli/beaker/pull/1815) ([bastelfreak](https://github.com/bastelfreak))
+- Build gems with verbosity and strictness [\#1811](https://github.com/voxpupuli/beaker/pull/1811) ([bastelfreak](https://github.com/bastelfreak))
+
 ## [5.2.0](https://github.com/voxpupuli/beaker/tree/5.2.0) (2023-04-28)
 
+[Full Changelog](https://github.com/voxpupuli/beaker/compare/5.1.0...5.2.0)
+
 **Implemented enhancements:**
 
-- Enhance documentation about roles [\#1800](https://github.com/voxpupuli/beaker/pull/1800) ([rwaffen](https://github.com/rwaffen))
 - Declare API interface on Beaker::Host [\#1806](https://github.com/voxpupuli/beaker/pull/1806) ([ekohl](https://github.com/ekohl))
+- Switch to voxpupuli-rubocop [\#1804](https://github.com/voxpupuli/beaker/pull/1804) ([bastelfreak](https://github.com/bastelfreak))
 - Support an extension to tmpfile [\#1735](https://github.com/voxpupuli/beaker/pull/1735) ([ekohl](https://github.com/ekohl))
 
 **Fixed bugs:**
 
-- Use systemctl to restat SSH on EL9 [\#1808](https://github.com/voxpupuli/beaker/pull/1808) ([ekohl](https://github.com/ekohl))
+- Use systemctl to restart SSH on EL9 [\#1808](https://github.com/voxpupuli/beaker/pull/1808) ([ekohl](https://github.com/ekohl))
 
-**Merged changes:**
+**Closed issues:**
+
+- Failed to exec 'vagrant up' \(rbenv, ruby 2.7.6, bundler 2.3.19, virtualbox\) [\#1752](https://github.com/voxpupuli/beaker/issues/1752)
+- EL 9 error - /sbin/service: No such file or directory [\#1751](https://github.com/voxpupuli/beaker/issues/1751)
+
+**Merged pull requests:**
 
-- Drop legacy yard tasks [\#1805](https://github.com/voxpupuli/beaker/pull/1805) ([bastelfreak](https://github.com/bastelfreak))
-- Switch to voxpupuli-rubocop [\#1804](https://github.com/voxpupuli/beaker/pull/1804) ([bastelfreak](https://github.com/bastelfreak))
 - Disable RSpec/IndexedLet [\#1807](https://github.com/voxpupuli/beaker/pull/1807) ([ekohl](https://github.com/ekohl))
+- Drop legacy yard tasks [\#1805](https://github.com/voxpupuli/beaker/pull/1805) ([bastelfreak](https://github.com/bastelfreak))
+- Enhance documentation about roles [\#1800](https://github.com/voxpupuli/beaker/pull/1800) ([rwaffen](https://github.com/rwaffen))
 
 ## [5.1.0](https://github.com/voxpupuli/beaker/tree/5.1.0) (2023-03-27)
 
+[Full Changelog](https://github.com/voxpupuli/beaker/compare/5.0.0...5.1.0)
+
 **Implemented enhancements:**
 
 - Introduce shareable rubocop config [\#1795](https://github.com/voxpupuli/beaker/pull/1795) ([bastelfreak](https://github.com/bastelfreak))
 
 ## [5.0.0](https://github.com/voxpupuli/beaker/tree/5.0.0) (2023-03-24)
 
+[Full Changelog](https://github.com/voxpupuli/beaker/compare/4.39.0...5.0.0)
+
 **Breaking changes:**
 
-- Drop Ruby 2.4/2.5/2.6 support [\#1767](https://github.com/voxpupuli/beaker/pull/1767) ([bastelfreak](https://github.com/bastelfreak))
-- Removes open_uri_redirections [\#1764](https://github.com/voxpupuli/beaker/pull/1764) ([mhashizume](https://github.com/mhashizume))
+- Remove install\_puppet\_agent\_\* methods [\#1775](https://github.com/voxpupuli/beaker/pull/1775) ([ekohl](https://github.com/ekohl))
+- Update fakefs requirement from ~\> 1.0 to ~\> 2.4 [\#1770](https://github.com/voxpupuli/beaker/pull/1770) ([dependabot[bot]](https://github.com/apps/dependabot))
 - Drop deprecated methods [\#1769](https://github.com/voxpupuli/beaker/pull/1769) ([ekohl](https://github.com/ekohl))
-- Remove add-el-extras, passenger, proxy_config, disable_iptables and clean up code [\#1731](https://github.com/voxpupuli/beaker/pull/1731) ([ekohl](https://github.com/ekohl))
-- Remove install_puppet_agent_* methods [\#1775](https://github.com/voxpupuli/beaker/pull/1775) ([ekohl](https://github.com/ekohl))
+- Drop Ruby 2.4/2.5/2.6 support [\#1767](https://github.com/voxpupuli/beaker/pull/1767) ([bastelfreak](https://github.com/bastelfreak))
+- \(maint\) Removes open\_uri\_redirections [\#1764](https://github.com/voxpupuli/beaker/pull/1764) ([mhashizume](https://github.com/mhashizume))
+- Remove add-el-extras, passenger, proxy\_config, disable\_iptables and clean up code [\#1731](https://github.com/voxpupuli/beaker/pull/1731) ([ekohl](https://github.com/ekohl))
 
 **Implemented enhancements:**
 
-- Fix many RuboCop violations: [\#1768](https://github.com/voxpupuli/beaker/pull/1768), [\#1777](https://github.com/voxpupuli/beaker/pull/1777), [\#1787](https://github.com/voxpupuli/beaker/pull/1787), [\#1778](https://github.com/voxpupuli/beaker/pull/1778), [\#1790](https://github.com/voxpupuli/beaker/pull/1790), [\#1791](https://github.com/voxpupuli/beaker/pull/1791), [\#1792](https://github.com/voxpupuli/beaker/pull/1792)
+- Drop rspec-its dependency in favor of have\_attributes [\#1788](https://github.com/voxpupuli/beaker/pull/1788) ([ekohl](https://github.com/ekohl))
 - Add Ruby 3.2 support [\#1762](https://github.com/voxpupuli/beaker/pull/1762) ([ekohl](https://github.com/ekohl))
-- Drop rspec-its dependency in favor of have_attributes [\#1788](https://github.com/voxpupuli/beaker/pull/1788)
 
-## [4.39.0](https://github.com/voxpupuli/beaker/tree/4.39.0) (2023-02-09)
+**Fixed bugs:**
+
+- 4.39.0 breaks beaker-puppet tests [\#1772](https://github.com/voxpupuli/beaker/issues/1772)
+
+**Merged pull requests:**
+
+- Use send instead of instance\_eval [\#1793](https://github.com/voxpupuli/beaker/pull/1793) ([ekohl](https://github.com/ekohl))
+- rubocop: Fix more Style cops [\#1792](https://github.com/voxpupuli/beaker/pull/1792) ([bastelfreak](https://github.com/bastelfreak))
+- Rubocop: Fix more Style cops [\#1791](https://github.com/voxpupuli/beaker/pull/1791) ([bastelfreak](https://github.com/bastelfreak))
+- Rubocop: Fix multiple Layout cops [\#1790](https://github.com/voxpupuli/beaker/pull/1790) ([bastelfreak](https://github.com/bastelfreak))
+- Add a CI job we can enforce in branch protection [\#1789](https://github.com/voxpupuli/beaker/pull/1789) ([bastelfreak](https://github.com/bastelfreak))
+- rubocop: disable Gemspec/DevelopmentDependencies [\#1787](https://github.com/voxpupuli/beaker/pull/1787) ([bastelfreak](https://github.com/bastelfreak))
+- Release pipeline: Dont install optional gems [\#1786](https://github.com/voxpupuli/beaker/pull/1786) ([bastelfreak](https://github.com/bastelfreak))
+- CI: Run on merges to master [\#1785](https://github.com/voxpupuli/beaker/pull/1785) ([bastelfreak](https://github.com/bastelfreak))
+- Run acceptance tests in CI [\#1784](https://github.com/voxpupuli/beaker/pull/1784) ([ekohl](https://github.com/ekohl))
+- Update in-parallel requirement from ~\> 0.1 to \>= 0.1, \< 2.0 [\#1783](https://github.com/voxpupuli/beaker/pull/1783) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Update rubocop-rspec requirement from ~\> 2.18.1 to ~\> 2.19.0 [\#1781](https://github.com/voxpupuli/beaker/pull/1781) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Update rubocop requirement from ~\> 1.47.0 to ~\> 1.48.0 [\#1780](https://github.com/voxpupuli/beaker/pull/1780) ([dependabot[bot]](https://github.com/apps/dependabot))
+- dependabot: check for github actions as well [\#1779](https://github.com/voxpupuli/beaker/pull/1779) ([bastelfreak](https://github.com/bastelfreak))
+- RuboCop: Fix Layout cops [\#1778](https://github.com/voxpupuli/beaker/pull/1778) ([bastelfreak](https://github.com/bastelfreak))
+- Fix more rubocop violations [\#1777](https://github.com/voxpupuli/beaker/pull/1777) ([bastelfreak](https://github.com/bastelfreak))
+- Use Enumerable\#all? [\#1776](https://github.com/voxpupuli/beaker/pull/1776) ([ekohl](https://github.com/ekohl))
+- Do not include Unix::Exec on Windows::Exec tests [\#1774](https://github.com/voxpupuli/beaker/pull/1774) ([ekohl](https://github.com/ekohl))
+- Update rubocop requirement from ~\> 1.45.0 to ~\> 1.47.0 [\#1773](https://github.com/voxpupuli/beaker/pull/1773) ([dependabot[bot]](https://github.com/apps/dependabot))
+- rubocop: Fix commas and whitespace and newlines [\#1768](https://github.com/voxpupuli/beaker/pull/1768) ([bastelfreak](https://github.com/bastelfreak))
+- CI: Use latest actions/checkout version [\#1766](https://github.com/voxpupuli/beaker/pull/1766) ([bastelfreak](https://github.com/bastelfreak))
+
+## [4.39.0](https://github.com/voxpupuli/beaker/tree/4.39.0) (2023-02-18)
 
 [Full Changelog](https://github.com/voxpupuli/beaker/compare/4.38.1...4.39.0)
 
-**Fixed bugs:**
+**Implemented enhancements:**
 
-- Extend list of permitted classes for YAML safe load and allow aliases [\#1758](https://github.com/voxpupuli/beaker/pull/1758) ([nmburgan](https://github.com/nmburgan))
+- \(maint\) StringInclude Rubocop corrections [\#1765](https://github.com/voxpupuli/beaker/pull/1765) ([mhashizume](https://github.com/mhashizume))
+- Add Rubocop [\#1761](https://github.com/voxpupuli/beaker/pull/1761) ([ekohl](https://github.com/ekohl))
 
-**Implemented enhancements:**
+**Fixed bugs:**
 
-- Add RuboCop [\#1761](https://github.com/voxpupuli/beaker/pull/1761) ([ekohl](https://github.com/ekohl))
-- Update net-scp requirement from >= 1.2, < 4.0 to >= 1.2, < 5.0 [\#1757](https://github.com/voxpupuli/beaker/pull/1757)
-- (maint) StringInclude Rubocop corrections [\1765](https://github.com/voxpupuli/beaker/pull/1765) ([mhashizume](https://github.com/mhashizume))
+- Extend list of permitted classes for YAML safe load and allow aliases [\#1758](https://github.com/voxpupuli/beaker/pull/1758) ([nmburgan](https://github.com/nmburgan))
 
 **Closed issues:**
 
 - Ruby 3.1/Psych 4 compatibility issues [\#1753](https://github.com/voxpupuli/beaker/issues/1753)
 
+**Merged pull requests:**
+
+- Update net-scp requirement from \>= 1.2, \< 4.0 to \>= 1.2, \< 5.0 [\#1757](https://github.com/voxpupuli/beaker/pull/1757) ([dependabot[bot]](https://github.com/apps/dependabot))
+
 ## [4.38.1](https://github.com/voxpupuli/beaker/tree/4.38.1) (2022-09-21)
 
 [Full Changelog](https://github.com/voxpupuli/beaker/compare/4.38.0...4.38.1)

data/Gemfile

@@ -26,6 +26,7 @@ if ENV['BEAKER_HYPERVISOR']
 end
 
 group :release do
+  gem 'faraday-retry', require: false
   gem 'github_changelog_generator', require: false
 end
 

data/acceptance/lib/helpers/test_helper.rb

@@ -59,7 +59,7 @@ end
 #      assert_equal expected, user
 #    end
 #
-# Absorbs any MiniTest::Assertion from a failing test assertion in the block.
+# Absorbs any Minitest::Assertion from a failing test assertion in the block.
 # This implies that the intermittent failure is caught and the suite will not
 # go red for this failure. Intended to be used with the Jenkins Build Failure
 # Analyzer (or similar), to detect these failures without failing the build.
@@ -70,7 +70,7 @@ def fails_intermittently(issue_link, args = {})
   raise ArgumentError, "a block is required" unless block_given?
 
   yield
-rescue MiniTest::Assertion, StandardError, SignalException # we have a test failure!
+rescue Minitest::Assertion, StandardError, SignalException # we have a test failure!
   STDERR.puts "\n\nIntermittent test failure! See: #{issue_link}"
 
   if args.empty?

data/acceptance/tests/base/dsl/helpers/configuration_test.rb

@@ -8,6 +8,7 @@ test_name "dsl::helpers::host_helpers test configuration validation" do
            "dsl::helpers::host_helpers acceptance tests require at least two hosts"
 
     agents = select_hosts(:roles => "agent")
+
     assert (agents.size > 1),
            "dsl::helpers::host_helpers acceptance tests require at least two hosts with the :agent role"
 

data/acceptance/tests/base/dsl/helpers/hocon_helpers_test.rb

@@ -15,6 +15,7 @@ test_name 'Hocon Helpers Test' do
 
   step '#hocon_file_read : reads doc' do
     doc = hocon_file_read_on(hosts[0], hocon_filename)
+
     assert(doc.has_value?('setting2'))
   end
 
@@ -34,7 +35,7 @@ test_name 'Hocon Helpers Test' do
         end
         fail('execution should not continue in failure mode')
       rescue ArgumentError => e
-        assert(e.to_s.include?('requires a filename'))
+        assert_includes(e.to_s, 'requires a filename')
       else
         fail('No exception raised in failure mode')
       end
@@ -53,7 +54,7 @@ test_name 'Hocon Helpers Test' do
         hocon_file_edit_on(hosts, hocon_filename)
         fail('execution should not continue in failure mode')
       rescue ArgumentError => e
-        assert(e.to_s.include?('No block was provided'))
+        assert_includes(e.to_s, 'No block was provided')
       else
         fail('No exception raised in failure mode')
       end
@@ -71,6 +72,7 @@ test_name 'Hocon Helpers Test' do
     step '#hocon_file_edit_on : independently read value to verify save' do
       hocon_file_edit_on(hosts, hocon_filename) do |_host, doc|
         msg_fail = 'Should have saved "a.b" value inserted in previous step'
+
         assert(doc.has_value?('a.b'), msg_fail)
       end
     end
@@ -86,6 +88,7 @@ test_name 'Hocon Helpers Test' do
     step '#hocon_file_edit_in_place_on : verify save' do
       hocon_file_edit_on(hosts, hocon_filename) do |_host, doc|
         msg_fail = 'Should have saved "c.d" value inserted in previous step'
+
         assert(doc.has_value?('c.d'), msg_fail)
       end
     end

data/acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb

@@ -15,6 +15,7 @@ test_name "dsl::helpers::host_helpers #archive_file_from" do
     assert_equal(false, Dir.exist?('archive'))
     assert_equal(false, Dir.exist?('archive/sut-files'))
     archive_file_from(default, filepath)
+
     assert_equal(true, Dir.exist?('archive/sut-files'))
   end
 
@@ -32,17 +33,20 @@ test_name "dsl::helpers::host_helpers #archive_file_from" do
     # Create a remote file to archive
     filepath = default.tmpfile('archive-file-test')
     create_remote_file(default, filepath, 'number of the beast')
+
     assert_equal(false, Dir.exist?(filepath))
 
     # Test that the file is copied locally to <archiveroot>/<hostname>/<filepath>
     Dir.mktmpdir do |tmpdir|
       tar_path = File.join(tmpdir, default, filepath + '.tgz')
       archive_file_from(default, filepath, {}, tmpdir, tar_path)
-      assert(File.exist?(tar_path))
+
+      assert_path_exists(tar_path)
       expected_path = File.join(tmpdir, default)
 
       tgz = Zlib::GzipReader.new(File.open(tar_path, 'rb'))
       Minitar.unpack(tgz, expected_path)
+
       assert_equal('number of the beast', File.read(expected_path + '/' + filepath).strip)
     end
   end

data/acceptance/tests/base/dsl/helpers/host_helpers/backup_the_file_test.rb

@@ -6,6 +6,7 @@ test_name "dsl::helpers::host_helpers #backup_the_file" do
     remote_source = default.tmpdir
     remote_destination = default.tmpdir
     result = backup_the_file default, remote_source, remote_destination
+
     assert_nil result
   end
 
@@ -29,6 +30,7 @@ test_name "dsl::helpers::host_helpers #backup_the_file" do
 
     assert_equal remote_destination_filename, result
     remote_contents = on(default, "cat #{remote_destination_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 
@@ -43,6 +45,7 @@ test_name "dsl::helpers::host_helpers #backup_the_file" do
 
     assert_equal remote_destination_filename, result
     remote_contents = on(default, "cat #{remote_destination_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 

data/acceptance/tests/base/dsl/helpers/host_helpers/check_for_package_test.rb

@@ -25,11 +25,13 @@ test_name "dsl::helpers::host_helpers #check_for_package" do
 
     step "#check_for_package will return false if the specified package is not installed on the remote host" do
       result = check_for_package default, "non-existent-package-name"
+
       assert !result
     end
 
     step "#check_for_package will return true if the specified package is installed on the remote host" do
       result = check_for_package default, known_installed_package
+
       assert result
     end
 
@@ -43,11 +45,13 @@ test_name "dsl::helpers::host_helpers #check_for_package" do
   confine_block :to, :platform => /solaris/ do
     step "#check_for_package will return false if the specified package is not installed on the remote host" do
       result = check_for_package default, "non-existent-package-name"
+
       assert !result
     end
 
     step "#check_for_package will return true if the specified package is installed on the remote host" do
       result = check_for_package default, known_installed_package
+
       assert result
     end
 
@@ -69,12 +73,14 @@ test_name "dsl::helpers::host_helpers #check_for_package" do
   confine_block :except, :platform => /windows|solaris|osx/ do
     step "#check_for_package will return false if the specified package is not installed on the remote host" do
       result = check_for_package default, "non-existent-package-name"
+
       assert !result
     end
 
     step "#check_for_package will return true if the specified package is installed on the remote host" do
       install_package default, known_installed_package
       result = check_for_package default, known_installed_package
+
       assert result
     end
 

data/acceptance/tests/base/dsl/helpers/host_helpers/create_remote_file_test.rb

@@ -43,6 +43,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
     create_remote_file_with_backups default, remote_filename, contents
 
     remote_contents = on(default, "cat #{remote_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 
@@ -54,6 +55,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
     create_remote_file_with_backups default, remote_filename, contents, { :protocol => "scp" }
 
     remote_contents = on(default, "cat #{remote_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 
@@ -72,6 +74,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
 
     hosts.each do |host|
       remote_contents = on(host, "cat #{remote_filename}").stdout
+
       assert_equal contents, remote_contents
     end
   end
@@ -91,6 +94,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
 
     hosts.each do |host|
       remote_contents = on(host, "cat #{remote_filename}").stdout
+
       assert_equal contents, remote_contents
     end
   end
@@ -144,6 +148,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
                            "contents" => contents,
                            "result" => result) do
         remote_contents = on(default, "cat #{remote_filename}").stdout
+
         assert_equal contents, remote_contents
       end
     end
@@ -171,6 +176,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
                              "contents" => contents,
                              "result" => result) do
           remote_contents = on(host, "cat #{remote_filename}").stdout
+
           assert_equal contents, remote_contents
         end
       end

data/acceptance/tests/base/dsl/helpers/host_helpers/curl_on_test.rb

@@ -25,6 +25,7 @@ test_name "dsl::helpers::host_helpers #curl_on" do
 
     assert_equal 0, result.exit_code
     remote_contents = on(default, "cat #{remote_targetfilename}").stdout
+
     assert_equal contents, remote_contents
   end
 
@@ -42,6 +43,7 @@ test_name "dsl::helpers::host_helpers #curl_on" do
 
     hosts.each do |host|
       remote_contents = on(host, "cat #{remote_targetfilename}").stdout
+
       assert_equal contents, remote_contents
     end
   end