beaker 5.1.0 → 5.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ed6c6126f85203546e505eb1c8b8770582c303c11db2ab209e6cd1f03414fe5
-  data.tar.gz: f007b424a8e1a4097c5704a5f009ec5d38c69e55535c4a40618eabf57e69637b
+  metadata.gz: b4829c1a428f59340c095f78aa87331fb6a7df76854cdb4d95ed62553af19112
+  data.tar.gz: 0e08786ce7520319ea25c94ece1fb8f3a2a56e507035fd4ced4edeabfa1153ac
 SHA512:
-  metadata.gz: 646c6603a729bbe62a91365a7c90c3de1a960517e0a8b036076ba9f6705b7971ab630f5d86a1ce2a3d690094459c2730e8522ebc01108557f5f8fa64fc3c3cf9
-  data.tar.gz: fd96942cd14a89a587fc010495f66124761c59502ad98b43f813bb80c53fd5429a748c710e9e4f4e614b59e789251e96957abbabaec486f39015f3524e9c6d50
+  metadata.gz: 7ecddce8f3ffcc7fba3dceb5061667d48332808a76d88aae73b7d681e1d1f4478d99bdd464aa9ea3a6568425630a105618eb643ee6b9d9710e4e90adabb8e529
+  data.tar.gz: dd41043f67f6d951beb5de7739e7e9363a221ff2a09d9448edca2bdb9e054ad19200e639da3714d1c364e2fcc5c7ee6b1d17f572b5bdd7c458373301c23acf3a

data/.github/workflows/release.yml

@@ -18,7 +18,7 @@ jobs:
         env:
           BUNDLE_WITHOUT: release:development:rubocop
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Publish gem to rubygems.org
         run: gem push *.gem
         env:

data/.github/workflows/test.yml

@@ -45,7 +45,7 @@ jobs:
           ruby-version: ${{ matrix.ruby }}
           bundler-cache: true
       - name: Build gem
-        run: gem build *.gemspec
+        run: gem build --strict --verbose *.gemspec
       - name: Run unit tests
         run: bundle exec rake spec
       - name: Run acceptance tests

data/.rubocop.yml

@@ -1,7 +1,8 @@
 ---
-inherit_from:
-  - rubocop.yml
-  - .rubocop_todo.yml
+inherit_from: .rubocop_todo.yml
+
+inherit_gem:
+  voxpupuli-rubocop: rubocop.yml
 
 Layout/LineLength:
   Exclude:
@@ -40,6 +41,9 @@ RSpec/StubbedMock:
 RSpec/MultipleExpectations:
   Enabled: false
 
+RSpec/IndexedLet:
+  Enabled: false
+
 RSpec/NestedGroups:
   Max: 4
 

data/.rubocop_todo.yml

@@ -1,11 +1,12 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.48.0.
+# `rubocop --auto-gen-config`
+# on 2023-05-30 09:17:22 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# Offense count: 15
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: enums
 Lint/ConstantDefinitionInBlock:
@@ -26,6 +27,7 @@ Lint/ConstantDefinitionInBlock:
     - 'spec/beaker/host/windows/pkg_spec.rb'
     - 'spec/beaker/options/hosts_file_parser_spec.rb'
 
+# Offense count: 17
 # Configuration parameters: AllowComments, AllowEmptyLambdas.
 Lint/EmptyBlock:
   Exclude:
@@ -35,16 +37,19 @@ Lint/EmptyBlock:
     - 'spec/beaker/logger_junit_spec.rb'
     - 'spec/beaker/logger_spec.rb'
 
+# Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Lint/NonAtomicFileOperation:
   Exclude:
     - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
 
+# Offense count: 2
 Lint/RescueException:
   Exclude:
     - 'lib/beaker/dsl/structure.rb'
     - 'lib/beaker/test_suite_result.rb'
 
+# Offense count: 27
 Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'lib/beaker/dsl/helpers/host_helpers.rb'
@@ -55,6 +60,7 @@ Lint/ShadowingOuterLocalVariable:
     - 'lib/beaker/host_prebuilt_steps.rb'
     - 'lib/beaker/perf.rb'
 
+# Offense count: 12
 Lint/UselessAssignment:
   Exclude:
     - 'acceptance/tests/base/dsl/helpers/host_helpers/curl_with_retries_test.rb'
@@ -62,6 +68,29 @@ Lint/UselessAssignment:
     - 'lib/beaker/dsl/helpers/host_helpers.rb'
     - 'lib/beaker/logger_junit.rb'
 
+# Offense count: 5
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Minitest/AssertTruthy:
+  Exclude:
+    - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
+    - 'acceptance/tests/base/host/host_test.rb'
+    - 'acceptance/tests/hypervisor/communication_test.rb'
+
+# Offense count: 2
+# Configuration parameters: Severity.
+Minitest/AssertWithExpectedArgument:
+  Exclude:
+    - 'acceptance/tests/base/dsl/helpers/hocon_helpers_test.rb'
+
+# Offense count: 9
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Minitest/RefuteFalse:
+  Exclude:
+    - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
+    - 'acceptance/tests/base/dsl/helpers/host_helpers/check_for_package_test.rb'
+    - 'acceptance/tests/base/host/host_test.rb'
+
+# Offense count: 20
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
@@ -77,6 +106,7 @@ Naming/HeredocDelimiterNaming:
     - 'spec/beaker/host/windows_spec.rb'
     - 'spec/beaker/test_case_spec.rb'
 
+# Offense count: 2
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
@@ -84,6 +114,7 @@ Naming/MemoizedInstanceVariableName:
     - 'lib/beaker/host.rb'
     - 'lib/beaker/options/presets.rb'
 
+# Offense count: 4
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:
   Exclude:
@@ -91,11 +122,13 @@ Performance/CollectionLiteralInLoop:
     - 'lib/beaker/dsl/structure.rb'
     - 'lib/beaker/test_suite_result.rb'
 
+# Offense count: 17
 RSpec/AnyInstance:
   Exclude:
     - 'spec/beaker/host/windows/file_spec.rb'
     - 'spec/beaker/subcommand_spec.rb'
 
+# Offense count: 12
 # This cop supports unsafe autocorrection (--autocorrect-all).
 RSpec/BeEq:
   Exclude:
@@ -104,15 +137,18 @@ RSpec/BeEq:
     - 'spec/beaker/host/windows/exec_spec.rb'
     - 'spec/beaker/host_spec.rb'
 
+# Offense count: 121
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
+# Offense count: 239
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 44
 
+# Offense count: 27
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/beaker/cli_spec.rb'
@@ -124,6 +160,7 @@ RSpec/ExpectInHook:
     - 'spec/beaker/options/parser_spec.rb'
     - 'spec/beaker/ssh_connection_spec.rb'
 
+# Offense count: 22
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Exclude:
@@ -133,10 +170,12 @@ RSpec/InstanceVariable:
     - 'spec/beaker/dsl/test_tagging_spec.rb'
     - 'spec/beaker/host_prebuilt_steps_spec.rb'
 
+# Offense count: 3
 RSpec/IteratedExpectation:
   Exclude:
     - 'spec/beaker/dsl/helpers/host_helpers_spec.rb'
 
+# Offense count: 12
 RSpec/LeakyConstantDeclaration:
   Exclude:
     - 'spec/beaker/host/freebsd/exec_spec.rb'
@@ -152,19 +191,23 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/beaker/host/windows/pkg_spec.rb'
     - 'spec/beaker/options/hosts_file_parser_spec.rb'
 
+# Offense count: 1
 RSpec/MultipleDescribes:
   Exclude:
     - 'spec/beaker/dsl/test_tagging_spec.rb'
 
+# Offense count: 134
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 17
 
+# Offense count: 500
 # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
 # SupportedStyles: always, named_only
 RSpec/NamedSubject:
   Enabled: false
 
+# Offense count: 42
 # Configuration parameters: AllowedPatterns.
 # AllowedPatterns: ^expect_, ^assert_
 RSpec/NoExpectationExample:
@@ -175,17 +218,20 @@ RSpec/NoExpectationExample:
     - 'spec/beaker/logger_spec.rb'
     - 'spec/beaker/options/subcommand_options_parser_spec.rb'
 
+# Offense count: 7
 RSpec/RepeatedDescription:
   Exclude:
     - 'spec/beaker/cli_spec.rb'
     - 'spec/beaker/host/unix/exec_spec.rb'
     - 'spec/beaker/host/unix/pkg_spec.rb'
 
+# Offense count: 4
 RSpec/RepeatedExample:
   Exclude:
     - 'spec/beaker/dsl/roles_spec.rb'
     - 'spec/beaker/logger_spec.rb'
 
+# Offense count: 178
 RSpec/SubjectStub:
   Exclude:
     - 'spec/beaker/dsl/assertions_spec.rb'
@@ -202,6 +248,7 @@ RSpec/SubjectStub:
     - 'spec/beaker/host/windows/user_spec.rb'
     - 'spec/beaker/host_prebuilt_steps_spec.rb'
 
+# Offense count: 12
 RSpec/UnspecifiedException:
   Exclude:
     - 'spec/beaker/cli_spec.rb'
@@ -209,15 +256,18 @@ RSpec/UnspecifiedException:
     - 'spec/beaker/host_spec.rb'
     - 'spec/beaker/test_suite_spec.rb'
 
+# Offense count: 86
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
 
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:
   Exclude:
     - 'Rakefile'
 
+# Offense count: 7
 Security/Eval:
   Exclude:
     - 'Rakefile'
@@ -228,12 +278,14 @@ Security/Eval:
     - 'lib/beaker/options/options_file_parser.rb'
     - 'lib/beaker/test_case.rb'
 
+# Offense count: 1
 Security/Open:
   Exclude:
     - 'lib/beaker/dsl/helpers/web_helpers.rb'
 
+# Offense count: 104
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
 # URISchemes: http, https
 Layout/LineLength:
-  Max: 226
+  Max: 225

data/CHANGELOG.md

@@ -1,5 +1,35 @@
 # Changelog
 
+## [5.3.0] (https://github.com/voxpupuli/beaker/tree/5.3.0) (2023-06-06)
+
+**Implemented enhancements:**
+
+- Add bcrypt_pbkdf to fix ed25519 ssh keys support [\#1810](https://github.com/voxpupuli/beaker/pull/1810) ([jay7x](https://github.com/jay7x))
+
+**Merged changes:**
+
+- Build gems with verbosity and strictness [\#1811](https://github.com/voxpupuli/beaker/pull/1811) ([bastelfreak](https://github.com/bastelfreak))
+- rubocop: autofix [\#1816](https://github.com/voxpupuli/beaker/pull/1816) ([bastelfreak](https://github.com/bastelfreak))
+- GCG: Add missing faraday dependency [\#1815](https://github.com/voxpupuli/beaker/pull/1815) ([bastelfreak](https://github.com/bastelfreak))
+
+## [5.2.0](https://github.com/voxpupuli/beaker/tree/5.2.0) (2023-04-28)
+
+**Implemented enhancements:**
+
+- Enhance documentation about roles [\#1800](https://github.com/voxpupuli/beaker/pull/1800) ([rwaffen](https://github.com/rwaffen))
+- Declare API interface on Beaker::Host [\#1806](https://github.com/voxpupuli/beaker/pull/1806) ([ekohl](https://github.com/ekohl))
+- Support an extension to tmpfile [\#1735](https://github.com/voxpupuli/beaker/pull/1735) ([ekohl](https://github.com/ekohl))
+
+**Fixed bugs:**
+
+- Use systemctl to restat SSH on EL9 [\#1808](https://github.com/voxpupuli/beaker/pull/1808) ([ekohl](https://github.com/ekohl))
+
+**Merged changes:**
+
+- Drop legacy yard tasks [\#1805](https://github.com/voxpupuli/beaker/pull/1805) ([bastelfreak](https://github.com/bastelfreak))
+- Switch to voxpupuli-rubocop [\#1804](https://github.com/voxpupuli/beaker/pull/1804) ([bastelfreak](https://github.com/bastelfreak))
+- Disable RSpec/IndexedLet [\#1807](https://github.com/voxpupuli/beaker/pull/1807) ([ekohl](https://github.com/ekohl))
+
 ## [5.1.0](https://github.com/voxpupuli/beaker/tree/5.1.0) (2023-03-27)
 
 **Implemented enhancements:**

data/Gemfile

@@ -25,14 +25,8 @@ if ENV['BEAKER_HYPERVISOR']
   gem "beaker-#{ENV['BEAKER_HYPERVISOR'].split('_').first}"
 end
 
-group :rubocop do
-  gem 'rubocop', '~> 1.48.0'
-  gem 'rubocop-performance', '~> 1.16.0'
-  gem 'rubocop-rake', '~> 0.6.0'
-  gem 'rubocop-rspec', '~> 2.19.0'
-end
-
 group :release do
+  gem 'faraday-retry', require: false
   gem 'github_changelog_generator', require: false
 end
 

data/Rakefile

@@ -16,14 +16,6 @@ end
 
 task :acceptance => ['test:base', 'test:hypervisor']
 
-task :yard do
-  Rake::Task['docs:gen'].invoke
-end
-
-task :history do
-  Rake::Task['history:gen'].invoke
-end
-
 module HarnessOptions
   defaults = {
     :tests => ['tests'],
@@ -189,120 +181,6 @@ namespace :test do
   end
 end
 
-###########################################################
-#
-#   History Tasks
-#
-###########################################################
-namespace :history do
-  desc 'Generate HISTORY.md'
-  task :gen do
-    Dir.chdir(__dir__) do
-      output = `bundle exec ruby history.rb .`
-      puts output
-      raise "History generation failed" if !output.include?('success')
-    end
-  end
-end
-
-###########################################################
-#
-#   Documentation Tasks
-#
-###########################################################
-DOCS_DIR = 'yard_docs'
-DOCS_DAEMON = "yard server --reload --daemon --docroot #{DOCS_DIR}"
-FOREGROUND_SERVER = "bundle exec yard server --reload --verbose lib/beaker --docroot #{DOCS_DIR}"
-
-def running?(cmdline)
-  ps = `ps -ef`
-  found = ps.lines.grep(/#{Regexp.quote(cmdline)}/)
-  raise StandardError, "Found multiple YARD Servers. Don't know what to do." if found.length > 1
-
-  yes = found.empty? ? false : true
-  return yes, found.first
-end
-
-def pid_from(output)
-  output.squeeze(' ').strip.split(' ')[1]
-end
-
-desc 'Start the documentation server in the foreground'
-task :docs => 'docs:clear' do
-  Dir.chdir(__dir__) do
-    sh FOREGROUND_SERVER
-  end
-end
-
-namespace :docs do
-  desc 'Clear the generated documentation cache'
-  task :clear do
-    Dir.chdir(__dir__) do
-      sh "rm -rf #{DOCS_DIR}"
-    end
-  end
-
-  desc 'Generate static documentation'
-  task :gen => 'docs:clear' do
-    Dir.chdir(__dir__) do
-      output = `bundle exec yard doc -o #{DOCS_DIR}`
-      puts output
-      fail "Errors/Warnings during yard documentation generation" if /\[warn\]|\[error\]/.match?(output)
-    end
-  end
-
-  desc 'Run the documentation server in the background, alias `bg`'
-  task :background => 'docs:clear' do
-    yes, output = running?(DOCS_DAEMON)
-    if yes
-      puts "Not starting a new YARD Server..."
-      puts "Found one running with pid #{pid_from(output)}."
-    else
-      Dir.chdir(__dir__) do
-        sh "bundle exec #{DOCS_DAEMON}"
-      end
-    end
-  end
-
-  task(:bg) { Rake::Task['docs:background'].invoke }
-
-  desc 'Check the status of the documentation server'
-  task :status do
-    yes, output = running?(DOCS_DAEMON)
-    if yes
-      pid = pid_from(output)
-      puts "Found a YARD Server running with pid #{pid}"
-    else
-      puts "Could not find a running YARD Server."
-    end
-  end
-
-  desc "Stop a running YARD Server"
-  task :stop do
-    yes, output = running?(DOCS_DAEMON)
-    if yes
-      pid = pid_from(output)
-      puts "Found a YARD Server running with pid #{pid}"
-      `kill #{pid}`
-      puts "Stopping..."
-      yes, _output = running?(DOCS_DAEMON)
-      if yes
-        `kill -9 #{pid}`
-        yes, _output = running?(DOCS_DAEMON)
-        if yes
-          puts "Could not Stop Server!"
-        else
-          puts "Server stopped."
-        end
-      else
-        puts "Server stopped."
-      end
-    else
-      puts "Could not find a running YARD Server"
-    end
-  end
-end
-
 begin
   require 'rubygems'
   require 'github_changelog_generator/task'

data/acceptance/tests/base/dsl/helpers/configuration_test.rb

@@ -8,6 +8,7 @@ test_name "dsl::helpers::host_helpers test configuration validation" do
            "dsl::helpers::host_helpers acceptance tests require at least two hosts"
 
     agents = select_hosts(:roles => "agent")
+
     assert (agents.size > 1),
            "dsl::helpers::host_helpers acceptance tests require at least two hosts with the :agent role"
 

data/acceptance/tests/base/dsl/helpers/hocon_helpers_test.rb

@@ -15,6 +15,7 @@ test_name 'Hocon Helpers Test' do
 
   step '#hocon_file_read : reads doc' do
     doc = hocon_file_read_on(hosts[0], hocon_filename)
+
     assert(doc.has_value?('setting2'))
   end
 
@@ -34,7 +35,7 @@ test_name 'Hocon Helpers Test' do
         end
         fail('execution should not continue in failure mode')
       rescue ArgumentError => e
-        assert(e.to_s.include?('requires a filename'))
+        assert_includes(e.to_s, 'requires a filename')
       else
         fail('No exception raised in failure mode')
       end
@@ -53,7 +54,7 @@ test_name 'Hocon Helpers Test' do
         hocon_file_edit_on(hosts, hocon_filename)
         fail('execution should not continue in failure mode')
       rescue ArgumentError => e
-        assert(e.to_s.include?('No block was provided'))
+        assert_includes(e.to_s, 'No block was provided')
       else
         fail('No exception raised in failure mode')
       end
@@ -71,6 +72,7 @@ test_name 'Hocon Helpers Test' do
     step '#hocon_file_edit_on : independently read value to verify save' do
       hocon_file_edit_on(hosts, hocon_filename) do |_host, doc|
         msg_fail = 'Should have saved "a.b" value inserted in previous step'
+
         assert(doc.has_value?('a.b'), msg_fail)
       end
     end
@@ -86,6 +88,7 @@ test_name 'Hocon Helpers Test' do
     step '#hocon_file_edit_in_place_on : verify save' do
       hocon_file_edit_on(hosts, hocon_filename) do |_host, doc|
         msg_fail = 'Should have saved "c.d" value inserted in previous step'
+
         assert(doc.has_value?('c.d'), msg_fail)
       end
     end

data/acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb

@@ -15,6 +15,7 @@ test_name "dsl::helpers::host_helpers #archive_file_from" do
     assert_equal(false, Dir.exist?('archive'))
     assert_equal(false, Dir.exist?('archive/sut-files'))
     archive_file_from(default, filepath)
+
     assert_equal(true, Dir.exist?('archive/sut-files'))
   end
 
@@ -32,17 +33,20 @@ test_name "dsl::helpers::host_helpers #archive_file_from" do
     # Create a remote file to archive
     filepath = default.tmpfile('archive-file-test')
     create_remote_file(default, filepath, 'number of the beast')
+
     assert_equal(false, Dir.exist?(filepath))
 
     # Test that the file is copied locally to <archiveroot>/<hostname>/<filepath>
     Dir.mktmpdir do |tmpdir|
       tar_path = File.join(tmpdir, default, filepath + '.tgz')
       archive_file_from(default, filepath, {}, tmpdir, tar_path)
-      assert(File.exist?(tar_path))
+
+      assert_path_exists(tar_path)
       expected_path = File.join(tmpdir, default)
 
       tgz = Zlib::GzipReader.new(File.open(tar_path, 'rb'))
       Minitar.unpack(tgz, expected_path)
+
       assert_equal('number of the beast', File.read(expected_path + '/' + filepath).strip)
     end
   end

data/acceptance/tests/base/dsl/helpers/host_helpers/backup_the_file_test.rb

@@ -6,6 +6,7 @@ test_name "dsl::helpers::host_helpers #backup_the_file" do
     remote_source = default.tmpdir
     remote_destination = default.tmpdir
     result = backup_the_file default, remote_source, remote_destination
+
     assert_nil result
   end
 
@@ -29,6 +30,7 @@ test_name "dsl::helpers::host_helpers #backup_the_file" do
 
     assert_equal remote_destination_filename, result
     remote_contents = on(default, "cat #{remote_destination_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 
@@ -43,6 +45,7 @@ test_name "dsl::helpers::host_helpers #backup_the_file" do
 
     assert_equal remote_destination_filename, result
     remote_contents = on(default, "cat #{remote_destination_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 

data/acceptance/tests/base/dsl/helpers/host_helpers/check_for_package_test.rb

@@ -25,11 +25,13 @@ test_name "dsl::helpers::host_helpers #check_for_package" do
 
     step "#check_for_package will return false if the specified package is not installed on the remote host" do
       result = check_for_package default, "non-existent-package-name"
+
       assert !result
     end
 
     step "#check_for_package will return true if the specified package is installed on the remote host" do
       result = check_for_package default, known_installed_package
+
       assert result
     end
 
@@ -43,11 +45,13 @@ test_name "dsl::helpers::host_helpers #check_for_package" do
   confine_block :to, :platform => /solaris/ do
     step "#check_for_package will return false if the specified package is not installed on the remote host" do
       result = check_for_package default, "non-existent-package-name"
+
       assert !result
     end
 
     step "#check_for_package will return true if the specified package is installed on the remote host" do
       result = check_for_package default, known_installed_package
+
       assert result
     end
 
@@ -69,12 +73,14 @@ test_name "dsl::helpers::host_helpers #check_for_package" do
   confine_block :except, :platform => /windows|solaris|osx/ do
     step "#check_for_package will return false if the specified package is not installed on the remote host" do
       result = check_for_package default, "non-existent-package-name"
+
       assert !result
     end
 
     step "#check_for_package will return true if the specified package is installed on the remote host" do
       install_package default, known_installed_package
       result = check_for_package default, known_installed_package
+
       assert result
     end
 

data/acceptance/tests/base/dsl/helpers/host_helpers/create_remote_file_test.rb

@@ -43,6 +43,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
     create_remote_file_with_backups default, remote_filename, contents
 
     remote_contents = on(default, "cat #{remote_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 
@@ -54,6 +55,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
     create_remote_file_with_backups default, remote_filename, contents, { :protocol => "scp" }
 
     remote_contents = on(default, "cat #{remote_filename}").stdout
+
     assert_equal contents, remote_contents
   end
 
@@ -72,6 +74,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
 
     hosts.each do |host|
       remote_contents = on(host, "cat #{remote_filename}").stdout
+
       assert_equal contents, remote_contents
     end
   end
@@ -91,6 +94,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
 
     hosts.each do |host|
       remote_contents = on(host, "cat #{remote_filename}").stdout
+
       assert_equal contents, remote_contents
     end
   end
@@ -144,6 +148,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
                            "contents" => contents,
                            "result" => result) do
         remote_contents = on(default, "cat #{remote_filename}").stdout
+
         assert_equal contents, remote_contents
       end
     end
@@ -171,6 +176,7 @@ test_name "dsl::helpers::host_helpers #create_remote_file" do
                              "contents" => contents,
                              "result" => result) do
           remote_contents = on(host, "cat #{remote_filename}").stdout
+
           assert_equal contents, remote_contents
         end
       end