beaker 4.41.2 → 5.0.0

data/Rakefile

@@ -4,7 +4,7 @@ require 'beaker-hostgenerator'
 require 'beaker'
 HOSTS_PRESERVED  = 'log/latest/hosts_preserved.yml'
 
-task :default => [ 'test:spec' ]
+task :default => ['test:spec']
 
 task :test do
   Rake::Task['test:spec'].invoke
@@ -14,9 +14,7 @@ task :spec do
   Rake::Task['test:spec'].invoke
 end
 
-
-task :acceptance => ['test:base', 'test:puppetgit', 'test:hypervisor']
-
+task :acceptance => ['test:base', 'test:hypervisor']
 
 task :yard do
   Rake::Task['docs:gen'].invoke
@@ -28,9 +26,9 @@ end
 
 module HarnessOptions
   defaults = {
-      :tests  => ['tests'],
-      :log_level => 'debug',
-      :preserve_hosts => 'onfail',
+    :tests => ['tests'],
+    :log_level => 'debug',
+    :preserve_hosts => 'onfail',
   }
 
   DEFAULTS = defaults
@@ -60,31 +58,28 @@ module HarnessOptions
     final_options.merge!(intermediary_options)
     final_options.merge!(local_overrides)
   end
-
 end
 
 def hosts_file_env
-  ENV['BEAKER_HOSTS']
+  ENV.fetch('BEAKER_HOSTS', nil)
 end
 
-def hosts_opt(use_preserved_hosts=false)
+def hosts_opt(use_preserved_hosts = false)
   if use_preserved_hosts
     "--hosts=#{HOSTS_PRESERVED}"
+  elsif hosts_file_env
+    "--hosts=#{hosts_file_env}"
   else
-    if hosts_file_env
-      "--hosts=#{hosts_file_env}"
-    else
-      "--hosts=tmp/#{HOSTS_FILE}"
-    end
+    "--hosts=tmp/#{HOSTS_FILE}"
   end
 end
 
 def agent_target
-  ENV['TEST_TARGET'] || 'redhat7-64af'
+  ENV['TEST_TARGET'] || 'centos7-64af'
 end
 
 def master_target
-  ENV['MASTER_TEST_TARGET'] || 'redhat7-64default.mdcal'
+  ENV['MASTER_TEST_TARGET'] || 'centos7-64default.mdcal'
 end
 
 def test_targets
@@ -94,11 +89,10 @@ end
 HOSTS_FILE = "#{test_targets}-#{SecureRandom.uuid}.yaml"
 
 def beaker_test(mode = :base, options = {})
-
   preserved_hosts_mode = options[:hosts] == HOSTS_PRESERVED
   final_options = HarnessOptions.final_options(mode, options)
 
-  options_opt  = ""
+  options_opt = ""
   # preserved hosts can not be used with an options file (BKR-670)
   #   one can still use OPTIONS
 
@@ -106,94 +100,88 @@ def beaker_test(mode = :base, options = {})
     options_file = 'merged_options.rb'
     options_opt  = "--options-file=#{options_file}"
     File.open(options_file, 'w') do |merged|
-      merged.puts <<-EOS
-# Copy this file to local_options.rb and adjust as needed if you wish to run
-# with some local overrides.
+      merged.puts <<~EOS
+        # Copy this file to local_options.rb and adjust as needed if you wish to run
+        # with some local overrides.
       EOS
       merged.puts(final_options)
     end
   end
 
-  tests = ENV['TESTS'] || ENV['TEST']
+  tests = ENV['TESTS'] || ENV.fetch('TEST', nil)
   tests_opt = ""
   tests_opt = "--tests=#{tests}" if tests
 
   overriding_options = ENV['OPTIONS'].to_s
 
-  args = [options_opt, hosts_opt(preserved_hosts_mode), tests_opt,
-          *overriding_options.split(' ')].compact
+  args = [options_opt, hosts_opt(preserved_hosts_mode), tests_opt, *overriding_options.split(' ')].compact
 
   sh("beaker", *args)
 end
 
-
 namespace :test do
-  USAGE = <<-EOS
-You may set BEAKER_HOSTS=config/nodes/foo.yaml or include it in an acceptance-options.rb for Beaker,
-or specify TEST_TARGET in a form beaker-hostgenerator accepts, e.g. ubuntu1504-64a.
-You may override the default master test target by specifying MASTER_TEST_TARGET.
-You may set TESTS=path/to/test,and/more/tests.
-You may set additional Beaker OPTIONS='--more --options'
-If there is a Beaker options hash in a ./acceptance/local_options.rb, it will be included.
-Commandline options set through the above environment variables will override settings in this file.
+  USAGE = <<~EOS
+    You may set BEAKER_HOSTS=config/nodes/foo.yaml or include it in an acceptance-options.rb for Beaker,
+    or specify TEST_TARGET in a form beaker-hostgenerator accepts, e.g. ubuntu1504-64a.
+    You may override the default master test target by specifying MASTER_TEST_TARGET.
+    You may set TESTS=path/to/test,and/more/tests.
+    You may set additional Beaker OPTIONS='--more --options'
+    If there is a Beaker options hash in a ./acceptance/local_options.rb, it will be included.
+    Commandline options set through the above environment variables will override settings in this file.
   EOS
 
   desc 'Run specs and check for deprecation warnings'
   task :spec do
-    original_dir = Dir.pwd
-    Dir.chdir( File.expand_path(File.dirname(__FILE__)) )
-    exit_status = 1
-    output = ''
-    Open3.popen3("bundle exec rspec") {|_stdin, stdout, _stderr, wait_thr|
-      while(line = stdout.gets)
-        puts line
-      end
-      output = stdout.to_s
-      if not wait_thr.value.success?
-        fail "Failed to 'bundle exec rspec' (exit status: #{wait_thr.value})"
+    Dir.chdir(__dir__) do
+      exit_status = 1
+      output = ''
+      Open3.popen3("bundle exec rspec") do |_stdin, stdout, _stderr, wait_thr|
+        while (line = stdout.gets)
+          puts line
+        end
+        output = stdout.to_s
+        fail "Failed to 'bundle exec rspec' (exit status: #{wait_thr.value})" if not wait_thr.value.success?
+
+        exit_status = wait_thr.value
       end
-      exit_status = wait_thr.value
-    }
-    if exit_status != /0/
-      #check for deprecation warnings
-      if output.include?('Deprecation Warnings')
-        fail "DEPRECATION WARNINGS in spec generation, please fix!"
+      if exit_status != /0/
+        # check for deprecation warnings
+        fail "DEPRECATION WARNINGS in spec generation, please fix!" if output.include?('Deprecation Warnings')
       end
     end
-    Dir.chdir( original_dir )
   end
 
-  desc <<-EOS
-Run the base beaker acceptance tests
-#{USAGE}
+  desc <<~EOS
+    Run the base beaker acceptance tests
+    #{USAGE}
   EOS
-  task :base  => 'gen_hosts' do
+  task :base => 'gen_hosts' do
     beaker_test(:base)
   end
 
-  desc <<-EOS
-Run the subcommand beaker acceptance tests
-#{USAGE}
+  desc <<~EOS
+    Run the subcommand beaker acceptance tests
+    #{USAGE}
   EOS
   task :subcommands => 'gen_hosts' do
     beaker_test(:subcommands)
   end
 
-  desc <<-EOS
-Run the hypervisor beaker acceptance tests
-#{USAGE}
+  desc <<~EOS
+    Run the hypervisor beaker acceptance tests
+    #{USAGE}
   EOS
-  task :hypervisor  => 'gen_hosts' do
+  task :hypervisor => 'gen_hosts' do
     beaker_test(:hypervisor)
   end
 
-
   desc 'Generate Beaker Host Config File'
   task :gen_hosts do
-    if hosts_file_env
-      next
-    end
-    cli = BeakerHostGenerator::CLI.new([test_targets])
+    next if hosts_file_env
+
+    arguments = [test_targets]
+    arguments += ['--hypervisor', ENV['BEAKER_HYPERVISOR']] if ENV['BEAKER_HYPERVISOR']
+    cli = BeakerHostGenerator::CLI.new(arguments)
     FileUtils.mkdir_p('tmp') # -p ignores when dir already exists
     File.open("tmp/#{HOSTS_FILE}", 'w') do |fh|
       fh.print(cli.execute)
@@ -201,7 +189,6 @@ Run the hypervisor beaker acceptance tests
   end
 end
 
-
 ###########################################################
 #
 #   History Tasks
@@ -210,16 +197,12 @@ end
 namespace :history do
   desc 'Generate HISTORY.md'
   task :gen do
-    original_dir = Dir.pwd
-    Dir.chdir( File.expand_path(File.dirname(__FILE__)) )
-    output = `bundle exec ruby history.rb .`
-    puts output
-    if !output.include?('success')
-      raise "History generation failed"
+    Dir.chdir(__dir__) do
+      output = `bundle exec ruby history.rb .`
+      puts output
+      raise "History generation failed" if !output.include?('success')
     end
-    Dir.chdir( original_dir )
   end
-
 end
 
 ###########################################################
@@ -231,62 +214,53 @@ DOCS_DIR = 'yard_docs'
 DOCS_DAEMON = "yard server --reload --daemon --docroot #{DOCS_DIR}"
 FOREGROUND_SERVER = "bundle exec yard server --reload --verbose lib/beaker --docroot #{DOCS_DIR}"
 
-def running?( cmdline )
+def running?(cmdline)
   ps = `ps -ef`
-  found = ps.lines.grep( /#{Regexp.quote( cmdline )}/ )
-  if found.length > 1
-    raise StandardError, "Found multiple YARD Servers. Don't know what to do."
-  end
+  found = ps.lines.grep(/#{Regexp.quote(cmdline)}/)
+  raise StandardError, "Found multiple YARD Servers. Don't know what to do." if found.length > 1
 
   yes = found.empty? ? false : true
   return yes, found.first
 end
 
-def pid_from( output )
+def pid_from(output)
   output.squeeze(' ').strip.split(' ')[1]
 end
 
 desc 'Start the documentation server in the foreground'
 task :docs => 'docs:clear' do
-  original_dir = Dir.pwd
-  Dir.chdir( File.expand_path(File.dirname(__FILE__)) )
-  sh FOREGROUND_SERVER
-  Dir.chdir( original_dir )
+  Dir.chdir(__dir__) do
+    sh FOREGROUND_SERVER
+  end
 end
 
 namespace :docs do
-
   desc 'Clear the generated documentation cache'
   task :clear do
-    original_dir = Dir.pwd
-    Dir.chdir( File.expand_path(File.dirname(__FILE__)) )
-    sh "rm -rf #{DOCS_DIR}"
-    Dir.chdir( original_dir )
+    Dir.chdir(__dir__) do
+      sh "rm -rf #{DOCS_DIR}"
+    end
   end
 
   desc 'Generate static documentation'
   task :gen => 'docs:clear' do
-    original_dir = Dir.pwd
-    Dir.chdir( File.expand_path(File.dirname(__FILE__)) )
-    output = `bundle exec yard doc -o #{DOCS_DIR}`
-    puts output
-    if /\[warn\]|\[error\]/.match?(output)
-      fail "Errors/Warnings during yard documentation generation"
+    Dir.chdir(__dir__) do
+      output = `bundle exec yard doc -o #{DOCS_DIR}`
+      puts output
+      fail "Errors/Warnings during yard documentation generation" if /\[warn\]|\[error\]/.match?(output)
     end
-    Dir.chdir( original_dir )
   end
 
   desc 'Run the documentation server in the background, alias `bg`'
   task :background => 'docs:clear' do
-    yes, output = running?( DOCS_DAEMON )
+    yes, output = running?(DOCS_DAEMON)
     if yes
       puts "Not starting a new YARD Server..."
-      puts "Found one running with pid #{pid_from( output )}."
+      puts "Found one running with pid #{pid_from(output)}."
     else
-      original_dir = Dir.pwd
-      Dir.chdir( File.expand_path(File.dirname(__FILE__)) )
-      sh "bundle exec #{DOCS_DAEMON}"
-      Dir.chdir( original_dir )
+      Dir.chdir(__dir__) do
+        sh "bundle exec #{DOCS_DAEMON}"
+      end
     end
   end
 
@@ -294,9 +268,9 @@ namespace :docs do
 
   desc 'Check the status of the documentation server'
   task :status do
-    yes, output = running?( DOCS_DAEMON )
+    yes, output = running?(DOCS_DAEMON)
     if yes
-      pid = pid_from( output )
+      pid = pid_from(output)
       puts "Found a YARD Server running with pid #{pid}"
     else
       puts "Could not find a running YARD Server."
@@ -305,16 +279,16 @@ namespace :docs do
 
   desc "Stop a running YARD Server"
   task :stop do
-    yes, output = running?( DOCS_DAEMON )
+    yes, output = running?(DOCS_DAEMON)
     if yes
-      pid = pid_from( output )
+      pid = pid_from(output)
       puts "Found a YARD Server running with pid #{pid}"
       `kill #{pid}`
       puts "Stopping..."
-      yes, _output = running?( DOCS_DAEMON )
+      yes, _output = running?(DOCS_DAEMON)
       if yes
         `kill -9 #{pid}`
-        yes, _output = running?( DOCS_DAEMON )
+        yes, _output = running?(DOCS_DAEMON)
         if yes
           puts "Could not Stop Server!"
         else
@@ -343,3 +317,17 @@ begin
 rescue LoadError
   # Optional group in bundler
 end
+
+begin
+  require 'rubocop/rake_task'
+rescue LoadError
+  # RuboCop is an optional group
+else
+  RuboCop::RakeTask.new(:rubocop) do |task|
+    # These make the rubocop experience maybe slightly less terrible
+    task.options = ['--display-cop-names', '--display-style-guide', '--extra-details']
+
+    # Use Rubocop's Github Actions formatter if possible
+    task.formatters << 'github' if ENV['GITHUB_ACTIONS'] == 'true'
+  end
+end

data/acceptance/config/acceptance-options.rb

@@ -1,6 +1,6 @@
 {
   :load_path => File.join('acceptance', 'lib'),
   :ssh => {
-    :keys => ["id_rsa_acceptance", "#{ENV['HOME']}/.ssh/id_rsa-acceptance"],
+    :keys => ["id_rsa_acceptance", "#{ENV.fetch('HOME', nil)}/.ssh/id_rsa-acceptance"],
   },
 }

data/acceptance/config/base/acceptance-options.rb

@@ -1,3 +1,3 @@
 {
-    :tests                => 'acceptance/tests/base'
-}.merge(eval File.read('acceptance/config/acceptance-options.rb'))
+  :tests => 'acceptance/tests/base',
+}.merge(eval File.read('acceptance/config/acceptance-options.rb'))

data/acceptance/config/hypervisor/acceptance-options.rb

@@ -1,3 +1,3 @@
 {
-    :tests                => 'acceptance/tests/hypervisor'
-}.merge(eval File.read('acceptance/config/acceptance-options.rb'))
+  :tests => 'acceptance/tests/hypervisor',
+}.merge(eval File.read('acceptance/config/acceptance-options.rb'))

data/acceptance/config/subcommands/acceptance-options.rb

@@ -1,4 +1,4 @@
 {
-    :pre_suite => 'acceptance/pre_suite/subcommands/',
-    :tests => 'acceptance/tests/subcommands/'
+  :pre_suite => 'acceptance/pre_suite/subcommands/',
+  :tests => 'acceptance/tests/subcommands/',
 }.merge(eval File.read('acceptance/config/acceptance-options.rb'))

data/acceptance/fixtures/module/Rakefile

@@ -9,7 +9,7 @@ task :validate do
   Dir['manifests/**/*.pp'].each do |manifest|
     sh "puppet parser validate --noop #{manifest}"
   end
-  Dir['spec/**/*.rb','lib/**/*.rb'].each do |ruby_file|
+  Dir['spec/**/*.rb', 'lib/**/*.rb'].each do |ruby_file|
     sh "ruby -c #{ruby_file}" unless ruby_file.include?('spec/fixtures')
   end
   Dir['templates/**/*.erb'].each do |template|

data/acceptance/fixtures/module/spec/acceptance/demo_spec.rb

@@ -1,11 +1,10 @@
 require 'spec_helper_acceptance'
 
 describe "my tests" do
-
   # an example using the beaker DSL
   # use http://www.rubydoc.info/github/puppetlabs/beaker/Beaker/DSL
   it "says hello!" do
-    result = shell( 'echo hello' )
+    result = shell('echo hello')
     expect(result.stdout).to match(/hello/)
   end
 
@@ -16,10 +15,10 @@ describe "my tests" do
   end
 
   it "can create and confirm a file" do
-    shell( 'rm -f demo.txt' )
+    shell('rm -f demo.txt')
     create_remote_file(default, 'demo.txt', 'foo\nfoo\nfoo\n')
-    shell( 'grep foo demo.txt' )
-    shell( 'grep bar demo.txt', :acceptable_exit_codes => [1] )
+    shell('grep foo demo.txt')
+    shell('grep bar demo.txt', :acceptable_exit_codes => [1])
   end
 
   it "is able to apply manifests" do
@@ -29,9 +28,9 @@ describe "my tests" do
           ensure => absent,}"
     manifest_3 = "user {'root':
           ensure => present,}"
-    apply_manifest( manifest_1, :expect_changes => true )
-    apply_manifest( manifest_2, :expect_changes => true )
-    apply_manifest( manifest_3 )
+    apply_manifest(manifest_1, :expect_changes => true)
+    apply_manifest(manifest_2, :expect_changes => true)
+    apply_manifest(manifest_3)
   end
 
   describe service('sshd') do
@@ -47,9 +46,8 @@ describe "my tests" do
   end
 
   context "can use both serverspec and Beaker DSL" do
-
     it "can create a file" do
-      shell( 'rm -f /tmp/demo.txt' )
+      shell('rm -f /tmp/demo.txt')
       manifest = "file {'demofile':
         path    => '/tmp/demo.txt',
         ensure  => present,
@@ -64,6 +62,4 @@ describe "my tests" do
       it { is_expected.to contain 'this is my file.' }
     end
   end
-
-
 end

data/acceptance/fixtures/module/spec/classes/init_spec.rb

@@ -1,6 +1,5 @@
 require 'spec_helper'
 describe 'demo' do
-
   context 'with defaults for all parameters' do
     it { is_expected.to contain_class('demo') }
   end

data/acceptance/fixtures/module/spec/spec_helper_acceptance.rb

@@ -3,7 +3,7 @@ require 'beaker-rspec'
 unless ENV['RS_PROVISION'] == 'no' or ENV['BEAKER_provision'] == 'no'
   # This will install the latest available package on el and deb based
   # systems fail on windows and osx, and install via gem on other *nixes
-  foss_opts = {:default_action => 'gem_install'}
+  foss_opts = { :default_action => 'gem_install' }
 
   if default.is_pe?; then
     install_pe;
@@ -12,16 +12,14 @@ unless ENV['RS_PROVISION'] == 'no' or ENV['BEAKER_provision'] == 'no'
   end
 
   hosts.each do |host|
-    unless host.is_pe?
-      on host, "/bin/echo '' > #{host.puppet('hiera_config')}"
-    end
+    on host, "/bin/echo '' > #{host.puppet('hiera_config')}" unless host.is_pe?
     on host, "mkdir -p #{host['distmoduledir']}"
   end
 end
 
 RSpec.configure do |c|
   # Project root
-  proj_root = File.expand_path(File.join(File.dirname(__FILE__), '..'))
+  proj_root = File.expand_path(File.join(__dir__, '..'))
 
   # Readable test descriptions
   c.formatter = :documentation

data/acceptance/lib/helpers/test_helper.rb

@@ -11,7 +11,7 @@ end
 # Returns the absolute path where file fixtures are located.
 def fixture_path
   @fixture_path ||=
-    File.expand_path(File.join(__FILE__, '..', '..', '..', 'fixtures', 'files'))
+    File.expand_path(File.join(__dir__, '..', '..', 'fixtures', 'files'))
 end
 
 # Returns the contents of a named fixture file, to be found in `fixture_path`.
@@ -27,7 +27,7 @@ def create_remote_file_from_fixture(fixture, host, remote_path, filename)
   full_filename = File.join(remote_path, filename)
   contents = fixture_contents fixture
   create_remote_file host, full_filename, contents
-  [ full_filename, contents ]
+  [full_filename, contents]
 end
 
 # Create a file locally, in the `local_path`, with file name `filename`,
@@ -43,7 +43,7 @@ def create_local_file_from_fixture(fixture, local_path, filename, perms = nil)
   end
   FileUtils.chmod perms, full_filename if perms
 
-  [ full_filename, contents ]
+  [full_filename, contents]
 end
 
 # Provide debugging information for tests which are known to fail intermittently
@@ -59,7 +59,7 @@ end
 #      assert_equal expected, user
 #    end
 #
-# Absorbs any Minitest::Assertion from a failing test assertion in the block.
+# Absorbs any MiniTest::Assertion from a failing test assertion in the block.
 # This implies that the intermittent failure is caught and the suite will not
 # go red for this failure. Intended to be used with the Jenkins Build Failure
 # Analyzer (or similar), to detect these failures without failing the build.
@@ -68,8 +68,9 @@ end
 def fails_intermittently(issue_link, args = {})
   raise ArgumentError, "provide a Jira ticket link" unless issue_link
   raise ArgumentError, "a block is required" unless block_given?
+
   yield
-rescue Minitest::Assertion, StandardError, SignalException # we have a test failure!
+rescue MiniTest::Assertion, StandardError, SignalException # we have a test failure!
   STDERR.puts "\n\nIntermittent test failure! See: #{issue_link}"
 
   if args.empty?

data/acceptance/pre_suite/subcommands/05_install_ruby.rb

@@ -1,13 +1,12 @@
-ruby_version, ruby_source = ENV['RUBY_VER'], "job parameter"
+ruby_version, ruby_source = ENV.fetch('RUBY_VER', nil), "job parameter"
 unless ruby_version
   ruby_version = "2.4.1"
   ruby_source = "default"
 end
 test_name "Install and configure Ruby #{ruby_version} (from #{ruby_source}) on the SUT" do
-
   step 'Ensure that the default system is an el-based system' do
     # The pre-suite currently only supports el systems, and we should
-    #fail early if the default platform is not a supported platform
+    # fail early if the default platform is not a supported platform
     assert(default.platform.variant == 'el',
            "Expected the platform variant to be 'el', not #{default.platform.variant}")
   end

data/acceptance/pre_suite/subcommands/08_install_beaker.rb

@@ -1,7 +1,6 @@
 test_name 'Install beaker and checkout branch if necessary' do
-
   step 'Download the beaker git repo' do
-   on default, 'git clone https://github.com/puppetlabs/beaker.git /opt/beaker/'
+    on default, 'git clone https://github.com/puppetlabs/beaker.git /opt/beaker/'
   end
 
   step 'Detect if checking out branch for testing and checkout' do

data/acceptance/tests/base/dsl/helpers/configuration_test.rb

@@ -1,17 +1,17 @@
-$LOAD_PATH << File.expand_path(File.join(File.dirname(__FILE__), '..', '..', '..', '..', 'lib'))
+$LOAD_PATH << File.expand_path(File.join(__dir__, '..', '..', '..', '..', 'lib'))
 
 require 'helpers/test_helper'
 
 test_name "dsl::helpers::host_helpers test configuration validation" do
   step "Validate hosts configuration" do
     assert (hosts.size > 1),
-      "dsl::helpers::host_helpers acceptance tests require at least two hosts"
+           "dsl::helpers::host_helpers acceptance tests require at least two hosts"
 
     agents = select_hosts(:roles => "agent")
     assert (agents.size > 1),
-      "dsl::helpers::host_helpers acceptance tests require at least two hosts with the :agent role"
+           "dsl::helpers::host_helpers acceptance tests require at least two hosts with the :agent role"
 
     assert default,
-      "dsl::helpers::host_helpers acceptance tests require a default host"
+           "dsl::helpers::host_helpers acceptance tests require a default host"
   end
 end

data/acceptance/tests/base/dsl/helpers/hocon_helpers_test.rb

@@ -1,7 +1,6 @@
 require 'hocon/config_value_factory'
 
 test_name 'Hocon Helpers Test' do
-
   hocon_filename = 'hocon.conf'
   step 'setup : create hocon file to play with' do
     hocon_content = <<-END
@@ -91,4 +90,4 @@ test_name 'Hocon Helpers Test' do
       end
     end
   end
-end
+end

data/acceptance/tests/base/dsl/helpers/host_helpers/add_system32_hosts_entry_test.rb

@@ -1,9 +1,7 @@
 require "helpers/test_helper"
 
 test_name "dsl::helpers::host_helpers #add_system32_hosts_entry" do
-
   confine_block :to, :platform => /windows/ do
-
     step "#add_system32_hosts_entry fails when run on a non-powershell platform" do
       # NOTE: would expect this to be better documented.
       if default.is_powershell?
@@ -36,7 +34,6 @@ test_name "dsl::helpers::host_helpers #add_system32_hosts_entry" do
   end
 
   confine_block :except, :platform => /windows/ do
-
     step "#add_system32_hosts_entry CURRENTLY fails with RuntimeError when run on a non-windows platform" do
       # NOTE: would expect this to behave the same way it does on a windows
       #       non-powershell platform (raises Beaker::Host::CommandFailure), or

data/acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb

@@ -1,7 +1,6 @@
 require "helpers/test_helper"
 
 test_name "dsl::helpers::host_helpers #archive_file_from" do
-
   step "archiveroot parameter defaults to `archive/sut-files`" do
     # Create a remote file to archive
     filepath = default.tmpfile('archive-file-test')
@@ -20,6 +19,9 @@ test_name "dsl::helpers::host_helpers #archive_file_from" do
   end
 
   step "fails archive_file_from when from_path is non-existant" do
+    # beaker-docker can't deal with closing the connection
+    confine :except, :hypervisor => 'docker'
+
     filepath = "foo-filepath-should-not-exist"
     assert_raises IOError do
       archive_file_from(default, filepath)