beaker 4.40.1 → 5.0.0

data/spec/beaker/host_prebuilt_steps_spec.rb

@@ -1,43 +1,41 @@
 require 'spec_helper'
 
 describe Beaker do
-  let( :options )        { make_opts.merge({ 'logger' => double().as_null_object }) }
-  let( :ntpserver_set )  { "ntp_server_set" }
-  let( :options_ntp )    { make_opts.merge({ 'ntp_server' => ntpserver_set }) }
-  let( :ntpserver )      { Beaker::HostPrebuiltSteps::NTPSERVER }
-  let( :apt_cfg )        { Beaker::HostPrebuiltSteps::APT_CFG }
-  let( :ips_pkg_repo )   { Beaker::HostPrebuiltSteps::IPS_PKG_REPO }
-  let( :sync_cmd )       { Beaker::HostPrebuiltSteps::ROOT_KEYS_SYNC_CMD }
-  let( :windows_pkgs )   { Beaker::HostPrebuiltSteps::WINDOWS_PACKAGES }
-  let( :unix_only_pkgs ) { Beaker::HostPrebuiltSteps::UNIX_PACKAGES }
-  let( :sles_only_pkgs ) { Beaker::HostPrebuiltSteps::SLES_PACKAGES }
-  let( :rhel8_packages ) { Beaker::HostPrebuiltSteps::RHEL8_PACKAGES }
-  let( :fedora_packages) { Beaker::HostPrebuiltSteps::FEDORA_PACKAGES }
-  let( :platform )       { @platform || 'unix' }
-  let( :ip )             { "ip.address.0.0" }
-  let( :stdout)          { @stdout || ip }
-  let( :hosts )          { hosts = make_hosts( { :stdout => stdout, :platform => platform } )
-                           hosts[0][:roles] = ['agent']
-                           hosts[1][:roles] = ['master', 'dashboard', 'agent', 'database']
-                           hosts[2][:roles] = ['agent']
-                           hosts }
-  let( :dummy_class )    { Class.new { include Beaker::HostPrebuiltSteps } }
+  let(:options)        { make_opts.merge({ 'logger' => double.as_null_object }) }
+  let(:ntpserver_set)  { "ntp_server_set" }
+  let(:options_ntp)    { make_opts.merge({ 'ntp_server' => ntpserver_set }) }
+  let(:ntpserver)      { Beaker::HostPrebuiltSteps::NTPSERVER }
+  let(:sync_cmd)       { Beaker::HostPrebuiltSteps::ROOT_KEYS_SYNC_CMD }
+  let(:windows_pkgs)   { Beaker::HostPrebuiltSteps::WINDOWS_PACKAGES }
+  let(:unix_only_pkgs) { Beaker::HostPrebuiltSteps::UNIX_PACKAGES }
+  let(:sles_only_pkgs) { Beaker::HostPrebuiltSteps::SLES_PACKAGES }
+  let(:rhel8_packages) { Beaker::HostPrebuiltSteps::RHEL8_PACKAGES }
+  let(:fedora_packages) { Beaker::HostPrebuiltSteps::FEDORA_PACKAGES }
+  let(:platform)       { @platform || 'unix' }
+  let(:ip)             { "ip.address.0.0" }
+  let(:stdout) { @stdout || ip }
+  let(:hosts) do
+    hosts = make_hosts({ :stdout => stdout, :platform => platform })
+    hosts[0][:roles] = ['agent']
+    hosts[1][:roles] = %w[master dashboard agent database]
+    hosts[2][:roles] = ['agent']
+    hosts
+  end
+  let(:dummy_class) { Class.new { include Beaker::HostPrebuiltSteps } }
 
   shared_examples 'enables_root_login' do |platform, commands, non_cygwin|
     subject { dummy_class.new }
 
     it "can enable root login on #{platform}" do
-      hosts = make_hosts( { :platform => platform, :is_cygwin => non_cygwin} )
+      hosts = make_hosts({ :platform => platform, :is_cygwin => non_cygwin })
 
-      if commands.empty?
-        expect( Beaker::Command ).to receive( :new ).exactly( 0 ).times
-      end
+      expect(Beaker::Command).to receive(:new).exactly(0).times if commands.empty?
 
-      commands.each do | command |
-        expect( Beaker::Command ).to receive( :new ).with(command).exactly( 3 ).times
+      commands.each do |command|
+        expect(Beaker::Command).to receive(:new).with(command).exactly(3).times
       end
 
-      subject.enable_root_login( hosts, options )
+      subject.enable_root_login(hosts, options)
     end
   end
 
@@ -47,109 +45,106 @@ describe Beaker do
 
   # Non-cygwin Windows
   it_behaves_like 'enables_root_login', 'windows', [
-    "sed -ri 's/^#?PermitRootLogin /PermitRootLogin yes/' /etc/sshd_config"
+    "sed -ri 's/^#?PermitRootLogin /PermitRootLogin yes/' /etc/sshd_config",
   ], true
 
   # FreeBSD
   it_behaves_like 'enables_root_login', 'freesbd', [
-    "sudo su -c \"sed -ri 's/^#?PermitRootLogin no|^#?PermitRootLogin yes/PermitRootLogin yes/' /etc/ssh/sshd_config\""
+    "sudo su -c \"sed -ri 's/^#?PermitRootLogin no|^#?PermitRootLogin yes/PermitRootLogin yes/' /etc/ssh/sshd_config\"",
   ], true
 
   it_behaves_like 'enables_root_login', 'osx-10.10', [
     "sudo sed -i '' 's/#PermitRootLogin yes/PermitRootLogin Yes/g' /etc/sshd_config",
-    "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /etc/sshd_config"
+    "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /etc/sshd_config",
   ]
 
   it_behaves_like 'enables_root_login', 'osx-10.11', [
     "sudo sed -i '' 's/#PermitRootLogin yes/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
-    "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config"
+    "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
   ]
 
   it_behaves_like 'enables_root_login', 'osx-10.12', [
-      "sudo sed -i '' 's/#PermitRootLogin yes/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
-      "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config"
+    "sudo sed -i '' 's/#PermitRootLogin yes/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
+    "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
   ]
 
   it_behaves_like 'enables_root_login', 'osx-10.13', [
-      "sudo sed -i '' 's/#PermitRootLogin yes/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
-      "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config"
+    "sudo sed -i '' 's/#PermitRootLogin yes/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
+    "sudo sed -i '' 's/#PermitRootLogin no/PermitRootLogin Yes/g' /private/etc/ssh/sshd_config",
   ]
 
   # Solaris
   it_behaves_like 'enables_root_login', 'solaris-10', [
     "sudo -E svcadm restart network/ssh",
-    "sudo gsed -i -e 's/#PermitRootLogin no/PermitRootLogin yes/g' /etc/ssh/sshd_config"
+    "sudo gsed -i -e 's/#PermitRootLogin no/PermitRootLogin yes/g' /etc/ssh/sshd_config",
   ], true
 
   it_behaves_like 'enables_root_login', 'solaris-11', [
     "sudo -E svcadm restart network/ssh",
     "sudo gsed -i -e 's/PermitRootLogin no/PermitRootLogin yes/g' /etc/ssh/sshd_config",
-    "if grep \"root::::type=role\" /etc/user_attr; then sudo rolemod -K type=normal root; else echo \"root user already type=normal\"; fi"
+    "if grep \"root::::type=role\" /etc/user_attr; then sudo rolemod -K type=normal root; else echo \"root user already type=normal\"; fi",
   ], true
 
-  ['debian','ubuntu','cumulus'].each do | deb_like |
+  %w[debian ubuntu cumulus].each do |deb_like|
     it_behaves_like 'enables_root_login', deb_like, [
       "sudo su -c \"sed -ri 's/^#?PermitRootLogin no|^#?PermitRootLogin yes/PermitRootLogin yes/' /etc/ssh/sshd_config\"",
-      "sudo su -c \"service ssh restart\""
+      "sudo su -c \"service ssh restart\"",
     ]
   end
 
-  ['centos','el-','redhat','fedora','eos'].each do | redhat_like |
+  ['centos', 'el-', 'redhat', 'fedora', 'eos'].each do |redhat_like|
     it_behaves_like 'enables_root_login', redhat_like, [
       "sudo su -c \"sed -ri 's/^#?PermitRootLogin no|^#?PermitRootLogin yes/PermitRootLogin yes/' /etc/ssh/sshd_config\"",
-      "sudo -E /sbin/service sshd reload"
+      "sudo -E /sbin/service sshd reload",
     ]
   end
 
   context 'timesync' do
-
     subject { dummy_class.new }
 
     it "can sync time on unix hosts" do
-      hosts = make_hosts( { :platform => 'unix' } )
+      hosts = make_hosts({ :platform => 'unix' })
 
-      expect( Beaker::Command ).to receive( :new ).with("ntpdate -u -t 20 #{ntpserver}").exactly( 3 ).times
+      expect(Beaker::Command).to receive(:new).with("ntpdate -u -t 20 #{ntpserver}").exactly(3).times
 
-      subject.timesync( hosts, options )
+      subject.timesync(hosts, options)
     end
 
     it "can retry on failure on unix hosts" do
-      hosts = make_hosts( { :platform => 'unix', :exit_code => [1, 0] } )
-      allow( subject ).to receive( :sleep ).and_return(true)
+      hosts = make_hosts({ :platform => 'unix', :exit_code => [1, 0] })
+      allow(subject).to receive(:sleep).and_return(true)
 
-      expect( Beaker::Command ).to receive( :new ).with("ntpdate -u -t 20 #{ntpserver}").exactly( 6 ).times
+      expect(Beaker::Command).to receive(:new).with("ntpdate -u -t 20 #{ntpserver}").exactly(6).times
 
-      subject.timesync( hosts, options )
+      subject.timesync(hosts, options)
     end
 
     it "eventually gives up and raises an error when unix hosts can't be synched" do
-      hosts = make_hosts( { :platform => 'unix', :exit_code => 1 } )
-      allow( subject ).to receive( :sleep ).and_return(true)
+      hosts = make_hosts({ :platform => 'unix', :exit_code => 1 })
+      allow(subject).to receive(:sleep).and_return(true)
 
-      expect( Beaker::Command ).to receive( :new ).with("ntpdate -u -t 20 #{ntpserver}").exactly( 5 ).times
+      expect(Beaker::Command).to receive(:new).with("ntpdate -u -t 20 #{ntpserver}").exactly(5).times
 
-      expect{ subject.timesync( hosts, options ) }.to raise_error(/NTP date was not successful after/)
+      expect { subject.timesync(hosts, options) }.to raise_error(/NTP date was not successful after/)
     end
 
     it "can sync time on windows hosts" do
-      hosts = make_hosts( { :platform => 'windows' } )
-
-      expect( Beaker::Command ).to receive( :new ).with("w32tm /register").exactly( 3 ).times
-      expect( Beaker::Command ).to receive( :new ).with("net start w32time").exactly( 3 ).times
-      expect( Beaker::Command ).to receive( :new ).with("w32tm /config /manualpeerlist:#{ntpserver} /syncfromflags:manual /update").exactly( 3 ).times
-      expect( Beaker::Command ).to receive( :new ).with("w32tm /resync").exactly( 3 ).times
+      hosts = make_hosts({ :platform => 'windows' })
 
-      subject.timesync( hosts, options )
+      expect(Beaker::Command).to receive(:new).with("w32tm /register").exactly(3).times
+      expect(Beaker::Command).to receive(:new).with("net start w32time").exactly(3).times
+      expect(Beaker::Command).to receive(:new).with("w32tm /config /manualpeerlist:#{ntpserver} /syncfromflags:manual /update").exactly(3).times
+      expect(Beaker::Command).to receive(:new).with("w32tm /resync").exactly(3).times
 
+      subject.timesync(hosts, options)
     end
 
     it "can sync time on Sles hosts" do
-      hosts = make_hosts( { :platform => 'sles-13.1-x64' } )
-
-      expect( Beaker::Command ).to receive( :new ).with("sntp #{ntpserver}").exactly( 3 ).times
+      hosts = make_hosts({ :platform => 'sles-13.1-x64' })
 
-      subject.timesync( hosts, options )
+      expect(Beaker::Command).to receive(:new).with("sntp #{ntpserver}").exactly(3).times
 
+      subject.timesync(hosts, options)
     end
 
     it "can sync time on RHEL8 hosts" do
@@ -171,32 +166,30 @@ describe Beaker do
     end
 
     it "can set time server on unix hosts" do
-      hosts = make_hosts( { :platform => 'unix' } )
+      hosts = make_hosts({ :platform => 'unix' })
 
-      expect( Beaker::Command ).to receive( :new ).with("ntpdate -u -t 20 #{ntpserver_set}").exactly( 3 ).times
+      expect(Beaker::Command).to receive(:new).with("ntpdate -u -t 20 #{ntpserver_set}").exactly(3).times
 
-      subject.timesync( hosts, options_ntp )
+      subject.timesync(hosts, options_ntp)
     end
 
     it "can set time server on windows hosts" do
-      hosts = make_hosts( { :platform => 'windows' } )
+      hosts = make_hosts({ :platform => 'windows' })
 
-      expect( Beaker::Command ).to receive( :new ).with("w32tm /register").exactly( 3 ).times
-      expect( Beaker::Command ).to receive( :new ).with("net start w32time").exactly( 3 ).times
-      expect( Beaker::Command ).to receive( :new ).with("w32tm /config /manualpeerlist:#{ntpserver_set} /syncfromflags:manual /update").exactly( 3 ).times
-      expect( Beaker::Command ).to receive( :new ).with("w32tm /resync").exactly( 3 ).times
-
-      subject.timesync( hosts, options_ntp )
+      expect(Beaker::Command).to receive(:new).with("w32tm /register").exactly(3).times
+      expect(Beaker::Command).to receive(:new).with("net start w32time").exactly(3).times
+      expect(Beaker::Command).to receive(:new).with("w32tm /config /manualpeerlist:#{ntpserver_set} /syncfromflags:manual /update").exactly(3).times
+      expect(Beaker::Command).to receive(:new).with("w32tm /resync").exactly(3).times
 
+      subject.timesync(hosts, options_ntp)
     end
 
     it "can set time server on Sles hosts" do
-      hosts = make_hosts( { :platform => 'sles-13.1-x64' } )
-
-      expect( Beaker::Command ).to receive( :new ).with("sntp #{ntpserver_set}").exactly( 3 ).times
+      hosts = make_hosts({ :platform => 'sles-13.1-x64' })
 
-      subject.timesync( hosts, options_ntp )
+      expect(Beaker::Command).to receive(:new).with("sntp #{ntpserver_set}").exactly(3).times
 
+      subject.timesync(hosts, options_ntp)
     end
 
     it "can set time server on RHEL8 hosts" do
@@ -213,41 +206,36 @@ describe Beaker do
     subject { dummy_class.new }
 
     it "can perform apt-get on ubuntu hosts" do
-      host = make_host( 'testhost', { :platform => 'ubuntu' } )
-
-      expect( Beaker::Command ).to receive( :new ).with("apt-get update").once
+      host = make_host('testhost', { :platform => 'ubuntu' })
 
-      subject.apt_get_update( host )
+      expect(Beaker::Command).to receive(:new).with("apt-get update").once
 
+      subject.apt_get_update(host)
     end
 
     it "can perform apt-get on debian hosts" do
-      host = make_host( 'testhost', { :platform => 'debian' } )
+      host = make_host('testhost', { :platform => 'debian' })
 
-      expect( Beaker::Command ).to receive( :new ).with("apt-get update").once
-
-      subject.apt_get_update( host )
+      expect(Beaker::Command).to receive(:new).with("apt-get update").once
 
+      subject.apt_get_update(host)
     end
 
     it "can perform apt-get on cumulus hosts" do
-      host = make_host( 'testhost', { :platform => 'cumulus' } )
-
-      expect( Beaker::Command ).to receive( :new ).with("apt-get update").once
+      host = make_host('testhost', { :platform => 'cumulus' })
 
-      subject.apt_get_update( host )
+      expect(Beaker::Command).to receive(:new).with("apt-get update").once
 
+      subject.apt_get_update(host)
     end
 
     it "does nothing on non debian/ubuntu/cumulus hosts" do
-      host = make_host( 'testhost', { :platform => 'windows' } )
+      host = make_host('testhost', { :platform => 'windows' })
 
-      expect( Beaker::Command ).not_to receive( :new )
-
-      subject.apt_get_update( host )
+      expect(Beaker::Command).not_to receive(:new)
 
+      subject.apt_get_update(host)
     end
-
   end
 
   context "copy_file_to_remote" do
@@ -257,125 +245,17 @@ describe Beaker do
       content = "this is the content"
       tempfilepath = "/path/to/tempfile"
       filepath = "/path/to/file"
-      host = make_host( 'testhost', { :platform => 'windows' })
-      tempfile = double( 'tempfile' )
-      allow( tempfile ).to receive( :path ).and_return( tempfilepath )
-      allow( Tempfile ).to receive( :open ).and_yield( tempfile )
-      file = double( 'file' )
-      allow( File ).to receive( :open ).and_yield( file )
+      host = make_host('testhost', { :platform => 'windows' })
+      tempfile = double('tempfile')
+      allow(tempfile).to receive(:path).and_return(tempfilepath)
+      allow(Tempfile).to receive(:open).and_yield(tempfile)
+      file = double('file')
+      allow(File).to receive(:open).and_yield(file)
 
-      expect( file ).to receive( :puts ).with( content ).once
-      expect( host ).to receive( :do_scp_to ).with( tempfilepath, filepath, subject.instance_variable_get( :@options ) ).once
+      expect(file).to receive(:puts).with(content).once
+      expect(host).to receive(:do_scp_to).with(tempfilepath, filepath, subject.instance_variable_get(:@options)).once
 
       subject.copy_file_to_remote(host, filepath, content)
-
-    end
-
-  end
-
-  context "proxy_config" do
-    subject { dummy_class.new }
-
-    it "correctly configures ubuntu hosts" do
-      hosts = make_hosts( { :platform => 'ubuntu', :exit_code => 1 } )
-
-      expect( Beaker::Command ).to receive( :new ).with( "if test -f /etc/apt/apt.conf; then mv /etc/apt/apt.conf /etc/apt/apt.conf.bk; fi" ).exactly( 3 )
-      hosts.each do |host|
-        expect( subject ).to receive( :copy_file_to_remote ).with( host, '/etc/apt/apt.conf', apt_cfg ).once
-        expect( subject ).to receive( :apt_get_update ).with( host ).once
-      end
-
-      subject.proxy_config( hosts, options )
-
-    end
-
-    it "correctly configures debian hosts" do
-      hosts = make_hosts( { :platform => 'debian' } )
-
-      expect( Beaker::Command ).to receive( :new ).with( "if test -f /etc/apt/apt.conf; then mv /etc/apt/apt.conf /etc/apt/apt.conf.bk; fi" ).exactly( 3 ).times
-      hosts.each do |host|
-        expect( subject ).to receive( :copy_file_to_remote ).with( host, '/etc/apt/apt.conf', apt_cfg ).once
-        expect( subject ).to receive( :apt_get_update ).with( host ).once
-      end
-
-      subject.proxy_config( hosts, options )
-
-    end
-
-    it "correctly configures cumulus hosts" do
-      hosts = make_hosts( { :platform => 'cumulus' } )
-
-      expect( Beaker::Command ).to receive( :new ).with( "if test -f /etc/apt/apt.conf; then mv /etc/apt/apt.conf /etc/apt/apt.conf.bk; fi" ).exactly( 3 ).times
-      hosts.each do |host|
-        expect( subject ).to receive( :copy_file_to_remote ).with( host, '/etc/apt/apt.conf', apt_cfg ).once
-        expect( subject ).to receive( :apt_get_update ).with( host ).once
-      end
-
-      subject.proxy_config( hosts, options )
-
-    end
-
-    it "correctly configures solaris-11 hosts" do
-      hosts = make_hosts( { :platform => 'solaris-11' } )
-
-      expect( Beaker::Command ).to receive( :new ).with( "/usr/bin/pkg unset-publisher solaris || :" ).exactly( 3 ).times
-      hosts.each do |_host|
-        expect( Beaker::Command ).to receive( :new ).with( "/usr/bin/pkg set-publisher -g %s solaris" % ips_pkg_repo ).once
-      end
-
-      subject.proxy_config( hosts, options )
-
-    end
-
-    it "does nothing for non ubuntu/debian/cumulus/solaris-11 hosts" do
-      hosts = make_hosts( { :platform => 'windows' } )
-
-      expect( Beaker::Command ).not_to receive( :new )
-
-      subject.proxy_config( hosts, options )
-
-    end
-  end
-
-  context "add_el_extras" do
-    subject { dummy_class.new }
-
-    it 'adds extras for el-6 hosts' do
-
-      hosts = make_hosts( { :platform => Beaker::Platform.new('el-6-arch'), :exit_code => 1 }, 4 )
-      hosts[1][:platform] = Beaker::Platform.new('centos-6-arch')
-      hosts[2][:platform] = Beaker::Platform.new('scientific-6-arch')
-      hosts[3][:platform] = Beaker::Platform.new('redhat-6-arch')
-
-      expect( Beaker::Command ).to receive( :new ).with(
-        "rpm -qa | grep epel-release"
-      ).exactly( hosts.count ).times
-      hosts.each do |host|
-        expect(host).to receive( :install_package_with_rpm ).with(
-          "http://dl.fedoraproject.org/pub/epel/epel-release-latest-6.noarch.rpm", "--replacepkgs", {:package_proxy => false}
-        ).once
-      end
-      expect( Beaker::Command ).to receive( :new ).with(
-        "sed -i -e 's;#baseurl.*$;baseurl=http://dl\\.fedoraproject\\.org/pub/epel/6/$basearch;' /etc/yum.repos.d/epel.repo"
-      ).exactly( hosts.count ).times
-      expect( Beaker::Command ).to receive( :new ).with(
-        "sed -i -e '/mirrorlist/d' /etc/yum.repos.d/epel.repo"
-      ).exactly( hosts.count ).times
-      expect( Beaker::Command ).to receive( :new ).with(
-        "yum clean all && yum makecache"
-      ).exactly( hosts.count ).times
-
-      subject.add_el_extras( hosts, options )
-
-    end
-
-    it "does nothing for non el-5/6 hosts" do
-      hosts = make_hosts( { :platform => Beaker::Platform.new('windows-version-arch') } )
-
-      expect( Beaker::Command ).not_to receive( :new )
-
-      subject.add_el_extras( hosts, options )
-
     end
   end
 
@@ -385,36 +265,30 @@ describe Beaker do
     it "can sync keys on a solaris/eos host" do
       @platform = 'solaris'
 
-      expect( Beaker::Command ).to receive( :new ).with( sync_cmd % "bash" ).exactly( 3 ).times
-
-      subject.sync_root_keys( hosts, options )
+      expect(Beaker::Command).to receive(:new).with(sync_cmd % "bash").exactly(3).times
 
+      subject.sync_root_keys(hosts, options)
     end
 
     it "can sync keys on a non-solaris host" do
+      expect(Beaker::Command).to receive(:new).with(sync_cmd % "env PATH=\"/usr/gnu/bin:$PATH\" bash").exactly(3).times
 
-      expect( Beaker::Command ).to receive( :new ).with( sync_cmd % "env PATH=\"/usr/gnu/bin:$PATH\" bash" ).exactly( 3 ).times
-
-      subject.sync_root_keys( hosts, options )
-
+      subject.sync_root_keys(hosts, options)
     end
-
   end
 
   context "validate_host" do
     subject { dummy_class.new }
 
     it "can validate unix hosts" do
-
       hosts.each do |host|
         unix_only_pkgs.each do |pkg|
-          expect( host ).to receive( :check_for_package ).with( pkg ).once.and_return( false )
-          expect( host ).to receive( :install_package ).with( pkg ).once
+          expect(host).to receive(:check_for_package).with(pkg).once.and_return(false)
+          expect(host).to receive(:install_package).with(pkg).once
         end
       end
 
       subject.validate_host(hosts, options)
-
     end
 
     it "can validate windows hosts" do
@@ -422,15 +296,14 @@ describe Beaker do
 
       hosts.each do |host|
         windows_pkgs.each do |pkg|
-          allow( host ).to receive( :cygwin_installed? ).and_return( true )
-          allow( host ).to receive( :is_cygwin? ).and_return( true )
-          expect( host ).to receive( :check_for_package ).with( pkg ).once.and_return( false )
-          expect( host ).to receive( :install_package ).with( pkg ).once
+          allow(host).to receive(:cygwin_installed?).and_return(true)
+          allow(host).to receive(:is_cygwin?).and_return(true)
+          expect(host).to receive(:check_for_package).with(pkg).once.and_return(false)
+          expect(host).to receive(:install_package).with(pkg).once
         end
       end
 
       subject.validate_host(hosts, options)
-
     end
 
     it "can validate SLES hosts" do
@@ -438,14 +311,12 @@ describe Beaker do
 
       hosts.each do |host|
         sles_only_pkgs.each do |pkg|
-          expect( host ).to receive( :check_for_package).with( pkg ).once.and_return( false )
-          expect( host ).to receive( :install_package ).with( pkg ).once
+          expect(host).to receive(:check_for_package).with(pkg).once.and_return(false)
+          expect(host).to receive(:install_package).with(pkg).once
         end
-
       end
 
       subject.validate_host(hosts, options)
-
     end
 
     it "can validate opensuse hosts" do
@@ -453,14 +324,12 @@ describe Beaker do
 
       hosts.each do |host|
         sles_only_pkgs.each do |pkg|
-          expect( host ).to receive( :check_for_package).with( pkg ).once.and_return( false )
-          expect( host ).to receive( :install_package ).with( pkg ).once
+          expect(host).to receive(:check_for_package).with(pkg).once.and_return(false)
+          expect(host).to receive(:install_package).with(pkg).once
         end
-
       end
 
       subject.validate_host(hosts, options)
-
     end
 
     it "can validate RHEL8 hosts" do
@@ -491,7 +360,7 @@ describe Beaker do
 
     it 'skips validation on cisco hosts' do
       host = make_host('cisco-7', { stdout: stdout, platform: 'cisco_nexus-7-x86_64' })
-      expect( subject ).to receive( :check_and_install_packages_if_needed ).with(host, []).once
+      expect(subject).to receive(:check_and_install_packages_if_needed).with(host, []).once
       subject.validate_host(host, options)
     end
   end
@@ -501,22 +370,24 @@ describe Beaker do
 
     shared_examples 'find domain name' do
       it "finds the domain name" do
-        expect( subject.get_domain_name( host ) ).to be === "labs.lan"
+        expect(subject.get_domain_name(host)).to be === "labs.lan"
       end
     end
 
     context "on windows" do
-      let(:host) { make_host( 'name', {
-        :platform => 'windows',
-        :is_cygwin => cygwin,
-        :stdout => "domain labs.lan d.labs.net dc1.labs.net labs.com\nnameserver 10.16.22.10\nnameserver 10.16.22.11",
-      } ) }
+      let(:host) do
+        make_host('name', {
+                    :platform => 'windows',
+                    :is_cygwin => cygwin,
+                    :stdout => "domain labs.lan d.labs.net dc1.labs.net labs.com\nnameserver 10.16.22.10\nnameserver 10.16.22.11",
+                  })
+      end
 
       context "with cygwin" do
         let(:cygwin) { true }
 
         before do
-          expect( Beaker::Command ).to receive( :new ).with( "cat /cygdrive/c/Windows/System32/drivers/etc/hosts" ).once
+          expect(Beaker::Command).to receive(:new).with("cat /cygdrive/c/Windows/System32/drivers/etc/hosts").once
         end
 
         include_examples 'find domain name'
@@ -526,22 +397,24 @@ describe Beaker do
         let(:cygwin) { false }
 
         before do
-          expect( Beaker::Command ).to receive( :new ).with( 'type C:\Windows\System32\drivers\etc\hosts' ).once
+          expect(Beaker::Command).to receive(:new).with('type C:\Windows\System32\drivers\etc\hosts').once
         end
 
         include_examples 'find domain name'
       end
     end
 
-    ['centos','redhat'].each do |platform|
+    %w[centos redhat].each do |platform|
       context "on platform '#{platform}'" do
-        let(:host) { make_host( 'name', {
-          :platform => platform,
-          :stdout => stdout,
-        } ) }
+        let(:host) do
+          make_host('name', {
+                      :platform => platform,
+                      :stdout => stdout,
+                    })
+        end
 
         before do
-          expect( Beaker::Command ).to receive( :new ).with( "cat /etc/resolv.conf" ).once
+          expect(Beaker::Command).to receive(:new).with("cat /etc/resolv.conf").once
         end
 
         context "with a domain entry" do
@@ -571,28 +444,6 @@ describe Beaker do
     end
   end
 
-  context "get_ip" do
-    subject { dummy_class.new }
-
-    it "can exec the get_ip command" do
-      host = make_host('name', { :stdout => "192.168.2.130\n" } )
-
-      expect( Beaker::Command ).to receive( :new ).with( "ip a | awk '/global/{print$2}' | cut -d/ -f1 | head -1", [], {:prepend_cmds=>nil, :cmdexe=>false} ).once
-
-      expect( subject.get_ip( host ) ).to be === "192.168.2.130"
-
-    end
-
-    it "can exec the get_ip command with tail with vagrant hypervisor" do
-      host = make_host('name', { :stdout => "192.168.2.131\n", :hypervisor => "vagrant" } )
-
-      expect( Beaker::Command ).to receive( :new ).with( "ip a | awk '/global/{print$2}' | cut -d/ -f1 | tail -1", [], {:prepend_cmds=>nil, :cmdexe=>false} ).once
-
-      expect( subject.get_ip( host ) ).to be === "192.168.2.131"
-    end
-
-  end
-
   context "set_etc_hosts" do
     subject { dummy_class.new }
 
@@ -600,49 +451,46 @@ describe Beaker do
       host = make_host('name', {})
       etc_hosts = "127.0.0.1  localhost\n192.168.2.130 pe-ubuntu-lucid\n192.168.2.128 pe-centos6\n192.168.2.131 pe-debian6"
 
-      expect( Beaker::Command ).to receive( :new ).with( "echo '#{etc_hosts}' >> /etc/hosts" ).once
-      expect( host ).to receive( :exec ).once
+      expect(Beaker::Command).to receive(:new).with("echo '#{etc_hosts}' >> /etc/hosts").once
+      expect(host).to receive(:exec).once
 
       subject.set_etc_hosts(host, etc_hosts)
     end
-
   end
 
   context "copy_ssh_to_root" do
     subject { dummy_class.new }
 
     it "can copy ssh to root in windows hosts with no cygwin" do
-      host = make_host( 'testhost', { :platform => 'windows', :is_cygwin => false })
-      expect( Beaker::Command ).to receive( :new ).with( "if exist .ssh (xcopy .ssh C:\\Users\\Administrator\\.ssh /s /e /y /i)" ).once
+      host = make_host('testhost', { :platform => 'windows', :is_cygwin => false })
+      expect(Beaker::Command).to receive(:new).with("if exist .ssh (xcopy .ssh C:\\Users\\Administrator\\.ssh /s /e /y /i)").once
 
       subject.copy_ssh_to_root(host, options)
     end
-
   end
 
   context "package_proxy" do
-
     subject { dummy_class.new }
 
     proxyurl = "http://192.168.2.100:3128"
 
     it "can set proxy config on a debian/ubuntu/cumulus host" do
-      host = make_host('name', { :platform => 'cumulus' } )
+      host = make_host('name', { :platform => 'cumulus' })
 
-      expect( Beaker::Command ).to receive( :new ).with( "echo 'Acquire::http::Proxy \"#{proxyurl}/\";' >> /etc/apt/apt.conf.d/10proxy" ).once
-      expect( host ).to receive( :exec ).once
+      expect(Beaker::Command).to receive(:new).with("echo 'Acquire::http::Proxy \"#{proxyurl}/\";' >> /etc/apt/apt.conf.d/10proxy").once
+      expect(host).to receive(:exec).once
 
-      subject.package_proxy(host, options.merge( {'package_proxy' => proxyurl}) )
+      subject.package_proxy(host, options.merge({ 'package_proxy' => proxyurl }))
     end
 
-    ['centos','redhat'].each do |platform|
+    %w[centos redhat].each do |platform|
       it "can set proxy config on a '#{platform}' host" do
-        host = make_host('name', { :platform => platform } )
+        host = make_host('name', { :platform => platform })
 
-        expect( Beaker::Command ).to receive( :new ).with( "echo 'proxy=#{proxyurl}/' >> /etc/yum.conf" ).once
-        expect( host ).to receive( :exec ).once
+        expect(Beaker::Command).to receive(:new).with("echo 'proxy=#{proxyurl}/' >> /etc/yum.conf").once
+        expect(host).to receive(:exec).once
 
-        subject.package_proxy(host, options.merge( {'package_proxy' => proxyurl}) )
+        subject.package_proxy(host, options.merge({ 'package_proxy' => proxyurl }))
       end
     end
   end
@@ -696,70 +544,68 @@ describe Beaker do
 
     it "skips an f5 host correctly" do
       host = make_host('name', {
-         :platform     => 'f5-stuff',
-         :ssh_env_file => 'ssh_env_file',
-         :is_cygwin   => true,
-      } )
+                         :platform => 'f5-stuff',
+                         :ssh_env_file => 'ssh_env_file',
+                         :is_cygwin => true,
+                       })
       opts = {
         :env1_key => :env1_value,
-        :env2_key => :env2_value
+        :env2_key => :env2_value,
       }
-      allow( host ).to receive( :skip_set_env? ).and_return('f5 say NO' )
+      allow(host).to receive(:skip_set_env?).and_return('f5 say NO')
 
-      expect( subject ).to receive( :construct_env ).exactly(0).times
-      expect( Beaker::Command ).to receive( :new ).exactly(0).times
-      expect( host ).to receive( :add_env_var ).exactly(0).times
+      expect(subject).to receive(:construct_env).exactly(0).times
+      expect(Beaker::Command).to receive(:new).exactly(0).times
+      expect(host).to receive(:add_env_var).exactly(0).times
       opts.each_pair do |key, value|
-        expect( host ).to receive( :add_env_var ).with( key, value ).exactly(0).times
+        expect(host).to receive(:add_env_var).with(key, value).exactly(0).times
       end
-      expect( host ).to receive( :exec ).exactly(0).times
+      expect(host).to receive(:exec).exactly(0).times
 
-      subject.set_env(host, options.merge( opts ))
+      subject.set_env(host, options.merge(opts))
     end
 
     it 'skips a cisco host correctly' do
       host = make_host('name', {
-        :platform     => 'cisco_nexus-7-x86_64',
-        :ssh_env_file => 'ssh_env_file',
-        :is_cygwin   => true,
-      } )
+                         :platform => 'cisco_nexus-7-x86_64',
+                         :ssh_env_file => 'ssh_env_file',
+                         :is_cygwin => true,
+                       })
       opts = {
         :env1_key => :env1_value,
-        :env2_key => :env2_value
+        :env2_key => :env2_value,
       }
-      allow( host ).to receive( :skip_set_env? ).and_return('cisco say NO' )
+      allow(host).to receive(:skip_set_env?).and_return('cisco say NO')
 
-      expect( subject ).to receive( :construct_env ).exactly(0).times
-      expect( Beaker::Command ).to receive( :new ).exactly(0).times
-      expect( host ).to receive( :add_env_var ).exactly(0).times
+      expect(subject).to receive(:construct_env).exactly(0).times
+      expect(Beaker::Command).to receive(:new).exactly(0).times
+      expect(host).to receive(:add_env_var).exactly(0).times
       opts.each_pair do |key, value|
-        expect( host ).to receive( :add_env_var ).with( key, value ).exactly(0).times
+        expect(host).to receive(:add_env_var).with(key, value).exactly(0).times
       end
-      expect( host ).to receive( :exec ).exactly(0).times
+      expect(host).to receive(:exec).exactly(0).times
 
-      subject.set_env(host, options.merge( opts ))
+      subject.set_env(host, options.merge(opts))
     end
 
     def test_host_ssh_calls(platform_name)
       host = make_host('name', {
-          :platform     => platform_name,
-          :ssh_env_file => 'ssh_env_file',
-          :is_cygwin   => true,
-        } )
+                         :platform => platform_name,
+                         :ssh_env_file => 'ssh_env_file',
+                         :is_cygwin => true,
+                       })
       opts = {
         :env1_key => :env1_value,
-        :env2_key => :env2_value
+        :env2_key => :env2_value,
       }
 
-      allow( host ).to receive( :skip_set_env? ).and_return( nil )
-      expect( subject ).to receive( :construct_env ).and_return( opts )
+      allow(host).to receive(:skip_set_env?).and_return(nil)
+      expect(subject).to receive(:construct_env).and_return(opts)
 
-      expect( host ).to receive( :ssh_permit_user_environment )
-      expect( host ).to receive( :ssh_set_user_environment )
+      expect(host).to receive(:ssh_permit_user_environment)
+      expect(host).to receive(:ssh_set_user_environment)
 
-      subject.set_env(host, options.merge( opts ))
+      subject.set_env(host, options.merge(opts))
     end
-
   end
-
 end