beaker 4.40.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 63f687c51eaaca96401643346f8a76a1cbf0e907950f92c29285df20ce713506
-  data.tar.gz: d54e2172b6b9d446204dd6fc0ccea5c5d963b411e8a0df536e329de3185ed585
+  metadata.gz: a779fedc9b7695d5a76a9731765e8ed5c5b8f9f1945563c2108cd0d0e01f564a
+  data.tar.gz: d5613d1aa5a289aff25f948229f5d8c89bec28fa25ec6ae310f446e95dd44363
 SHA512:
-  metadata.gz: 181a5743faac578d27ed8ebb1068804626cd7e47952792a5ea3d59cb572c91e330efedc6238fd05cdf678396f4e13089cc3017d10a03c50bc444d3b847c2ec5f
-  data.tar.gz: 86fbf39233cb4ce3e25fff57b0bff05f09cc6cd387f41465fe269507f7e775ae3ac835069cdf775662db9106554399b81aac63cf0a83baf9e40dcaa60f3d3240
+  metadata.gz: 33dae1fd1af4921f1fd3f00e18413a1a823749444fbed1c1fae0ed967cf055988a31692ceba29d5535bba8b1283f0b6ec0535cf21b589ecfc9f55c0d6498f51b
+  data.tar.gz: 8ccefb72d40022e47506fdd6ab8307318fbcd3eb736f89f965368de923e65b52e14a3faac8ea4afcb7aad3d3c80e059a9ce665578d18f32c01ff073675b75387

data/.github/dependabot.yml

@@ -1,8 +1,17 @@
 version: 2
 updates:
+# raise PRs for gem updates
 - package-ecosystem: bundler
   directory: "/"
   schedule:
     interval: daily
     time: "13:00"
   open-pull-requests-limit: 10
+
+# Maintain dependencies for GitHub Actions
+- package-ecosystem: github-actions
+  directory: "/"
+  schedule:
+    interval: daily
+    time: "13:00"
+  open-pull-requests-limit: 10

data/.github/workflows/release.yml

@@ -10,13 +10,13 @@ jobs:
     runs-on: ubuntu-latest
     if: github.repository_owner == 'voxpupuli'
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Install Ruby 3.0
         uses: ruby/setup-ruby@v1
         with:
           ruby-version: '3.0'
         env:
-          BUNDLE_WITHOUT: release
+          BUNDLE_WITHOUT: release:development:rubocop
       - name: Build gem
         run: gem build *.gemspec
       - name: Publish gem to rubygems.org

data/.github/workflows/test.yml

@@ -1,42 +1,44 @@
 name: Test
 
 on:
-  - pull_request
-  - push
-
-env:
-  BUNDLE_WITHOUT: release
+  pull_request: {}
+  push:
+    branches:
+      - master
 
 jobs:
   rubocop:
+    env:
+      BUNDLE_WITHOUT: release
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
       - name: Install Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: "3.1"
+          ruby-version: "3.2"
           bundler-cache: true
       - name: Run Rubocop
-        run: bundle exec rubocop --format github
+        run: bundle exec rake rubocop
 
   test:
-    runs-on: ubuntu-latest
+    # CentOS 7 testing is broken on Ubuntu 22.04
+    runs-on: ubuntu-20.04
     strategy:
       fail-fast: false
       matrix:
         include:
-          - ruby: "2.4"
-          - ruby: "2.5"
-          - ruby: "2.6"
           - ruby: "2.7"
           - ruby: "3.0"
           - ruby: "3.1"
+          - ruby: "3.2"
             coverage: "yes"
     env:
       COVERAGE: ${{ matrix.coverage }}
+      BUNDLE_WITHOUT: release:rubocop
+      BEAKER_HYPERVISOR: docker
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Install Ruby ${{ matrix.ruby }}
         uses: ruby/setup-ruby@v1
         with:
@@ -44,5 +46,16 @@ jobs:
           bundler-cache: true
       - name: Build gem
         run: gem build *.gemspec
-      - name: Run tests
+      - name: Run unit tests
         run: bundle exec rake spec
+      - name: Run acceptance tests
+        run: bundle exec rake acceptance
+
+  tests:
+    needs:
+      - rubocop
+      - test
+    runs-on: ubuntu-latest
+    name: Test suite
+    steps:
+      - run: echo Test suite completed

data/.rubocop.yml

@@ -7,25 +7,32 @@ require:
   - rubocop-rspec
 
 AllCops:
+  TargetRubyVersion: 2.7
   NewCops: enable
 
-Layout/ArgumentAlignment:
+Gemspec/RequireMFA:
   Enabled: false
 
+Gemspec/DevelopmentDependencies:
+  Enabled: false
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: True
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInArrayLiteral:
+  Enabled: True
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrailingCommaInArguments:
+  Enabled: True
+  EnforcedStyleForMultiline: comma
+
 Layout/LineLength:
   Exclude:
     - acceptance/**/*.rb
     - spec/**/*.rb
 
-Layout:
-  Enabled: false
-
-Metrics:
-  Enabled: false
-
-Style:
-  Enabled: false
-
 Naming/AccessorMethodName:
   Enabled: false
 
@@ -60,3 +67,9 @@ RSpec/MultipleExpectations:
 
 RSpec/NestedGroups:
   Max: 4
+
+Metrics:
+  Enabled: false
+
+Style:
+  Enabled: false

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp`
-# using RuboCop version 1.12.1.
+# using RuboCop version 1.48.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -35,10 +35,10 @@ Lint/EmptyBlock:
     - 'spec/beaker/logger_junit_spec.rb'
     - 'spec/beaker/logger_spec.rb'
 
-Lint/MissingSuper:
+# This cop supports unsafe autocorrection (--autocorrect-all).
+Lint/NonAtomicFileOperation:
   Exclude:
-    - 'lib/beaker/hypervisor/noop.rb'
-    - 'lib/beaker/tasks/rake_task.rb'
+    - 'acceptance/tests/base/dsl/helpers/host_helpers/archive_file_from_test.rb'
 
 Lint/RescueException:
   Exclude:
@@ -63,7 +63,7 @@ Lint/UselessAssignment:
     - 'lib/beaker/logger_junit.rb'
 
 # Configuration parameters: ForbiddenDelimiters.
-# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'Rakefile'
@@ -96,7 +96,15 @@ RSpec/AnyInstance:
     - 'spec/beaker/host/windows/file_spec.rb'
     - 'spec/beaker/subcommand_spec.rb'
 
-# Configuration parameters: Prefixes.
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Exclude:
+    - 'spec/beaker/cli_spec.rb'
+    - 'spec/beaker/host/pswindows/file_spec.rb'
+    - 'spec/beaker/host/windows/exec_spec.rb'
+    - 'spec/beaker/host_spec.rb'
+
+# Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
@@ -128,7 +136,6 @@ RSpec/InstanceVariable:
 RSpec/IteratedExpectation:
   Exclude:
     - 'spec/beaker/dsl/helpers/host_helpers_spec.rb'
-    - 'spec/beaker/host_prebuilt_steps_spec.rb'
 
 RSpec/LeakyConstantDeclaration:
   Exclude:
@@ -151,12 +158,23 @@ RSpec/MultipleDescribes:
 
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
-  Max: 19
+  Max: 17
 
-# Configuration parameters: IgnoreSharedExamples.
+# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
+# SupportedStyles: always, named_only
 RSpec/NamedSubject:
   Enabled: false
 
+# Configuration parameters: AllowedPatterns.
+# AllowedPatterns: ^expect_, ^assert_
+RSpec/NoExpectationExample:
+  Exclude:
+    - 'acceptance/fixtures/module/spec/acceptance/demo_spec.rb'
+    - 'spec/beaker/host/windows/pkg_spec.rb'
+    - 'spec/beaker/host_prebuilt_steps_spec.rb'
+    - 'spec/beaker/logger_spec.rb'
+    - 'spec/beaker/options/subcommand_options_parser_spec.rb'
+
 RSpec/RepeatedDescription:
   Exclude:
     - 'spec/beaker/cli_spec.rb'
@@ -195,7 +213,7 @@ RSpec/UnspecifiedException:
 RSpec/VerifiedDoubles:
   Enabled: false
 
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Rake/Desc:
   Exclude:
     - 'Rakefile'
@@ -213,3 +231,9 @@ Security/Eval:
 Security/Open:
   Exclude:
     - 'lib/beaker/dsl/helpers/web_helpers.rb'
+
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 226

data/CHANGELOG.md

@@ -1,14 +1,22 @@
 # Changelog
 
-## [4.40.0](https://github.com/voxpupuli/beaker/tree/4.40.0) (2023-04-04)
+## [5.0.0](https://github.com/voxpupuli/beaker/tree/5.0.0) (2023-03-24)
 
-[Full Changelog](https://github.com/voxpupuli/beaker/compare/4.39.0...4.40.0)
+**Breaking changes:**
+
+- Drop Ruby 2.4/2.5/2.6 support [\#1767](https://github.com/voxpupuli/beaker/pull/1767) ([bastelfreak](https://github.com/bastelfreak))
+- Removes open_uri_redirections [\#1764](https://github.com/voxpupuli/beaker/pull/1764) ([mhashizume](https://github.com/mhashizume))
+- Drop deprecated methods [\#1769](https://github.com/voxpupuli/beaker/pull/1769) ([ekohl](https://github.com/ekohl))
+- Remove add-el-extras, passenger, proxy_config, disable_iptables and clean up code [\#1731](https://github.com/voxpupuli/beaker/pull/1731) ([ekohl](https://github.com/ekohl))
+- Remove install_puppet_agent_* methods [\#1775](https://github.com/voxpupuli/beaker/pull/1775) ([ekohl](https://github.com/ekohl))
 
 **Implemented enhancements:**
 
-- \(maint\) Backport 'Removes open\_uri\_redirections' [\#1798](https://github.com/voxpupuli/beaker/pull/1798) ([joshcooper](https://github.com/joshcooper))
+- Fix many RuboCop violations: [\#1768](https://github.com/voxpupuli/beaker/pull/1768), [\#1777](https://github.com/voxpupuli/beaker/pull/1777), [\#1787](https://github.com/voxpupuli/beaker/pull/1787), [\#1778](https://github.com/voxpupuli/beaker/pull/1778), [\#1790](https://github.com/voxpupuli/beaker/pull/1790), [\#1791](https://github.com/voxpupuli/beaker/pull/1791), [\#1792](https://github.com/voxpupuli/beaker/pull/1792)
+- Add Ruby 3.2 support [\#1762](https://github.com/voxpupuli/beaker/pull/1762) ([ekohl](https://github.com/ekohl))
+- Drop rspec-its dependency in favor of have_attributes [\#1788](https://github.com/voxpupuli/beaker/pull/1788)
 
-## [4.39.0](https://github.com/voxpupuli/beaker/tree/4.39.0) (2023-02-18)
+## [4.39.0](https://github.com/voxpupuli/beaker/tree/4.39.0) (2023-02-09)
 
 [Full Changelog](https://github.com/voxpupuli/beaker/compare/4.38.1...4.39.0)
 
@@ -18,9 +26,9 @@
 
 **Implemented enhancements:**
 
-- Add Rubocop [\#1761](https://github.com/voxpupuli/beaker/pull/1761) ([ekohl](https://github.com/ekohl))
+- Add RuboCop [\#1761](https://github.com/voxpupuli/beaker/pull/1761) ([ekohl](https://github.com/ekohl))
 - Update net-scp requirement from >= 1.2, < 4.0 to >= 1.2, < 5.0 [\#1757](https://github.com/voxpupuli/beaker/pull/1757)
-- \(maint\) StringInclude Rubocop corrections [\#1765](https://github.com/voxpupuli/beaker/pull/1765) ([mhashizume](https://github.com/mhashizume))
+- (maint) StringInclude Rubocop corrections [\1765](https://github.com/voxpupuli/beaker/pull/1765) ([mhashizume](https://github.com/mhashizume))
 
 **Closed issues:**
 

data/Gemfile

@@ -15,23 +15,28 @@ gemspec
 
 if ENV['BEAKER_PE_PR_REPO_URL']
   lib = ENV['BEAKER_PE_PR_REPO_URL'].match(/\/([^\/]+)\.git$/)[1]
-  author = ENV['BEAKER_PE_PR_AUTHOR']
-  ref = ENV['BEAKER_PE_PR_COMMIT']
+  author = ENV.fetch('BEAKER_PE_PR_AUTHOR', nil)
+  ref = ENV.fetch('BEAKER_PE_PR_COMMIT', nil)
   gem lib, :git => "git@github.com:#{author}/#{lib}.git", :branch => ref
 end
 
+if ENV['BEAKER_HYPERVISOR']
+  # vagrant_libvirt -> vagrant
+  gem "beaker-#{ENV['BEAKER_HYPERVISOR'].split('_').first}"
+end
+
 group :rubocop do
-  gem 'rubocop', '~> 1.12.0'
-  gem 'rubocop-performance'
-  gem 'rubocop-rake'
-  gem 'rubocop-rspec'
+  gem 'rubocop', '~> 1.48.0'
+  gem 'rubocop-performance', '~> 1.16.0'
+  gem 'rubocop-rake', '~> 0.6.0'
+  gem 'rubocop-rspec', '~> 2.19.0'
 end
 
 group :release do
   gem 'github_changelog_generator', require: false
 end
 
-group :coverage, optional: ENV['COVERAGE']!='yes' do
+group :coverage, optional: ENV['COVERAGE'] != 'yes' do
   gem 'codecov', :require => false
   gem 'simplecov-console', :require => false
 end