beaker 4.39.0 → 5.1.0

data/spec/beaker/dsl/test_tagging_spec.rb

@@ -12,155 +12,154 @@ describe ClassMixedWithDSLStructure do
   let(:metadata) { @metadata ||= {} }
 
   before do
-    allow( subject ).to receive(:metadata).and_return(metadata)
+    allow(subject).to receive(:metadata).and_return(metadata)
   end
 
   describe '#tag' do
-    let( :test_tag_and     ) { @test_tag_and     || [] }
-    let( :test_tag_or      ) { @test_tag_or      || [] }
-    let( :test_tag_exclude ) { @test_tag_exclude || [] }
-    let( :options          ) {
+    let(:test_tag_and) { @test_tag_and || [] }
+    let(:test_tag_or) { @test_tag_or || [] }
+    let(:test_tag_exclude) { @test_tag_exclude || [] }
+    let(:options) do
       opts                    = Beaker::Options::OptionsHash.new
       opts[:test_tag_and]     = test_tag_and
       opts[:test_tag_or]      = test_tag_or
       opts[:test_tag_exclude] = test_tag_exclude
       opts
-    }
+    end
 
     before do
-      allow( subject ).to receive( :platform_specific_tag_confines )
+      allow(subject).to receive(:platform_specific_tag_confines)
     end
 
     it 'sets tags on the TestCase\'s metadata object' do
       subject.instance_variable_set(:@options, options)
-      tags = ['pants', 'jayjay', 'moguely']
+      tags = %w[pants jayjay moguely]
       subject.tag(*tags)
-      expect( metadata[:case][:tags] ).to be === tags
+      expect(metadata[:case][:tags]).to be === tags
     end
 
     it 'lowercases the tags' do
       subject.instance_variable_set(:@options, options)
-      tags_upper = ['pANTs', 'jAYJAy', 'moGUYly']
+      tags_upper = %w[pANTs jAYJAy moGUYly]
       tags_lower = tags_upper.map(&:downcase)
       subject.tag(*tags_upper)
-      expect( metadata[:case][:tags] ).to be === tags_lower
+      expect(metadata[:case][:tags]).to be === tags_lower
     end
 
     it 'skips the test if any of the requested tags isn\'t included in this test' do
-      test_tags     = ['pants', 'jayjay', 'moguely']
+      test_tags     = %w[pants jayjay moguely]
       @test_tag_and = test_tags.compact.push('needed_tag_not_in_test')
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).to receive(:skip_test)
       subject.tag(*test_tags)
     end
 
     it 'runs the test if all requested tags are included in this test' do
-      @test_tag_and = ['pants_on_head', 'jayjay_jayjay', 'mo']
+      @test_tag_and = %w[pants_on_head jayjay_jayjay mo]
       test_tags     = @test_tag_and.compact.push('extra_asdf')
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).not_to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).not_to receive(:skip_test)
       subject.tag(*test_tags)
     end
 
     it 'skips the test if any of the excluded tags are included in this test' do
-      test_tags         = ['ports', 'jay_john_mary', 'mog_the_dog']
+      test_tags         = %w[ports jay_john_mary mog_the_dog]
       @test_tag_exclude = [test_tags[0]]
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).to receive(:skip_test)
       subject.tag(*test_tags)
     end
 
     it 'skips the test if an and-included & excluded tag are in this test' do
-      test_tags         = ['ports', 'jay_john_mary', 'mog_the_dog']
+      test_tags         = %w[ports jay_john_mary mog_the_dog]
       @test_tag_and     = [test_tags[1]]
       @test_tag_exclude = [test_tags[0]]
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).to receive(:skip_test)
       subject.tag(*test_tags)
     end
 
     it 'runs the test if none of the excluded tags are included in this test' do
-      @test_tag_exclude = ['pants_on_head', 'jayjay_jayjay', 'mo']
-      test_tags         = ['pants_at_head', 'jayj00_jayjay', 'motly_crew']
+      @test_tag_exclude = %w[pants_on_head jayjay_jayjay mo]
+      test_tags         = %w[pants_at_head jayj00_jayjay motly_crew]
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).not_to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).not_to receive(:skip_test)
       subject.tag(*test_tags)
     end
 
     it 'skips the test if none of the OR tags are included in this test' do
-      test_tags = ['portmanteau', 'foolios']
-      @test_tag_or = ['fish', 'crayons', 'parkas']
+      test_tags = %w[portmanteau foolios]
+      @test_tag_or = %w[fish crayons parkas]
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).to receive(:skip_test)
       subject.tag(*test_tags)
     end
 
     it 'runs the test if only one of the OR tags are included in this test' do
-      test_tags = ['portmanteau', 'foolios']
-      @test_tag_or = ['foolios', 'crayons', 'parkas']
+      test_tags = %w[portmanteau foolios]
+      @test_tag_or = %w[foolios crayons parkas]
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).not_to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).not_to receive(:skip_test)
       subject.tag(*test_tags)
     end
 
     it 'skips the test if an or-included & excluded tag are included in this test' do
-      test_tags         = ['ports', 'jay_john_mary', 'mog_the_dog']
+      test_tags         = %w[ports jay_john_mary mog_the_dog]
       @test_tag_or      = [test_tags[1]]
       @test_tag_exclude = [test_tags[0]]
       subject.instance_variable_set(:@options, options)
 
-      allow( subject ).to receive( :path )
-      expect( subject ).to receive( :skip_test )
+      allow(subject).to receive(:path)
+      expect(subject).to receive(:skip_test)
       subject.tag(*test_tags)
     end
   end
 end
 
 describe Beaker::DSL::TestTagging::PlatformTagConfiner do
-  let( :confines_array ) { @confines_array || [] }
-  let( :confiner ) {
-    described_class.new( confines_array )
-  }
+  let(:confines_array) { @confines_array || [] }
+  let(:confiner) do
+    described_class.new(confines_array)
+  end
 
   describe '#initialize' do
     it 'transforms one entry' do
       platform_regex = /^ubuntu$/
       tag_reason_hash = {
         'tag1' => 'reason1',
-        'tag2' => 'reason2'
+        'tag2' => 'reason2',
       }
-      @confines_array = [ {
-                            :platform => platform_regex,
-                            :tag_reason_hash => tag_reason_hash
-                          }
-      ]
+      @confines_array = [{
+        :platform => platform_regex,
+        :tag_reason_hash => tag_reason_hash,
+      }]
 
-      internal_hash = confiner.instance_variable_get( :@tag_confine_details_hash )
-      expect( internal_hash.keys() ).to include( 'tag1' )
-      expect( internal_hash.keys() ).to include( 'tag2' )
-      expect( internal_hash.keys().length() ).to be === 2
+      internal_hash = confiner.instance_variable_get(:@tag_confine_details_hash)
+      expect(internal_hash.keys).to include('tag1')
+      expect(internal_hash.keys).to include('tag2')
+      expect(internal_hash.keys.length).to be === 2
 
       tag_reason_hash.each do |tag, reason|
         tag_array = internal_hash[tag]
-        expect( tag_array.length() ).to be === 1
+        expect(tag_array.length).to be === 1
         tag_hash = tag_array[0]
-        expect( tag_hash[:platform_regex] ).to eql( platform_regex )
-        expect( tag_hash[:log_message] ).to match( /#{reason}/ )
-        expect( tag_hash[:type] ).to be === :except
+        expect(tag_hash[:platform_regex]).to eql(platform_regex)
+        expect(tag_hash[:log_message]).to match(/#{reason}/)
+        expect(tag_hash[:type]).to be === :except
       end
     end
 
@@ -170,25 +169,25 @@ describe Beaker::DSL::TestTagging::PlatformTagConfiner do
           :platform => /^el-/,
           :tag_reason_hash => {
             'tag1' => 'reason el 1',
-            'tag2' => 'reason2'
-          }
+            'tag2' => 'reason2',
+          },
         }, {
           :platform => /^cisco-/,
           :tag_reason_hash => {
             'tag1' => 'reason cisco 1',
-            'tag3' => 'reason3'
-          }
-        }
+            'tag3' => 'reason3',
+          },
+        },
       ]
 
-      internal_hash = confiner.instance_variable_get( :@tag_confine_details_hash )
-      expect( internal_hash.keys() ).to include( 'tag1' )
-      expect( internal_hash.keys() ).to include( 'tag2' )
-      expect( internal_hash.keys() ).to include( 'tag3' )
-      expect( internal_hash.keys().length() ).to be === 3
+      internal_hash = confiner.instance_variable_get(:@tag_confine_details_hash)
+      expect(internal_hash.keys).to include('tag1')
+      expect(internal_hash.keys).to include('tag2')
+      expect(internal_hash.keys).to include('tag3')
+      expect(internal_hash.keys.length).to be === 3
 
       shared_tag_array = internal_hash['tag1']
-      expect( shared_tag_array.length() ).to be === 2
+      expect(shared_tag_array.length).to be === 2
 
       platform_el_found = false
       platform_cisco_found = false
@@ -205,40 +204,40 @@ describe Beaker::DSL::TestTagging::PlatformTagConfiner do
         else
           log_msg = "unexpected log message for confine_details: "
           log_msg << confine_details[:log_message]
-          fail( log_msg )
+          fail(log_msg)
         end
 
-        expect( confine_details[:platform_regex] ).to eql( platform_to_match )
-        expect( confine_details[:log_message] ).to match( reason_to_match )
+        expect(confine_details[:platform_regex]).to eql(platform_to_match)
+        expect(confine_details[:log_message]).to match(reason_to_match)
       end
-      expect( platform_el_found ).to be === true
-      expect( platform_cisco_found ).to be === true
+      expect(platform_el_found).to be === true
+      expect(platform_cisco_found).to be === true
     end
   end
 
   describe '#confine_details' do
     it 'returns an empty array if no tags match' do
-      fake_confine_details_hash = { 'tag1' => [ {:type => 1}, {:type => 2} ]}
+      fake_confine_details_hash = { 'tag1' => [{ :type => 1 }, { :type => 2 }] }
       confiner.instance_variable_set(
         :@tag_confine_details_hash, fake_confine_details_hash
       )
-      expect( confiner.confine_details( [ 'tag2', 'tag3' ] ) ).to be === []
+      expect(confiner.confine_details(%w[tag2 tag3])).to be === []
     end
 
     context 'descriminates on tag name' do
       fake_confine_details_hash = {
-        'tag0' => [ 10, 20, 30, 40 ],
-        'tag1' => [ 41, 51, 61, 71 ],
-        'tag2' => [ 22, 32, 42, 52 ],
-        'tag3' => [ 63, 73, 83, 93 ],
-        'tag4' => [ 34, 44, 54, 64 ],
+        'tag0' => [10, 20, 30, 40],
+        'tag1' => [41, 51, 61, 71],
+        'tag2' => [22, 32, 42, 52],
+        'tag3' => [63, 73, 83, 93],
+        'tag4' => [34, 44, 54, 64],
       }
 
       key_combos_to_test = fake_confine_details_hash.keys.map { |key| [key] }
-      key_combos_to_test << [ 'tag0', 'tag2' ]
-      key_combos_to_test << [ 'tag1', 'tag4' ]
-      key_combos_to_test << [ 'tag2', 'tag3', 'tag4' ]
-      key_combos_to_test << fake_confine_details_hash.keys()
+      key_combos_to_test << %w[tag0 tag2]
+      key_combos_to_test << %w[tag1 tag4]
+      key_combos_to_test << %w[tag2 tag3 tag4]
+      key_combos_to_test << fake_confine_details_hash.keys
 
       before do
         confiner.instance_variable_set(
@@ -252,23 +251,23 @@ describe Beaker::DSL::TestTagging::PlatformTagConfiner do
           key_combo_to_have.each do |key_to_have|
             haves += fake_confine_details_hash[key_to_have]
           end
-          keys_not_to_have = fake_confine_details_hash.keys.reject { |key_trial|
-            key_combo_to_have.include?( key_trial )
-          }
+          keys_not_to_have = fake_confine_details_hash.keys.reject do |key_trial|
+            key_combo_to_have.include?(key_trial)
+          end
           have_nots = []
           keys_not_to_have.each do |key_not_to_have|
             have_nots += fake_confine_details_hash[key_not_to_have]
           end
 
-          details = confiner.confine_details( key_combo_to_have )
+          details = confiner.confine_details(key_combo_to_have)
           have_nots.each do |confine_details|
-            expect( details ).not_to include( confine_details )
+            expect(details).not_to include(confine_details)
           end
           haves.each do |confine_details|
-            expect( details ).to     include( confine_details )
+            expect(details).to     include(confine_details)
           end
         end
       end
     end
   end
-end
+end

data/spec/beaker/dsl/wrappers_spec.rb

@@ -7,73 +7,72 @@ end
 describe ClassMixedWithDSLWrappers do
   describe '#host_command' do
     it 'delegates to HostCommand.new' do
-      expect( Beaker::HostCommand ).to receive( :new ).with( 'blah' )
-      subject.host_command( 'blah' )
+      expect(Beaker::HostCommand).to receive(:new).with('blah')
+      subject.host_command('blah')
     end
   end
 
   describe '#powershell' do
     it 'passes "powershell.exe <args> -Command <command>" to Command' do
       command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'")
-      expect(command.command ).to be === 'powershell.exe'
-      expect( command.args).to be ===  ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
-      expect( command.options ).to be === {}
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
+      expect(command.options).to be === {}
     end
 
     it 'merges the arguments provided with the defaults' do
-      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", {'ExecutionPolicy' => 'Unrestricted'})
-      expect( command.command).to be === 'powershell.exe'
-      expect( command.args ).to be === ["-ExecutionPolicy Unrestricted", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
-      expect( command.options ).to be === {}
+      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", { 'ExecutionPolicy' => 'Unrestricted' })
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Unrestricted", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
+      expect(command.options).to be === {}
     end
 
     it 'uses EncodedCommand when EncodedCommand => true' do
       cmd = "Set-Content -path 'fu.txt' -value 'fu'"
       cmd = subject.encode_command(cmd)
-      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", {'EncodedCommand' => true})
-      expect(command.command ).to be === 'powershell.exe'
-      expect( command.args).to be ===  ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-EncodedCommand #{cmd}"]
-      expect( command.options ).to be === {}
+      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", { 'EncodedCommand' => true })
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-EncodedCommand #{cmd}"]
+      expect(command.options).to be === {}
     end
 
     it 'uses EncodedCommand when EncodedCommand => ""' do
       cmd = "Set-Content -path 'fu.txt' -value 'fu'"
       cmd = subject.encode_command(cmd)
-      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", {'EncodedCommand' => ""})
-      expect(command.command ).to be === 'powershell.exe'
-      expect( command.args).to be ===  ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-EncodedCommand #{cmd}"]
-      expect( command.options ).to be === {}
+      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", { 'EncodedCommand' => "" })
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-EncodedCommand #{cmd}"]
+      expect(command.options).to be === {}
     end
 
     it 'uses EncodedCommand when EncodedCommand => nil' do
       cmd = "Set-Content -path 'fu.txt' -value 'fu'"
       cmd = subject.encode_command(cmd)
-      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", {'EncodedCommand' => nil})
-      expect(command.command ).to be === 'powershell.exe'
-      expect( command.args).to be ===  ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-EncodedCommand #{cmd}"]
-      expect( command.options ).to be === {}
+      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", { 'EncodedCommand' => nil })
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-EncodedCommand #{cmd}"]
+      expect(command.options).to be === {}
     end
 
     it 'does not use EncodedCommand when EncodedCommand => false' do
-      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", {'EncodedCommand' => false})
-      expect(command.command ).to be === 'powershell.exe'
-      expect( command.args).to be ===  ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
-      expect( command.options ).to be === {}
+      command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", { 'EncodedCommand' => false })
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
+      expect(command.options).to be === {}
     end
 
     it 'does not use EncodedCommand when EncodedCommand not present' do
       command = subject.powershell("Set-Content -path 'fu.txt' -value 'fu'", {})
-      expect(command.command ).to be === 'powershell.exe'
-      expect( command.args).to be ===  ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
-      expect( command.options ).to be === {}
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-Command Set-Content -path 'fu.txt' -value 'fu'"]
+      expect(command.options).to be === {}
     end
 
     it 'has no -Command/-EncodedCommand when command is empty' do
-      command = subject.powershell("", {"File" => 'myfile.ps1'})
-      expect(command.command ).to be === 'powershell.exe'
-      expect( command.args).to be ===  ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-File myfile.ps1"]
-      expect( command.options ).to be === {}
-
+      command = subject.powershell("", { "File" => 'myfile.ps1' })
+      expect(command.command).to be === 'powershell.exe'
+      expect(command.args).to be === ["-ExecutionPolicy Bypass", "-InputFormat None", "-NoLogo", "-NoProfile", "-NonInteractive", "-File myfile.ps1"]
+      expect(command.options).to be === {}
     end
   end
 end

data/spec/beaker/host/aix_spec.rb

@@ -3,49 +3,49 @@ require 'spec_helper'
 module Aix
   describe Host do
     let(:options)  { @options ? @options : {} }
-    let(:platform) {
+    let(:platform) do
       if @platform
-        { :platform => Beaker::Platform.new( @platform) }
+        { :platform => Beaker::Platform.new(@platform) }
       else
-        { :platform => Beaker::Platform.new( 'aix-vers-arch-extra' ) }
+        { :platform => Beaker::Platform.new('aix-vers-arch-extra') }
       end
-    }
-    let(:host)    { make_host( 'name', options.merge(platform) ) }
+    end
+    let(:host) { make_host('name', options.merge(platform)) }
 
     describe '#ssh_service_restart' do
       it 'invokes the correct commands on the host' do
-        expect( Beaker::Command ).to receive( :new ).with( 'stopsrc -g ssh'  ).once.ordered
-        expect( Beaker::Command ).to receive( :new ).with( 'startsrc -g ssh' ).once.ordered
+        expect(Beaker::Command).to receive(:new).with('stopsrc -g ssh').once.ordered
+        expect(Beaker::Command).to receive(:new).with('startsrc -g ssh').once.ordered
         host.ssh_service_restart
       end
     end
 
     describe '#ssh_permit_user_environment' do
       it 'calls echo to set PermitUserEnvironment' do
-        expect( Beaker::Command ).to receive( :new ).with( /^echo\ / ).once.ordered
-        allow( host ).to receive( :ssh_service_restart )
+        expect(Beaker::Command).to receive(:new).with(/^echo\ /).once.ordered
+        allow(host).to receive(:ssh_service_restart)
         host.ssh_permit_user_environment
       end
 
       it 'uses the correct ssh config file' do
-        expect( Beaker::Command ).to receive( :new ).with( /#{Regexp.escape(' >> /etc/ssh/sshd_config')}$/ ).once
-        allow( host ).to receive( :ssh_service_restart )
+        expect(Beaker::Command).to receive(:new).with(/#{Regexp.escape(' >> /etc/ssh/sshd_config')}$/).once
+        allow(host).to receive(:ssh_service_restart)
         host.ssh_permit_user_environment
       end
     end
 
     describe '#reboot' do
       it 'invokes the correct command on the host' do
-        expect( Beaker::Command ).to receive( :new ).with( 'shutdown -Fr' ).once
+        expect(Beaker::Command).to receive(:new).with('shutdown -Fr').once
         host.reboot
       end
     end
 
     describe '#get_ip' do
       it 'invokes the correct command on the host' do
-        expect( host ).to receive( :execute ).with( /^ifconfig\ \-a\ inet\|\ / ).once.and_return( '' )
+        expect(host).to receive(:execute).with(/^ifconfig\ \-a\ inet\|\ /).once.and_return('')
         host.get_ip
       end
     end
   end
-end
+end