beaker 3.18.0 → 3.19.0

data/lib/beaker/version.rb

@@ -1,5 +1,5 @@
 module Beaker
   module Version
-    STRING = '3.18.0'
+    STRING = '3.19.0'
   end
 end

data/spec/beaker/host/unix/pkg_spec.rb

@@ -450,6 +450,136 @@ module Beaker
         end
       end
     end
+
+    describe '#install_local_package' do
+      let( :platform      ) { @platform || 'fedora' }
+      let( :version       ) { @version  || 6        }
+      let( :platform_mock ) {
+        mock = Object.new
+        allow( mock ).to receive( :to_array ) { [platform, version, '', ''] }
+        mock
+      }
+
+      before :each do
+        allow( instance ).to receive( :[] ).with( 'platform' ) { platform_mock }
+      end
+
+      it 'Fedora 22-29: uses dnf' do
+        (22...29).each do |version|
+          @version = version
+          package_file = 'test_123.yay'
+          expect( instance ).to receive( :execute ).with( /^dnf.*#{package_file}$/ )
+          instance.install_local_package( package_file )
+        end
+      end
+
+      it 'Fedora 21 & 30: uses yum' do
+        package_file = 'testing_456.yay'
+        platform_mock = Object.new
+        [21, 30].each do |version|
+          @version = version
+          expect( instance ).to receive( :execute ).with( /^yum.*#{package_file}$/ )
+          instance.install_local_package( package_file )
+        end
+      end
+
+      it 'Centos & EL: uses yum' do
+        package_file = 'testing_789.yay'
+        ['centos', 'el'].each do |platform|
+          @platform = platform
+          expect( instance ).to receive( :execute ).with( /^yum.*#{package_file}$/ )
+          instance.install_local_package( package_file )
+        end
+      end
+
+      it 'Debian, Ubuntu, Cumulus: uses dpkg' do
+        package_file = 'testing_012.yay'
+        ['debian', 'ubuntu', 'cumulus'].each do |platform|
+          @platform = platform
+          expect( instance ).to receive( :execute ).with( /^dpkg.*#{package_file}$/ )
+          expect( instance ).to receive( :execute ).with( 'apt-get update' )
+          instance.install_local_package( package_file )
+        end
+      end
+
+      it 'Solaris: calls solaris-specific install method' do
+        package_file = 'testing_345.yay'
+        @platform = 'solaris'
+        expect( instance ).to receive( :solaris_install_local_package ).with( package_file, anything )
+        instance.install_local_package( package_file )
+      end
+
+      it 'OSX: calls host.install_package' do
+        package_file = 'testing_678.yay'
+        @platform = 'osx'
+        expect( instance ).to receive( :install_package ).with( package_file )
+        instance.install_local_package( package_file )
+      end
+    end
+
+    describe '#uncompress_local_tarball' do
+      let( :platform      ) { @platform || 'fedora' }
+      let( :version       ) { @version  || 6        }
+      let( :tar_file      ) { 'test.tar.gz'         }
+      let( :base_dir      ) { '/base/dir/fake'      }
+      let( :download_file ) { 'download_file.txt'   }
+      let( :platform_mock ) {
+        mock = Object.new
+        allow( mock ).to receive( :to_array ) { [platform, version, '', ''] }
+        mock
+      }
+
+      before :each do
+        allow( instance ).to receive( :[] ).with( 'platform' ) { platform_mock }
+      end
+
+      it 'rejects unsupported platforms' do
+        @platform = 'huawei'
+        expect {
+          instance.uncompress_local_tarball( tar_file, base_dir, download_file )
+        }.to raise_error(
+          /^Platform #{platform} .* not supported .* uncompress_local_tarball$/
+        )
+      end
+
+      it 'untars the file given' do
+        @platform = 'sles'
+        expect( instance ).to receive( :execute ).with(
+          /^tar .* #{tar_file} .* #{base_dir}$/
+        )
+        instance.uncompress_local_tarball( tar_file, base_dir, download_file )
+      end
+
+      context 'on solaris' do
+
+        before :each do
+          @platform = 'solaris'
+        end
+
+        it 'rejects unsupported versions' do
+          @version = '12'
+          expect {
+            instance.uncompress_local_tarball( tar_file, base_dir, download_file )
+          }.to raise_error(
+            /^Solaris #{version} .* not supported .* uncompress_local_tarball$/
+          )
+        end
+
+        it 'v10: gunzips before untaring' do
+          @version = '10'
+          expect( instance ).to receive( :execute ).with( /^gunzip #{tar_file}$/ )
+          expect( instance ).to receive( :execute ).with( /^tar .* #{download_file}$/ )
+          instance.uncompress_local_tarball( tar_file, base_dir, download_file )
+        end
+
+        it 'v11: untars only' do
+          @version = '11'
+          expect( instance ).to receive( :execute ).with( /^tar .* #{tar_file}$/ )
+          instance.uncompress_local_tarball( tar_file, base_dir, download_file )
+        end
+
+      end
+    end
   end
 end
 

data/spec/beaker/hypervisor/docker_spec.rb

@@ -162,7 +162,34 @@ module Beaker
 
       it 'should pass the Dockerfile on to Docker::Image.create' do
         allow( docker ).to receive(:dockerfile_for).and_return('special testing value')
-        expect( ::Docker::Image ).to receive(:build).with('special testing value', { :rm => true })
+        expect( ::Docker::Image ).to receive(:build).with('special testing value', { :rm => true, :buildargs => '{}' })
+
+        docker.provision
+      end
+
+      it 'should pass the buildargs from ENV DOCKER_BUILDARGS on to Docker::Image.create' do
+        allow( docker ).to receive(:dockerfile_for).and_return('special testing value')
+        ENV['DOCKER_BUILDARGS'] = 'HTTP_PROXY=http://1.1.1.1:3128'
+        expect( ::Docker::Image ).to receive(:build).with('special testing value', { :rm => true, :buildargs => "{\"HTTP_PROXY\":\"http://1.1.1.1:3128\"}" })
+
+        docker.provision
+      end
+
+      it 'should create a container based on the Image (identified by image.id)' do
+        hosts.each do |host|
+          expect( ::Docker::Container ).to receive(:create).with({
+            'Image' => image.id,
+            'Hostname' => host.name,
+          })
+        end
+
+        docker.provision
+      end
+
+      it 'should pass the multiple buildargs from ENV DOCKER_BUILDARGS on to Docker::Image.create' do
+        allow( docker ).to receive(:dockerfile_for).and_return('special testing value')
+        ENV['DOCKER_BUILDARGS'] = 'HTTP_PROXY=http://1.1.1.1:3128	HTTPS_PROXY=https://1.1.1.1:3129'
+        expect( ::Docker::Image ).to receive(:build).with('special testing value', { :rm => true, :buildargs => "{\"HTTP_PROXY\":\"http://1.1.1.1:3128\",\"HTTPS_PROXY\":\"https://1.1.1.1:3129\"}" })
 
         docker.provision
       end

data/spec/beaker/options/parser_spec.rb

@@ -140,23 +140,31 @@ module Beaker
           let(:env) { @env || {:level => 'highest'} }
           let(:argv) { @argv || {:level => 'second'} }
           let(:host_file) { @host_file || {:level => 'third'} }
-          let(:opt_file) { @opt_file || {:level => 'fourth', 
-                            :ssh => {
-                              :auth_methods => 'auth123',
-                              :user_known_hosts_file => 'hosts123'
-                            }                                
-          } }
+          let(:opt_file) { @opt_file || {
+              :level => 'fourth',
+              :ssh => {
+                  :auth_methods => 'auth123',
+                  :user_known_hosts_file => 'hosts123'
+              }
+          }}
           let(:subcommand_file) {@subcommand_file || {:level => 'fifth'}}
-          let(:presets) { {:level => 'lowest',
-                            :ssh => {
-                              :config => 'config123',
-                              :paranoid => 'paranoid123',
-                              :port => 'port123',
-                              :forward_agent => 'forwardagent123',
-                              :keys => 'keys123',
-                              :keepalive => 'keepalive123'
-                            } 
-          } }
+          let(:homedir_file) {@homedir_file || {
+              :level => 'sixth',
+              :ssh => {
+                  :auth_methods => 'auth_home_123'
+              }
+          }}
+          let(:presets) { {
+              :level => 'lowest',
+              :ssh => {
+                  :config => 'config123',
+                  :paranoid => 'paranoid123',
+                  :port => 'port123',
+                  :forward_agent => 'forwardagent123',
+                  :keys => 'keys123',
+                  :keepalive => 'keepalive123'
+              }
+          }}
 
           before :each do
             expect(parser).to receive(:normalize_args).and_return(true)
@@ -175,11 +183,11 @@ module Beaker
             allow(OptionsFileParser).to receive(:parse_options_file).and_return(opt_file)
             allow(parser).to receive(:parse_hosts_options).and_return(host_file)
 
-            allow(SubcommandOptionsParser).to receive(:parse_subcommand_options).and_return(subcommand_file)
+            allow(SubcommandOptionsParser).to receive(:parse_subcommand_options).and_return(homedir_file, subcommand_file)
           end
 
           it 'presets have the lowest priority' do
-            @env = @argv = @host_file = @opt_file = @subcommand_file = {}
+            @env = @argv = @host_file = @opt_file = @subcommand_file = @homedir_file = {}
             mock_out_parsing
 
             opts = parser.parse_args([])
@@ -188,6 +196,18 @@ module Beaker
             expect(attribution[:level]).to be == 'preset'
           end
 
+          it 'home directory options should have sixth priority' do
+            @env = @argv = @host_file = @opt_file = @subcommand_file = {}
+            mock_out_parsing
+
+            opts = parser.parse_args([])
+            attribution = parser.attribution
+            expect(opts[:ssh][:auth_methods]).to be == 'auth_home_123'
+            expect(attribution[:ssh][:auth_methods]).to be == 'homedir'
+            expect(opts[:level]).to be == 'sixth'
+            expect(attribution[:level]).to be == 'homedir'
+          end
+
           it 'subcommand_options should have fifth priority' do
             @env = @argv = @host_file = @opt_file = {}
             mock_out_parsing

data/spec/beaker/options/subcommand_options_parser_spec.rb

@@ -3,8 +3,11 @@ require 'spec_helper'
 module Beaker
   module Options
     describe '#parse_subcommand_options' do
-      let( :parser ) {Beaker::Options::SubcommandOptionsParser.parse_subcommand_options(argv)}
+      let(:home_options_file_path) {ENV['HOME']+'/.beaker/subcommand_options.yaml'}
+      let( :parser ) {Beaker::Options::SubcommandOptionsParser.parse_subcommand_options(argv, options_file)}
+      let( :file_parser ){Beaker::Options::SubcommandOptionsParser.parse_options_file({})}
       let( :argv ) {[]}
+      let( :options_file ) {""}
 
       it 'returns an empty OptionsHash if not executing a subcommand' do
         expect(parser).to be_kind_of(OptionsHash)
@@ -21,13 +24,33 @@ module Beaker
 
       describe 'when the subcommand is not init' do
         let( :argv ) {['provision']}
+        let(:options_file) {Beaker::Subcommands::SubcommandUtil::SUBCOMMAND_OPTIONS}
+        it 'calls parse_options_file with subcommand options file when home_dir is false' do
+          allow(parser).to receive(:execute_subcommand?).with('provision').and_return true
+          allow(parser).to receive(:parse_options_file).with(Beaker::Subcommands::SubcommandUtil::SUBCOMMAND_OPTIONS)
+        end
+
+        let( :options_file ) {home_options_file_path}
+        it 'calls parse_options_file with home directory options file when home_dir is true' do
+          allow(parser).to receive(:execute_subcommand?).with('provision').and_return true
+          allow(parser).to receive(:parse_options_file).with(home_options_file_path)
+        end
+
         it 'checks for file existence and loads the YAML file' do
-          expect(Beaker::Subcommands::SubcommandUtil::SUBCOMMAND_OPTIONS).to receive(:exist?).and_return(true)
+          allow(File).to receive(:exist?).and_return true
           allow(YAML).to receive(:load_file).and_return({})
-          expect(parser).to be_kind_of(Hash)
-          expect(parser).not_to be_kind_of(OptionsHash)
+          expect(file_parser).to be_kind_of(Hash)
+          expect(file_parser).not_to be_kind_of(OptionsHash)
         end
+
+        let(:options_file) {""}
+        it 'returns an empty options hash when file does not exist' do
+          allow(File).to receive(:exist?).and_return false
+          expect(parser).to be_kind_of(OptionsHash)
+          expect(parser).to be_empty
+        end
+
       end
     end
   end
-end
+end

data/spec/beaker/ssh_connection_spec.rb

@@ -18,25 +18,25 @@ module Beaker
 
     it 'self.connect creates connects and returns a proxy for that connection' do
       # grrr
-      expect( Net::SSH ).to receive(:start).with( ip, user, ssh_opts ).and_return(true)
+      expect( Net::SSH ).to receive(:start).with( vmhostname, user, ssh_opts ).and_return(true)
       connection_constructor = SshConnection.connect name_hash, user, ssh_opts, options
       expect( connection_constructor ).to be_a_kind_of SshConnection
     end
 
     it 'connect creates a new connection' do
-      expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts).and_return(true)
+      expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts).and_return(true)
       connection.connect
     end
 
     it 'connect caches its connection' do
-      expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts ).once.and_return true
+      expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts ).once.and_return true
       connection.connect
       connection.connect
     end
 
-    it 'attempts to connect by vmhostname if ip address connection fails' do
-      expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts).and_return(false)
-      expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts).and_return(true).once
+    it 'attempts to connect by ip address if vmhostname connection fails' do
+      expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts).and_return(false)
+      expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts).and_return(true).once
       expect( Net::SSH ).to receive( :start ).with( hostname, user, ssh_opts).never
       connection.connect
     end
@@ -53,7 +53,7 @@ module Beaker
 
       it 'runs ssh close' do
         mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { mock_ssh }
         connection.connect
 
         allow( mock_ssh).to receive( :closed? ).once.and_return(false)
@@ -63,7 +63,7 @@ module Beaker
 
       it 'sets the @ssh variable to nil' do
         mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { mock_ssh }
         connection.connect
 
         allow( mock_ssh).to receive( :closed? ).once.and_return(false)
@@ -76,7 +76,7 @@ module Beaker
       it 'calls ssh shutdown & re-raises if ssh close fails with an unexpected Error' do
         mock_ssh = Object.new
         allow( mock_ssh ).to receive( :close ) { raise StandardError }
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { mock_ssh }
         connection.connect
 
         allow( mock_ssh).to receive( :closed? ).once.and_return(false)
@@ -90,7 +90,7 @@ module Beaker
     describe '#execute' do
       it 'retries if failed with a retryable exception' do
         mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { mock_ssh }
         connection.connect
 
         allow( subject ).to receive( :close )
@@ -102,7 +102,7 @@ module Beaker
 
       it 'raises an error if it fails both times' do
         mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { mock_ssh }
         connection.connect
 
         allow( subject ).to receive( :close )
@@ -115,7 +115,7 @@ module Beaker
     describe '#request_terminal_for' do
       it 'fails correctly by raising Net::SSH::Exception' do
         mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { mock_ssh }
         connection.connect
 
         mock_channel = Object.new
@@ -128,7 +128,7 @@ module Beaker
     describe '#register_stdout_for' do
       before :each do
         @mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { @mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { @mock_ssh }
         connection.connect
 
         @data = '7 of clubs'
@@ -164,7 +164,7 @@ module Beaker
 
       before :each do
         @mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { @mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { @mock_ssh }
         connection.connect
 
         @data = '3 of spades'
@@ -203,7 +203,7 @@ module Beaker
 
       it 'assigns the output\'s exit code correctly from the data' do
         mock_ssh = Object.new
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { mock_ssh }
         connection.connect
 
         data = '10 of jeromes'
@@ -236,7 +236,7 @@ module Beaker
         @mock_scp = Object.new
         allow( @mock_scp ).to receive( :upload! )
         allow( @mock_ssh ).to receive( :scp ).and_return( @mock_scp )
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { @mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { @mock_ssh }
         connection.connect
       end
 
@@ -263,7 +263,7 @@ module Beaker
         @mock_scp = Object.new
         allow( @mock_scp ).to receive( :download! )
         allow( @mock_ssh ).to receive( :scp ).and_return( @mock_scp )
-        expect( Net::SSH ).to receive( :start ).with( ip, user, ssh_opts) { @mock_ssh }
+        expect( Net::SSH ).to receive( :start ).with( vmhostname, user, ssh_opts) { @mock_ssh }
         connection.connect
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: beaker
 version: !ruby/object:Gem::Version
-  version: 3.18.0
+  version: 3.19.0
 platform: ruby
 authors:
 - Puppet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-06-14 00:00:00.000000000 Z
+date: 2017-06-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -290,6 +290,20 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: beaker-puppet
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '0.0'
 - !ruby/object:Gem::Dependency
   name: rbvmomi
   requirement: !ruby/object:Gem::Requirement
@@ -412,10 +426,7 @@ files:
 - acceptance/config/acceptance-options.rb
 - acceptance/config/base/acceptance-options.rb
 - acceptance/config/hypervisor/acceptance-options.rb
-- acceptance/config/puppetgem/acceptance-options.rb
-- acceptance/config/puppetgit/acceptance-options.rb
 - acceptance/config/puppetpe/acceptance-options.rb
-- acceptance/config/puppetpkg/acceptance-options.rb
 - acceptance/config/subcommands/acceptance-options.rb
 - acceptance/fixtures/README.md
 - acceptance/fixtures/files/failing_shell_script.txt
@@ -474,9 +485,6 @@ files:
 - acceptance/lib/helpers/test_helper.rb
 - acceptance/pre_suite/README.md
 - acceptance/pre_suite/pe/install.rb
-- acceptance/pre_suite/puppet_gem/install.rb
-- acceptance/pre_suite/puppet_git/install.rb
-- acceptance/pre_suite/puppet_pkg/install.rb
 - acceptance/pre_suite/subcommands/05_install_ruby.rb
 - acceptance/pre_suite/subcommands/08_install_beaker.rb
 - acceptance/tests/base/README.md
@@ -518,11 +526,6 @@ files:
 - acceptance/tests/hypervisor/communication_test.rb
 - acceptance/tests/install/from_file.rb
 - acceptance/tests/load_path_bootstrap.rb
-- acceptance/tests/puppet/README.md
-- acceptance/tests/puppet/install_smoke_test.rb
-- acceptance/tests/puppet/stub_host.rb
-- acceptance/tests/puppet/web_helpers_test.rb
-- acceptance/tests/puppet/with_puppet_running_on.rb
 - acceptance/tests/subcommands/destroy.rb
 - acceptance/tests/subcommands/exec.rb
 - acceptance/tests/subcommands/init.rb
@@ -598,18 +601,10 @@ files:
 - lib/beaker/dsl/helpers/facter_helpers.rb
 - lib/beaker/dsl/helpers/hocon_helpers.rb
 - lib/beaker/dsl/helpers/host_helpers.rb
-- lib/beaker/dsl/helpers/puppet_helpers.rb
 - lib/beaker/dsl/helpers/test_helpers.rb
-- lib/beaker/dsl/helpers/tk_helpers.rb
 - lib/beaker/dsl/helpers/web_helpers.rb
 - lib/beaker/dsl/install_utils.rb
-- lib/beaker/dsl/install_utils/aio_defaults.rb
-- lib/beaker/dsl/install_utils/ezbake_utils.rb
-- lib/beaker/dsl/install_utils/foss_defaults.rb
-- lib/beaker/dsl/install_utils/foss_utils.rb
-- lib/beaker/dsl/install_utils/module_utils.rb
 - lib/beaker/dsl/install_utils/pe_defaults.rb
-- lib/beaker/dsl/install_utils/puppet_utils.rb
 - lib/beaker/dsl/install_utils/windows_utils.rb
 - lib/beaker/dsl/outcomes.rb
 - lib/beaker/dsl/patterns.rb
@@ -678,7 +673,6 @@ files:
 - lib/beaker/network_manager.rb
 - lib/beaker/options.rb
 - lib/beaker/options/command_line_parser.rb
-- lib/beaker/options/homedir_options_file_parser.rb
 - lib/beaker/options/hosts_file_parser.rb
 - lib/beaker/options/options_file_parser.rb
 - lib/beaker/options/options_hash.rb
@@ -709,16 +703,10 @@ files:
 - spec/beaker/command_spec.rb
 - spec/beaker/dsl/assertions_spec.rb
 - spec/beaker/dsl/ezbake_utils_spec.rb
-- spec/beaker/dsl/helpers/facter_helpers_spec.rb
 - spec/beaker/dsl/helpers/host_helpers_spec.rb
-- spec/beaker/dsl/helpers/puppet_helpers_spec.rb
 - spec/beaker/dsl/helpers/test_helpers_spec.rb
-- spec/beaker/dsl/helpers/tk_helpers_spec.rb
 - spec/beaker/dsl/helpers/web_helpers_spec.rb
-- spec/beaker/dsl/install_utils/foss_utils_spec.rb
-- spec/beaker/dsl/install_utils/module_utils_spec.rb
 - spec/beaker/dsl/install_utils/pe_defaults_spec.rb
-- spec/beaker/dsl/install_utils/puppet_utils_spec.rb
 - spec/beaker/dsl/install_utils/windows_utils_spec.rb
 - spec/beaker/dsl/outcomes_spec.rb
 - spec/beaker/dsl/roles_spec.rb