beaker 2.7.1 → 2.8.0

data/spec/beaker/dsl/helpers/tk_helpers_spec.rb

@@ -0,0 +1,83 @@
+require 'spec_helper'
+
+class ClassMixedWithDSLHelpers
+  include Beaker::DSL::Helpers
+  include Beaker::DSL::Wrappers
+  include Beaker::DSL::Roles
+  include Beaker::DSL::Patterns
+
+  def logger
+    RSpec::Mocks::Double.new('logger').as_null_object
+  end
+
+end
+
+describe ClassMixedWithDSLHelpers do
+  let( :opts )   { Beaker::Options::Presets.env_vars }
+  let( :command ){ 'ls' }
+  let( :host )   { double.as_null_object }
+  let( :result ) { Beaker::Result.new( host, command ) }
+
+  let( :master ) { make_host( 'master',   :roles => %w( master agent default)    ) }
+  let( :agent )  { make_host( 'agent',    :roles => %w( agent )           ) }
+  let( :custom ) { make_host( 'custom',   :roles => %w( custom agent )    ) }
+  let( :dash )   { make_host( 'console',  :roles => %w( dashboard agent ) ) }
+  let( :db )     { make_host( 'db',       :roles => %w( database agent )  ) }
+  let( :hosts )  { [ master, agent, dash, db, custom ] }
+
+
+  describe 'modify_tk_config' do
+    let(:host) { double.as_null_object }
+    let(:config_file_path) { 'existing-file-path'}
+    let(:invalid_config_file_path) { 'nonexisting-file-path'}
+    let(:options_hash) { {:key => 'value'} }
+    let(:replace) { true }
+
+    shared_examples 'modify-tk-config-without-error' do
+      it 'dumps to the SUT config file path' do
+        allow( JSON ).to receive(:dump)
+        allow( subject ).to receive(:create_remote_file).with(host, config_file_path, anything())
+        subject.modify_tk_config(host, config_file_path, options_hash, replace)
+      end
+    end
+
+    before do
+      allow( host ).to receive(:file_exist?).with(invalid_config_file_path).and_return(false)
+      allow( host ).to receive(:file_exist?).with(config_file_path).and_return(true)
+    end
+
+    describe 'if file does not exist on SUT' do
+      it 'raises Runtime error' do
+        expect do
+          subject.modify_tk_config(host, invalid_config_file_path, options_hash)
+        end.to raise_error(RuntimeError, /.* does not exist on .*/)
+      end
+    end
+
+    describe 'given an empty options hash' do
+      it 'returns nil' do
+        expect(subject.modify_tk_config(host, 'blahblah', {})).to eq(nil)
+      end
+    end
+
+    describe 'given a non-empty options hash' do
+
+      describe 'given a false value to its `replace` parameter' do
+        let(:replace) { false }
+        before do
+          expect( subject ).to receive(:read_tk_config_string).with(anything())
+        end
+        include_examples('modify-tk-config-without-error')
+      end
+
+      describe 'given a true value to its `replace` parameter' do
+        before do
+          expect( JSON ).to receive(:dump)
+          expect( subject ).to receive(:create_remote_file).with(host, config_file_path, anything())
+        end
+        include_examples('modify-tk-config-without-error')
+      end
+    end
+  end
+
+end

data/spec/beaker/dsl/helpers/web_helpers_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+class ClassMixedWithDSLHelpers
+  include Beaker::DSL::Helpers
+  include Beaker::DSL::Wrappers
+  include Beaker::DSL::Roles
+  include Beaker::DSL::Patterns
+
+  def logger
+    RSpec::Mocks::Double.new('logger').as_null_object
+  end
+
+end
+
+describe ClassMixedWithDSLHelpers do
+
+  def fetch_allows
+    allow(subject).to receive( :logger ) { logger }
+  end
+
+  describe "#fetch_http_file" do
+    let( :logger) { double("Beaker::Logger", :notify => nil , :debug => nil ) }
+
+    before do
+      fetch_allows
+    end
+
+    describe "given valid arguments" do
+
+      it "returns its second and third arguments concatenated." do
+        create_files(['destdir/name'])
+        result = subject.fetch_http_file "http://beaker.tool/", "name", "destdir"
+        expect(result).to eq("destdir/name")
+      end
+
+    end
+
+  end
+
+  describe "#fetch_http_dir" do
+    let( :logger) { double("Beaker::Logger", :notify => nil , :debug => nil ) }
+    let( :result) { double(:each_line => []) }
+
+    before do
+      fetch_allows
+    end
+
+    describe "given valid arguments" do
+
+      it "returns basename of first argument concatenated to second." do
+        expect(subject).to receive(:`).with(/^wget.*/).ordered { result }
+        expect($?).to receive(:to_i).and_return(0)
+        result = subject.fetch_http_dir "http://beaker.tool/beep", "destdir"
+        expect(result).to eq("destdir/beep")
+      end
+
+    end
+
+  end
+end

data/spec/beaker/dsl/install_utils/module_utils_spec.rb

@@ -0,0 +1,241 @@
+require 'spec_helper'
+
+class ClassMixedWithDSLInstallUtils
+  include Beaker::DSL::InstallUtils
+  include Beaker::DSL::Wrappers
+  include Beaker::DSL::Helpers
+  include Beaker::DSL::Structure
+  include Beaker::DSL::Roles
+  include Beaker::DSL::Patterns
+
+  def logger
+    @logger ||= RSpec::Mocks::Double.new('logger').as_null_object
+  end
+end
+
+describe ClassMixedWithDSLInstallUtils do
+  let(:presets)       { Beaker::Options::Presets.new }
+  let(:opts)          { presets.presets.merge(presets.env_vars) }
+  let(:basic_hosts)   { make_hosts( { :pe_ver => '3.0',
+                                       :platform => 'linux',
+                                       :roles => [ 'agent' ] }, 4 ) }
+  let(:hosts)         { basic_hosts[0][:roles] = ['master', 'database', 'dashboard']
+                        basic_hosts[1][:platform] = 'windows'
+                        basic_hosts[2][:platform] = 'osx-10.9-x86_64'
+                        basic_hosts[3][:platform] = 'eos'
+                        basic_hosts  }
+  let(:hosts_sorted)  { [ hosts[1], hosts[0], hosts[2], hosts[3] ] }
+
+
+
+  describe '#install_dev_puppet_module_on' do
+    context 'having set allow( a ).to receive forge' do
+      it 'stubs the forge on the host' do
+        master = hosts.first
+        allow( subject ).to receive( :options ).and_return( {:forge_host => 'ahost.com'} )
+
+        expect( subject ).to receive( :with_forge_stubbed_on )
+
+        subject.install_dev_puppet_module_on( master, {:source => '/module', :module_name => 'test'} )
+      end
+
+      it 'installs via #install_puppet_module_via_pmt' do
+        master = hosts.first
+        allow( subject ).to receive( :options ).and_return( {:forge_host => 'ahost.com'} )
+        allow( subject ).to receive( :with_forge_stubbed_on ).and_yield
+
+        expect( subject ).to receive( :install_puppet_module_via_pmt_on )
+
+        subject.install_dev_puppet_module_on( master, {:source => '/module', :module_name => 'test'} )
+      end
+    end
+    context 'without allow( a ).to receive forge (default)' do
+      it 'calls copy_module_to to get the module on the SUT' do
+        master = hosts.first
+        allow( subject ).to receive( :options ).and_return( {} )
+
+        expect( subject ).to receive( :copy_module_to )
+
+        subject.install_dev_puppet_module_on( master, {:source => '/module', :module_name => 'test'} )
+      end
+    end
+  end
+
+  describe '#install_dev_puppet_module' do
+    it 'delegates to #install_dev_puppet_module_on with the hosts list' do
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+      allow( subject ).to receive( :options ).and_return( {} )
+
+      hosts.each do |host|
+        expect( subject ).to receive( :install_dev_puppet_module_on ).
+          with( host, {:source => '/module', :module_name => 'test'})
+      end
+
+      subject.install_dev_puppet_module( {:source => '/module', :module_name => 'test'} )
+    end
+  end
+
+  describe '#install_puppet_module_via_pmt_on' do
+    it 'installs module via puppet module tool' do
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+      master = hosts.first
+
+
+      expect( subject ).to receive( :puppet ).with('module install test ', {}).once
+
+      subject.install_puppet_module_via_pmt_on( master, {:module_name => 'test'} )
+    end
+
+    it 'takes the trace option and passes it down correctly' do
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+      master = hosts.first
+      trace_opts = { :trace => nil }
+      master['default_module_install_opts'] = trace_opts
+
+      expect( subject ).to receive( :puppet ).with('module install test ', trace_opts).once
+
+      subject.install_puppet_module_via_pmt_on( master, {:module_name => 'test'} )
+    end
+  end
+
+  describe '#install_puppet_module_via_pmt' do
+    it 'delegates to #install_puppet_module_via_pmt with the hosts list' do
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+
+      expect( subject ).to receive( :install_puppet_module_via_pmt_on ).with( hosts, {:source => '/module', :module_name => 'test'}).once
+
+      subject.install_puppet_module_via_pmt( {:source => '/module', :module_name => 'test'} )
+    end
+  end
+
+  describe 'copy_module_to' do
+    let(:ignore_list) { Beaker::DSL::InstallUtils::ModuleUtils::PUPPET_MODULE_INSTALL_IGNORE }
+    let(:source){ File.expand_path('./')}
+    let(:target){'/etc/puppetlabs/puppet/modules/testmodule'}
+    let(:module_parse_name){'testmodule'}
+
+    shared_examples 'copy_module_to' do  |opts|
+      it{
+        host = double("host")
+        allow( host ).to receive(:[]).with('distmoduledir').and_return('/etc/puppetlabs/puppet/modules')
+        result = double
+        stdout = target.split('/')[0..-2].join('/') + "\n"
+        allow( result ).to receive(:stdout).and_return( stdout )
+        expect( subject ).to receive(:on).with(host, "echo #{File.dirname(target)}" ).and_return(result )
+        allow( Dir ).to receive(:getpwd).and_return(source)
+
+        allow( subject ).to receive(:parse_for_moduleroot).and_return(source)
+        if module_parse_name
+          allow( subject ).to receive(:parse_for_modulename).with(any_args()).and_return(module_parse_name)
+        else
+          expect( subject).to_not receive(:parse_for_modulename)
+        end
+
+        allow( File ).to receive(:exists?).with(any_args()).and_return(false)
+        allow( File ).to receive(:directory?).with(any_args()).and_return(false)
+
+        expect( subject ).to receive(:scp_to).with(host,source, File.dirname(target), {:ignore => ignore_list})
+        expect( subject ).to receive(:on).with(host, "mv #{File.join(File.dirname(target), File.basename(source))} #{target}")
+        if opts.nil?
+          subject.copy_module_to(host)
+        else
+          subject.copy_module_to(host,opts)
+        end
+      }
+    end
+
+    describe 'should call scp with the correct info, with only providing host' do
+      let(:target){'/etc/puppetlabs/puppet/modules/testmodule'}
+
+      it_should_behave_like 'copy_module_to', :module_name => 'testmodule'
+    end
+
+    describe 'should call scp with the correct info, when specifying the modulename' do
+      let(:target){'/etc/puppetlabs/puppet/modules/bogusmodule'}
+      let(:module_parse_name){false}
+      it_should_behave_like 'copy_module_to', {:module_name =>'bogusmodule'}
+    end
+
+    describe 'should call scp with the correct info, when specifying the target to a different path' do
+      target = '/opt/shared/puppet/modules'
+      let(:target){"#{target}/testmodule"}
+      it_should_behave_like 'copy_module_to', {:target_module_path => target, :module_name => 'testmodule'}
+    end
+
+    describe 'should accept multiple hosts when' do
+      it 'used in a default manner' do
+        allow( subject ).to receive( :build_ignore_list ).and_return( [] )
+        allow( subject ).to receive( :parse_for_modulename ).and_return( [nil, 'modulename'] )
+        allow( subject ).to receive( :on ).and_return( double.as_null_object )
+        hosts = [{}, {}]
+
+        expect( subject ).to receive( :scp_to ).twice
+        subject.copy_module_to( hosts )
+      end
+    end
+  end
+
+  describe 'split_author_modulename' do
+    it 'should return a correct modulename' do
+      result =  subject.split_author_modulename('myname-test_43_module')
+      expect(result[:author]).to eq('myname')
+      expect(result[:module]).to eq('test_43_module')
+    end
+  end
+
+  describe 'get_module_name' do
+    it 'should return an array of author and modulename' do
+      expect(subject.get_module_name('myname-test_43_module')).to eq(['myname', 'test_43_module'])
+    end
+    it 'should return nil for invalid names' do
+      expect(subject.get_module_name('myname-')).to eq(nil)
+    end
+  end
+
+  describe 'parse_for_modulename' do
+    directory = '/testfilepath/myname-testmodule'
+    it 'should return name from metadata.json' do
+      allow( File ).to receive(:exists?).with("#{directory}/metadata.json").and_return(true)
+      allow( File ).to receive(:read).with("#{directory}/metadata.json").and_return(" {\"name\":\"myname-testmodule\"} ")
+      expect( subject.logger ).to receive(:debug).with("Attempting to parse Modulename from metadata.json")
+      expect(subject.logger).to_not receive(:debug).with('Unable to determine name, returning null')
+      expect(subject.parse_for_modulename(directory)).to eq(['myname', 'testmodule'])
+    end
+    it 'should return name from Modulefile' do
+      allow( File ).to receive(:exists?).with("#{directory}/metadata.json").and_return(false)
+      allow( File ).to receive(:exists?).with("#{directory}/Modulefile").and_return(true)
+      allow( File ).to receive(:read).with("#{directory}/Modulefile").and_return("name    'myname-testmodule'  \nauthor   'myname'")
+      expect( subject.logger ).to receive(:debug).with("Attempting to parse Modulename from Modulefile")
+      expect(subject.logger).to_not receive(:debug).with("Unable to determine name, returning null")
+      expect(subject.parse_for_modulename(directory)).to eq(['myname', 'testmodule'])
+    end
+  end
+
+  describe 'parse_for_module_root' do
+    directory = '/testfilepath/myname-testmodule'
+    describe 'stops searching when either' do
+      it 'finds a Modulefile' do
+        allow( File ).to receive(:exists?).and_return(false)
+        allow( File ).to receive(:exists?).with("#{directory}/Modulefile").and_return(true)
+
+        expect( subject.logger ).to_not receive(:debug).with("At root, can't parse for another directory")
+        expect( subject.logger ).to receive(:debug).with("No Modulefile or metadata.json found at #{directory}/acceptance, moving up")
+        expect(subject.parse_for_moduleroot("#{directory}/acceptance")).to eq(directory)
+      end
+      it 'finds a metadata.json file' do
+        allow( File ).to receive(:exists?).and_return(false)
+        allow( File ).to receive(:exists?).with("#{directory}/metadata.json").and_return(true)
+
+        expect( subject.logger ).to_not receive(:debug).with("At root, can't parse for another directory")
+        expect( subject.logger ).to receive(:debug).with("No Modulefile or metadata.json found at #{directory}/acceptance, moving up")
+        expect(subject.parse_for_moduleroot("#{directory}/acceptance")).to eq(directory)
+      end
+    end
+    it 'should recersively go up the directory to find the module files' do
+      allow( File ).to receive(:exists?).and_return(false)
+      expect( subject.logger ).to receive(:debug).with("No Modulefile or metadata.json found at #{directory}, moving up")
+      expect( subject.logger ).to receive(:error).with("At root, can't parse for another directory")
+      expect(subject.parse_for_moduleroot(directory)).to eq(nil)
+    end
+  end
+end

data/spec/beaker/dsl/install_utils/pe_utils_spec.rb

@@ -0,0 +1,475 @@
+require 'spec_helper'
+
+class ClassMixedWithDSLInstallUtils
+  include Beaker::DSL::InstallUtils
+  include Beaker::DSL::Wrappers
+  include Beaker::DSL::Helpers
+  include Beaker::DSL::Structure
+  include Beaker::DSL::Roles
+  include Beaker::DSL::Patterns
+
+  def logger
+    @logger ||= RSpec::Mocks::Double.new('logger').as_null_object
+  end
+end
+
+describe ClassMixedWithDSLInstallUtils do
+  let(:presets)       { Beaker::Options::Presets.new }
+  let(:opts)          { presets.presets.merge(presets.env_vars) }
+  let(:basic_hosts)   { make_hosts( { :pe_ver => '3.0',
+                                       :platform => 'linux',
+                                       :roles => [ 'agent' ] }, 4 ) }
+  let(:hosts)         { basic_hosts[0][:roles] = ['master', 'database', 'dashboard']
+                        basic_hosts[1][:platform] = 'windows'
+                        basic_hosts[2][:platform] = 'osx-10.9-x86_64'
+                        basic_hosts[3][:platform] = 'eos'
+                        basic_hosts  }
+  let(:hosts_sorted)  { [ hosts[1], hosts[0], hosts[2], hosts[3] ] }
+  let(:winhost)       { make_host( 'winhost', { :platform => 'windows',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp' } ) }
+  let(:machost)       { make_host( 'machost', { :platform => 'osx-10.9-x86_64',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp' } ) }
+  let(:unixhost)      { make_host( 'unixhost', { :platform => 'linux',
+                                                 :pe_ver => '3.0',
+                                                 :working_dir => '/tmp',
+                                                 :dist => 'puppet-enterprise-3.1.0-rc0-230-g36c9e5c-debian-7-i386' } ) }
+  let(:eoshost)       { make_host( 'eoshost', { :platform => 'eos',
+                                                :pe_ver => '3.0',
+                                                :working_dir => '/tmp',
+                                                :dist => 'puppet-enterprise-3.7.1-rc0-78-gffc958f-eos-4-i386' } ) }
+
+  describe 'sorted_hosts' do
+    it 'can reorder so that the master comes first' do
+      allow( subject ).to receive( :hosts ).and_return( hosts_sorted )
+      expect( subject.sorted_hosts ).to be === hosts
+    end
+
+    it 'leaves correctly ordered hosts alone' do
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+      expect( subject.sorted_hosts ).to be === hosts
+    end
+
+    it 'does not allow nil entries' do
+      allow( subject ).to receive( :options ).and_return( { :masterless => true } )
+      masterless_host = [basic_hosts[0]]
+      allow( subject ).to receive( :hosts ).and_return( masterless_host )
+      expect( subject.sorted_hosts ).to be === masterless_host
+    end
+  end
+
+  describe 'installer_cmd' do
+
+    it 'generates a windows PE install command for a windows host' do
+      winhost['dist'] = 'puppet-enterprise-3.0'
+      allow( subject ).to receive( :hosts ).and_return( [ hosts[1], hosts[0], hosts[2], winhost ] )
+      expect( subject.installer_cmd( winhost, {} ) ).to be === "cd /tmp && cmd /C 'start /w msiexec.exe /qn /L*V tmp.log /i puppet-enterprise-3.0.msi PUPPET_MASTER_SERVER=vm1 PUPPET_AGENT_CERTNAME=winhost'"
+    end
+
+    it 'generates a unix PE install command for a unix host' do
+      the_host = unixhost.dup
+      the_host['pe_installer'] = 'puppet-enterprise-installer'
+      expect( subject.installer_cmd( the_host, {} ) ).to be === "cd /tmp/puppet-enterprise-3.1.0-rc0-230-g36c9e5c-debian-7-i386 && ./puppet-enterprise-installer -a /tmp/answers"
+    end
+
+    it 'generates a unix PE frictionless install command for a unix host with role "frictionless"' do
+      allow( subject ).to receive( :version_is_less ).and_return( false )
+      allow( subject ).to receive( :master ).and_return( 'testmaster' )
+      the_host = unixhost.dup
+      the_host['pe_installer'] = 'puppet-enterprise-installer'
+      the_host['roles'] = ['frictionless']
+      expect( subject.installer_cmd( the_host, {} ) ).to be ===  "cd /tmp && curl --tlsv1 -kO https://testmaster:8140/packages/3.0/install.bash && bash install.bash"
+    end
+
+    it 'generates a unix PE frictionless install command for a unix host with role "frictionless" and "frictionless_options"' do
+      allow( subject ).to receive( :version_is_less ).and_return( false )
+      allow( subject ).to receive( :master ).and_return( 'testmaster' )
+      the_host = unixhost.dup
+      the_host['pe_installer'] = 'puppet-enterprise-installer'
+      the_host['roles'] = ['frictionless']
+      the_host['frictionless_options'] = { 'main' => { 'dns_alt_names' => 'puppet' } }
+      expect( subject.installer_cmd( the_host, {} ) ).to be ===  "cd /tmp && curl --tlsv1 -kO https://testmaster:8140/packages/3.0/install.bash && bash install.bash main:dns_alt_names=puppet"
+    end
+
+    it 'generates a osx PE install command for a osx host' do
+      the_host = machost.dup
+      the_host['pe_installer'] = 'puppet-enterprise-installer'
+      expect( subject.installer_cmd( the_host, {} ) ).to be === "cd /tmp && hdiutil attach .dmg && installer -pkg /Volumes/puppet-enterprise-3.0/puppet-enterprise-installer-3.0.pkg -target /"
+    end
+
+    it 'generates an EOS PE install command for an EOS host' do
+      the_host = eoshost.dup
+      commands = ['enable', "extension puppet-enterprise-#{the_host['pe_ver']}-#{the_host['platform']}.swix"]
+      command = commands.join("\n")
+      expect( subject.installer_cmd( the_host, {} ) ).to be === "Cli -c '#{command}'"
+    end
+
+    it 'generates a unix PE install command in verbose for a unix host when pe_debug is enabled' do
+      the_host = unixhost.dup
+      the_host['pe_installer'] = 'puppet-enterprise-installer'
+      the_host[:pe_debug] = true
+      expect( subject.installer_cmd( the_host, {} ) ).to be === "cd /tmp/puppet-enterprise-3.1.0-rc0-230-g36c9e5c-debian-7-i386 && ./puppet-enterprise-installer -D -a /tmp/answers"
+    end
+
+    it 'generates a osx PE install command in verbose for a osx host when pe_debug is enabled' do
+      the_host = machost.dup
+      the_host['pe_installer'] = 'puppet-enterprise-installer'
+      the_host[:pe_debug] = true
+      expect( subject.installer_cmd( the_host, {} ) ).to be === "cd /tmp && hdiutil attach .dmg && installer -verboseR -pkg /Volumes/puppet-enterprise-3.0/puppet-enterprise-installer-3.0.pkg -target /"
+    end
+
+    it 'generates a unix PE frictionless install command in verbose for a unix host with role "frictionless" and pe_debug is enabled' do
+      allow( subject ).to receive( :version_is_less ).and_return( false )
+      allow( subject ).to receive( :master ).and_return( 'testmaster' )
+      the_host = unixhost.dup
+      the_host['pe_installer'] = 'puppet-enterprise-installer'
+      the_host['roles'] = ['frictionless']
+      the_host[:pe_debug] = true
+      expect( subject.installer_cmd( the_host, {} ) ).to be === "cd /tmp && curl --tlsv1 -kO https://testmaster:8140/packages/3.0/install.bash && bash -x install.bash"
+    end
+
+  end
+
+
+  describe 'fetch_pe' do
+
+    it 'can push a local PE .tar.gz to a host and unpack it' do
+      allow( File ).to receive( :directory? ).and_return( true ) #is local
+      allow( File ).to receive( :exists? ).and_return( true ) #is a .tar.gz
+      unixhost['pe_dir'] = '/local/file/path'
+      allow( subject ).to receive( :scp_to ).and_return( true )
+
+      path = unixhost['pe_dir']
+      filename = "#{ unixhost['dist'] }"
+      extension = '.tar.gz'
+      expect( subject ).to receive( :scp_to ).with( unixhost, "#{ path }/#{ filename }#{ extension }", "#{ unixhost['working_dir'] }/#{ filename }#{ extension }" ).once
+      expect( subject ).to receive( :on ).with( unixhost, /gunzip/ ).once
+      expect( subject ).to receive( :on ).with( unixhost, /tar -xvf/ ).once
+      subject.fetch_pe( [unixhost], {} )
+    end
+
+    it 'can download a PE .tar from a URL to a host and unpack it' do
+      allow( File ).to receive( :directory? ).and_return( false ) #is not local
+      allow( subject ).to receive( :link_exists? ) do |arg|
+        if arg =~ /.tar.gz/ #there is no .tar.gz link, only a .tar
+          false
+        else
+          true
+        end
+      end
+      allow( subject ).to receive( :on ).and_return( true )
+
+      path = unixhost['pe_dir']
+      filename = "#{ unixhost['dist'] }"
+      extension = '.tar'
+      expect( subject ).to receive( :on ).with( unixhost, "cd #{ unixhost['working_dir'] }; curl #{ path }/#{ filename }#{ extension } | tar -xvf -" ).once
+      subject.fetch_pe( [unixhost], {} )
+    end
+
+    it 'can download a PE .tar.gz from a URL to a host and unpack it' do
+      allow( File ).to receive( :directory? ).and_return( false ) #is not local
+      allow( subject ).to receive( :link_exists? ).and_return( true ) #is a tar.gz
+      allow( subject ).to receive( :on ).and_return( true )
+
+      path = unixhost['pe_dir']
+      filename = "#{ unixhost['dist'] }"
+      extension = '.tar.gz'
+      expect( subject ).to receive( :on ).with( unixhost, "cd #{ unixhost['working_dir'] }; curl #{ path }/#{ filename }#{ extension } | gunzip | tar -xvf -" ).once
+      subject.fetch_pe( [unixhost], {} )
+    end
+
+    it 'can download a PE .swix from a URL to an EOS host and unpack it' do
+      allow( File ).to receive( :directory? ).and_return( false ) #is not local
+      allow( subject ).to receive( :link_exists? ).and_return( true ) #is a tar.gz
+      allow( subject ).to receive( :on ).and_return( true )
+
+      path = eoshost['pe_dir']
+      filename = "#{ eoshost['dist'] }"
+      extension = '.swix'
+      commands = ['enable', "copy #{path}/#{filename}#{extension} extension:"]
+      command = commands.join("\n")
+      expect( subject ).to receive( :on ).with( eoshost, "Cli -c '#{command}'" ).once
+      subject.fetch_pe( [eoshost], {} )
+    end
+
+    it 'can push a local PE package to a windows host' do
+      allow( File ).to receive( :directory? ).and_return( true ) #is local
+      allow( File ).to receive( :exists? ).and_return( true ) #is present
+      winhost['dist'] = 'puppet-enterprise-3.0'
+      allow( subject ).to receive( :scp_to ).and_return( true )
+
+      path = winhost['pe_dir']
+      filename = "puppet-enterprise-#{ winhost['pe_ver'] }"
+      extension = '.msi'
+      expect( subject ).to receive( :scp_to ).with( winhost, "#{ path }/#{ filename }#{ extension }", "#{ winhost['working_dir'] }/#{ filename }#{ extension }" ).once
+      subject.fetch_pe( [winhost], {} )
+
+    end
+
+    it 'can download a PE dmg from a URL to a mac host' do
+      allow( File ).to receive( :directory? ).and_return( false ) #is not local
+      allow( subject ).to receive( :link_exists? ).and_return( true ) #is  not local
+      allow( subject ).to receive( :on ).and_return( true )
+
+      path = machost['pe_dir']
+      filename = "#{ machost['dist'] }"
+      extension = '.dmg'
+      expect( subject ).to receive( :on ).with( machost, "cd #{ machost['working_dir'] }; curl -O #{ path }/#{ filename }#{ extension }" ).once
+      subject.fetch_pe( [machost], {} )
+    end
+
+    it 'can push a PE dmg to a mac host' do
+      allow( File ).to receive( :directory? ).and_return( true ) #is local
+      allow( File ).to receive( :exists? ).and_return( true ) #is present
+      allow( subject ).to receive( :scp_to ).and_return( true )
+
+      path = machost['pe_dir']
+      filename = "#{ machost['dist'] }"
+      extension = '.dmg'
+      expect( subject ).to receive( :scp_to ).with( machost, "#{ path }/#{ filename }#{ extension }", "#{ machost['working_dir'] }/#{ filename }#{ extension }" ).once
+      subject.fetch_pe( [machost], {} )
+    end
+
+    it "does nothing for a frictionless agent for PE >= 3.2.0" do
+      unixhost['roles'] << 'frictionless'
+      unixhost['pe_ver'] = '3.2.0'
+
+      expect( subject).to_not receive(:scp_to)
+      expect( subject).to_not receive(:on)
+      allow( subject ).to receive(:version_is_less).with('3.2.0', '3.2.0').and_return(false)
+      subject.fetch_pe( [unixhost], {} )
+    end
+  end
+
+  describe 'do_install' do
+    it 'can perform a simple installation' do
+      allow( subject ).to receive( :on ).and_return( Beaker::Result.new( {}, '' ) )
+      allow( subject ).to receive( :fetch_pe ).and_return( true )
+      allow( subject ).to receive( :create_remote_file ).and_return( true )
+      allow( subject ).to receive( :sign_certificate_for ).and_return( true )
+      allow( subject ).to receive( :stop_agent_on ).and_return( true )
+      allow( subject ).to receive( :sleep_until_puppetdb_started ).and_return( true )
+      allow( subject ).to receive( :version_is_less ).with('3.0', '4.0').and_return( true )
+      allow( subject ).to receive( :version_is_less ).with('3.0', '3.4').and_return( true )
+      allow( subject ).to receive( :version_is_less ).with('3.0', '3.0').and_return( false )
+      allow( subject ).to receive( :version_is_less ).with('3.0', '3.4').and_return( true )
+      allow( subject ).to receive( :wait_for_host_in_dashboard ).and_return( true )
+      allow( subject ).to receive( :puppet_agent ) do |arg|
+        "puppet agent #{arg}"
+      end
+      allow( subject ).to receive( :puppet ) do |arg|
+        "puppet #{arg}"
+      end
+
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+      #create answers file per-host, except windows
+      expect( subject ).to receive( :create_remote_file ).with( hosts[0], /answers/, /q/ ).once
+      #run installer on all hosts
+      expect( subject ).to receive( :on ).with( hosts[0], /puppet-enterprise-installer/ ).once
+      expect( subject ).to receive( :on ).with( hosts[1], /msiexec.exe/ ).once
+      expect( subject ).to receive( :on ).with( hosts[2], / hdiutil attach puppet-enterprise-3.0-osx-10.9-x86_64.dmg && installer -pkg \/Volumes\/puppet-enterprise-3.0\/puppet-enterprise-installer-3.0.pkg -target \// ).once
+      expect( subject ).to receive( :on ).with( hosts[3], /^Cli/ ).once
+      #does extra mac/EOS specific commands
+      expect( subject ).to receive( :on ).with( hosts[2], /puppet config set server/ ).once
+      expect( subject ).to receive( :on ).with( hosts[3], /puppet config set server/ ).once
+      expect( subject ).to receive( :on ).with( hosts[2], /puppet config set certname/ ).once
+      expect( subject ).to receive( :on ).with( hosts[3], /puppet config set certname/ ).once
+      expect( subject ).to receive( :on ).with( hosts[2], /puppet agent -t/, :acceptable_exit_codes => [1] ).once
+      expect( subject ).to receive( :on ).with( hosts[3], /puppet agent -t/, :acceptable_exit_codes => [0, 1] ).once
+      #sign certificate per-host
+      expect( subject ).to receive( :sign_certificate_for ).with( hosts[0] ).once
+      expect( subject ).to receive( :sign_certificate_for ).with( hosts[1] ).once
+      expect( subject ).to receive( :sign_certificate_for ).with( hosts[2] ).once
+      expect( subject ).to receive( :sign_certificate_for ).with( hosts[3] ).once
+      #stop puppet agent on all hosts
+      expect( subject ).to receive( :stop_agent_on ).with( hosts[0] ).once
+      expect( subject ).to receive( :stop_agent_on ).with( hosts[1] ).once
+      expect( subject ).to receive( :stop_agent_on ).with( hosts[2] ).once
+      expect( subject ).to receive( :stop_agent_on ).with( hosts[3] ).once
+      #wait for puppetdb to start
+      expect( subject ).to receive( :sleep_until_puppetdb_started ).with( hosts[0] ).once
+      #run each puppet agent once
+      expect( subject ).to receive( :on ).with( hosts[0], /puppet agent -t/, :acceptable_exit_codes => [0,2] ).once
+      expect( subject ).to receive( :on ).with( hosts[1], /puppet agent -t/, :acceptable_exit_codes => [0,2] ).once
+      expect( subject ).to receive( :on ).with( hosts[2], /puppet agent -t/, :acceptable_exit_codes => [0,2] ).once
+      expect( subject ).to receive( :on ).with( hosts[3], /puppet agent -t/, :acceptable_exit_codes => [0,2] ).once
+      #run rake task on dashboard
+      expect( subject ).to receive( :on ).with( hosts[0], /\/opt\/puppet\/bin\/rake -sf \/opt\/puppet\/share\/puppet-dashboard\/Rakefile .* RAILS_ENV=production/ ).once
+      #wait for all hosts to appear in the dashboard
+      #run puppet agent now that installation is complete
+      expect( subject ).to receive( :on ).with( hosts, /puppet agent/, :acceptable_exit_codes => [0,2] ).once
+      subject.do_install( hosts, opts )
+    end
+
+    it 'can perform a masterless installation' do
+      hosts = make_hosts({
+        :pe_ver => '3.0',
+        :roles => ['agent']
+      }, 1)
+
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+      allow( subject ).to receive( :options ).and_return({ :masterless => true })
+      allow( subject ).to receive( :on ).and_return( Beaker::Result.new( {}, '' ) )
+      allow( subject ).to receive( :fetch_pe ).and_return( true )
+      allow( subject ).to receive( :create_remote_file ).and_return( true )
+      allow( subject ).to receive( :stop_agent_on ).and_return( true )
+      allow( subject ).to receive( :version_is_less ).with(anything, '3.2.0').exactly(hosts.length + 1).times.and_return( false )
+
+      expect( subject ).to receive( :on ).with( hosts[0], /puppet-enterprise-installer/ ).once
+      expect( subject ).to receive( :create_remote_file ).with( hosts[0], /answers/, /q/ ).once
+      expect( subject ).to_not receive( :sign_certificate_for )
+      expect( subject ).to receive( :stop_agent_on ).with( hosts[0] ).once
+      expect( subject ).to_not receive( :sleep_until_puppetdb_started )
+      expect( subject ).to_not receive( :wait_for_host_in_dashboard )
+      expect( subject ).to_not receive( :on ).with( hosts[0], /puppet agent -t/, :acceptable_exit_codes => [0,2] )
+      subject.do_install( hosts, opts)
+    end
+  end
+
+  describe 'do_higgs_install' do
+
+    before :each do
+      my_time = double( "time double" )
+      allow( my_time ).to receive( :strftime ).and_return( "2014-07-01_15.27.53" )
+      allow( Time ).to receive( :new ).and_return( my_time )
+
+      hosts[0]['working_dir'] = "tmp/2014-07-01_15.27.53"
+      hosts[0]['dist'] = 'dist'
+      hosts[0]['pe_installer'] = 'pe-installer'
+      allow( hosts[0] ).to receive( :tmpdir ).and_return( "/tmp/2014-07-01_15.27.53" )
+
+      @fail_result = Beaker::Result.new( {}, '' )
+      @fail_result.stdout = "No match here"
+      @success_result = Beaker::Result.new( {}, '' )
+      @success_result.stdout = "Please go to https://website in your browser to continue installation"
+    end
+
+    it 'can perform a simple installation' do
+      allow( subject ).to receive( :fetch_pe ).and_return( true )
+      allow( subject ).to receive( :sleep ).and_return( true )
+
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+
+      #run higgs installer command
+      expect( subject ).to receive( :on ).with( hosts[0],
+                                         "cd /tmp/2014-07-01_15.27.53/puppet-enterprise-3.0-linux ; nohup ./pe-installer <<<Y > higgs_2014-07-01_15.27.53.log 2>&1 &",
+                                        opts ).once
+      #check to see if the higgs installation has proceeded correctly, works on second check
+      expect( subject ).to receive( :on ).with( hosts[0], /cat #{hosts[0]['higgs_file']}/, { :acceptable_exit_codes => 0..255 }).and_return( @fail_result, @success_result )
+      subject.do_higgs_install( hosts[0], opts )
+    end
+
+    it 'fails out after checking installation log 10 times' do
+      allow( subject ).to receive( :fetch_pe ).and_return( true )
+      allow( subject ).to receive( :sleep ).and_return( true )
+
+      allow( subject ).to receive( :hosts ).and_return( hosts )
+
+      #run higgs installer command
+      expect( subject ).to receive( :on ).with( hosts[0],
+                                         "cd /tmp/2014-07-01_15.27.53/puppet-enterprise-3.0-linux ; nohup ./pe-installer <<<Y > higgs_2014-07-01_15.27.53.log 2>&1 &",
+                                        opts ).once
+      #check to see if the higgs installation has proceeded correctly, works on second check
+      expect( subject ).to receive( :on ).with( hosts[0], /cat #{hosts[0]['higgs_file']}/, { :acceptable_exit_codes => 0..255 }).exactly(10).times.and_return( @fail_result )
+      expect{ subject.do_higgs_install( hosts[0], opts ) }.to raise_error
+    end
+
+  end
+
+  describe 'install_pe' do
+
+    it 'calls do_install with sorted hosts' do
+      allow( subject ).to receive( :options ).and_return( {} )
+      allow( subject ).to receive( :hosts ).and_return( hosts_sorted )
+      allow( subject ).to receive( :do_install ).and_return( true )
+      expect( subject ).to receive( :do_install ).with( hosts, {} )
+      subject.install_pe
+    end
+
+    it 'fills in missing pe_ver' do
+      hosts.each do |h|
+        h['pe_ver'] = nil
+      end
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version ).and_return( '2.8' )
+      allow( subject ).to receive( :hosts ).and_return( hosts_sorted )
+      allow( subject ).to receive( :options ).and_return( {} )
+      allow( subject ).to receive( :do_install ).and_return( true )
+      expect( subject ).to receive( :do_install ).with( hosts, {} )
+      subject.install_pe
+      hosts.each do |h|
+        expect( h['pe_ver'] ).to be === '2.8'
+      end
+    end
+  end
+
+  describe 'install_higgs' do
+    it 'fills in missing pe_ver' do
+      hosts[0]['pe_ver'] = nil
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version ).and_return( '2.8' )
+      allow( subject ).to receive( :hosts ).and_return( [ hosts[1], hosts[0], hosts[2] ] )
+      allow( subject ).to receive( :options ).and_return( {} )
+      allow( subject ).to receive( :do_higgs_install ).and_return( true )
+      expect( subject ).to receive( :do_higgs_install ).with( hosts[0], {} )
+      subject.install_higgs
+      expect( hosts[0]['pe_ver'] ).to be === '2.8'
+    end
+
+  end
+
+  describe 'upgrade_pe' do
+
+    it 'calls puppet-enterprise-upgrader for pre 3.0 upgrades' do
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version ).and_return( '2.8' )
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version_win ).and_return( '2.8' )
+      the_hosts = [ hosts[0].dup, hosts[1].dup, hosts[2].dup ]
+      allow( subject ).to receive( :hosts ).and_return( the_hosts )
+      allow( subject ).to receive( :options ).and_return( {} )
+      allow( subject ).to receive( :version_is_less ).with('3.0', '3.4.0').and_return( true )
+      allow( subject ).to receive( :version_is_less ).with('2.8', '3.0').and_return( true )
+      version = version_win = '2.8'
+      path = "/path/to/upgradepkg"
+      expect( subject ).to receive( :do_install ).with( the_hosts, {:type=>:upgrade, :set_console_password=>true} )
+      subject.upgrade_pe( path )
+      the_hosts.each do |h|
+        expect( h['pe_installer'] ).to be === 'puppet-enterprise-upgrader'
+      end
+    end
+
+    it 'uses standard upgrader for post 3.0 upgrades' do
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version ).and_return( '3.1' )
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version_win ).and_return( '3.1' )
+      the_hosts = [ hosts[0].dup, hosts[1].dup, hosts[2].dup ]
+      allow( subject ).to receive( :hosts ).and_return( the_hosts )
+      allow( subject ).to receive( :options ).and_return( {} )
+      allow( subject ).to receive( :version_is_less ).with('3.0', '3.4.0').and_return( true )
+      allow( subject ).to receive( :version_is_less ).with('3.1', '3.0').and_return( false )
+      version = version_win = '3.1'
+      path = "/path/to/upgradepkg"
+      expect( subject ).to receive( :do_install ).with( the_hosts, {:type=>:upgrade, :set_console_password=>true} )
+      subject.upgrade_pe( path )
+      the_hosts.each do |h|
+        expect( h['pe_installer'] ).to be nil
+      end
+    end
+
+    it 'updates pe_ver post upgrade' do
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version ).and_return( '2.8' )
+      allow( Beaker::Options::PEVersionScraper ).to receive( :load_pe_version_win ).and_return( '2.8' )
+      the_hosts = [ hosts[0].dup, hosts[1].dup, hosts[2].dup ]
+      allow( subject ).to receive( :hosts ).and_return( the_hosts )
+      allow( subject ).to receive( :options ).and_return( {} )
+      allow( subject ).to receive( :version_is_less ).with('3.0', '3.4.0').and_return( true )
+      allow( subject ).to receive( :version_is_less ).with('2.8', '3.0').and_return( true )
+      version = version_win = '2.8'
+      path = "/path/to/upgradepkg"
+      expect( subject ).to receive( :do_install ).with( the_hosts, {:type=>:upgrade, :set_console_password=>true} )
+      subject.upgrade_pe( path )
+      the_hosts.each do |h|
+        expect( h['pe_ver'] ).to be === '2.8'
+      end
+    end
+
+  end
+
+end