beaker-puppet 4.1.1 → 4.3.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (16) hide show
  1. checksums.yaml +4 -4
  2. data/.github/workflows/release.yml +3 -3
  3. data/.github/workflows/test.yml +8 -9
  4. data/.rubocop_todo.yml +317 -83
  5. data/CHANGELOG.md +24 -3
  6. data/Gemfile +3 -0
  7. data/beaker-puppet.gemspec +2 -2
  8. data/lib/beaker-puppet/helpers/puppet_helpers.rb +1 -2
  9. data/lib/beaker-puppet/helpers/tk_helpers.rb +1 -2
  10. data/lib/beaker-puppet/inifile.rb +635 -0
  11. data/lib/beaker-puppet/install_utils/foss_utils.rb +1 -1
  12. data/lib/beaker-puppet/version.rb +1 -1
  13. data/lib/beaker-puppet.rb +1 -0
  14. data/spec/beaker-puppet/helpers/facter_helpers_spec.rb +1 -1
  15. data/spec/beaker-puppet/install_utils/foss_utils_spec.rb +1 -1
  16. metadata +10 -9
data/.rubocop_todo.yml CHANGED
@@ -1,11 +1,19 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2023-12-19 12:29:40 UTC using RuboCop version 1.57.2.
3
+ # on 2025-01-17 01:06:09 UTC using RuboCop version 1.67.0.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
+ # Offense count: 2
10
+ # This cop supports safe autocorrection (--autocorrect).
11
+ # Configuration parameters: Include.
12
+ # Include: **/*.gemspec
13
+ Gemspec/AddRuntimeDependency:
14
+ Exclude:
15
+ - 'beaker-puppet.gemspec'
16
+
9
17
  # Offense count: 1
10
18
  # This cop supports safe autocorrection (--autocorrect).
11
19
  # Configuration parameters: Severity, Include.
@@ -14,6 +22,103 @@ Gemspec/DeprecatedAttributeAssignment:
14
22
  Exclude:
15
23
  - 'beaker-puppet.gemspec'
16
24
 
25
+ # Offense count: 4
26
+ # This cop supports safe autocorrection (--autocorrect).
27
+ # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
28
+ # SupportedStyles: case, end
29
+ Layout/CaseIndentation:
30
+ Exclude:
31
+ - 'lib/beaker-puppet/inifile.rb'
32
+
33
+ # Offense count: 5
34
+ # This cop supports safe autocorrection (--autocorrect).
35
+ Layout/EmptyLineAfterGuardClause:
36
+ Exclude:
37
+ - 'lib/beaker-puppet/inifile.rb'
38
+
39
+ # Offense count: 2
40
+ # This cop supports safe autocorrection (--autocorrect).
41
+ # Configuration parameters: EnforcedStyle.
42
+ # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
43
+ Layout/EmptyLinesAroundClassBody:
44
+ Exclude:
45
+ - 'lib/beaker-puppet/inifile.rb'
46
+
47
+ # Offense count: 2
48
+ # This cop supports safe autocorrection (--autocorrect).
49
+ # Configuration parameters: EnforcedStyleAlignWith, Severity.
50
+ # SupportedStylesAlignWith: keyword, variable, start_of_line
51
+ Layout/EndAlignment:
52
+ Exclude:
53
+ - 'lib/beaker-puppet/inifile.rb'
54
+
55
+ # Offense count: 3
56
+ # This cop supports safe autocorrection (--autocorrect).
57
+ # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
58
+ Layout/ExtraSpacing:
59
+ Exclude:
60
+ - 'lib/beaker-puppet/inifile.rb'
61
+
62
+ # Offense count: 1
63
+ # This cop supports safe autocorrection (--autocorrect).
64
+ Layout/HeredocIndentation:
65
+ Exclude:
66
+ - 'setup/common/003_solaris_cert_fix.rb'
67
+
68
+ # Offense count: 2
69
+ # This cop supports safe autocorrection (--autocorrect).
70
+ # Configuration parameters: Width, AllowedPatterns.
71
+ Layout/IndentationWidth:
72
+ Exclude:
73
+ - 'lib/beaker-puppet/inifile.rb'
74
+
75
+ # Offense count: 1
76
+ # This cop supports safe autocorrection (--autocorrect).
77
+ # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment, AllowRBSInlineAnnotation.
78
+ Layout/LeadingCommentSpace:
79
+ Exclude:
80
+ - 'lib/beaker-puppet/inifile.rb'
81
+
82
+ # Offense count: 9
83
+ # This cop supports safe autocorrection (--autocorrect).
84
+ Layout/SpaceAfterComma:
85
+ Exclude:
86
+ - 'lib/beaker-puppet/inifile.rb'
87
+
88
+ # Offense count: 2
89
+ # This cop supports safe autocorrection (--autocorrect).
90
+ # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals.
91
+ # SupportedStylesForExponentOperator: space, no_space
92
+ # SupportedStylesForRationalLiterals: space, no_space
93
+ Layout/SpaceAroundOperators:
94
+ Exclude:
95
+ - 'lib/beaker-puppet/inifile.rb'
96
+
97
+ # Offense count: 14
98
+ # This cop supports safe autocorrection (--autocorrect).
99
+ # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
100
+ # SupportedStyles: space, no_space
101
+ # SupportedStylesForEmptyBraces: space, no_space
102
+ Layout/SpaceInsideBlockBraces:
103
+ Exclude:
104
+ - 'lib/beaker-puppet/inifile.rb'
105
+
106
+ # Offense count: 40
107
+ # This cop supports safe autocorrection (--autocorrect).
108
+ # Configuration parameters: EnforcedStyle.
109
+ # SupportedStyles: space, compact, no_space
110
+ Layout/SpaceInsideParens:
111
+ Exclude:
112
+ - 'lib/beaker-puppet/inifile.rb'
113
+
114
+ # Offense count: 1
115
+ # This cop supports safe autocorrection (--autocorrect).
116
+ # Configuration parameters: EnforcedStyle.
117
+ # SupportedStyles: final_newline, final_blank_line
118
+ Layout/TrailingEmptyLines:
119
+ Exclude:
120
+ - 'lib/beaker-puppet/inifile.rb'
121
+
17
122
  # Offense count: 2
18
123
  # This cop supports safe autocorrection (--autocorrect).
19
124
  # Configuration parameters: AllowedMethods, AllowedPatterns.
@@ -103,12 +208,6 @@ Lint/ShadowingOuterLocalVariable:
103
208
  Exclude:
104
209
  - 'lib/beaker-puppet/helpers/puppet_helpers.rb'
105
210
 
106
- # Offense count: 1
107
- # This cop supports safe autocorrection (--autocorrect).
108
- Lint/UnifiedInteger:
109
- Exclude:
110
- - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb'
111
-
112
211
  # Offense count: 1
113
212
  # Configuration parameters: AllowedPatterns.
114
213
  # AllowedPatterns: (?-mix:(exactly|at_least|at_most)\(\d+\)\.times)
@@ -118,7 +217,7 @@ Lint/UnreachableLoop:
118
217
 
119
218
  # Offense count: 19
120
219
  # This cop supports safe autocorrection (--autocorrect).
121
- # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
220
+ # Configuration parameters: AutoCorrect, IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
122
221
  Lint/UnusedBlockArgument:
123
222
  Exclude:
124
223
  - 'lib/beaker-puppet/helpers/puppet_helpers.rb'
@@ -133,14 +232,15 @@ Lint/UnusedBlockArgument:
133
232
 
134
233
  # Offense count: 3
135
234
  # This cop supports safe autocorrection (--autocorrect).
136
- # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
235
+ # Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
137
236
  Lint/UnusedMethodArgument:
138
237
  Exclude:
139
238
  - 'lib/beaker-puppet/helpers/puppet_helpers.rb'
140
239
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
141
240
 
142
- # Offense count: 17
143
- # This cop supports unsafe autocorrection (--autocorrect-all).
241
+ # Offense count: 13
242
+ # This cop supports safe autocorrection (--autocorrect).
243
+ # Configuration parameters: AutoCorrect.
144
244
  Lint/UselessAssignment:
145
245
  Exclude:
146
246
  - 'acceptance/tests/clone_git_repo_on_test.rb'
@@ -162,7 +262,7 @@ Naming/AccessorMethodName:
162
262
  Exclude:
163
263
  - 'Rakefile'
164
264
 
165
- # Offense count: 5
265
+ # Offense count: 6
166
266
  Naming/ConstantName:
167
267
  Exclude:
168
268
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
@@ -191,6 +291,17 @@ Naming/HeredocDelimiterNaming:
191
291
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
192
292
  - 'tasks/ci.rake'
193
293
 
294
+ # Offense count: 1
295
+ # Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
296
+ # NamePrefix: is_, has_, have_
297
+ # ForbiddenPrefixes: is_, has_, have_
298
+ # AllowedMethods: is_a?
299
+ # MethodDefinitionMacros: define_method, define_singleton_method
300
+ Naming/PredicateName:
301
+ Exclude:
302
+ - 'spec/**/*'
303
+ - 'lib/beaker-puppet/inifile.rb'
304
+
194
305
  # Offense count: 7
195
306
  # This cop supports safe autocorrection (--autocorrect).
196
307
  # Configuration parameters: PreferredName.
@@ -209,12 +320,6 @@ Naming/VariableNumber:
209
320
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
210
321
  - 'setup/git/000_EnvSetup.rb'
211
322
 
212
- # Offense count: 1
213
- # This cop supports safe autocorrection (--autocorrect).
214
- Performance/BlockGivenWithExplicitBlock:
215
- Exclude:
216
- - 'lib/beaker-puppet/helpers/puppet_helpers.rb'
217
-
218
323
  # Offense count: 1
219
324
  # Configuration parameters: MinSize.
220
325
  Performance/CollectionLiteralInLoop:
@@ -241,7 +346,7 @@ Performance/RedundantMerge:
241
346
  Exclude:
242
347
  - 'lib/beaker-puppet/helpers/facter_helpers.rb'
243
348
 
244
- # Offense count: 43
349
+ # Offense count: 41
245
350
  # This cop supports safe autocorrection (--autocorrect).
246
351
  Performance/RegexpMatch:
247
352
  Exclude:
@@ -258,7 +363,20 @@ Performance/RegexpMatch:
258
363
  - 'setup/gem/010_GemInstall.rb'
259
364
  - 'setup/git/000_EnvSetup.rb'
260
365
 
261
- # Offense count: 30
366
+ # Offense count: 1
367
+ # This cop supports unsafe autocorrection (--autocorrect-all).
368
+ # Configuration parameters: SafeMultiline.
369
+ Performance/StartWith:
370
+ Exclude:
371
+ - 'lib/beaker-puppet/inifile.rb'
372
+
373
+ # Offense count: 1
374
+ # This cop supports safe autocorrection (--autocorrect).
375
+ Performance/StringIdentifierArgument:
376
+ Exclude:
377
+ - 'spec/beaker-puppet/wrappers_spec.rb'
378
+
379
+ # Offense count: 28
262
380
  # This cop supports unsafe autocorrection (--autocorrect-all).
263
381
  Performance/StringInclude:
264
382
  Exclude:
@@ -299,7 +417,7 @@ RSpec/ContextMethod:
299
417
  Exclude:
300
418
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
301
419
 
302
- # Offense count: 52
420
+ # Offense count: 41
303
421
  # Configuration parameters: Prefixes, AllowedPatterns.
304
422
  # Prefixes: when, with, without
305
423
  RSpec/ContextWording:
@@ -311,7 +429,7 @@ RSpec/ContextWording:
311
429
  - 'spec/beaker-puppet/install_utils/puppet_utils_spec.rb'
312
430
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
313
431
 
314
- # Offense count: 24
432
+ # Offense count: 22
315
433
  # This cop supports safe autocorrection (--autocorrect).
316
434
  # Configuration parameters: AllowConsecutiveOneLiners.
317
435
  RSpec/EmptyLineAfterExample:
@@ -327,7 +445,7 @@ RSpec/EmptyLineAfterExampleGroup:
327
445
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
328
446
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
329
447
 
330
- # Offense count: 19
448
+ # Offense count: 16
331
449
  # This cop supports safe autocorrection (--autocorrect).
332
450
  RSpec/EmptyLineAfterFinalLet:
333
451
  Exclude:
@@ -336,12 +454,11 @@ RSpec/EmptyLineAfterFinalLet:
336
454
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
337
455
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
338
456
 
339
- # Offense count: 4
457
+ # Offense count: 3
340
458
  # This cop supports safe autocorrection (--autocorrect).
341
459
  # Configuration parameters: AllowConsecutiveOneLiners.
342
460
  RSpec/EmptyLineAfterHook:
343
461
  Exclude:
344
- - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
345
462
  - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb'
346
463
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
347
464
 
@@ -351,12 +468,12 @@ RSpec/Eq:
351
468
  Exclude:
352
469
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
353
470
 
354
- # Offense count: 138
471
+ # Offense count: 113
355
472
  # Configuration parameters: CountAsOne.
356
473
  RSpec/ExampleLength:
357
- Max: 34
474
+ Max: 30
358
475
 
359
- # Offense count: 24
476
+ # Offense count: 34
360
477
  # This cop supports safe autocorrection (--autocorrect).
361
478
  # Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
362
479
  # DisallowedExamples: works
@@ -365,32 +482,16 @@ RSpec/ExampleWording:
365
482
  - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb'
366
483
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
367
484
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
485
+ - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
368
486
  - 'spec/beaker-puppet/wrappers_spec.rb'
369
487
 
370
- # Offense count: 8
488
+ # Offense count: 4
371
489
  RSpec/ExpectInHook:
372
490
  Exclude:
373
491
  - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
374
492
  - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb'
375
493
 
376
- # Offense count: 11
377
- # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
378
- # Include: **/*_spec*rb*, **/spec/**/*
379
- RSpec/FilePath:
380
- Exclude:
381
- - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb'
382
- - 'spec/beaker-puppet/helpers/host_helpers_spec.rb'
383
- - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
384
- - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb'
385
- - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb'
386
- - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
387
- - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
388
- - 'spec/beaker-puppet/install_utils/puppet5_spec.rb'
389
- - 'spec/beaker-puppet/install_utils/puppet_utils_spec.rb'
390
- - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
391
- - 'spec/beaker-puppet/wrappers_spec.rb'
392
-
393
- # Offense count: 26
494
+ # Offense count: 22
394
495
  # This cop supports safe autocorrection (--autocorrect).
395
496
  # Configuration parameters: EnforcedStyle.
396
497
  # SupportedStyles: implicit, each, example
@@ -408,7 +509,7 @@ RSpec/IndexedLet:
408
509
  Exclude:
409
510
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
410
511
 
411
- # Offense count: 14
512
+ # Offense count: 12
412
513
  # Configuration parameters: AssignmentOnly.
413
514
  RSpec/InstanceVariable:
414
515
  Exclude:
@@ -428,13 +529,7 @@ RSpec/IteratedExpectation:
428
529
  Exclude:
429
530
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
430
531
 
431
- # Offense count: 1
432
- # This cop supports safe autocorrection (--autocorrect).
433
- RSpec/LetBeforeExamples:
434
- Exclude:
435
- - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
436
-
437
- # Offense count: 508
532
+ # Offense count: 412
438
533
  # Configuration parameters: EnforcedStyle.
439
534
  # SupportedStyles: have_received, receive
440
535
  RSpec/MessageSpies:
@@ -450,16 +545,16 @@ RSpec/MessageSpies:
450
545
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
451
546
  - 'spec/beaker-puppet/wrappers_spec.rb'
452
547
 
453
- # Offense count: 183
548
+ # Offense count: 147
454
549
  RSpec/MultipleExpectations:
455
- Max: 12
550
+ Max: 8
456
551
 
457
- # Offense count: 150
552
+ # Offense count: 134
458
553
  # Configuration parameters: AllowSubject.
459
554
  RSpec/MultipleMemoizedHelpers:
460
555
  Max: 25
461
556
 
462
- # Offense count: 940
557
+ # Offense count: 800
463
558
  # Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
464
559
  # SupportedStyles: always, named_only
465
560
  RSpec/NamedSubject:
@@ -476,23 +571,21 @@ RSpec/NamedSubject:
476
571
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
477
572
  - 'spec/beaker-puppet/wrappers_spec.rb'
478
573
 
479
- # Offense count: 31
574
+ # Offense count: 21
480
575
  # Configuration parameters: AllowedGroups.
481
576
  RSpec/NestedGroups:
482
577
  Max: 5
483
578
 
484
- # Offense count: 8
579
+ # Offense count: 4
485
580
  # Configuration parameters: AllowedPatterns.
486
581
  # AllowedPatterns: ^expect_, ^assert_
487
582
  RSpec/NoExpectationExample:
488
583
  Exclude:
489
- - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
490
584
  - 'spec/beaker-puppet/helpers/tk_helpers_spec.rb'
491
585
  - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb'
492
- - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
493
586
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
494
587
 
495
- # Offense count: 10
588
+ # Offense count: 8
496
589
  # This cop supports safe autocorrection (--autocorrect).
497
590
  # Configuration parameters: EnforcedStyle.
498
591
  # SupportedStyles: not_to, to_not
@@ -502,14 +595,14 @@ RSpec/NotToNot:
502
595
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
503
596
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
504
597
 
505
- # Offense count: 24
598
+ # Offense count: 16
506
599
  # This cop supports safe autocorrection (--autocorrect).
507
600
  RSpec/ReceiveCounts:
508
601
  Exclude:
509
602
  - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
510
603
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
511
604
 
512
- # Offense count: 66
605
+ # Offense count: 64
513
606
  # This cop supports unsafe autocorrection (--autocorrect-all).
514
607
  RSpec/ReceiveMessages:
515
608
  Exclude:
@@ -534,7 +627,7 @@ RSpec/RepeatedDescription:
534
627
  - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
535
628
  - 'spec/beaker-puppet/install_utils/puppet5_spec.rb'
536
629
 
537
- # Offense count: 33
630
+ # Offense count: 25
538
631
  # This cop supports safe autocorrection (--autocorrect).
539
632
  # Configuration parameters: EnforcedStyle.
540
633
  # SupportedStyles: and_return, block
@@ -562,7 +655,7 @@ RSpec/SpecFilePathFormat:
562
655
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
563
656
  - 'spec/beaker-puppet/wrappers_spec.rb'
564
657
 
565
- # Offense count: 106
658
+ # Offense count: 88
566
659
  RSpec/StubbedMock:
567
660
  Exclude:
568
661
  - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb'
@@ -574,7 +667,7 @@ RSpec/StubbedMock:
574
667
  - 'spec/beaker-puppet/install_utils/puppet_utils_spec.rb'
575
668
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
576
669
 
577
- # Offense count: 593
670
+ # Offense count: 501
578
671
  RSpec/SubjectStub:
579
672
  Exclude:
580
673
  - 'spec/beaker-puppet/helpers/facter_helpers_spec.rb'
@@ -596,11 +689,10 @@ RSpec/VerifiedDoubleReference:
596
689
  Exclude:
597
690
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
598
691
 
599
- # Offense count: 9
692
+ # Offense count: 5
600
693
  # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
601
694
  RSpec/VerifiedDoubles:
602
695
  Exclude:
603
- - 'spec/beaker-puppet/helpers/puppet_helpers_spec.rb'
604
696
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
605
697
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
606
698
  - 'spec/helpers.rb'
@@ -648,7 +740,23 @@ Security/YAMLLoad:
648
740
  Exclude:
649
741
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
650
742
 
651
- # Offense count: 6
743
+ # Offense count: 2
744
+ # This cop supports safe autocorrection (--autocorrect).
745
+ # Configuration parameters: EnforcedStyle.
746
+ # SupportedStyles: separated, grouped
747
+ Style/AccessorGrouping:
748
+ Exclude:
749
+ - 'lib/beaker-puppet/inifile.rb'
750
+
751
+ # Offense count: 3
752
+ # This cop supports safe autocorrection (--autocorrect).
753
+ # Configuration parameters: EnforcedStyle.
754
+ # SupportedStyles: prefer_alias, prefer_alias_method
755
+ Style/Alias:
756
+ Exclude:
757
+ - 'lib/beaker-puppet/inifile.rb'
758
+
759
+ # Offense count: 5
652
760
  # This cop supports unsafe autocorrection (--autocorrect-all).
653
761
  # Configuration parameters: EnforcedStyle.
654
762
  # SupportedStyles: always, conditionals
@@ -657,6 +765,17 @@ Style/AndOr:
657
765
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
658
766
  - 'lib/beaker-puppet/install_utils/puppet_utils.rb'
659
767
 
768
+ # Offense count: 1
769
+ # This cop supports safe autocorrection (--autocorrect).
770
+ # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
771
+ # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
772
+ # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
773
+ # FunctionalMethods: let, let!, subject, watch
774
+ # AllowedMethods: lambda, proc, it
775
+ Style/BlockDelimiters:
776
+ Exclude:
777
+ - 'lib/beaker-puppet/inifile.rb'
778
+
660
779
  # Offense count: 10
661
780
  # This cop supports safe autocorrection (--autocorrect).
662
781
  # Configuration parameters: AllowOnConstant, AllowOnSelfClass.
@@ -667,20 +786,20 @@ Style/CaseEquality:
667
786
  - 'spec/beaker-puppet/install_utils/puppet5_spec.rb'
668
787
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
669
788
 
670
- # Offense count: 3
789
+ # Offense count: 1
671
790
  # This cop supports unsafe autocorrection (--autocorrect-all).
672
791
  # Configuration parameters: MinBranchesCount.
673
792
  Style/CaseLikeIf:
674
793
  Exclude:
675
794
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
676
- - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
677
795
 
678
- # Offense count: 1
796
+ # Offense count: 2
679
797
  # This cop supports unsafe autocorrection (--autocorrect-all).
680
798
  # Configuration parameters: EnforcedStyle.
681
799
  # SupportedStyles: nested, compact
682
800
  Style/ClassAndModuleChildren:
683
801
  Exclude:
802
+ - 'lib/beaker-puppet/inifile.rb'
684
803
  - 'spec/beaker-puppet/install_utils/ezbake_utils_spec.rb'
685
804
 
686
805
  # Offense count: 1
@@ -696,6 +815,12 @@ Style/CombinableLoops:
696
815
  Exclude:
697
816
  - 'spec/beaker-puppet/install_utils/windows_utils_spec.rb'
698
817
 
818
+ # Offense count: 1
819
+ # This cop supports unsafe autocorrection (--autocorrect-all).
820
+ Style/CommentedKeyword:
821
+ Exclude:
822
+ - 'lib/beaker-puppet/inifile.rb'
823
+
699
824
  # Offense count: 3
700
825
  # Configuration parameters: AllowedConstants.
701
826
  Style/Documentation:
@@ -706,12 +831,30 @@ Style/Documentation:
706
831
  - 'lib/beaker-puppet/install_utils/puppet5.rb'
707
832
  - 'lib/beaker-puppet/wrappers.rb'
708
833
 
834
+ # Offense count: 2
835
+ # This cop supports safe autocorrection (--autocorrect).
836
+ Style/EmptyLiteral:
837
+ Exclude:
838
+ - 'lib/beaker-puppet/inifile.rb'
839
+
840
+ # Offense count: 1
841
+ # This cop supports safe autocorrection (--autocorrect).
842
+ Style/Encoding:
843
+ Exclude:
844
+ - 'lib/beaker-puppet/inifile.rb'
845
+
709
846
  # Offense count: 1
710
847
  # This cop supports unsafe autocorrection (--autocorrect-all).
711
848
  Style/EnvHome:
712
849
  Exclude:
713
850
  - 'acceptance/config/acceptance-options.rb'
714
851
 
852
+ # Offense count: 1
853
+ # This cop supports safe autocorrection (--autocorrect).
854
+ Style/ExplicitBlockArgument:
855
+ Exclude:
856
+ - 'lib/beaker-puppet/inifile.rb'
857
+
715
858
  # Offense count: 20
716
859
  # This cop supports safe autocorrection (--autocorrect).
717
860
  # Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns.
@@ -719,19 +862,29 @@ Style/EnvHome:
719
862
  Style/FormatStringToken:
720
863
  EnforcedStyle: unannotated
721
864
 
722
- # Offense count: 74
865
+ # Offense count: 75
723
866
  # This cop supports unsafe autocorrection (--autocorrect-all).
724
867
  # Configuration parameters: EnforcedStyle.
725
868
  # SupportedStyles: always, always_true, never
726
869
  Style/FrozenStringLiteralComment:
727
870
  Enabled: false
728
871
 
729
- # Offense count: 1
872
+ # Offense count: 2
730
873
  # Configuration parameters: MinBranchesCount.
731
874
  Style/HashLikeCase:
732
875
  Exclude:
876
+ - 'lib/beaker-puppet/inifile.rb'
733
877
  - 'lib/beaker-puppet/install_utils/windows_utils.rb'
734
878
 
879
+ # Offense count: 1
880
+ # This cop supports safe autocorrection (--autocorrect).
881
+ # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
882
+ # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
883
+ # SupportedShorthandSyntax: always, never, either, consistent, either_consistent
884
+ Style/HashSyntax:
885
+ Exclude:
886
+ - 'lib/beaker-puppet/inifile.rb'
887
+
735
888
  # Offense count: 4
736
889
  # This cop supports unsafe autocorrection (--autocorrect-all).
737
890
  Style/IdenticalConditionalBranches:
@@ -739,7 +892,7 @@ Style/IdenticalConditionalBranches:
739
892
  - 'lib/beaker-puppet/helpers/tk_helpers.rb'
740
893
  - 'lib/beaker-puppet/install_utils/ezbake_utils.rb'
741
894
 
742
- # Offense count: 13
895
+ # Offense count: 12
743
896
  # This cop supports safe autocorrection (--autocorrect).
744
897
  Style/IfUnlessModifier:
745
898
  Exclude:
@@ -756,6 +909,12 @@ Style/LineEndConcatenation:
756
909
  - 'lib/beaker-puppet/helpers/puppet_helpers.rb'
757
910
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
758
911
 
912
+ # Offense count: 1
913
+ # This cop supports unsafe autocorrection (--autocorrect-all).
914
+ Style/MapIntoArray:
915
+ Exclude:
916
+ - 'acceptance/pre_suite/git/install.rb'
917
+
759
918
  # Offense count: 1
760
919
  # This cop supports unsafe autocorrection (--autocorrect-all).
761
920
  Style/MapToHash:
@@ -767,7 +926,7 @@ Style/MixinUsage:
767
926
  Exclude:
768
927
  - 'tasks/ci.rake'
769
928
 
770
- # Offense count: 37
929
+ # Offense count: 39
771
930
  # This cop supports unsafe autocorrection (--autocorrect-all).
772
931
  # Configuration parameters: EnforcedStyle.
773
932
  # SupportedStyles: literals, strict
@@ -807,13 +966,27 @@ Style/OptionalBooleanParameter:
807
966
  - 'Rakefile'
808
967
  - 'lib/beaker-puppet/helpers/tk_helpers.rb'
809
968
 
810
- # Offense count: 8
969
+ # Offense count: 19
970
+ # This cop supports safe autocorrection (--autocorrect).
971
+ # Configuration parameters: PreferredDelimiters.
972
+ Style/PercentLiteralDelimiters:
973
+ Exclude:
974
+ - 'lib/beaker-puppet/inifile.rb'
975
+
976
+ # Offense count: 11
977
+ # This cop supports safe autocorrection (--autocorrect).
978
+ Style/PerlBackrefs:
979
+ Exclude:
980
+ - 'lib/beaker-puppet/inifile.rb'
981
+
982
+ # Offense count: 9
811
983
  # This cop supports unsafe autocorrection (--autocorrect-all).
812
984
  # Configuration parameters: EnforcedStyle.
813
985
  # SupportedStyles: short, verbose
814
986
  Style/PreferredHashMethods:
815
987
  Exclude:
816
988
  - 'lib/beaker-puppet/helpers/puppet_helpers.rb'
989
+ - 'lib/beaker-puppet/inifile.rb'
817
990
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
818
991
  - 'lib/beaker-puppet/install_utils/module_utils.rb'
819
992
  - 'spec/helpers.rb'
@@ -826,7 +999,7 @@ Style/RedundantArgument:
826
999
  - 'Rakefile'
827
1000
  - 'tasks/ci.rake'
828
1001
 
829
- # Offense count: 17
1002
+ # Offense count: 9
830
1003
  # This cop supports unsafe autocorrection (--autocorrect-all).
831
1004
  Style/RedundantInterpolation:
832
1005
  Exclude:
@@ -838,6 +1011,44 @@ Style/RedundantInterpolation:
838
1011
  - 'spec/beaker-puppet/install_utils/foss_utils_spec.rb'
839
1012
  - 'tasks/ci.rake'
840
1013
 
1014
+ # Offense count: 2
1015
+ # This cop supports safe autocorrection (--autocorrect).
1016
+ Style/RedundantLineContinuation:
1017
+ Exclude:
1018
+ - 'lib/beaker-puppet/inifile.rb'
1019
+
1020
+ # Offense count: 1
1021
+ # This cop supports safe autocorrection (--autocorrect).
1022
+ Style/RedundantParentheses:
1023
+ Exclude:
1024
+ - 'setup/git/000_EnvSetup.rb'
1025
+
1026
+ # Offense count: 3
1027
+ # This cop supports safe autocorrection (--autocorrect).
1028
+ Style/RedundantRegexpArgument:
1029
+ Exclude:
1030
+ - 'lib/beaker-puppet/inifile.rb'
1031
+
1032
+ # Offense count: 7
1033
+ # This cop supports safe autocorrection (--autocorrect).
1034
+ Style/RedundantSelf:
1035
+ Exclude:
1036
+ - 'lib/beaker-puppet/inifile.rb'
1037
+
1038
+ # Offense count: 19
1039
+ # This cop supports safe autocorrection (--autocorrect).
1040
+ # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
1041
+ # SupportedStyles: slashes, percent_r, mixed
1042
+ Style/RegexpLiteral:
1043
+ Exclude:
1044
+ - 'lib/beaker-puppet/inifile.rb'
1045
+
1046
+ # Offense count: 1
1047
+ # This cop supports safe autocorrection (--autocorrect).
1048
+ Style/RescueModifier:
1049
+ Exclude:
1050
+ - 'lib/beaker-puppet/inifile.rb'
1051
+
841
1052
  # Offense count: 2
842
1053
  # This cop supports unsafe autocorrection (--autocorrect-all).
843
1054
  # Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
@@ -846,12 +1057,13 @@ Style/SafeNavigation:
846
1057
  Exclude:
847
1058
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
848
1059
 
849
- # Offense count: 3
1060
+ # Offense count: 4
850
1061
  # This cop supports unsafe autocorrection (--autocorrect-all).
851
1062
  # Configuration parameters: RequireEnglish, EnforcedStyle.
852
1063
  # SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names
853
1064
  Style/SpecialGlobalVars:
854
1065
  Exclude:
1066
+ - 'lib/beaker-puppet/inifile.rb'
855
1067
  - 'lib/beaker-puppet/install_utils/puppet5.rb'
856
1068
 
857
1069
  # Offense count: 15
@@ -864,6 +1076,28 @@ Style/StringConcatenation:
864
1076
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
865
1077
  - 'spec/beaker-puppet/install_utils/module_utils_spec.rb'
866
1078
 
1079
+ # Offense count: 6
1080
+ # This cop supports safe autocorrection (--autocorrect).
1081
+ # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
1082
+ # SupportedStyles: single_quotes, double_quotes
1083
+ Style/StringLiterals:
1084
+ Exclude:
1085
+ - 'lib/beaker-puppet/inifile.rb'
1086
+
1087
+ # Offense count: 1
1088
+ # This cop supports unsafe autocorrection (--autocorrect-all).
1089
+ # Configuration parameters: AllowMethodsWithArguments, AllowedMethods, AllowedPatterns, AllowComments.
1090
+ # AllowedMethods: define_method
1091
+ Style/SymbolProc:
1092
+ Exclude:
1093
+ - 'lib/beaker-puppet/inifile.rb'
1094
+
1095
+ # Offense count: 8
1096
+ # This cop supports safe autocorrection (--autocorrect).
1097
+ Style/WhenThen:
1098
+ Exclude:
1099
+ - 'lib/beaker-puppet/inifile.rb'
1100
+
867
1101
  # Offense count: 1
868
1102
  # This cop supports unsafe autocorrection (--autocorrect-all).
869
1103
  # Configuration parameters: EnforcedStyle.
@@ -879,7 +1113,7 @@ Style/ZeroLengthPredicate:
879
1113
  - 'lib/beaker-puppet/helpers/puppet_helpers.rb'
880
1114
  - 'lib/beaker-puppet/install_utils/foss_utils.rb'
881
1115
 
882
- # Offense count: 122
1116
+ # Offense count: 108
883
1117
  # This cop supports safe autocorrection (--autocorrect).
884
1118
  # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
885
1119
  # URISchemes: http, https