beaker-puppet 2.1.0 → 3.0.0

data/spec/beaker-puppet/install_utils/foss_utils_spec.rb

@@ -202,9 +202,9 @@ describe ClassMixedWithDSLInstallUtils do
   context 'lookup_in_env' do
     it 'returns a default properly' do
       env_var = subject.lookup_in_env('noway', 'nonesuch', 'returnme')
-      expect(env_var).to be == 'returnme'
+      expect(env_var).to eq 'returnme'
       env_var = subject.lookup_in_env('noway', nil, 'returnme')
-      expect(env_var).to be == 'returnme'
+      expect(env_var).to eq 'returnme'
     end
     it 'finds correct env variable' do
       allow(ENV).to receive(:[]).with(nil).and_return(nil)
@@ -212,13 +212,13 @@ describe ClassMixedWithDSLInstallUtils do
       allow(ENV).to receive(:[]).with('NONESUCH').and_return('present')
       allow(ENV).to receive(:[]).with('NOWAY_PROJ_NONESUCH').and_return('exists')
       env_var = subject.lookup_in_env('nonesuch', 'noway-proj', 'fail')
-      expect(env_var).to be == 'exists'
+      expect(env_var).to eq 'exists'
       env_var = subject.lookup_in_env('nonesuch')
-      expect(env_var).to be == 'present'
+      expect(env_var).to eq 'present'
       env_var = subject.lookup_in_env('reallynone')
-      expect(env_var).to be == nil # rubocop:disable Style/NilComparison
+      expect(env_var).to eq nil # rubocop:disable Style/NilComparison
       env_var = subject.lookup_in_env('reallynone', nil, 'default')
-      expect(env_var).to be == 'default'
+      expect(env_var).to eq 'default'
     end
   end
 
@@ -229,21 +229,21 @@ describe ClassMixedWithDSLInstallUtils do
       allow(ENV).to receive(:[]).with('PUPPET_FORK').and_return(nil)
       allow(ENV).to receive(:[]).with('PUPPET_SERVER').and_return(nil)
       url = subject.build_giturl('puppet')
-      expect(url).to be == 'https://github.com/puppetlabs/puppet.git'
+      expect(url).to eq 'https://github.com/puppetlabs/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck')
-      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      expect(url).to eq 'https://github.com/er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'bitbucket.com')
-      expect(url).to be == 'https://bitbucket.com/er0ck-puppet.git'
+      expect(url).to eq 'https://bitbucket.com/er0ck-puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https://')
-      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      expect(url).to eq 'https://github.com/er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https')
-      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      expect(url).to eq 'https://github.com/er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git@')
-      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      expect(url).to eq 'git@github.com:er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git')
-      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      expect(url).to eq 'git@github.com:er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'ssh')
-      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      expect(url).to eq 'git@github.com:er0ck/puppet.git'
     end
 
     it 'uses ENV to build urls properly' do
@@ -252,21 +252,21 @@ describe ClassMixedWithDSLInstallUtils do
       allow(ENV).to receive(:[]).with('PUPPET_FORK').and_return('er0ck/repo')
       allow(ENV).to receive(:[]).with('PUPPET_SERVER').and_return('gitlab.com')
       url = subject.build_giturl('puppet')
-      expect(url).to be == 'https://gitlab.com/er0ck/repo-puppet.git'
+      expect(url).to eq 'https://gitlab.com/er0ck/repo-puppet.git'
       url = subject.build_giturl('puppet', 'er0ck')
-      expect(url).to be == 'https://gitlab.com/er0ck-puppet.git'
+      expect(url).to eq 'https://gitlab.com/er0ck-puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'bitbucket.com')
-      expect(url).to be == 'https://bitbucket.com/er0ck-puppet.git'
+      expect(url).to eq 'https://bitbucket.com/er0ck-puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https://')
-      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      expect(url).to eq 'https://github.com/er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'https')
-      expect(url).to be == 'https://github.com/er0ck/puppet.git'
+      expect(url).to eq 'https://github.com/er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git@')
-      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      expect(url).to eq 'git@github.com:er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'git')
-      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      expect(url).to eq 'git@github.com:er0ck/puppet.git'
       url = subject.build_giturl('puppet', 'er0ck', 'github.com', 'ssh')
-      expect(url).to be == 'git@github.com:er0ck/puppet.git'
+      expect(url).to eq 'git@github.com:er0ck/puppet.git'
     end
   end
 
@@ -278,9 +278,9 @@ describe ClassMixedWithDSLInstallUtils do
       it "handles #{type[:protocol]} uris" do
         uri = "#{type[:path]}#master"
         repo_info = subject.extract_repo_info_from uri
-        expect(repo_info[:name]).to be == 'project'
-        expect(repo_info[:path]).to be == type[:path]
-        expect(repo_info[:rev]).to  be == 'master'
+        expect(repo_info[:name]).to eq 'project'
+        expect(repo_info[:path]).to eq type[:path]
+        expect(repo_info[:rev]).to  eq 'master'
       end
     end
   end
@@ -291,9 +291,9 @@ describe ClassMixedWithDSLInstallUtils do
         { name: 'puppet_plugin' }, { name: 'puppet' }, { name: 'facter' },
       ]
       ordered_repos = subject.order_packages named_repos
-      expect(ordered_repos[0][:name]).to be == 'facter'
-      expect(ordered_repos[1][:name]).to be == 'puppet'
-      expect(ordered_repos[2][:name]).to be == 'puppet_plugin'
+      expect(ordered_repos[0][:name]).to eq 'facter'
+      expect(ordered_repos[1][:name]).to eq 'puppet'
+      expect(ordered_repos[2][:name]).to eq 'puppet_plugin'
     end
   end
 
@@ -313,7 +313,7 @@ describe ClassMixedWithDSLInstallUtils do
       subject.instance_variable_set(:@metadata, {})
       version = subject.find_git_repo_versions(host, path, repository)
 
-      expect(version).to be == { 'name' => '2' }
+      expect(version).to be == { 'name' => '2' } # rubocop:ignore RSpec/Eq
     end
   end
 
@@ -1005,7 +1005,7 @@ describe ClassMixedWithDSLInstallUtils do
       expect(subject).to receive(:install_a_puppet_msi_on).with(host, opts)
 
       subject.install_puppet_agent_from_msi_on(host, opts)
-      expect(host['dist']).to be == 'puppet-agent-VERSION-x86'
+      expect(host['dist']).to eq 'puppet-agent-VERSION-x86'
     end
 
     it 'uses x86 msi when host is_x86_64 and install_32 is set on the options' do
@@ -1015,7 +1015,7 @@ describe ClassMixedWithDSLInstallUtils do
       expect(subject).to receive(:install_a_puppet_msi_on).with(host, opts)
 
       subject.install_puppet_agent_from_msi_on(host, opts)
-      expect(host['dist']).to be == 'puppet-agent-VERSION-x86'
+      expect(host['dist']).to eq 'puppet-agent-VERSION-x86'
     end
 
     it 'uses x86 msi when host is_x86_64 and ruby_arch is x86 on the host' do
@@ -1025,7 +1025,7 @@ describe ClassMixedWithDSLInstallUtils do
       expect(subject).to receive(:install_a_puppet_msi_on).with(host, opts)
 
       subject.install_puppet_agent_from_msi_on(host, opts)
-      expect(host['dist']).to be == 'puppet-agent-VERSION-x86'
+      expect(host['dist']).to eq 'puppet-agent-VERSION-x86'
     end
 
     it 'uses x86 msi when host !is_x86_64' do
@@ -1033,7 +1033,7 @@ describe ClassMixedWithDSLInstallUtils do
       expect(subject).to receive(:install_a_puppet_msi_on).with(host, opts)
 
       subject.install_puppet_agent_from_msi_on(host, opts)
-      expect(host['dist']).to be == 'puppet-agent-VERSION-x86'
+      expect(host['dist']).to eq 'puppet-agent-VERSION-x86'
     end
 
     it 'uses x64 msi when host is_x86_64, no install_32 and ruby_arch != x86' do
@@ -1041,7 +1041,7 @@ describe ClassMixedWithDSLInstallUtils do
       expect(subject).to receive(:install_a_puppet_msi_on).with(host, opts)
 
       subject.install_puppet_agent_from_msi_on(host, opts)
-      expect(host['dist']).to be == 'puppet-agent-VERSION-x64'
+      expect(host['dist']).to eq 'puppet-agent-VERSION-x64'
     end
   end
 
@@ -1092,435 +1092,6 @@ describe ClassMixedWithDSLInstallUtils do
     end
   end
 
-  describe '#install_puppet_agent_dev_repo_on' do
-    let(:package_name) { 'puppet-agent' }
-    let(:platform) { @platform || 'other' }
-    let(:host) do
-      FakeHost.create('fakvm', platform, opts)
-    end
-
-    before :each do
-      allow(subject).to receive(:configure_foss_defaults_on).and_return(true)
-    end
-
-    it 'raises an exception when host platform is unsupported' do
-      host = basic_hosts.first
-      host['platform'] = Beaker::Platform.new('f5-5-x4')
-      opts = { version: '0.1.0' }
-      allow(subject).to receive(:options).and_return({})
-
-      expect do
-        subject.install_puppet_agent_dev_repo_on(host, opts)
-      end.to raise_error(RuntimeError, /No repository installation step for/)
-    end
-
-    it 'runs the correct install for el-based platforms' do
-      host = basic_hosts.first
-      host['platform'] = Beaker::Platform.new('el-5-x86_64')
-      sha_value = 'ereiuwoiur'
-      opts = { version: '0.1.0', puppet_agent_sha: sha_value }
-      allow(subject).to receive(:options).and_return({})
-
-      expect(subject).to receive(:install_puppetlabs_dev_repo).with(
-        host, 'puppet-agent', sha_value, nil, anything
-      )
-      expect(host).to receive(:install_package).with('puppet-agent')
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'runs the correct install for el-based platforms on s390x architectures' do
-      host = basic_hosts.first
-      host['platform'] = Beaker::Platform.new('el-5-s390x')
-      sha_value = 'ereiuwoiur'
-      opts = { version: '0.1.0', puppet_agent_sha: sha_value }
-      allow(subject).to receive(:options).and_return({})
-
-      release_path_end = 'fake_release_path_end'
-      release_file = 'fake_29835_release_file'
-      expect(host).to receive(:puppet_agent_dev_package_info).and_return(
-        [release_path_end, release_file],
-      )
-
-      expect(subject).not_to receive(:install_puppetlabs_dev_repo)
-      expect(host).not_to receive(:install_package)
-
-      expect(subject).to receive(:fetch_http_file).once.with(/#{release_path_end}$/, release_file, %r{/el$})
-      expect(subject).to receive(:scp_to).once.with(host, /#{release_file}$/, anything)
-      expect(subject).to receive(:on).ordered.with(host, /rpm -ivh.*#{release_file}$/)
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'runs the correct agent install for el-based platforms on ec2 hypervisor' do
-      host = basic_hosts.first
-      host['platform'] = Beaker::Platform.new('el-5-x86_64')
-      host['hypervisor'] = 'ec2'
-      sha_value = 'ereiuwoiur'
-      opts = { version: '0.1.0', puppet_agent_sha: sha_value }
-      allow(subject).to receive(:options).and_return({})
-
-      release_path_end = 'fake_release_path_end'
-      release_file = 'fake_29835_release_file'
-      expect(host).to receive(:puppet_agent_dev_package_info).and_return(
-        [release_path_end, release_file],
-      )
-
-      expect(subject).not_to receive(:install_puppetlabs_dev_repo)
-      expect(host).not_to receive(:install_package)
-
-      expect(subject).to receive(:fetch_http_file).once.with(/#{release_path_end}$/, release_file, %r{/el$})
-      expect(subject).to receive(:scp_to).once.with(host, /#{release_file}$/, anything)
-      expect(subject).to receive(:on).ordered.with(host, /rpm -ivh.*#{release_file}$/)
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'runs the correct install for debian-based platforms' do
-      platform = Beaker::Platform.new('debian-5-x86_64')
-      host = basic_hosts.first
-      host['platform'] = platform
-      sha_value = 'ereigregerge'
-      opts = { version: '0.1.0', puppet_agent_sha: sha_value }
-      allow(subject).to receive(:options).and_return({})
-
-      expect(subject).to receive(:install_puppetlabs_dev_repo).with(
-        host, 'puppet-agent', sha_value, nil, anything
-      )
-      expect(host).to receive(:install_package).with('puppet-agent')
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'runs the correct install for windows platforms' do
-      host = winhost
-      external_copy_base = 'tmp_install_windows_copy_base_1325'
-      allow(host).to receive(:external_copy_base).and_return(external_copy_base)
-      opts = { version: '0.1.0' }
-      allow(subject).to receive(:options).and_return({})
-      copied_path = "#{win_temp}\\puppet-agent-0.1.0-x64.msi"
-      mock_echo = Object.new
-      allow(mock_echo).to receive(:raw_output).and_return(copied_path)
-
-      expect(subject).to receive(:fetch_http_file).once.with(%r{/windows$}, 'puppet-agent-0.1.0-x64.msi', %r{/windows$})
-      expect(subject).to receive(:scp_to).once.with(host, %r{/puppet-agent-0.1.0-x64.msi$}, /#{external_copy_base}/)
-      expect(subject).to receive(:install_msi_on).with(host, copied_path, {}, { debug: nil }).once
-      expect(subject).to receive(:on).ordered.with(host, /echo/).and_return(mock_echo)
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'runs the correct install for osx platforms' do
-      host = machost
-      host['platform'] = Beaker::Platform.new('osx-109-x86_64')
-      sha_value = 'runs the correct install for osx platforms'
-      copy_dir_external = 'fake_15_copy_dir_external'
-      opts = {
-        version: '0.1.0',
-        puppet_agent_sha: sha_value,
-        copy_dir_external: copy_dir_external,
-      }
-
-      release_path_end = 'fake_release_path_end'
-      release_file = 'fake_29835_release_file'
-      expect(host).to receive(:puppet_agent_dev_package_info).and_return(
-        [release_path_end, release_file],
-      )
-
-      expect(subject).to receive(:fetch_http_file).once.with(/#{release_path_end}$/, release_file, %r{/osx$})
-      expect(subject).to receive(:scp_to).once.with(host, /#{release_file}$/, copy_dir_external)
-      # the star is necessary, as that's not the entire filename, & we rely on
-      # the globbing to get this right on OSX SUTs
-      expect(host).to receive(:install_package).with(/^puppet-agent-0.1.0\*$/)
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'runs the correct install for solaris platforms' do
-      @platform = 'solaris-10-x86_64'
-      opts = { version: '0.1.0' }
-      allow(subject).to receive(:options).and_return({})
-
-      release_path_end = 'fake_release_path_end'
-      release_file = 'fake_sol10_8495_release_file'
-      expect(host).to receive(:puppet_agent_dev_package_info).and_return(
-        [release_path_end, release_file],
-      )
-
-      expect(subject).to receive(:fetch_http_file).once.with(
-        /#{release_path_end}$/, release_file, anything
-      )
-      expect(subject).to receive(:scp_to).once.with(
-        host, /#{release_file}$/, anything
-      )
-
-      expect(host).to receive(:solaris_install_local_package)
-
-      allow(subject).to receive(:configure_type_defaults_on)
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'allows you to override the local copy directory' do
-      # only applies to hosts that don't go down the
-      # install_puppetlabs_dev_repo route
-      host = eoshost
-      host['platform'] = Beaker::Platform.new('eos-5-x86_64')
-      sha_value = 'dahdahdahdah'
-      copy_base_local_override = 'face'
-      opts = {
-        version: '0.1.0',
-        copy_base_local: copy_base_local_override,
-        puppet_agent_sha: sha_value,
-      }
-      allow(subject).to receive(:options).and_return({})
-
-      allow(host).to receive(:puppet_agent_dev_package_info).and_return(['', ''])
-
-      allow(host).to receive(:get_remote_file).once.with(anything)
-      allow(host).to receive(:install_from_file)
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'allows you to override the external copy directory' do
-      host = basic_hosts.first
-      host['platform'] = Beaker::Platform.new('osx-5-x86_64')
-      copy_dir_custom = 'muppetsBB8-1435'
-      opts = { version: '0.1.0', copy_dir_external: copy_dir_custom }
-      allow(subject).to receive(:options).and_return({})
-
-      allow(host).to receive(:puppet_agent_dev_package_info).and_return(['', ''])
-
-      allow(subject).to receive(:fetch_http_file).once
-      expect(subject).to receive(:scp_to).once.with(
-        host, anything, /#{copy_dir_custom}/
-      )
-      allow(host).to receive(:install_package)
-
-      subject.install_puppet_agent_dev_repo_on(host, opts)
-    end
-
-    it 'copies package to the cygwin root directory and installs it' do
-      @platform = 'windows-7-x86_64'
-      expect(subject).to receive(:install_msi_on).with(any_args)
-      copy_base = 'copy_base_cygwin'
-      allow(host).to receive(:external_copy_base).and_return(copy_base)
-      expect(subject).to receive(:scp_to).with(host, /puppet-agent-1\.0\.0-x64\.msi/, /#{copy_base}/)
-      expect(subject).to receive(:configure_type_defaults_on).with(host)
-      expect(subject).to receive(:fetch_http_file).with(%r{[^/]\z}, anything, anything)
-      subject.install_puppet_agent_dev_repo_on(host, opts.merge({ puppet_agent_version: '1.0.0' }))
-    end
-
-    it 'installs on different hosts without erroring' do
-      mhosts = hosts
-      mhosts[3] = eoshost
-
-      mhosts.each_with_index do |host, index|
-        if index == 0
-          host['platform'] = Beaker::Platform.new('solaris-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host0' }
-        elsif index == 1
-          host['platform'] = Beaker::Platform.new('windows-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host1' }
-        elsif index == 2
-          host['platform'] = Beaker::Platform.new('osx-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host2' }
-        elsif index == 3
-          host['platform'] = Beaker::Platform.new('eos-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host3' }
-        end
-        allow(host).to receive(:puppet_agent_dev_package_info).with(any_args).and_return(%w[test blah])
-      end
-
-      expect(subject).to receive(:add_role).with(any_args).exactly(mhosts.length).times
-
-      expect(subject).to receive(:fetch_http_file).with(any_args).exactly(3).times
-      expect(subject).to receive(:scp_to).with(any_args).exactly(3).times
-
-      expect(subject).to receive(:install_msi_on).with(mhosts[1], 'xyz', {}, anything).exactly(1).times
-      expect(mhosts[0]).to receive(:solaris_install_local_package).with('blah', '/host0').exactly(1).times
-      expect(mhosts[2]).to receive(:install_package).with(any_args).exactly(1).times
-      expect(mhosts[3]).to receive(:install_from_file).with('blah').exactly(1).times
-
-      result = object_double(Beaker::Result.new({}, 'foo'), raw_output: 'xyz')
-      allow(subject).to receive(:on).with(mhosts[1], anything).and_return(result)
-
-      expect(subject).to receive(:configure_type_defaults_on).with(any_args).exactly(mhosts.length).times
-
-      subject.install_puppet_agent_dev_repo_on(mhosts, opts.merge({ puppet_agent_version: '1.0.0' }))
-    end
-
-    it 'installs on different hosts with options specifying :copy_dir_external' do
-      mhosts = hosts
-      mhosts[3] = eoshost
-
-      mhosts.each_with_index do |host, index|
-        if index == 0
-          host['platform'] = Beaker::Platform.new('solaris-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host0' }
-        elsif index == 1
-          host['platform'] = Beaker::Platform.new('windows-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host1' }
-        elsif index == 2
-          host['platform'] = Beaker::Platform.new('osx-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host2' }
-        elsif index == 3
-          host['platform'] = Beaker::Platform.new('eos-5-x4')
-          allow(host).to receive(:external_copy_base) { '/host3' }
-        end
-        allow(host).to receive(:puppet_agent_dev_package_info).with(any_args).and_return(['test', '/blah'])
-      end
-
-      expect(subject).to receive(:add_role).with(any_args).exactly(mhosts.length).times
-
-      expect(subject).to receive(:fetch_http_file).with(any_args).exactly(3).times
-      expect(subject).to receive(:scp_to).with(any_args).exactly(3).times
-
-      expect(subject).to receive(:install_msi_on).with(mhosts[1], 'xyz', {}, anything).exactly(1).times
-      expect(mhosts[0]).to receive(:solaris_install_local_package).with('/blah', '/tmp').exactly(1).times
-      expect(mhosts[2]).to receive(:install_package).with(any_args).exactly(1).times
-      expect(mhosts[3]).to receive(:install_from_file).with('/blah').exactly(1).times
-      expect(mhosts[0]).to receive(:external_copy_base).with(no_args).exactly(0).times
-      expect(mhosts[1]).to receive(:external_copy_base).with(no_args).exactly(0).times
-      expect(mhosts[2]).to receive(:external_copy_base).with(no_args).exactly(0).times
-      expect(mhosts[3]).to receive(:external_copy_base).with(no_args).exactly(0).times
-
-      result = object_double(Beaker::Result.new({}, 'foo'), raw_output: 'xyz')
-      allow(subject).to receive(:on).with(mhosts[1], anything).and_return(result)
-
-      expect(subject).to receive(:configure_type_defaults_on).with(any_args).exactly(mhosts.length).times
-
-      subject.install_puppet_agent_dev_repo_on(mhosts,
-                                               opts.merge({ puppet_agent_version: '1.0.0', copy_dir_external: '/tmp' }))
-    end
-  end
-
-  describe '#install_puppet_agent_pe_promoted_repo_on' do
-    let(:package_name) { 'puppet-agent' }
-    let(:platform) { @platform || 'other' }
-    let(:host) do
-      FakeHost.create('fakvm', platform, opts)
-    end
-
-    before :each do
-      allow(subject).to receive(:configure_foss_defaults_on).and_return(true)
-      allow(subject).to receive(:install_msi_on).with(any_args)
-    end
-
-    def test_fetch_http_file_no_ending_slash(platform)
-      @platform = platform
-      allow(subject).to receive(:scp_to)
-      allow(subject).to receive(:configure_type_defaults_on).with(host)
-
-      expect(subject).to receive(:fetch_http_file).with(%r{[^/]\z}, anything, anything)
-      subject.install_puppet_agent_pe_promoted_repo_on(host, opts)
-    end
-
-    context 'on windows' do
-      it 'calls fetch_http_file with no ending slash' do
-        test_fetch_http_file_no_ending_slash('windows-7-x86_64')
-      end
-    end
-
-    it 'calls fetch_http_file with no ending slash' do
-      test_fetch_http_file_no_ending_slash('debian-5-x86_64')
-    end
-
-    context 'when setting different agent versions' do
-      let(:host) { basic_hosts.first }
-      let(:platform) { Beaker::Platform.new('el-6-x86_64') }
-      let(:downloadurl) { 'http://pm.puppet.com' }
-      before :each do
-        allow(subject).to receive(:options).and_return(opts)
-        allow(subject).to receive(:scp_to)
-        allow(subject).to receive(:configure_type_defaults_on).with(host)
-      end
-
-      it 'sets correct file paths when agent version is set to latest' do
-        host['platform'] = platform
-        agentversion = 'latest'
-        collection = 'puppet'
-        opts = { puppet_agent_version: "#{agentversion}", pe_promoted_builds_url: "#{downloadurl}" }
-
-        expect(subject).to receive(:fetch_http_file).once.with(
-          %r{pm\.puppet\.com/puppet-agent/.*/#{agentversion}/repos},
-          /puppet-agent-el-6*/,
-          %r{/el$},
-        )
-        expect(host).to receive(:pe_puppet_agent_promoted_package_install).with(
-          anything,
-          /puppet-agent-el-6*/,
-          %r{.*/el/6/#{collection}/.*rpm},
-          /puppet-agent-el-6/,
-          anything,
-        )
-        subject.install_puppet_agent_pe_promoted_repo_on(host, opts)
-      end
-
-      it 'sets correct file paths for agent version 1.x.x' do
-        host['platform'] = platform
-        agentversion = '1.x.x'
-        collection = 'pc1'
-        opts = { puppet_agent_version: "#{agentversion}", pe_promoted_builds_url: "#{downloadurl}" }
-
-        expect(subject).to receive(:fetch_http_file).once.with(
-          %r{pm\.puppet\.com/puppet-agent/.*/#{agentversion}/repos},
-          /puppet-agent-el-6*/, %r{/el$}
-        )
-        expect(host).to receive(:pe_puppet_agent_promoted_package_install).with(
-          anything,
-          /puppet-agent-el-6*/,
-          %r{.*/el/6/#{collection}/.*rpm},
-          /puppet-agent-el-6/,
-          anything,
-        )
-        subject.install_puppet_agent_pe_promoted_repo_on(host, opts)
-      end
-
-      it 'sets correct file paths for agent version >= 5.5.4' do
-        host['platform'] = platform
-        agentversion = '5.5.4'
-        collection = 'puppet5'
-        opts = { puppet_agent_version: "#{agentversion}", pe_promoted_builds_url: "#{downloadurl}" }
-
-        expect(subject).to receive(:fetch_http_file).once.with(
-          %r{pm\.puppet\.com/puppet-agent/.*/#{agentversion}/repos},
-          /puppet-agent-el-6*/,
-          %r{/el$},
-        )
-        expect(host).to receive(:pe_puppet_agent_promoted_package_install).with(
-          anything,
-          /puppet-agent-el-6*/,
-          %r{.*/el/6/#{collection}/.*rpm},
-          /puppet-agent-el-6/,
-          anything,
-        )
-        subject.install_puppet_agent_pe_promoted_repo_on(host, opts)
-      end
-
-      it 'sets correct file paths for agent version > 5.99' do
-        host['platform'] = platform
-        agentversion = '6.0.0'
-        collection = 'puppet6'
-        opts = { puppet_agent_version: "#{agentversion}", pe_promoted_builds_url: "#{downloadurl}" }
-
-        expect(subject).to receive(:fetch_http_file).once.with(
-          %r{pm\.puppet\.com/puppet-agent/.*/#{agentversion}/repos},
-          /puppet-agent-el-6*/,
-          %r{/el$},
-        )
-        expect(host).to receive(:pe_puppet_agent_promoted_package_install).with(
-          anything,
-          /puppet-agent-el-6*/,
-          %r{.*/el/6/#{collection}/.*rpm},
-          /puppet-agent-el-6/,
-          anything,
-        )
-        subject.install_puppet_agent_pe_promoted_repo_on(host, opts)
-      end
-    end
-  end
-
   describe '#install_puppetserver_on' do
     let(:host) { make_host('master', platform: 'el-7-x86_64') }
 

data/spec/beaker-puppet/install_utils/puppet_utils_spec.rb

@@ -71,11 +71,6 @@ describe ClassMixedWithDSLInstallUtils do
       subject.configure_defaults_on(hosts, 'aio')
     end
 
-    it 'can set pe defaults' do
-      expect(subject).to receive(:add_pe_defaults_on).exactly(hosts.length).times
-      subject.configure_defaults_on(hosts, 'pe')
-    end
-
     it 'can remove old defaults ands replace with new' do
       # fake the results of calling configure_pe_defaults_on
       hosts.each do |host|
@@ -128,24 +123,6 @@ describe ClassMixedWithDSLInstallUtils do
       expect(subject).to receive(:add_aio_defaults_on).exactly(hosts.length).times
       subject.configure_type_defaults_on(hosts)
     end
-
-    it 'can set pe defaults for pe type' do
-      hosts.each do |host|
-        host['type'] = 'pe'
-      end
-      expect(subject).to receive(:add_pe_defaults_on).exactly(hosts.length).times
-      subject.configure_type_defaults_on(hosts)
-    end
-
-    it 'adds aio defaults to pe hosts when they an aio pe version' do
-      hosts.each do |host|
-        host['type'] = 'pe'
-        host['pe_ver'] = '4.0'
-      end
-      expect(subject).to receive(:add_pe_defaults_on).exactly(hosts.length).times
-      expect(subject).to receive(:add_aio_defaults_on).exactly(hosts.length).times
-      subject.configure_type_defaults_on(hosts)
-    end
   end
 
   describe '#puppetserver_version_on' do