beaker-module_install_helper 0.1.7 → 2.0.0

data/spec/unit/beaker/module_install_helper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Beaker::ModuleInstallHelper do
@@ -6,7 +8,7 @@ describe Beaker::ModuleInstallHelper do
       let(:hosts) do
         [
           { 'roles' => %w[master database dashboard classifier] },
-          { 'roles' => ['agent'] }
+          { 'roles' => ['agent'] },
         ]
       end
 
@@ -71,24 +73,48 @@ describe Beaker::ModuleInstallHelper do
     let(:module_source_dir) { '/a/b/c/d' }
     let(:host) { { 'roles' => %w[master database dashboard classifier] } }
 
-    before do
-      $module_source_dir = '/a/b/c/d'
-      allow(File).to receive(:exist?).and_return(true)
-      allow(File).to receive(:read).and_return('{"name": "puppetlabs-vcsrepo"}')
-
-      allow_any_instance_of(Beaker::DSL::InstallUtils::ModuleUtils)
-        .to receive(:copy_module_to)
-        .with(anything)
-        .and_return(false)
+    context 'without options' do
+      before do
+        $module_source_dir = '/a/b/c/d'
+        allow(File).to receive(:exist?).and_return(true)
+        allow(File).to receive(:read).and_return('{"name": "puppetlabs-vcsrepo"}')
+
+        allow_any_instance_of(Beaker::DSL::InstallUtils::ModuleUtils)
+          .to receive(:copy_module_to)
+          .with(anything)
+          .and_return(false)
+
+        allow_any_instance_of(Beaker::DSL::InstallUtils::ModuleUtils)
+          .to receive(:copy_module_to)
+          .with(host, source: module_source_dir, module_name: 'vcsrepo')
+          .and_return(true)
+      end
 
-      allow_any_instance_of(Beaker::DSL::InstallUtils::ModuleUtils)
-        .to receive(:copy_module_to)
-        .with(host, source: module_source_dir, module_name: 'vcsrepo')
-        .and_return(true)
+      it 'copy module to given host' do
+        expect(install_module_on(host)).to be true
+      end
     end
 
-    it 'copy module to given host' do
-      expect(install_module_on(host)).to be true
+    context 'with options' do
+      before do
+        $module_source_dir = '/a/b/c/d'
+        allow(File).to receive(:exist?).and_return(true)
+        allow(File).to receive(:read).and_return('{"name": "puppetlabs-vcsrepo"}')
+
+        allow_any_instance_of(Beaker::DSL::InstallUtils::ModuleUtils)
+          .to receive(:copy_module_to)
+          .with(anything)
+          .and_return(false)
+
+        allow_any_instance_of(Beaker::DSL::InstallUtils::ModuleUtils)
+          .to receive(:copy_module_to)
+          .with(host, source: module_source_dir, module_name: 'vcsrepo', protocol: 'rsync')
+          .and_return(true)
+      end
+
+      it 'copy module to given host' do
+        expect(install_module_on(host, protocol: 'rsync')).to be true
+      end
     end
   end
 
@@ -123,19 +149,19 @@ describe Beaker::ModuleInstallHelper do
           'dependencies' => [
             {
               'name' => 'puppetlabs/stdlib',
-              'version_requirement' => '>= 4.13.1 <= 4.14.0'
+              'version_requirement' => '>= 4.13.1 <= 4.14.0',
             }, {
               'name' => 'puppetlabs/concat',
-              'version_requirement' => '>= 2.0.0 <= 2.2.0'
-            }
-          ]
+              'version_requirement' => '>= 2.0.0 <= 2.2.0',
+            },
+          ],
         }
       end
 
       let(:desired) do
         [
           { module_name: 'puppetlabs-stdlib', version: '4.14.0' },
-          { module_name: 'puppetlabs-concat', version: '2.2.0' }
+          { module_name: 'puppetlabs-concat', version: '2.2.0' },
         ]
       end
 
@@ -151,15 +177,15 @@ describe Beaker::ModuleInstallHelper do
           'name' => 'puppetlabs-vcsrepo',
           'dependencies' => [
             { 'name' => 'puppetlabs/stdlib' },
-            { 'name' => 'puppetlabs/concat' }
-          ]
+            { 'name' => 'puppetlabs/concat' },
+          ],
         }
       end
 
       let(:desired) do
         [
           { module_name: 'puppetlabs-stdlib' },
-          { module_name: 'puppetlabs-concat' }
+          { module_name: 'puppetlabs-concat' },
         ]
       end
 
@@ -173,7 +199,7 @@ describe Beaker::ModuleInstallHelper do
       let(:input_metadata) do
         {
           'name' => 'puppetlabs-vcsrepo',
-          'dependencies' => []
+          'dependencies' => [],
         }
       end
       let(:desired) { [] }
@@ -212,7 +238,7 @@ describe Beaker::ModuleInstallHelper do
       it 'return array with 2 gem version dependency objects' do
         res = version_requirements_from_string("#{lower_bound} #{upper_bound}")
         expect(res).to eql([Gem::Dependency.new('', lower_bound),
-                            Gem::Dependency.new('', upper_bound)])
+                            Gem::Dependency.new('', upper_bound),])
       end
     end
   end
@@ -273,9 +299,9 @@ describe Beaker::ModuleInstallHelper do
           'dependencies' => [
             {
               'name' => 'puppetlabs/stdlib',
-              'version_requirement' => '>= 4.13.1 <= 4.14.0'
-            }
-          ]
+              'version_requirement' => '>= 4.13.1 <= 4.14.0',
+            },
+          ],
         }
       end
 
@@ -295,8 +321,8 @@ describe Beaker::ModuleInstallHelper do
           'name' => 'puppetlabs-vcsrepo',
           'dependencies' => [
             { 'name' => 'puppetlabs/stdlib' },
-            { 'name' => 'puppetlabs/concat' }
-          ]
+            { 'name' => 'puppetlabs/concat' },
+          ],
         }
       end
       let(:a_host) { { name: 'a_host' } }
@@ -334,4 +360,29 @@ describe Beaker::ModuleInstallHelper do
       install_module_from_forge_on(a_host, input_module_name, input_module_version_requirement)
     end
   end
+
+  describe 'module_version_from_requirement' do
+    context 'when looking up resolvable version contraints for a valid module' do
+      it 'gets a response', live_fire: true do
+        ver = module_version_from_requirement('puppetlabs-vcsrepo', '>= 1 < 2')
+        expect(ver).to eq '1.5.0'
+      end
+    end
+
+    context 'when looking up *unresolvable* version contraints for a valid module' do
+      it 'gets a response', live_fire: true do
+        expect do
+          module_version_from_requirement('puppetlabs-vcsrepo', '> 1.4 < 1.5')
+        end.to raise_error(/^No release version found matching 'puppetlabs-vcsrepo' '> 1.4 < 1.5'/)
+      end
+    end
+
+    context 'when looking up metadata for a *invalid* module name' do
+      it 'gets a response', live_fire: true do
+        expect do
+          module_version_from_requirement('puppet-does-not-exist', '>= 1 < 2')
+        end.to raise_error(/^Puppetforge API error/)
+      end
+    end
+  end
 end

metadata

@@ -1,29 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: beaker-module_install_helper
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 2.0.0
 platform: ruby
 authors:
-- Puppet
+- Vox Pupuli
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-08 00:00:00.000000000 Z
+date: 2023-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.12'
+- !ruby/object:Gem::Dependency
+  name: voxpupuli-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: beaker
   requirement: !ruby/object:Gem::Requirement
@@ -31,6 +45,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -38,29 +55,54 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '2.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
+- !ruby/object:Gem::Dependency
+  name: beaker-puppet
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '3'
 description: A helper gem for use in a Puppet Modules spec_helper_acceptance.rb file
   to help install the module under test and its dependencies on the system under test
 email:
-- wilson@puppet.com
+- voxpupuli@groups.io
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
+- ".github/workflows/release.yml"
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
+- ".rubocop_todo.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE
-- MAINTAINERS
 - README.md
 - Rakefile
 - beaker-module_install_helper.gemspec
 - lib/beaker/module_install_helper.rb
 - spec/spec_helper.rb
 - spec/unit/beaker/module_install_helper_spec.rb
-homepage: https://github.com/puppetlabs/beaker-module_install_helper
+homepage: https://github.com/voxpupuli/beaker-module_install_helper
 licenses:
 - Apache-2.0
 metadata: {}
@@ -72,18 +114,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.7.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 3.2.33
 signing_key: 
 specification_version: 4
 summary: A helper gem for use in a Puppet Modules spec_helper_acceptance.rb file
-test_files:
-- spec/spec_helper.rb
-- spec/unit/beaker/module_install_helper_spec.rb
+test_files: []

data/.travis.yml

@@ -1,8 +0,0 @@
-language: ruby
-script:
-  - bundle exec rake lint spec
-notifications:
-  email: false
-rvm:
-  - 2.1.6
-  - 2.3.0

data/MAINTAINERS

@@ -1,11 +0,0 @@
-{
-  "version": 1,
-  "file_format": "This MAINTAINERS file format is described at http://pup.pt/maintainers",
-  "issues": "https://github.com/puppetlabs/beaker-module_install_helper/issues",
-  "people": [
-    {
-      "github": "wilson208",
-      "name": "Wilson McCoubrey"
-    }
-  ]
-}