bcn_ni 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d17fe676aa77facf97c9cf4355d7de85a4ff7f3f0f047324b56201992264092
-  data.tar.gz: 65cb53118d9f3086d96d29c41fd5c5745f1ca789f91b8e04b9da2a6545cf25f7
+  metadata.gz: 4f096b5bf6ea7fa64c15436453d3f13259a916b383f305066f50989eaab85dfc
+  data.tar.gz: 6466f3159fb88a11248a532a6bb626c24b69c67aa25f0ff9cf644c7796d01116
 SHA512:
-  metadata.gz: 7312305624a80c519b8956faad2c1faecaa3cc93f2e59dbc194b6b991c9958deb91f27686df5cbbb07648115066833935e37d7aa164f62e2cdbb08ba8c80974a
-  data.tar.gz: 99f45ec56e4e64b7382853c8fa0abeff6839f9a65a2bfbb3c626fa262a445f6a795bcf6f00a4424b4b833fc04fcad55f2111e76f662fc94de62c00202e9eba87
+  metadata.gz: 9d79136f6bcd9d1838cdea7baea3da138e76ce727bff4afb2bb1290ca5efb0dca0f4b298cc6493de97ac3c1a858b9db5afa951c93b6679b883a3fea485d7040e
+  data.tar.gz: 34587ba34e542d02ae192e48b795af3090b229b2d0a47a8e96024d44303d8ffe3cac725aa714e9c18093e500e9033f6d6dd9ba7200631dc9e1492faf2cb41d49

data/README.md

@@ -70,7 +70,7 @@ Add this line to your application's Gemfile:
 gem 'bcn_ni', git: 'https://github.com/mldoscar/bcn_ni', branch: 'master'
 
 # From ruby gems
-gem 'bcn_ni', '~> 0.1.7'
+gem 'bcn_ni', '~> 0.1.8'
 
 # Using gem install
 gem install bcn_ni
@@ -85,6 +85,7 @@ $ bundle
 ## Changelog
 
 ```
+2026.05.31 - SOAP request fallback for modern OpenSSL, XML parsing fixes, and test updates
 2022.04.06 - Rails 6.x 7.x compatibility
 2021.06.28 - Bugfix: Cambio en el URI para el request de scrapping, el BCN cambió de parámetros y ubicación de URL
 ```

data/lib/bcn_ni/core.rb

@@ -24,4 +24,4 @@ module BcnNi
   def self.exceptions
     return @@exceptions
   end
-end
+end

data/lib/bcn_ni/helpers/request.rb

@@ -4,6 +4,7 @@ require 'net/https'
 require 'nokogiri'
 require 'open-uri'
 require 'json'
+require 'open3'
 require 'active_support/core_ext/hash'
 begin
   require 'active_support/time'
@@ -93,7 +94,7 @@ module BcnNi
 
         # Generate the full url
         full_url = request_url + '?' + args.to_param
-        
+
         # This loop prevents a random EOFError (main cause is not known yet)
         retries   = 0
         response  = nil
@@ -102,10 +103,10 @@ module BcnNi
           raise StopIteration if retries >= 5
 
           begin
-            response = open(full_url, { ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE })
+            response = URI.open(full_url, ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE)
             # Exit loop if response has been assigned
             break
-          rescue EOFError => e
+          rescue EOFError
             # Sum retry and sleep the thread for a while
             retries += 1
             sleep(2.seconds)
@@ -145,67 +146,90 @@ module BcnNi
 
       def soap__exchange_day(year, month, day)
         # Build body through a XML envelope
-        body          = soap__envelope(soap__letter_exchange_day(year, month, day))
-        json_response = soap__request(body)
+        body         = soap__envelope(soap__letter_exchange_day(year, month, day))
+        xml_response = soap__request(body)
+        doc          = Nokogiri::XML(xml_response)
 
-        # Get the result value
-        value_result = json_response['Envelope']['Body']['RecuperaTC_DiaResponse']['RecuperaTC_DiaResult']
         # Parse the result value and finally return it
+        value_result = doc.at_xpath("//*[local-name()='RecuperaTC_DiaResult']")&.text
         return value_result.to_f
       end
 
       def soap__exchange_month(year, month)
         # Build body through a XML envelope
-        body          = soap__envelope(soap__letter_exchange_month(year, month))
-        json_response = soap__request(body)
-
-        # Get the result array
-        exchange_table = json_response['Envelope']['Body']['RecuperaTC_MesResponse']['RecuperaTC_MesResult']['Detalle_TC']['Tc']
-
-        if exchange_table.present?
-          # Parse the table to a custom and better JSON
-          # The format example will be: {date: as Date, value: as Float}
-          parsed_table = exchange_table.map{ |x| { date: Date.parse(x['Fecha']), value: x['Valor'].to_f } }
-          # Sort the parsed table and finally return it
-          return parsed_table.sort_by { |x| x[:date] }
-        else
-          return []
+        body         = soap__envelope(soap__letter_exchange_month(year, month))
+        xml_response = soap__request(body)
+        doc          = Nokogiri::XML(xml_response)
+
+        # Parse the table to a custom and better JSON
+        # The format example will be: {date: as Date, value: as Float}
+        exchange_rows = doc.xpath("//*[local-name()='Detalle_TC']/*[local-name()='Tc']")
+        parsed_table = exchange_rows.map do |row|
+          {
+            date: Date.parse(row.at_xpath("*[local-name()='Fecha']")&.text.to_s),
+            value: row.at_xpath("*[local-name()='Valor']")&.text.to_f
+          }
         end
+
+        # Sort the parsed table and finally return it
+        return parsed_table.sort_by { |x| x[:date] }
       end
 
       def soap__request(body)
-        # Parse the URI
+        xml_response = begin
+          soap__request_with_net_http(body)
+        rescue OpenSSL::SSL::SSLError => e
+          # BCN SOAP endpoint currently negotiates TLS in a way OpenSSL 3 may reject.
+          # Fallback to curl keeps compatibility in modern Ruby runtimes.
+          raise unless e.message.to_s.downcase.include?('unsupported protocol')
+
+          soap__request_with_curl(body)
+        end
+
+        return xml_response
+      end
+
+      def soap__request_with_net_http(body)
         uri           = URI.parse(request_url)
-        # Create protocol to the URI
         request_engine              = Net::HTTP.new(uri.host, uri.port)
         request_engine.use_ssl      = true
         request_engine.verify_mode  = OpenSSL::SSL::VERIFY_NONE
         request_engine.open_timeout = 15.seconds
+        request_engine.read_timeout = 15.seconds
 
-        # Create a new POST request as XML content type
         req                 = Net::HTTP::Post.new(uri.path)
         req['Content-Type'] = 'text/xml'
+        req.body            = body
 
-        # Set the request body as a RAW SOAP XML request
-        req.body = body
-        # Process the request
         res = request_engine.request(req)
-        # Get the XML response
-        xml_response = res.body
+        return res.body
+      end
 
-        # Parse to a JSON hash
-        return Hash.from_xml(xml_response)
+      def soap__request_with_curl(body)
+        stdout, stderr, status = Open3.capture3(
+          'curl',
+          '--silent',
+          '--show-error',
+          '--insecure',
+          '--header', 'Content-Type: text/xml',
+          '--data-binary', '@-',
+          request_url,
+          stdin_data: body
+        )
+
+        raise StandardError, "curl SOAP request failed: #{stderr.strip}" unless status.success?
+
+        return stdout
       end
 
       def soap__envelope(letter)
-        envelope = <<-XML
-          <?xml version="1.0" encoding="utf-8"?>
+        envelope = <<~XML
           <soap:Envelope xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:soap="http://schemas.xmlsoap.org/soap/envelope/">
             <soap:Body>
               #{letter}
             </soap:Body>
           </soap:Envelope>
-XML
+        XML
         return envelope
       end
 
@@ -231,4 +255,4 @@ XML
       end
 
   end
-end
+end

data/lib/bcn_ni/version.rb

@@ -1,3 +1,3 @@
 module BcnNi
-  VERSION = '0.1.7'
+  VERSION = '0.1.8'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: bcn_ni
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Oscar Rodriguez
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-07 00:00:00.000000000 Z
+date: 2026-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -34,44 +33,82 @@ dependencies:
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '1.14'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.14'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '13.0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '14.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '13.0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '14.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.12'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '3.12'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4.0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '11.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '12.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '11.0'
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '12.0'
 description: This gem provides NIO (Córdoba Oro Nicaragüense) against USD (United
   States Dollar) money exchange rates consuming the official Central Bank of Nicaragüa
   (BCN) SOAP Service or HTML page
@@ -94,7 +131,6 @@ homepage: https://github.com/mldoscar/bcn_ni
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -109,8 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
-signing_key:
+rubygems_version: 3.6.3
 specification_version: 4
 summary: This tool pretends to be helpful for developers who can request exchange
   rates from Nicaragua in a easier way