bcn_ni 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1c4b383d91f4ad21fc044cdb93170c13cd097cf04f47d0eb973ad49cbb20030
-  data.tar.gz: a265fce14d08e714a372ba1f049f4fa5cb3c4b871c8cc83228c90a39f6b2de38
+  metadata.gz: 3f0e01abc9ca4e65e1f22527f880650253b861badbd36e6b7f4c387e44a0fc04
+  data.tar.gz: c9b29f47fca3b6dec463b896b665ab65907f22ad45645941ab06a1e806d265fc
 SHA512:
-  metadata.gz: bcefbc683faa59247e875254834a524fc100797610e38c4d02052226953eb670376467cb02bf18dcc2015ff2275dcab9bc76bac435f2dc58fb71e04005c3c0fc
-  data.tar.gz: b9c7ef36a12e8072f01de2c024f31e0d98c5ebe80387c7ef13535fc7a2e3ecc7fb6a45af7b52b583fe390cea86e836e371710df474eebcf04e53134343c29089
+  metadata.gz: 677ca5cc3b6f864b40e4573ad0fe0c978ec3929b6262eb1212f9ec9455ddfe107b268db429af33cdbf97a70b20a325a56922335736130600e760201f20b46157
+  data.tar.gz: ed2a566e0fc5477a53fbd9c24abbc0f22ac7adee37c397857a10dd2beeceaffb675aae64c0910ffc37acc66154026ebe2ee76ba5082416c83f6d75fef7ace016

data/README.md

@@ -1,5 +1,5 @@
 # BcnNi
-This gem provides NIO (Córdoba oro Nicaragüense) versus USD (United States dollar) money exchange rates consuming the official Central Bank of Nicaragüa (BCN) SOAP Service
+This gem provides NIO (Córdoba Oro Nicaragüense) against USD (United States Dollar) money exchange rates consuming the official Central Bank of Nicaragüa (BCN) SOAP Service or HTML page
 
 ## Basic usage
 ```ruby
@@ -67,7 +67,7 @@ Add this line to your application's Gemfile:
 gem 'bcn_ni', git: 'https://github.com/mldoscar/bcn_ni', branch: 'master'
 
 # From ruby gems
-gem 'bcn_ni', '>= 0.1.3'
+gem 'bcn_ni', '>= 0.1.4'
 
 # Using gem install
 gem install bcn_ni

data/lib/bcn_ni/core.rb

@@ -1,15 +1,27 @@
 module BcnNi
   require File.expand_path(File.dirname(__FILE__)) + '/helpers/request'
 
+  @@exceptions  = []
+
   def self.exchange_month(year, month, args = {})
-    request = BcnNi::Request.new(args)
+    engine        = BcnNi::Request.new(args)
+
+    result        = engine.exchange_month(year, month)
+    @@exceptions  = engine.exceptions
 
-    return request.exchange_month(year, month)
+    return result
   end
 
   def self.exchange_day(year, month, day, args = {})
-    request = BcnNi::Request.new(args)
+    engine        = BcnNi::Request.new(args)
+
+    result        = engine.exchange_day(year, month, day)
+    @@exceptions  = engine.exceptions
+
+    return result
+  end
 
-    return request.exchange_day(year, month, day)
+  def self.exceptions
+    return @@exceptions
   end
 end

data/lib/bcn_ni/helpers/request.rb

@@ -8,11 +8,25 @@ require 'json'
 
 module BcnNi
   class Request
-    @request_url  = ""
+    @request_url  = nil
     @request_mode = nil
+    @exceptions   = nil
+
+    def request_url
+      return @request_url
+    end
+
+    def request_mode
+      return @request_mode
+    end
+
+    def exceptions
+      return @exceptions
+    end
 
     def initialize(args = {})
       @request_mode = (args[:request_mode] || :scrapping).to_sym
+      @exceptions   = []
 
       case @request_mode
       when :scrapping
@@ -21,37 +35,43 @@ module BcnNi
         # See 'https://servicios.bcn.gob.ni/Tc_Servicio/ServicioTC.asmx' for more info about how to build a RAW SOAP request
         @request_url = "https://servicios.bcn.gob.ni/Tc_Servicio/ServicioTC.asmx?WSDL"
       else
-        raise Exception.new('Request mode not implemented')
+        raise NotImplementedError, 'Request mode not implemented'
       end
     end
 
-    def request_url
-      return @request_url
-    end
-
-    def request_mode
-      return @request_mode
-    end
-
     def exchange_month(year, month)
-      case request_mode
-      when :scrapping
-        return scra__exchange_month(year, month)
-      when :soap
-        return soap__exchange_month(year, month)
-      else
-        raise Exception.new('Request mode not implemented')
+      begin
+        # Evaluate scrapping mode to call the correct method for processing the request
+        case request_mode
+        when :scrapping
+          return scra__exchange_month(year, month)
+        when :soap
+          return soap__exchange_month(year, month)
+        end
+      rescue Exception => e
+        # Save the exception into the exception list for future error messages or debugging
+        @exceptions.push e
+
+        # Return an empty value according to the called method
+        return []
       end
     end
 
     def exchange_day(year, month, day)
-      case request_mode
-      when :scrapping
-        return scra__exchange_day(year, month, day)
-      when :soap
-        return soap__exchange_day(year, month, day)
-      else
-        raise Exception.new('Request mode not implemented')
+      begin
+        # Evaluate scrapping mode to call the correct method for processing the request
+        case request_mode
+        when :scrapping
+          return scra__exchange_day(year, month, day)
+        when :soap
+          return soap__exchange_day(year, month, day)
+        end
+      rescue Exception => e
+        # Save the exception into the exception list for future error messages or debugging
+        @exceptions.push e
+
+        # Return an empty value according to the called method
+        return nil
       end
     end
 
@@ -69,9 +89,27 @@ module BcnNi
 
         # Generate the full url
         full_url = request_url + '?' + args.to_param
+        
+        # This loop prevents a random EOFError (main cause is not known yet)
+        retries   = 0
+        response  = nil
+        while true
+          # Raise an error if too many retries
+          raise StopIteration if retries >= 5
+
+          begin
+            response = open(full_url, { ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE })
+            # Exit loop if response has been assigned
+            break
+          rescue EOFError => e
+            # Sum retry and sleep the thread for a while
+            retries += 1
+            sleep(2.seconds)
+          end
+        end
 
-        # Fetch and parse HTML document
-        doc = Nokogiri::HTML(open(full_url, { ssl_verify_mode: OpenSSL::SSL::VERIFY_NONE }))
+        # Parse the HTML document
+        doc = Nokogiri::HTML(response)
 
         result = []
         # Iterate table

data/lib/bcn_ni/version.rb

@@ -1,3 +1,3 @@
 module BcnNi
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bcn_ni
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Oscar Rodriguez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-13 00:00:00.000000000 Z
+date: 2019-02-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,34 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 5.1.3
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 5.1.3
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '1.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.10'
+        version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -72,8 +66,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.8'
-description: This tool pretends to be helpful for developers who can request exchange
-  rates in a easier way
+description: This gem provides NIO (Córdoba Oro Nicaragüense) against USD (United
+  States Dollar) money exchange rates consuming the official Central Bank of Nicaragüa
+  (BCN) SOAP Service or HTML page
 email:
 - mld.oscar@yahoo.com
 executables: []
@@ -112,7 +107,6 @@ rubyforge_project:
 rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
-summary: This gem provides NIO (Córdoba oro Nicaragüense) versus USD (United States
-  dollar) money exchange rates consuming the official Central Bank of Nicaragüa (BCN)
-  SOAP Service
+summary: This tool pretends to be helpful for developers who can request exchange
+  rates from Nicaragua in a easier way
 test_files: []