bcms_sitemap 0.9.0 → 0.9.1

data/README.markdown

@@ -1,6 +1,6 @@
 **WARNING: This module has not yet been tested in a live production environment** 
 
-**NOTE: Gem has not been built yet.**
+Available as a gem at [Gemcutter.org](http://gemcutter.org)
 
 # BCMS\_sitemap BrowserCMS sitemap submission module
 

data/app/helpers/sitemaps_helper.rb

@@ -4,7 +4,14 @@ module SitemapsHelper
   end
   
   def xml_url(object)
-    "http://#{SITE_DOMAIN}#{object.path}"
+    if object.respond_to? :path
+      "http://#{SITE_DOMAIN}#{object.path}"
+    elsif object.respond_to? :route_params
+      object_name = ActionController::RecordIdentifier::singular_class_name(object)
+      self.send("#{object_name}_url", object.route_params) 
+    else
+      polymorphic_url(object)
+    end
   end
   
   def xml_article_url(object)

data/app/views/sitemaps/news_articles.builder

@@ -1,6 +1,6 @@
 xml.instruct! :xml, :version => "1.0", :encoding => "UTF-8" 
 xml.urlset :xmlns => "http://www.sitemaps.org/schemas/sitemap/0.9" do
-  @articles.each do |object|
+  @news_articles.each do |object|
     xml.url do
       xml.loc news_article_url(object.route_params)
       xml.lastmod xml_lastmod(object)

data/test/functional/sitemaps_controller_test.rb

@@ -34,7 +34,7 @@ def page(path, priority = 0.9, frequency = :daily, archived = false)
 <?xml version="1.0" encoding="UTF-8"?>
 <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
   <url>
-    <loc>http://localhost:3000#{path}</loc>
+    <loc>http://test.host#{path}</loc>
     <lastmod>2010-02-05T10:54:49Z</lastmod>
     <changefreq>#{frequency}</changefreq>
     <priority>#{priority}</priority>
@@ -115,23 +115,39 @@ TEXT
       setup do
         @article = create_news_article(:name => 'This is the name of the article', :release_date => @time.to_date)
       end
-      should_eventually 'publish articles' do
+      should 'publish articles' do
         @expected = <<-TEXT
-        <?xml version="1.0" encoding="UTF-8"?>
-        <urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
-          <url>
-            <loc>http://localhost:3000/news/articles/2010/02/10/this-is-the-name-of-the-article</loc>
-            <lastmod>2010-02-05T10:54:49Z</lastmod>
-            <changefreq>weekly</changefreq>
-            <priority>0.7</priority>
-          </url>
-        </urlset>
+<?xml version="1.0" encoding="UTF-8"?>
+<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
+  <url>
+    <loc>http://test.host/news/articles/2010/02/04/this-is-the-name-of-the-article</loc>
+    <lastmod>2010-02-05T10:54:49Z</lastmod>
+    <changefreq>weekly</changefreq>
+    <priority>0.7</priority>
+  </url>
+</urlset>
         TEXT
-        get :news_articles, :format => 'xml'
+        get :model, :model => 'news_articles', :format => :xml
         assert_response :success
         assert_dom_equal @expected, @response.body
       end
       should_eventually 'give archived articles lower priority' do
+        @article.update_attribute(:archived, true)
+        @expected = <<-TEXT
+<?xml version="1.0" encoding="UTF-8"?>
+<urlset xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
+  <url>
+    <loc>http://test.host/news/articles/2010/02/04/this-is-the-name-of-the-article</loc>
+    <lastmod>2010-02-05T10:54:49Z</lastmod>
+    <changefreq>never</changefreq>
+    <priority>0.4</priority>
+  </url>
+</urlset>
+        TEXT
+        get :model, :model => 'news_articles', :format => :xml
+        assert_response :success
+        assert_dom_equal @expected, @response.body
+        
       end
     end
     

data/test/integration/sitemap_submitter_test.rb

@@ -33,7 +33,7 @@ class Cms::SitemapSubmitterTest < ActiveSupport::TestCase
       assert_equal 404, resp
     end
     should 'generate correct parameters' do
-      assert_equal "http%3A%2F%2Flocalhost%3A3000%2Fsitemaps.xml", @submitter.parameters
+      assert_equal "http%3A%2F%2Ftest.host%2Fsitemaps.xml", @submitter.parameters
     end
   end
   

data/test/test_factory.rb

@@ -26,4 +26,7 @@ module TestFactory
   def create_news_article(options = {})
     _create NewsArticle.create({:name => 'Nyhet', :body => 'i dag', :published => true, :release_date => Date.today}.merge(options))
   end  
+  def new_news_article(options = {})
+    NewsArticle.new({:name => 'Nyhet', :body => 'i dag', :published => true, :release_date => Date.today}.merge(options))
+  end  
 end

data/test/unit/helpers/sitemaps_helper_test.rb

@@ -1,4 +1,22 @@
 require 'test_helper'
+require 'test_factory'
 
 class SitemapsHelperTest < ActionView::TestCase
+  fixtures :page_routes
+  
+  context 'xml_url' do
+    setup do
+      page_routes(:new_article).reload_routes
+      @news = create_news_article :name => 'good-news', :created_at => Date.parse('2010-03-03')
+      flunk "Expected news article not to respond to path" if @news.respond_to?(:path)
+      @page = create_page :path => '/home'
+      flunk "Expected page to respond to path" unless @page.respond_to?(:path)
+    end
+    should 'handle objects which has path' do
+      assert_equal "http://test.host/home", xml_url(@page)
+    end
+    should 'handle objects which does not have path' do
+      assert_equal "http://test.host/news/articles/2010/03/02/good-news", xml_url(@news)
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: bcms_sitemap
 version: !ruby/object:Gem::Version 
-  version: 0.9.0
+  version: 0.9.1
 platform: ruby
 authors: 
 - Knut Stenmark
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-17 00:00:00 +01:00
+date: 2010-03-03 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency