bbc-a11y 0.3.0 → 0.3.1

data/lib/bbc/a11y/js/standards.js

@@ -1,8 +1,9 @@
 var xpath = require('./xpath');
 
-function Standards(standards, skipped) {
+function Standards(standards, skipped, only) {
   this.standards = standards;
   this.skipped = skipped;
+  this.only = only;
 }
 
 Standards.sections = {
@@ -87,7 +88,7 @@ Standards.matching = function(criteria) {
     return Standards.matching({});
   }
   if (typeof(criteria) == 'string') {
-    return Standards.matching({ only: criteria });
+    return Standards.matching({ only: [criteria] });
   }
   var matching = standardsMatching(criteria);
   return new Standards(matching.matches, matching.skipped);
@@ -98,15 +99,17 @@ function standardsMatching(criteria) {
   for (var i = 0; i < skips.length; ++i) {
     skips[i] = normaliseStandardName(skips[i]);
   }
-  var isOnly = typeof(criteria.only) == 'string';
-  var only = isOnly ? normaliseStandardName(criteria.only) : null;
+  var onlies = criteria.only || [];
+  for (var i = 0; i < onlies.length; ++i) {
+    onlies[i] = normaliseStandardName(onlies[i]);
+  }
   var matches = [];
   var skipped = [];
   for (var i = 0; i < Standards.all.length; ++i) {
     var standard = Standards.all[i];
     var name = standard.section.toLowerCase() + normaliseStandardName(standard.name);
-    if (isOnly) {
-      if (only == name) {
+    if (onlies.length > 0) {
+      if (onlies.indexOf(name) > -1) {
         matches.push(standard);
       } else {
         skipped.push(standard.name);

data/lib/bbc/a11y/linter.rb

@@ -5,7 +5,7 @@ module BBC
       def lint(page_settings)
         browser.visit page_settings.url
         browser.execute_script(BBC::A11y::Javascript.bundle)
-        criteria = { skip: page_settings.skipped_standards }.to_json
+        criteria = { skip: page_settings.skipped_standards, only: page_settings.only_standards }.to_json
         validation = browser.evaluate_script("a11y.validate(#{criteria})")
         LintResult.from_json(validation)
       end

data/lib/bbc/a11y/version

@@ -1 +1 @@
-0.3.0
+0.3.1

data/package.json

@@ -6,18 +6,19 @@
   "directories": {},
   "scripts": {
     "test": "karma start --single-run --browsers PhantomJS",
-    "browserify": "browserify ./lib/bbc/a11y/js/a11y.js -o ./lib/bbc/a11y/js/bundle.js"
+    "browserify": "browserify ./lib/bbc/a11y/js/a11y.js -o ./lib/bbc/a11y/js/bundle.js",
+    "watchify": "watchify ./lib/bbc/a11y/js/a11y.js -o ./lib/bbc/a11y/js/bundle.js"
   },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/cucumber-ltd/bbc-a11y.git"
+    "url": "git+https://github.com/bbc/bbc-a11y.git"
   },
   "author": "",
   "license": "ISC",
   "bugs": {
-    "url": "https://github.com/cucumber-ltd/bbc-a11y/issues"
+    "url": "https://github.com/bbc/bbc-a11y/issues"
   },
-  "homepage": "https://github.com/cucumber-ltd/bbc-a11y#readme",
+  "homepage": "https://github.com/bbc/bbc-a11y#readme",
   "devDependencies": {
     "browser-monkey": "^1.26.3",
     "browserify": "^12.0.1",

data/spec/bbc/a11y/configuration_spec.rb

@@ -19,31 +19,5 @@ module BBC::A11y
       expect(configuration.pages[1].url).to eq "two.html"
     end
 
-    it "allows you to specify settings for all pages matching a given URL pattern" do
-      configuration = BBC::A11y.configure do
-        page "three.html" do
-          skip_standard /^Foo/
-        end
-        page "four.html"
-        page "five.html"
-
-        for_pages_matching /^f/ do
-          skip_standard /^Bar/
-        end
-
-        for_pages_matching /^five/ do
-          skip_standard /^Baz/
-        end
-      end
-
-      bar = double(name: "BarStandard")
-      baz = double(name: "BazStandard")
-      four_page_settings = configuration.pages[1]
-      expect(four_page_settings.skip_standard?(bar)).to be_truthy
-      five_page_settings = configuration.pages[2]
-      expect(five_page_settings.skip_standard?(bar)).to be_truthy
-      expect(five_page_settings.skip_standard?(baz)).to be_truthy
-    end
-
   end
 end

data/spec/bbc/a11y/js/a11ySpec.js

@@ -48,4 +48,10 @@ describe('a11y', function() {
     var validation = a11y.validate({ skip: ['Main landmark: Exactly one main landmark'] });
     expect(validation.skipped).to.eql(['Exactly one main landmark']);
   });
+
+  it('only runs specific standards', function() {
+    var validation = a11y.validate({ only: ['Main landmark: Exactly one main landmark'] });
+    expect(validation.results.length).to.equal(1)
+    expect(validation.results[0].standard.name).to.equal('Exactly one main landmark')
+  });
 });

data/spec/bbc/a11y/js/minimumTextSizeStandardSpec.js

@@ -22,4 +22,12 @@ describe('minimum text size standard', function() {
     standard.validate($, fail);
     expect(failures).to.eql([]);
   });
+
+  it('only reports the parent element when a child element also has small fonts', function() {
+    $('<div style="font-size: 1px"><span style="font-size: 2px">Text!</span></div>').appendTo('body');
+    var failures = [];
+    var fail = function(failure) { failures.push(failure); }
+    standard.validate($, fail);
+    expect(failures).to.eql(['Text size too small (2px):']);
+  });
 });

data/spec/bbc/a11y/js/standardsSpec.js

@@ -23,9 +23,9 @@ describe('standards', function() {
     });
   });
 
-  describe('.matching({ only: "Focusable controls: Anchors must have hrefs" })', function() {
+  describe('.matching({ only: ["Focusable controls: Anchors must have hrefs"] })', function() {
     it('finds one standard', function() {
-      var matches = standards.matching({ only: "Focusable controls: Anchors must have hrefs" });
+      var matches = standards.matching({ only: ["Focusable controls: Anchors must have hrefs"] });
       expect(matches.standards.length).to.equal(1);
     });
   });

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bbc-a11y
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Matt Wynne
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-11 00:00:00.000000000 Z
+date: 2016-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -140,6 +140,7 @@ files:
 - CONTRIBUTING.md
 - GETTINGSTARTED.md
 - Gemfile
+- HISTORY.md
 - LICENSE
 - README.md
 - Rakefile
@@ -241,10 +242,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
-summary: bbc-a11y-0.3.0
+summary: bbc-a11y-0.3.1
 test_files:
 - features/README.md
 - features/check_standards/01_core_purpose.feature