batch_api 0.2.0 → 0.2.1

data/spec/integration/shared_examples.rb

@@ -1,3 +1,24 @@
+shared_examples_for "a get request" do
+  it "returns the body as objects" do
+    @result = JSON.parse(response.body)["results"][0]
+    @result["body"].should == get_result[:body]
+  end
+
+  it "returns the expected status" do
+    @result["status"].should == get_result[:status]
+  end
+
+  it "returns the expected headers" do
+    @result["headers"].should include(get_result[:headers])
+  end
+
+  it "verifies that the right headers were received" do
+    @result["headers"]["REQUEST_HEADERS"].should include(
+      headerize(get_headers)
+    )
+  end
+end
+
 shared_examples_for "integrating with a server" do
   def headerize(hash)
     Hash[hash.map do |k, v|
@@ -25,6 +46,12 @@ shared_examples_for "integrating with a server" do
     params: get_params
   } }
 
+  let(:get_by_default_request) { {
+    url: "/endpoint",
+    headers: get_headers,
+    params: get_params
+  } }
+
   let(:get_result) { {
     status: 422,
     body: {
@@ -123,7 +150,8 @@ shared_examples_for "integrating with a server" do
         missing_request,
         parameter_request,
         silent_request,
-        failed_silent_request
+        failed_silent_request,
+        get_by_default_request
       ],
       sequential: true
     }.to_json, "CONTENT_TYPE" => "application/json"
@@ -138,29 +166,20 @@ shared_examples_for "integrating with a server" do
   end
 
   context "for a get request" do
-    describe "the response" do
+    describe "with an explicit get" do
       before :each do
         @result = JSON.parse(response.body)["results"][0]
       end
 
-      it "returns the body as objects" do
-        @result = JSON.parse(response.body)["results"][0]
-        @result["body"].should == get_result[:body]
-      end
-
-      it "returns the expected status" do
-        @result["status"].should == get_result[:status]
-      end
+      it_should_behave_like "a get request"
+    end
 
-      it "returns the expected headers" do
-        @result["headers"].should include(get_result[:headers])
+    describe "with no method" do
+      before :each do
+        @result = JSON.parse(response.body)["results"][7]
       end
 
-      it "verifies that the right headers were received" do
-        @result["headers"]["REQUEST_HEADERS"].should include(
-          headerize(get_headers)
-        )
-      end
+      it_should_behave_like "a get request"
     end
   end
 
@@ -182,15 +201,7 @@ shared_examples_for "integrating with a server" do
         @result = JSON.parse(response.body)["results"][1]
       end
 
-      it "returns the body raw if decode_json_responses = false" do
-        # BatchApi.config.decode_bodies = false
-        xhr :post, "/batch", {ops: [post_request], sequential: true}.to_json,
-          "CONTENT_TYPE" => "application/json"
-        @result = JSON.parse(response.body)["results"][0]
-        @result["body"].should == JSON.parse(post_result[:body].to_json)
-      end
-
-      it "returns the body as objects if decode_json_responses = true" do
+      it "returns the body as objects (since DecodeJsonBody is default)" do
         @result["body"].should == post_result[:body]
       end
 

data/spec/lib/operation/rack_spec.rb

@@ -40,6 +40,11 @@ describe BatchApi::Operation::Rack do
       operation.options.should == op_params
     end
 
+    it "defaults method to get if not provided" do
+      op = BatchApi::Operation::Rack.new(op_params.except("method"), env, app)
+      op.method.should == "get"
+    end
+
     it "defaults params to {} if not provided" do
       op = BatchApi::Operation::Rack.new(op_params.except("params"), env, app)
       op.params.should == {}
@@ -63,21 +68,11 @@ describe BatchApi::Operation::Rack do
       end
     end
 
-    it "raises a MalformedOperationError if method or URL are missing" do
-      no_method = op_params.dup.tap {|o| o.delete("method") }
-      expect {
-        BatchApi::Operation::Rack.new(no_method, env, app)
-      }.to raise_exception(BatchApi::Errors::MalformedOperationError)
-
+    it "raises a MalformedOperationError if URL is missing" do
       no_url = op_params.dup.tap {|o| o.delete("url") }
       expect {
         BatchApi::Operation::Rack.new(no_url, env, app)
       }.to raise_exception(BatchApi::Errors::MalformedOperationError)
-
-      nothing = op_params.dup.tap {|o| o.delete("url"); o.delete("method") }
-      expect {
-        BatchApi::Operation::Rack.new(nothing, env, app)
-      }.to raise_exception(BatchApi::Errors::MalformedOperationError)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: batch_api
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-11 00:00:00.000000000 Z
+date: 2012-10-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: middleware
@@ -226,7 +226,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1297509053132292607
+      hash: -4458634048209158378
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -235,7 +235,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 1297509053132292607
+      hash: -4458634048209158378
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24