basketball 0.0.8 → 0.0.9

data/lib/basketball/season/coordinator.rb

@@ -1,179 +1,238 @@
 # frozen_string_literal: true
 
-require_relative 'calendar'
-
 module Basketball
   module Season
-    # This is the service class responsible for actually picking out free dates ane pairing up teams to
-    # play each other.  This is a reasonable naive first pass at some underlying match-making algorithms
-    # but could definitely use some help with the complexity/runtime/etc.
+    # Main iterator-based object that knows how to manage a calendar and simulate games per day.
     class Coordinator
-      MIN_PRESEASON_GAMES_PER_TEAM = 3
-      MAX_PRESEASON_GAMES_PER_TEAM = 6
+      extend Forwardable
+
+      class AlreadyPlayedGameError < StandardError; end
+      class GameNotCurrentError < StandardError; end
+      class OutOfBoundsError < StandardError; end
+      class PlayedGamesError < StandardError; end
+      class UnknownGameError < StandardError; end
+      class UnknownTeamError < StandardError; end
+      class UnplayedGamesError < StandardError; end
+
+      attr_reader :calendar,
+                  :current_date,
+                  :arena,
+                  :results,
+                  :league,
+                  :id
+
+      def_delegators :calendar,
+                     :preseason_start_date,
+                     :preseason_end_date,
+                     :season_start_date,
+                     :season_end_date,
+                     :games,
+                     :exhibitions_for,
+                     :regulars_for,
+                     :games_for
+
+      def initialize(
+        calendar:,
+        current_date:,
+        results: [],
+        league: Org::League.new
+      )
+        super()
+
+        raise ArgumentError, 'calendar is required' unless calendar
+        raise ArgumentError, 'current_date is required' if current_date.to_s.empty?
+        raise ArgumentError, 'league is required' unless league
+
+        @calendar     = calendar
+        @current_date = current_date
+        @arena        = Arena.new
+        @results      = []
+        @league       = league
+
+        results.each { |result| replay!(result) }
+
+        assert_current_date
+        assert_all_past_dates_are_played
+        assert_all_future_dates_arent_played
+        assert_all_known_teams
+      end
 
-      private_constant :MIN_PRESEASON_GAMES_PER_TEAM,
-                       :MAX_PRESEASON_GAMES_PER_TEAM
+      def sim_rest!(&)
+        events = []
 
-      def schedule(year:, league:)
-        Calendar.new(year:).tap do |calendar|
-          schedule_preseason!(calendar:, league:)
-          schedule_season!(calendar:, league:)
+        while not_done?
+          new_events = sim!(&)
+
+          events += new_events
         end
-      end
 
-      private
+        events
+      end
 
-      def base_matchup_count(league, team1, team2)
-        # Same Conference, Same Division
-        if league.division_for(team1) == league.division_for(team2)
-          4
-        # Same Conference, Different Division  and one of 4/10 that play 3 times
-        elsif league.conference_for(team1) == league.conference_for(team2)
-          3
-        # Different Conference
-        else
-          2
+      def assert_current_date
+        if current_date < preseason_start_date
+          raise OutOfBoundsError, "current date #{current_date} should be on or after #{preseason_start_date}"
         end
+
+        return unless current_date > season_end_date
+
+        raise OutOfBoundsError, "current date #{current_date} should be on or after #{preseason_start_date}"
       end
 
-      # rubocop:disable Metrics/AbcSize
-      # This method derives the plan for which a schedule can be generated from.
-      def matchup_plan(league)
-        matchups    = {}
-        game_counts = league.teams.to_h { |t| [t, 0] }
-        teams       = game_counts.keys
-
-        (0...teams.length).each do |i|
-          team1 = teams[i]
-
-          (i + 1...teams.length).each do |j|
-            team2              = teams[j]
-            key                = [team1, team2].sort
-            count              = base_matchup_count(league, team1, team2)
-            matchups[key]      = count
-            game_counts[team1] += count
-            game_counts[team2] += count
-          end
-        end
+      def sim!
+        return [] if done?
 
-        # Each team will play 6 games against conference opponents in other divisions.
-        # The fours hash will be that plan.
-        find_fours(league).each do |team, opponents|
-          next if game_counts[team] == 82
+        events = []
+        games  = games_for(date: current_date)
 
-          opponents.each do |opponent|
-            next if game_counts[team] == 82
-            next if game_counts[opponent] == 82
+        games.each do |game|
+          home_players = opponent_team(game.home_opponent).players
+          away_players = opponent_team(game.away_opponent).players
+          matchup      = Matchup.new(game:, home_players:, away_players:)
+          event        = arena.play(matchup)
 
-            game_counts[team] += 1
-            game_counts[opponent] += 1
+          play!(event)
 
-            key = [team, opponent].sort
+          yield(event) if block_given?
 
-            matchups[key] += 1
-          end
+          events << event
         end
 
-        matchups
-      end
-      # rubocop:enable Metrics/AbcSize
+        increment_current_date!
 
-      # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
-      # I am not liking this algorithm implementation at all but it will seemingly produce a valid
-      # result about 1 out of every 1000 cycles. I have yet to spot the assignment pattern to make
-      # this way more deterministic.
-      def find_fours(league)
-        balanced     = false
-        count        = 0
-        four_tracker = {}
+        events
+      end
 
-        until balanced
-          # Let's not completely thrash our CPUs in case this algorithm hits an infinite loop.
-          # Instead, lets hard-fail against a hard boundary.
-          raise ArgumentError, 'we spent too much CPU time and didnt resolve fours' if count > 100_000
+      def total_days
+        (season_end_date - preseason_start_date).to_i
+      end
 
-          four_tracker = league.teams.to_h { |team| [team, []] }
+      def days_left
+        (season_end_date - current_date).to_i
+      end
 
-          league.teams.each do |team|
-            opponents = league.cross_division_opponents_for(team).shuffle
+      def total_exhibitions
+        exhibitions_for.length
+      end
 
-            opponents.each do |opponent|
-              if four_tracker[team].length < 6 && four_tracker[opponent].length < 6
-                four_tracker[opponent] << team
-                four_tracker[team] << opponent
-              end
-            end
-          end
+      def exhibitions_left
+        total_exhibitions - exhibition_result_events.length
+      end
 
-          good = true
+      def total_regulars
+        regulars_for.length
+      end
 
-          # trip-wire: if one team isnt balanced then we are not balanced
-          four_tracker.each { |_k, v| good = false if v.length < 6 }
+      def regulars_left
+        total_regulars - regular_result_events.length
+      end
 
-          balanced = good
+      def current_games
+        games_for(date: current_date) - results.map(&:game)
+      end
 
-          count += 1
-        end
+      def done?
+        current_date == season_end_date && games.length == results.length
+      end
 
-        four_tracker
+      def not_done?
+        !done?
       end
-      # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
-      def schedule_season!(calendar:, league:)
-        matchups = matchup_plan(league)
+      def add!(game)
+        assert_today_or_in_future(game)
+        assert_known_teams(game)
 
-        matchups.each do |(team1, team2), count|
-          candidates = calendar.available_season_matchup_dates(team1, team2)
-          dates      = candidates.sample(count)
-          games      = balanced_games(dates, team1, team2)
+        calendar.add!(game)
 
-          games.each { |game| calendar.add!(game) }
-        end
+        self
       end
 
-      def balanced_games(dates, team1, team2)
-        dates.map.with_index(1) do |date, index|
-          if index.even?
-            SeasonGame.new(date:, home_team: team1, away_team: team2)
-          else
-            SeasonGame.new(date:, home_team: team2, away_team: team1)
-          end
+      def result_for(game)
+        results.find do |result|
+          result.game == game
         end
       end
 
-      def schedule_preseason!(calendar:, league:)
-        league.teams.each do |team|
-          current_games = calendar.preseason_games_for(team:)
-          count         = current_games.length
+      private
+
+      attr_writer :id, :arena
+
+      def opponent_team(opponent)
+        league.teams.find { |t| t == opponent }
+      end
+
+      def exhibition_result_events
+        results.select { |e| e.game.is_a?(Exhibition) }
+      end
 
-          next if count >= MIN_PRESEASON_GAMES_PER_TEAM
+      def regular_result_events
+        results.select { |e| e.game.is_a?(Regular) }
+      end
 
-          other_teams = (league.teams - [team]).shuffle
+      def increment_current_date!
+        return self if current_date >= season_end_date
 
-          other_teams.each do |other_team|
-            break if count > MIN_PRESEASON_GAMES_PER_TEAM
-            next  if calendar.preseason_games_for(team: other_team).length >= MAX_PRESEASON_GAMES_PER_TEAM
+        @current_date = current_date + 1
 
-            candidates = calendar.available_preseason_matchup_dates(team, other_team)
+        self
+      end
 
-            next if candidates.empty?
+      def assert_today_or_in_future(game)
+        return unless game.date <= current_date
 
-            date = candidates.sample
-            game = random_preseason_game(date, team, other_team)
+        raise OutOfBoundsError, "#{game.date} is on or before the current date (#{current_date})"
+      end
 
-            calendar.add!(game)
+      def assert_known_teams(game)
+        raise UnknownTeamError, "unknown opponent: #{game.home_opponent}" if league.not_registered?(game.home_opponent)
 
-            count += 1
-          end
-        end
+        return unless league.not_registered?(game.away_opponent)
+
+        raise UnknownTeamError, "unknown opponent: #{game.away_opponent}"
       end
 
-      def random_preseason_game(date, team1, team2)
-        if rand(1..2) == 1
-          PreseasonGame.new(date:, home_team: team1, away_team: team2)
-        else
-          PreseasonGame.new(date:, home_team: team2, away_team: team1)
+      def assert_all_past_dates_are_played
+        games_that_should_be_played = games.select { |game| game.date < current_date }
+
+        games_played   = results.map(&:game)
+        unplayed_games = games_that_should_be_played - games_played
+
+        return if unplayed_games.empty?
+
+        raise UnplayedGamesError, "#{unplayed_games.length} game(s) not played before #{current_date}"
+      end
+
+      def assert_all_future_dates_arent_played
+        games_that_shouldnt_be_played = results.select do |result|
+          result.date > current_date
         end
+
+        count = games_that_shouldnt_be_played.length
+
+        return unless games_that_shouldnt_be_played.any?
+
+        raise PlayedGamesError, "#{count} game(s) played after #{current_date}"
+      end
+
+      def play!(result)
+        raise GameNotCurrentError, "#{result} is not for #{current_date}" if result.date != current_date
+
+        replay!(result)
+      end
+
+      def replay!(result)
+        raise AlreadyPlayedGameError, "#{result.game} already played!" if result_for(result.game)
+
+        raise UnknownGameError, "game not added: #{result.game}" unless games.include?(result.game)
+
+        results << result
+
+        result
+      end
+
+      def assert_all_known_teams
+        calendar.games.each { |game| assert_known_teams(game) }
       end
     end
   end

data/lib/basketball/season/{preseason_game.rb → exhibition.rb}

@@ -2,7 +2,8 @@
 
 module Basketball
   module Season
-    class PreseasonGame < Game
+    # An exhibition game.
+    class Exhibition < Game
       def to_s
         "#{super} (preseason)"
       end

data/lib/basketball/season/game.rb

@@ -2,30 +2,35 @@
 
 module Basketball
   module Season
+    # Base class describing what all games have in common.
     class Game < ValueObject
-      attr_reader_value :date, :home_team, :away_team
+      value_reader :date, :home_opponent, :away_opponent
 
-      def initialize(date:, home_team:, away_team:)
+      def initialize(date:, home_opponent:, away_opponent:)
         super()
 
         raise ArgumentError, 'date is required'             unless date
-        raise ArgumentError, 'home_team is required'        unless home_team
-        raise ArgumentError, 'away_team is required'        unless away_team
-        raise ArgumentError, 'teams cannot play themselves' if home_team == away_team
+        raise ArgumentError, 'home_opponent is required'    unless home_opponent
+        raise ArgumentError, 'away_opponent is required'    unless away_opponent
+        raise ArgumentError, 'teams cannot play themselves' if home_opponent == away_opponent
 
-        @date      = date
-        @home_team = home_team
-        @away_team = away_team
+        @date          = date
+        @home_opponent = home_opponent
+        @away_opponent = away_opponent
 
         freeze
       end
 
+      def for?(team)
+        teams.include?(team)
+      end
+
       def teams
-        [home_team, away_team]
+        [home_opponent, away_opponent]
       end
 
       def to_s
-        "#{date} - #{away_team} at #{home_team}"
+        "#{date} - #{away_opponent} at #{home_opponent}"
       end
     end
   end

data/lib/basketball/season/matchup.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module Basketball
+  module Season
+    # A Matchup is a late materialization of a game.  While a game is a skeleton for a future
+    # matchup, it does not materialize until game time (rosters could change right up until game time).
+    class Matchup
+      class PlayersOnBothTeamsError < StandardError; end
+
+      attr_reader :game, :home_players, :away_players
+
+      def initialize(game:, home_players: [], away_players: [])
+        raise ArgumentError, 'game is required' unless game
+
+        @game         = game
+        @home_players = home_players.uniq
+        @away_players = away_players.uniq
+
+        if home_players.intersect?(away_players)
+          raise PlayersOnBothTeamsError, 'players cannot be on both home and away team'
+        end
+
+        freeze
+      end
+    end
+  end
+end

data/lib/basketball/season/opponent.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module Basketball
+  module Season
+    # Represents a team without a roster.  Equal to a team by identity.
+    # A team's roster will not be known until the last minute (when it is game time).
+    class Opponent < Entity
+      def initialize(id:)
+        super(id)
+
+        freeze
+      end
+    end
+  end
+end

data/lib/basketball/season/{season_game.rb → regular.rb}

@@ -2,7 +2,8 @@
 
 module Basketball
   module Season
-    class SeasonGame < Game
+    # A regular season game.
+    class Regular < Game
     end
   end
 end

data/lib/basketball/season/result.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module Basketball
+  module Season
+    # Base class describing the end result of a game.  This should/could be sub-classed to include
+    # more sport-specific information.
+    class Result
+      extend Forwardable
+
+      class CannotTieError < StandardError; end
+
+      attr_reader :game, :home_score, :away_score
+
+      def_delegators :game, :date, :home_opponent, :away_opponent, :teams
+
+      def initialize(game:, home_score:, away_score:)
+        raise ArgumentError, 'game is required' unless game
+        raise CannotTieError, "#{game} ended in a tie" if home_score == away_score
+
+        @game       = game
+        @home_score = home_score.to_i
+        @away_score = away_score.to_i
+      end
+
+      def to_s
+        "#{game.date} - #{away_opponent} (#{away_score}) at #{home_opponent} (#{home_score})"
+      end
+
+      def ==(other)
+        game == other.game &&
+          home_score == other.home_score &&
+          away_score == other.away_score
+      end
+      alias eql? ==
+    end
+  end
+end

data/lib/basketball/season.rb

@@ -1,17 +1,16 @@
 # frozen_string_literal: true
 
-require_relative 'season/scheduling_cli'
+# Common
+require_relative 'season/arena'
+require_relative 'season/calendar'
+require_relative 'season/result'
+require_relative 'season/game'
+require_relative 'season/matchup'
+require_relative 'season/opponent'
 
-module Basketball
-  module Season
-    class ConferenceAlreadyRegisteredError < StandardError; end
-    class DivisionAlreadyRegisteredError < StandardError; end
-    class TeamAlreadyRegisteredError < StandardError; end
+# Game Subclasses
+require_relative 'season/exhibition'
+require_relative 'season/regular'
 
-    class BadConferencesSizeError < StandardError; end
-    class BadDivisionsSizeError < StandardError; end
-    class BadTeamsSizeError < StandardError; end
-
-    class UnknownTeamError < StandardError; end
-  end
-end
+# Specific
+require_relative 'season/coordinator'

data/lib/basketball/value_object.rb

@@ -1,6 +1,9 @@
 # frozen_string_literal: true
 
 module Basketball
+  # A Value Object is something that has no specific identity, instead its identity is the sum of
+  # the attribute values. Changing one will change the entire object's identity.
+  # Comes with a very simple DSL for specifying properties along with base equality and sorting methods.
   class ValueObject
     include Comparable
 
@@ -23,7 +26,7 @@ module Basketball
         @value_keys ||= []
       end
 
-      def attr_reader_value(*keys)
+      def value_reader(*keys)
         keys.each { |k| value_keys << k.to_sym }
 
         attr_reader(*keys)

data/lib/basketball/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Basketball
-  VERSION = '0.0.8'
+  VERSION = '0.0.9'
 end

data/lib/basketball.rb

@@ -1,16 +1,21 @@
 # frozen_string_literal: true
 
-require 'faker'
+require 'date'
 require 'fileutils'
 require 'forwardable'
 require 'json'
-require 'securerandom'
 require 'slop'
 
-# Top-level
+# Generic
 require_relative 'basketball/entity'
 require_relative 'basketball/value_object'
 
-# Submodules
+# Dependent on Generic
+require_relative 'basketball/org'
+
+# Dependent on Org
 require_relative 'basketball/draft'
 require_relative 'basketball/season'
+
+# Dependent on All
+require_relative 'basketball/app'