basketball 0.0.15 → 0.0.17

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27530180da34588494d04824d1fe1e9a6bfd4e0d94adc98afde3f659b070759c
-  data.tar.gz: 4f8e961e2e8ac1bedd5d0869d5f5f8e0e2498cb24465ef0d4505f20d4219b7fc
+  metadata.gz: 7f2c7326c8bfa26bcedb1ccbedec191db4681bed0831d5f37bb7691782a12ae4
+  data.tar.gz: c22558bd6733383f7926ee33506b86eb9bb8f4fa0807d8eb246d8a8b2912041b
 SHA512:
-  metadata.gz: bbb24ef7d1f192e39dd3e0740d60210e47fcdc041e6b69ec8d9a2897a39514dca775439c8c2894f228afc6ef8ebedf2005a83ea7b8817d00247a69e5e0ae2177
-  data.tar.gz: 3c24e207c24e33c49baadb8bf13f8107a2bea9dc1d8bf6404601551635ef9a375f03f4b27da0b18118ef37eea55cda7d7e24b2572fd1649bc012d3a7081c9928
+  metadata.gz: f04c5f0691974ae8750d3e66eaf2be925b792b771201ee727313e3f678ca7712f2f5e22878486a682cf17c0a31cac3f38428e5a1eae7337a5b0b7929596cbc22
+  data.tar.gz: 1b6a61df353c5c4ec77935cd4a406839be050eed15ccd5f3f6c79aca701b2ed5ad09cb66efb4fda4f098e2e3fd75c76596170ed8359c2f5b6abbdc4b7ac8c194

data/.rubocop.yml

@@ -18,6 +18,9 @@ RSpec/ExampleLength:
 RSpec/NestedGroups:
   Max: 5
 
+RSpec/MultipleExpectations:
+  Max: 2
+
 Metrics/ParameterLists:
   Max: 6
 

data/README.md

@@ -14,7 +14,7 @@ Element      | Description
 **Assessment** | When the Room needs to know who a Front Office wants to select, the Room will send the Front Office an Assessment. The Assessment is a report of where the team currently stands: players picked, players available, and round information.
 **Calendar** | Stores important boundary dates (exhibition start, exhibition end, season start, and season end).
 **Conference** | A collection of Divisions.
-**Coordinator Repository** | Understands how to save and load Coordinator objects from JSON files on disk.
+**Coordinator Repository** | Understands how to save and load Coordinator objects.
 **Coordinator** | Object which can take a League, Calendar, Games, and an Arena and provide an iterable interface to enumerate through days and simulate games as results.
 **Detail** | Re-representation of a Result object but from a specific team's perspective.
 **Division** | A collection of teams.
@@ -34,13 +34,14 @@ Element      | Description
 **Record** | Represents a team's overall record.
 **Regular** | Game that counts towards regular season record.
 **Result** | The outcome of a game (typically with a home and away score).
-**Room Repository** | Understands how to save and load Room objects from JSON files on disk.
+**Room Repository** | Understands how to save and load Room objects.
 **Room** | Main object responsible for providing an iterable interface capable of executing a draft, pick by pick.
 **Scheduler** | Knows how to take a League and a year and generate a game-populated calendar.
 **Scout** | Knows how to stack rank lists of players.
 **Season** | Bounded context (sub-module) dealing with calendar and matchup generation.
 **Skip** | Result event emitted when a front office decides to skip a round.
 **Standings** | Synthesizes teams and results into team standings with win/loss records and more.
+**Standings Repository** | Understands how to save and load Standings objects.
 **Store** | Interface for the underlying Repository persistence layer.  While a Document Repository is mainly responsible for serialization/de-serialization, the store actually knows how to read/write the data.
 **Team Group** | Set of rosters that together form a cohesive league.
 **Team** | Member of a league and signs players.  Has games assigned and played.

data/lib/basketball/app/league_repository.rb

@@ -2,7 +2,7 @@
 
 module Basketball
   module App
-    # Knows how to flatten a League instance and rehydrate one from JSON and/or a Ruby hash.
+    # Knows how to flatten a League instances and rehydrate one from JSON and/or a Ruby hash.
     class LeagueRepository < DocumentRepository
       private
 

data/lib/basketball/app/room_repository.rb

@@ -2,7 +2,7 @@
 
 module Basketball
   module App
-    # Can load and save Room objects to JSON files.
+    # Can load and save Room objects as JSON Documents.
     class RoomRepository < DocumentRepository
       PICK_EVENT = 'Pick'
       SKIP_EVENT = 'Skip'
@@ -66,6 +66,7 @@ module Basketball
 
       def serialize_pick(event)
         {
+          id: event.id || event.pick,
           type: PICK_EVENT,
           front_office: event.front_office.id,
           pick: event.pick,
@@ -78,6 +79,7 @@ module Basketball
 
       def serialize_skip(event)
         {
+          id: event.id || event.pick,
           type: SKIP_EVENT,
           front_office: event.front_office.id,
           pick: event.pick,
@@ -141,11 +143,16 @@ module Basketball
           front_office_id = hash[:front_office]
           front_office    = front_offices.find { |fo| fo.id == front_office_id }
 
-          case hash[:type]
-          when PICK_EVENT
-            deserialize_pick(hash, players:, front_office:)
-          when SKIP_EVENT
-            deserialize_skip(hash, front_office:)
+          event =
+            case hash[:type]
+            when PICK_EVENT
+              deserialize_pick(hash, players:, front_office:)
+            when SKIP_EVENT
+              deserialize_skip(hash, front_office:)
+            end
+
+          event.tap do |e|
+            e.send('id=', hash[:id])
           end
         end
       end

data/lib/basketball/app/standings_repository.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+module Basketball
+  module App
+    # Can load and save Standings objects as JSON Documents.
+    class StandingsRepository < DocumentRepository
+      private
+
+      def from_h(hash)
+        Season::Standings.new(
+          records: deserialize_records(hash[:records])
+        )
+      end
+
+      def to_h(standings)
+        {
+          id: standings.id,
+          records: serialize_records(standings.records)
+        }
+      end
+
+      # Serialization
+
+      def serialize_records(records)
+        (records || []).map do |record|
+          {
+            id: record.id,
+            details: serialize_details(record.details)
+          }
+        end
+      end
+
+      def serialize_details(details)
+        (details || []).map do |detail|
+          {
+            date: detail.date.to_s,
+            home: detail.home,
+            opponent: detail.opponent.id,
+            opponent_score: detail.opponent_score,
+            score: detail.score
+          }
+        end
+      end
+
+      # Deserialization
+
+      def deserialize_records(record_hashes)
+        (record_hashes || []).map do |record_hash|
+          Season::Record.new(
+            id: record_hash[:id],
+            details: deserialize_details(record_hash[:details])
+          )
+        end
+      end
+
+      def deserialize_details(detail_hashes)
+        (detail_hashes || []).map do |detail_hash|
+          Season::Detail.new(
+            date: Date.parse(detail_hash[:date]),
+            home: detail_hash[:home],
+            opponent: Season::Opponent.new(id: detail_hash[:opponent]),
+            opponent_score: detail_hash[:opponent_score].to_i,
+            score: detail_hash[:score].to_i
+          )
+        end
+      end
+    end
+  end
+end

data/lib/basketball/app.rb

@@ -11,3 +11,4 @@ require_relative 'app/document_repository'
 require_relative 'app/coordinator_repository'
 require_relative 'app/league_repository'
 require_relative 'app/room_repository'
+require_relative 'app/standings_repository'

data/lib/basketball/draft/event.rb

@@ -3,8 +3,8 @@
 module Basketball
   module Draft
     # Describes what all Room events have to have to be considered an "event".
-    class Event < ValueObject
-      value_reader :pick, :round, :round_pick, :front_office
+    class Event < Entity
+      attr_reader :pick, :round, :round_pick, :front_office
 
       def initialize(front_office:, pick:, round:, round_pick:)
         super()
@@ -18,7 +18,7 @@ module Basketball
       end
 
       def to_s
-        "[##{pick} R:#{round} P:#{round_pick}] #{front_office}"
+        "[#{id}] ##{pick} R:#{round} P:#{round_pick} - #{front_office}"
       end
     end
   end

data/lib/basketball/draft/pick.rb

@@ -4,7 +4,7 @@ module Basketball
   module Draft
     # Room event where a player is selected.
     class Pick < Event
-      value_reader :player, :auto
+      attr_reader :player, :auto
 
       def initialize(front_office:, player:, pick:, round:, round_pick:, auto: false)
         super(front_office:, pick:, round:, round_pick:)
@@ -13,8 +13,6 @@ module Basketball
 
         @player = player
         @auto   = auto
-
-        freeze
       end
 
       def to_s

data/lib/basketball/season/record.rb

@@ -8,7 +8,7 @@ module Basketball
       class DetailAlreadyAddedError < StandardError; end
       class OpponentNotFoundError < StandardError; end
 
-      def initialize(id:)
+      def initialize(id:, details: [])
         super(id)
 
         @details_by_date = {}
@@ -53,9 +53,15 @@ module Basketball
       end
 
       def win_percentage
+        return 0 unless game_count.positive?
+
         (win_count.to_f / game_count).round(3)
       end
 
+      def win_percentage_display
+        format('%.3f', win_percentage)
+      end
+
       def game_count
         details.length
       end
@@ -69,17 +75,13 @@ module Basketball
       end
 
       def to_s
-        "[#{super}] #{win_count}-#{loss_count} (#{win_percentage})"
+        "[#{super}] #{win_count}-#{loss_count} (#{win_percentage_display})"
       end
 
       def <=>(other)
         [win_count, win_percentage] <=> [other.win_count, other.win_percentage]
       end
 
-      private
-
-      attr_reader :details_by_date
-
       def add!(detail)
         raise DetailAlreadyAddedError, "#{detail} already added for date" if detail_for(detail.date)
 
@@ -87,6 +89,10 @@ module Basketball
 
         self
       end
+
+      private
+
+      attr_reader :details_by_date
     end
   end
 end

data/lib/basketball/season/standings.rb

@@ -3,18 +3,29 @@
 module Basketball
   module Season
     # Represents a League with each team's win/loss details.
-    class Standings
+    class Standings < Entity
       class TeamAlreadyRegisteredError < StandardError; end
       class TeamNotRegisteredError < StandardError; end
 
-      def initialize
+      def initialize(records: [])
+        super()
+
         @records_by_id = {}
+
+        records.each { |record| add!(record) }
       end
 
-      def register!(team)
-        raise TeamAlreadyRegisteredError, "#{team} already registered!" if team?(team)
+      def add!(record)
+        raise ArgumentError, 'record is required' unless record
+        raise TeamAlreadyRegisteredError, "#{team} already registered!" if team?(record)
+
+        records_by_id[record.id] = record
 
-        records_by_id[team.id] = Record.new(id: team.id)
+        self
+      end
+
+      def register!(team)
+        add!(Record.new(id: team.id))
 
         self
       end

data/lib/basketball/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Basketball
-  VERSION = '0.0.15'
+  VERSION = '0.0.17'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: basketball
 version: !ruby/object:Gem::Version
-  version: 0.0.15
+  version: 0.0.17
 platform: ruby
 authors:
 - Matthew Ruggio
@@ -40,6 +40,7 @@ files:
 - lib/basketball/app/in_memory_store.rb
 - lib/basketball/app/league_repository.rb
 - lib/basketball/app/room_repository.rb
+- lib/basketball/app/standings_repository.rb
 - lib/basketball/draft.rb
 - lib/basketball/draft/assessment.rb
 - lib/basketball/draft/event.rb