basket 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d504bc414e4f443644bd06aa327dbeaabd175ff27b0ec29ef29a9c39a699f62f
-  data.tar.gz: 11ad15d5ce03c2876d4ae11bb555df30497c5901474eeceeaf7e12a3ccedbb7b
+  metadata.gz: 0a3e9da361b2587c986144240ada1490a812ae9a9d0f6f639c0e38c167874ac8
+  data.tar.gz: 936a8d8b31d126cd35913cc1c087ecffbca722a2d5cc06747b23f26ba90d9055
 SHA512:
-  metadata.gz: 243ffd026cdf35b1e8a284c6c7f4f518f0ebb552ec89cc7fa6eca98ae481d1122db2f67d442a7e0b39e0efe89ada816f7d1d5ad2a4ae5f8eba7bde070c1dad5a
-  data.tar.gz: e290079ae4dd146465549cb5d891eb7739dbb9e3b807f23a4d2406d4a74dbc52b1de4305dd276b98312ec7be1b1c9feb92373e47dc8d71c4ee7017d3f00258d0
+  metadata.gz: 551534c644dbb4a269f2de9de81ae43aef66f7e41dedef2e27845d4edcd17584d74067339110611628052282f5601ca9d5c39dd7962a4a71103110b9d1b37b1a
+  data.tar.gz: 96af7b3698edec4b70b3fa13acbb007ee17a03750c2df6583ed42df0e144bc32da8074378425ac24a655e6630070d2bcadd5b9870f2e4523804003fcdbd72fb6

data/.ruby-version

@@ -0,0 +1 @@
+3.1.0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    basket (0.0.5)
+    basket (0.0.6)
       redis
       redis-namespace
 

data/README.md

@@ -32,7 +32,7 @@ while chicken.laying? do
 end
 ```
 
-The item added to the basket can be any data you want!  If you are using the in memory Queue, it is fine to store Ruby objects, but if you have a different backend, it might be better to stick to easily serializable objects.
+The item added to the basket can be any data you want!  If you are using the in memory Queue, it is fine to store Ruby objects, but if you have a different backend, must be JSON serializable via `to_json`.
 
 ```ruby
 class QuicheBasket
@@ -100,7 +100,7 @@ end
 
 The defaults for a redis backend are the standard `"127.0.0.1"`, `6379`, `15` with a namespace of `:basket`.
 
-The default for the backend is the HashBackend, which can be set by passing `:hash` to `config.backend`, but you don't have to do that.  Because it's the default!
+The default for the backend is the MemoryBackend, which can be set by passing `:memory` to `config.backend`, but you don't have to do that.  Because it's the default!
 
 For the redis configuration, you can alternatively pass a url, thusly:
 

data/lib/basket/backend_adapter/{hash_backend.rb → memory_backend.rb}

@@ -1,6 +1,6 @@
 module Basket
   class BackendAdapter
-    class HashBackend < Basket::BackendAdapter
+    class MemoryBackend < Basket::BackendAdapter
       def initialize
         @data = {}
       end

data/lib/basket/backend_adapter/redis_backend.rb

@@ -1,4 +1,5 @@
 require "redis-namespace"
+require "json"
 
 module Basket
   class BackendAdapter
@@ -25,9 +26,7 @@ module Basket
       end
 
       def push(queue, data)
-        # TODO: should we use JSON vs Marshal?
-        marshalled_data = Marshal.dump(data)
-        @client.lpush(queue, marshalled_data)
+        @client.lpush(queue, serialize_data(data))
       end
 
       def length(queue)
@@ -44,8 +43,12 @@ module Basket
 
       private
 
+      def serialize_data(data)
+        JSON.generate(data)
+      end
+
       def deserialized_queue_data(queue)
-        @client.lrange(queue, 0, -1).reverse.map { |marshalled_data| Marshal.load(marshalled_data) }
+        @client.lrange(queue, 0, -1).reverse.map { |serialized_data| JSON.parse(serialized_data) }
       end
 
       def select_redis_connection

data/lib/basket/configuration.rb

@@ -7,15 +7,15 @@ module Basket
       @redis_host = "127.0.0.1"
       @redis_port = 6379
       @redis_db = 15
-      @backend = BackendAdapter::HashBackend
+      @backend = BackendAdapter::MemoryBackend
       @namespace = :basket
       @redis_url = nil
     end
 
     def backend=(backend)
       case backend
-      when :hash
-        @backend = BackendAdapter::HashBackend
+      when :memory
+        @backend = BackendAdapter::MemoryBackend
       when :redis
         @backend = BackendAdapter::RedisBackend
       else

data/lib/basket/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Basket
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/lib/basket.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "basket/backend_adapter"
-require_relative "basket/backend_adapter/hash_backend"
+require_relative "basket/backend_adapter/memory_backend"
 require_relative "basket/backend_adapter/redis_backend"
 require_relative "basket/batcher"
 require_relative "basket/configuration"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: basket
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - nichol alexander
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-04-04 00:00:00.000000000 Z
+date: 2023-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -62,6 +62,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".rspec"
+- ".ruby-version"
 - ".standard.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
@@ -74,7 +75,7 @@ files:
 - basket.gemspec
 - lib/basket.rb
 - lib/basket/backend_adapter.rb
-- lib/basket/backend_adapter/hash_backend.rb
+- lib/basket/backend_adapter/memory_backend.rb
 - lib/basket/backend_adapter/redis_backend.rb
 - lib/basket/batcher.rb
 - lib/basket/configuration.rb
@@ -105,7 +106,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.7
+rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
 summary: Wait until you have a bunch of things, then do something.