basic_table_sorter 0.0.2.beta → 0.0.3.beta

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5d450654560793ee8c97eecee62988c0a3fdecf5
-  data.tar.gz: f3b7532e3634887b6d8ce3cab5c61707cac32e69
+  metadata.gz: db76dcc9dd75596012bba9f3d3dd4c0afbe11ebb
+  data.tar.gz: f612c2f0f9cc036be4f156c1430f8e0919dbf0cf
 SHA512:
-  metadata.gz: f240ff897add0bb33a8bb3820b9dbb635cc43a88ae6ed87ea07ae72586368fdb1c1a00b737c760d16ec3344039d6220bed25cf68297ca43af3e5fcae1244ab5a
-  data.tar.gz: f47e149a85990db0991c1be32dbafad1a5b1e46a7bdb46cab62d40476e32cc5d2a7a064b23b63cc7a13fe3f38d64a062f52e38847c43aaa590f7b46275c98250
+  metadata.gz: 1d70c381dff1c8743e3c8a7dc68a96fb53a926ae742c6850044a3b1902c299569c63a66018166ccadd78429bfd87bd255a31913fbbc5e555d1a4c90f4e456118
+  data.tar.gz: fc98d2bec5e1f01e3546f0e209d13b65f8bb292487603bee332058820c98dd703b555bdfce86b6775edf8a5644d72277dca177e904fe451ec1cbfa604185feac

data/basic_table_sorter.gemspec

@@ -19,6 +19,6 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
 
   gem.add_development_dependency "rspec", "~>2.13.0"
-  gem.add_development_dependency "actionpack", "~>3.2"
+  gem.add_development_dependency "actionpack", "~>4.0"
   gem.add_development_dependency "guard-rspec", "~>3.0.1"
 end

data/lib/basic_table_sorter/version.rb

@@ -1,3 +1,3 @@
 module BasicTableSorter
-  VERSION = "0.0.2.beta"
+  VERSION = "0.0.3.beta"
 end

data/lib/basic_table_sorter/view_helpers.rb

@@ -12,11 +12,11 @@ module BasicTableSorter
 
       if column_selected
         #link_to takes automatically current controller and action from params if missing in arguments
-        link_to link_params, class: 'selected-column' do
+        link_to url_for(link_params), class: 'selected-column' do
           content_tag(:span, title) + tag(:i, class: icon_class)
         end
       else
-        link_to title, link_params
+        link_to title, url_for(link_params)
       end
     end
   end

data/spec/basic_table_sorter/view_helpers_spec.rb

@@ -6,6 +6,8 @@ describe BasicTableSorter::ViewHelpers do
     helper_class = Class.new
     helper_class.send(:include, BasicTableSorter::ViewHelpers)
     helper_class.send(:include, ActionView::Helpers::TagHelper)
+    helper_class.any_instance.stub(:url_for).and_return('url_returned_by_url_for')
+    helper_class.any_instance.stub(:link_to)
     helper_class.new
   end
 
@@ -17,13 +19,21 @@ describe BasicTableSorter::ViewHelpers do
         helper.stub(:params).and_return({table_sort: 'title'})
         helper.stub(:table_sort_direction).and_return('asc')
 
-        expected_link_params = {table_sort: :title, table_sort_direction: 'desc'}
-        helper.should_receive(:link_to).with(expected_link_params, class: 'selected-column') do |&block|
+        helper.should_receive(:link_to).with('url_returned_by_url_for', class: 'selected-column') do |&block|
           block.call.should match /<span>Title<\/span><i class="icon-.*" \/>/
         end
         helper.sortable(:title, 'Title')
       end
 
+
+      it 'should call url_for with correct params' do
+        helper.stub(:params).and_return({table_sort: 'title'})
+        helper.stub(:table_sort_direction).and_return('asc')
+        expected_link_params = {table_sort: :title, table_sort_direction: 'desc'}
+        helper.should_receive(:url_for).with(expected_link_params)
+        helper.sortable(:title, 'Title')
+      end
+
       context 'column sorted asc' do
 
         before :each do
@@ -32,7 +42,7 @@ describe BasicTableSorter::ViewHelpers do
         end
 
         it 'should have link to sort desc' do
-          helper.should_receive(:link_to).with({:table_sort => :name, :table_sort_direction => "desc"}, {:class => "selected-column"})
+          helper.should_receive(:link_to).with('url_returned_by_url_for', {:class => "selected-column"})
           helper.sortable(:name, 'Name')
         end
 
@@ -54,7 +64,8 @@ describe BasicTableSorter::ViewHelpers do
         end
 
         it 'should have link to sort asc' do
-          helper.should_receive(:link_to).with({:table_sort => :name, :table_sort_direction => "asc"}, {:class => "selected-column"})
+          expected_link_params = {:table_sort => :name, :table_sort_direction => "asc"}
+          helper.should_receive(:link_to).with('url_returned_by_url_for', {:class => "selected-column"})
           helper.sortable(:name, 'Name')
         end
 
@@ -72,14 +83,22 @@ describe BasicTableSorter::ViewHelpers do
 
       it 'should return link with title' do
         helper.stub(:params).and_return({table_sort: 'first_name'})
-        helper.should_receive(:link_to).with('Name', {table_sort: :last_name, table_sort_direction: 'asc'})
+        helper.should_receive(:link_to).with('Name', 'url_returned_by_url_for')
+        helper.sortable(:last_name, 'Name')
+      end
+
+      it 'should call url_for with correct params' do
+        helper.stub(:params).and_return({table_sort: 'first_name'})
+        expected_params = {table_sort: :last_name, table_sort_direction: 'asc'}
+        helper.should_receive(:url_for).with(expected_params)
         helper.sortable(:last_name, 'Name')
       end
     end
 
-    it 'should merge additional arguments' do
+    it 'should merge additional arguments before calling url for' do
       helper.stub(:params).and_return({table_sort: 'title'})
-      helper.should_receive(:link_to).with('Name', {table_sort: :last_name, table_sort_direction: 'asc', extra_param: 'extra_param'})
+      epected_params = {table_sort: :last_name, table_sort_direction: 'asc', extra_param: 'extra_param'}
+      helper.should_receive(:url_for).with(epected_params)
       helper.sortable(:last_name, 'Name', extra_param: 'extra_param')
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: basic_table_sorter
 version: !ruby/object:Gem::Version
-  version: 0.0.2.beta
+  version: 0.0.3.beta
 platform: ruby
 authors:
 - Daniel Grawunder, Christian Mierich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-11 00:00:00.000000000 Z
+date: 2013-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '3.2'
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement