basic_assumption 0.3.10 → 0.3.11

data/HISTORY.rdoc

@@ -1,3 +1,8 @@
+== 0.3.11 / 2010-06-28
+* Test Enhancement
+  * Cucumber features covering most of the basic functionality within a Rails 2.3 app (not included in gem)
+* Bug Fix
+  * RestfulRails now works correctly on an index where pagination is in effect
 == 0.3.10 / 2010-06-18
 * License
   * Rename LICENSE to MIT-LICENSE; terms remain the same

data/README.rdoc

@@ -318,6 +318,25 @@ manager. For example, if that's RubyGems:
 
 If you're unfamiliar with why this is being done, take a look
 {here for a start}[http://tomayko.com/writings/require-rubygems-antipattern].
+
+There is also a Cucumber suite that can be run to check BasicAssumption against
+an actual Rails app. Until Bundler has been introduced to manage the gem
+dependencies for the development environment, you will need to ensure at least
+the following gems are installed:
+
+* aruba (0.1.9)
+* capybara (0.3.8)
+* cucumber (0.8.3)
+* cucumber-rails (0.3.2)
+* database_cleaner (0.5.2)
+* rails (2.3.5)
+* rake (0.8.7)
+* sqlite3-ruby (1.3.0)
+* will_paginate (2.3.14)
+
+There is an .rvmrc file in the repository that will require a basic_assumption
+gemset if you're using RVM, which will help to manage the gem dependencies.
+
 Other than that, fork away and send back pull requests! Thanks.
 
 == But should I use it?

data/lib/basic_assumption/default_assumption/restful_rails.rb

@@ -14,8 +14,8 @@ module BasicAssumption
         @action    = params['action']
         @resource_attributes = params[singular_name]
 
-        if @page = params['page']
-          @per_page = params['per_page'] || '15'
+        if @page = params[:page]
+          @per_page = params[:per_page]
         end
       end
 
@@ -45,9 +45,8 @@ module BasicAssumption
       # for the # behavior of +assume+. If the model responds to +paginate+ and
       # there is a +page+ key in the +params+ hash, +assume+ will attempt to
       # find all records of the model type paginated based on the +page+
-      # value in params and also a +per_page+ value. 15 will be the default
-      # if +per_page+ is not present. Otherwise, it returns all # records for
-      # the model.
+      # value in params and also a +per_page+ value. Otherwise, it returns all
+      # # records for the model.
       def block
         super
       end
@@ -66,7 +65,7 @@ module BasicAssumption
 
       def list #:nodoc:
         if page?
-          model_class.paginate('page' => page, 'per_page' => per_page)
+          model_class.paginate(:page => page, :per_page => per_page)
         else
           model_class.all
         end

data/lib/basic_assumption/version.rb

@@ -1,3 +1,3 @@
 module BasicAssumption
-  VERSION = '0.3.10'
+  VERSION = '0.3.11'
 end

data/spec/lib/basic_assumption/default_assumption/cautious_rails_spec.rb

@@ -2,8 +2,9 @@ require 'spec_helper'
 require 'active_support'
 require 'basic_assumption/default_assumption/cautious_rails'
 
+class Model; end
+
 describe BasicAssumption::DefaultAssumption::CautiousRails do
-  class Model; end
 
   context "#block" do
     let(:default) { BasicAssumption::DefaultAssumption::CautiousRails.new }

data/spec/lib/basic_assumption/default_assumption/rails_spec.rb

@@ -2,8 +2,9 @@ require 'spec_helper'
 require 'active_support'
 require 'basic_assumption/default_assumption/rails'
 
+class Model; end
+
 describe BasicAssumption::DefaultAssumption::Rails do
-  class Model; end
 
   context "#block" do
     let(:default) { BasicAssumption::DefaultAssumption::Rails.new }

data/spec/lib/basic_assumption/default_assumption/restful_rails_spec.rb

@@ -2,17 +2,16 @@ require 'spec_helper'
 require 'active_support'
 require 'basic_assumption/default_assumption/restful_rails'
 
-describe BasicAssumption::DefaultAssumption::RestfulRails do
-  class Model
-    attr_accessor :age, :color
-    def initialize(hash = {})
-      hash.each do |k, v|
-        self.send("#{k}=", v)
-      end
+class Model
+  attr_accessor :age, :color
+  def initialize(hash = {})
+    hash.each do |k, v|
+      self.send("#{k}=", v)
     end
   end
+end
 
-  it { should be }
+describe BasicAssumption::DefaultAssumption::RestfulRails do
 
   context "#block" do
     let(:default) { BasicAssumption::DefaultAssumption::RestfulRails.new(:model, params) }
@@ -33,13 +32,13 @@ describe BasicAssumption::DefaultAssumption::RestfulRails do
             before { params['id'] = 123 }
             context "when action is #{action}" do
               before { Model.should_receive(:all) }
-              context "when 'page' exists in the request params" do
-                before { params['page'] = '5' }
+              context "when :page exists in the request params" do
+                before { params[:page] = '5' }
                 it "finds all the records of the model class" do
                   default.block.call(name)
                 end
               end
-              context "when 'page' does not exist in the request params" do
+              context "when :page does not exist in the request params" do
                 it "finds all the records of the model class" do
                   default.block.call(name)
                 end
@@ -50,13 +49,13 @@ describe BasicAssumption::DefaultAssumption::RestfulRails do
           context "when there is not an id in the params" do
             context "when action is #{action}" do
               before { Model.should_receive(:all) }
-              context "when 'page' exists in the request params" do
-                before { params['page'] = '5' }
+              context "when :page exists in the request params" do
+                before { params[:page] = '5' }
                 it "finds all the records of the model class" do
                   default.block.call(name)
                 end
               end
-              context "when 'page' does not exist in the request params" do
+              context "when :page does not exist in the request params" do
                 it "finds all the records of the model class" do
                   default.block.call(name)
                 end
@@ -74,27 +73,27 @@ describe BasicAssumption::DefaultAssumption::RestfulRails do
             before { params['id'] = 123 }
             context "when action is #{action}" do
               before { Model.stub! :paginate }
-              context "when 'page' exists in the request params" do
-                before { params['page'] = '5' }
+              context "when :page exists in the request params" do
+                before { params[:page] = '5' }
                 it "paginates the records of the model class" do
                   Model.should_receive(:paginate)
                   default.block.call(name)
                 end
-                context "when 'per_page' exists in the request params" do
-                  it "paginates using 'page' and 'per_page' from the params" do
-                    params['per_page'] = '10'
-                    Model.should_receive(:paginate).with('page' => '5', 'per_page' => '10')
+                context "when :per_page exists in the request params" do
+                  it "paginates using :page and :per_page from the params" do
+                    params[:per_page] = '10'
+                    Model.should_receive(:paginate).with(:page => '5', :per_page => '10')
                     default.block.call(name)
                   end
                 end
-                context "when 'per_page' does not exist in the request params" do
-                  it "paginates using 'page' from the params and a default 'per_page' of 15" do
-                    Model.should_receive(:paginate).with('page' => '5', 'per_page' => '15')
+                context "when :per_page does not exist in the request params" do
+                  it "paginates using :page from the params" do
+                    Model.should_receive(:paginate).with(:page => '5', :per_page => nil)
                     default.block.call(name)
                   end
                 end
               end
-              context "when 'page' does not exist in the request params" do
+              context "when :page does not exist in the request params" do
                 it "finds all the records of the model class" do
                   Model.should_receive(:all)
                   default.block.call(name)
@@ -106,27 +105,27 @@ describe BasicAssumption::DefaultAssumption::RestfulRails do
           context "when there is not an id in the params" do
             context "when action is #{action}" do
               before { Model.stub! :paginate }
-              context "when 'page' exists in the request params" do
-                before { params['page'] = '5' }
+              context "when :page exists in the request params" do
+                before { params[:page] = '5' }
                 it "paginates the records of the model class" do
                   Model.should_receive(:paginate)
                   default.block.call(name)
                 end
-                context "when 'per_page' exists in the request params" do
-                  it "paginates using 'page' and 'per_page' from the params" do
-                    params['per_page'] = '10'
-                    Model.should_receive(:paginate).with('page' => '5', 'per_page' => '10')
+                context "when :per_page exists in the request params" do
+                  it "paginates using :page and :per_page from the params" do
+                    params[:per_page] = '10'
+                    Model.should_receive(:paginate).with(:page => '5', :per_page => '10')
                     default.block.call(name)
                   end
                 end
-                context "when 'per_page' does not exist in the request params" do
-                  it "paginates using 'page' from the params and a default 'per_page' of 15" do
-                    Model.should_receive(:paginate).with('page' => '5', 'per_page' => '15')
+                context "when :per_page does not exist in the request params" do
+                  it "paginates using :page from the params" do
+                    Model.should_receive(:paginate).with(:page => '5', :per_page => nil)
                     default.block.call(name)
                   end
                 end
               end
-              context "when 'page' does not exist in the request params" do
+              context "when :page does not exist in the request params" do
                 it "finds all the records of the model class" do
                   Model.should_receive(:all)
                   default.block.call(name)

data/spec/lib/basic_assumption/default_assumption_spec.rb

@@ -1,5 +1,5 @@
 require 'spec_helper'
-require 'lib/basic_assumption/default_assumption/rails'
+require 'basic_assumption/default_assumption/rails'
 
 describe BasicAssumption::DefaultAssumption do
   let(:mod) { BasicAssumption::DefaultAssumption }

data/spec/lib/basic_assumption_spec.rb

@@ -120,7 +120,7 @@ describe BasicAssumption do
 
   context "within Rails" do
     before(:all) do
-      require 'rails/init.rb'
+      require File.expand_path(File.dirname(__FILE__) + '/../../rails/init.rb')
     end
     let(:controller_class) { Class.new(::ActionController::Base) }
     let(:controller_instance) { controller_class.new }

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 10
-  version: 0.3.10
+  - 11
+  version: 0.3.11
 platform: ruby
 authors: 
 - Matt Yoho
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-06-18 00:00:00 -05:00
+date: 2010-06-28 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency