basepack 1.0.0.pre.0 → 1.0.0

data/spec/integration/basic/create/basepack_basic_create_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "RailsAdmin Basic Create" do
+describe "RailsAdmin Basic Create", type: :request do
 
   describe "create without association" do
 
@@ -28,7 +28,7 @@ describe "RailsAdmin Basic Create" do
       visit new_employee_path
       fill_in "employee[name]", with: "John Smith"
       fill_in "employee[email]", with: "john.smith@gmail.com"
-      add_select2 'Position', with: position.to_label 
+      add_select2 'Position', with: position.to_label
       click_on "Save"
 
       @created_employee = Employee.last
@@ -53,15 +53,15 @@ describe "RailsAdmin Basic Create" do
 
     it "adds project" do
       click_on "Save"
-      
+
       created_employee = Employee.last
-      expect(created_employee.project_ids).to include(project1.id) 
+      expect(created_employee.project_ids).to include(project1.id)
     end
 
     it "adds projects" do
       add_select2 "Projects", with: project2.to_label
       click_on "Save"
-      
+
       created_employee = Employee.last
       expect(created_employee.project_ids).to eq [project1.id, project2.id]
     end
@@ -71,7 +71,7 @@ describe "RailsAdmin Basic Create" do
       remove_select2 "Projects", with: project1.to_label
 
       click_on "Save"
-      
+
       created_employee = Employee.last
       expect(created_employee.project_ids).to be_empty
     end
@@ -94,15 +94,15 @@ describe "RailsAdmin Basic Create" do
 
     it "adds skill" do
       click_on "Save"
-      
+
       created_employee = Employee.last
-      expect(created_employee.skill_ids).to include(skill1.id) 
+      expect(created_employee.skill_ids).to include(skill1.id)
     end
 
     it "adds skills" do
       add_select2 "Skills", with: skill2.to_label
       click_on "Save"
-      
+
       created_employee = Employee.last
       expect(created_employee.skill_ids).to eq [skill1.id, skill2.id]
     end
@@ -112,7 +112,7 @@ describe "RailsAdmin Basic Create" do
       remove_select2 "Skills", with: skill1.to_label
 
       click_on "Save"
-      
+
       created_employee = Employee.last
       expect(created_employee.skill_ids).to be_empty
     end
@@ -158,8 +158,7 @@ describe "RailsAdmin Basic Create" do
       ApplicationController.any_instance.stub(:current_ability).and_return(ability)
       expect {
         page.driver.submit :post, "/employees", { employee: { name: "created employee", email: "foo@bar.com"} }
-      }.to_not change(Employee, :count).by(1)
-      expect(page.driver.status_code).to_not eq 200
+      }.to change(Employee, :count).by(0)
     end
   end
 

data/spec/integration/basic/destroy/basepack_basic_destroy_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Basepack Basic Destroy" do
+describe "Basepack Basic Destroy", type: :request do
   let(:employee) { FactoryGirl.create(:employee) }
 
   describe "destroy from show" do
@@ -25,8 +25,8 @@ describe "Basepack Basic Destroy" do
     context "when not destroyed" do
       it "redirects back to the object" do
         pending "It should redirect to show page when object can not be destroyed and display failure flash messages"
-        # currently it is displaying successful message even when object wasn't destroyed!! 
-        
+        # currently it is displaying successful message even when object wasn't destroyed!!
+
         # show some error in base
         Employee.any_instance.stub(:errors).and_return(['error'])
         allow_any_instance_of(Employee).to receive(:destroy_hook).and_return false

data/spec/integration/basic/edit/basepack_basic_edit_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Basepack Basic Edit" do
+describe "Basepack Basic Edit", type: :request do
 let!(:employee) { FactoryGirl.create(:employee) }
 
   describe "without association" do
@@ -181,14 +181,14 @@ let!(:employee) { FactoryGirl.create(:employee) }
             field :status do
               visible true
               html_attributes do
-              { 
-                data: { 
+              {
+                data: {
                   "dynamic-fields" => [
                     { condition: ["Postponed", "Done"], field_actions: { completed_percents: { visible: false }} },
                     { condition: ["In progress"], field_actions: { completed_percents: { visible: true  }} },
-                  ]   
-                }   
-              }   
+                  ]
+                }
+              }
               end
             end
 

data/spec/integration/basic/export/basepack_basic_export_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe "Basepack Basic Export" do
+describe "Basepack Basic Export", type: :request do
   let(:employee) { FactoryGirl.create(:employee) }
   let(:export_template) { FactoryGirl.create(:export_template,
   	class_type: "Employee",

data/spec/integration/basic/filter/basepack_basic_filter_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Basepack basic filter", js: true do
+describe "Basepack basic filter", type: :request, js: true do
   let(:employee1) { FactoryGirl.create :employee }
   let(:employee2) { FactoryGirl.create :employee }
 
@@ -179,7 +179,7 @@ describe "Basepack basic filter", js: true do
       end
       find(".additional-fieldset").click
       find('.hasDatepicker').click
-      within("#ui-datepicker-div") do 
+      within("#ui-datepicker-div") do
         click_on "1"
       end
 

data/spec/integration/basic/import/basepack_basic_import_spec.rb

@@ -1,11 +1,10 @@
 require 'spec_helper'
 
-describe "Basepack basic list" do
+describe "Basepack basic list", type: :request do
   # subject { page }
 
   describe "import" do
     it "imports an file" do
-      sleep 10
       visit employees_path
       click_link "Import"
       path = File.join(::Rails.root, "../../spec/fixtures/employees.csv")

data/spec/integration/basic/list/basepack_basic_list_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Basepack basic list" do
+describe "Basepack basic list", type: :request do
   # subject { page }
 
   let(:employee1) { FactoryGirl.create :employee }
@@ -306,8 +306,8 @@ describe "Basepack basic list" do
         end
       end
 
-      employee1.projects.build(name: 'first project') 
-      employee1.projects.build(name: 'second project') 
+      employee1.projects.build(name: 'first project')
+      employee1.projects.build(name: 'second project')
       employee1.save!
     end
 

data/spec/integration/basic/list/basepack_bulk_actions_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Bulk actions" do
+describe "Bulk actions", type: :request do
   let(:task1) { FactoryGirl.create :task }
   let(:task2) { FactoryGirl.create :task }
 
@@ -33,7 +33,7 @@ describe "Bulk actions" do
         visit tasks_path
 
         find(:css, "input[type=checkbox]#check_all").set(true)
-        expect(page).to have_selector("input[name^='bulk_ids[]']:checked", 
+        expect(page).to have_selector("input[name^='bulk_ids[]']:checked",
           count: tasks.count)
       end
     end
@@ -71,7 +71,7 @@ describe "Bulk actions" do
           task1
           visit tasks_path
 
-          expect(page).to_not have_selector(:link_or_button, 
+          expect(page).to_not have_selector(:link_or_button,
             "Delete selected")
         end
 
@@ -121,7 +121,7 @@ describe "Bulk actions" do
 
       expect(page.driver.status_code).to eq 200
       expect(page).not_to have_selector("#check_all")
-      expect(page).not_to have_selector("input[name^='bulk_ids[]']", 
+      expect(page).not_to have_selector("input[name^='bulk_ids[]']",
         count: 1)
     end
   end

data/spec/integration/basic/list/basepack_tree_list_spec.rb

@@ -8,7 +8,7 @@ def find_node_expander(node)
   find_node(node).find('span.fancytree-expander')
 end
 
-describe "Basepack basic list" do
+describe "Basepack basic list", type: :request do
 
   let(:ability) { Object.new.extend(CanCan::Ability) }
 
@@ -27,7 +27,7 @@ describe "Basepack basic list" do
   let(:project123) { FactoryGirl.create(:project, name: 'Project1-2-3.', parent: project12) }
 
   let(:tree) do
-    [project1, project2, project11, project12, project13, project21, 
+    [project1, project2, project11, project12, project13, project21,
      project22, project121, project122, project123]
   end
 

data/spec/integration/basic/merge/basepack_basic_merge_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Basepack basic merge" do
+describe "Basepack basic merge", type: :request do
   # subject { page }
 
   describe "diff" do
@@ -12,7 +12,7 @@ describe "Basepack basic merge" do
   end
 
   describe "merge" do
-    
+
   end
 
 end

data/spec/integration/basic/new/basepack_basic_new_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Basepack Basic New" do
+describe "Basepack Basic New", type: :request do
   describe "GET /employees/new without association" do
     before(:each) do
       RailsAdmin.config Employee do
@@ -105,14 +105,14 @@ describe "Basepack Basic New" do
               field :status do
                 visible true
                 html_attributes do
-                { 
-                  data: { 
+                {
+                  data: {
                     "dynamic-fields" => [
                       { condition: ["Postponed", "Done"], field_actions: { completed_percents: { visible: false }} },
                       { condition: ["In progress"], field_actions: { completed_percents: { visible: true  }} },
-                    ]   
-                  }   
-                }   
+                    ]
+                  }
+                }
                 end
               end
 
@@ -127,12 +127,13 @@ describe "Basepack Basic New" do
       # save_and_open_page
       fill_in "Status", with: "Postponed"
       fill_in "Name", with: "Test"
-      # find("#employee_name").click      
+      # find("#employee_name").click
       expect(page).to have_no_content('Completed percents')
     end
 
     it "shows field" do
       pending "basepack helper"
+      fail
       visit new_task_path
       fill_in "Status", with: "In progress"
       fill_in "Name", with: "Test showing percents"
@@ -153,7 +154,7 @@ describe "Basepack Basic New" do
           end
 
           html_attributes do
-          { data: { 
+          { data: {
             # set project's field as dependent select box
             "dependant-filteringselect" => "field=position_category_id",
 
@@ -178,17 +179,19 @@ describe "Basepack Basic New" do
 
     it "selecting category limits positions" do
       pending "needs basepack helper"
+      fail
     end
 
     it "shows no position when no category is choosen" do
       pending "needs basepack helper"
+      fail
     end
   end
 
   describe "types", js: true do
     describe "wysihtml5" do
       before(:each) do
-        RailsAdmin.config Project do 
+        RailsAdmin.config Project do
           edit do
             field :description, :wysihtml5
             field :name
@@ -198,6 +201,7 @@ describe "Basepack Basic New" do
       end
 
       it "displays wysihtml5 basic elements correctly" do
+        #save_and_open_page
         expect(page).to have_selector(:link_or_button, "Normal text")
         expect(page).to have_selector(:link_or_button, "Bold")
         expect(page).to have_selector(:link_or_button, "Italic")
@@ -233,7 +237,7 @@ describe "Basepack Basic New" do
       it "displays time picker" do
         visit new_project_path
         find('.hasTimepicker').click
-        page.execute_script %Q{ $('a.ui-datepicker-next').trigger("click") } # move one month forward 
+        page.execute_script %Q{ $('a.ui-datepicker-next').trigger("click") } # move one month forward
         page.execute_script %Q{ $("a.ui-state-default:contains('15')").trigger("click") } # click on day 15
 
         click_on "Save"
@@ -243,7 +247,7 @@ describe "Basepack Basic New" do
 
     describe "tags", js: true do
       before(:each) do
-        RailsAdmin.config Project do 
+        RailsAdmin.config Project do
           show do
             field :tags
           end
@@ -262,7 +266,7 @@ describe "Basepack Basic New" do
         visit new_project_path
         expect(page).to have_selector(".icon-tags")
         # expect(page).to have_select2("Tag list")
-      
+
         add_select2 "Tag list", with: "first tag, second"
         click_on "Save"
 

data/spec/integration/basic/show/basepack_basic_show_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Basepack Basic Show" do
+describe "Basepack Basic Show", type: :request do
   # subject { page }
   let(:employee) { FactoryGirl.create :employee }
   let(:ability) { Object.new.extend(CanCan::Ability) }
@@ -198,8 +198,8 @@ describe "Basepack Basic Show" do
         field :projects
       end
 
-      employee.projects.build(name: 'first project') 
-      employee.projects.build(name: 'second project') 
+      employee.projects.build(name: 'first project')
+      employee.projects.build(name: 'second project')
       employee.save!
     end
 

data/spec/integration/basic/update/basepack_basic_update_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe "Basepack basic update" do
+describe "Basepack basic update", type: :request do
   # subject { page }
 
   let!(:employee1) { FactoryGirl.create :employee }
@@ -16,8 +16,8 @@ describe "Basepack basic update" do
      page.driver.submit :put, "/employees/#{employee1.id}", { employee: { id: new_id } }
      expect(page.driver.status_code).to eq 200
 
-     expect(Employee.exists?(new_id)).to be_false
-     expect(Employee.exists?(employee1.id)).to be_true
+     expect(Employee.exists?(new_id)).to be_falsy
+     expect(Employee.exists?(employee1.id)).to be_truthy
     end
 
     it "returns to edit page" do
@@ -53,7 +53,7 @@ describe "Basepack basic update" do
 
   describe "update belongs_to" do
     before(:each) do
-      RailsAdmin.config Employee do 
+      RailsAdmin.config Employee do
         edit do
           field :position
         end
@@ -68,15 +68,15 @@ describe "Basepack basic update" do
       add_select2 "Position", with: position.to_label
       click_on "Save"
 
-      employee1.reload      
-      expect(employee1.position.id).to eq(position.id) 
+      employee1.reload
+      expect(employee1.position.id).to eq(position.id)
     end
 
   end
 
   describe "update has_one association", js: true do
     before(:each) do
-      RailsAdmin.config Employee do 
+      RailsAdmin.config Employee do
         edit do
           field :account
         end
@@ -91,11 +91,11 @@ describe "Basepack basic update" do
       add_select2 "Account", with: account.to_label
       click_on "Save"
 
-      employee1.reload      
-      expect(employee1.account.id).to eq(account.id) 
+      employee1.reload
+      expect(employee1.account.id).to eq(account.id)
     end
 
-    
+
   end
 
   describe "update has_many associations", js: true do
@@ -108,8 +108,8 @@ describe "Basepack basic update" do
       add_select2 "Projects", with: project.to_label
       click_on "Save"
 
-      employee1.reload      
-      expect(employee1.project_ids).to include(project.id) 
+      employee1.reload
+      expect(employee1.project_ids).to include(project.id)
     end
 
     it "removes all projects", js:true do
@@ -119,11 +119,11 @@ describe "Basepack basic update" do
         end
       end
       visit edit_employee_path(id: employee_with_projects)
-      
+
       remove_all_select2 "Projects"
       click_on "Save"
 
-      employee_with_projects.reload      
+      employee_with_projects.reload
       expect(employee_with_projects.project_ids).to be_empty
     end
 
@@ -134,19 +134,19 @@ describe "Basepack basic update" do
         end
       end
       visit edit_employee_path(id: employee_with_projects)
-      
+
       remove_select2 "Projects", with: employee_with_projects.projects.first.to_label
       project = employee_with_projects.projects.last
       click_on "Save"
 
-      employee_with_projects.reload      
+      employee_with_projects.reload
       expect(employee_with_projects.projects).to eq([project])
     end
   end
 
   describe "has_and_belongs_to_many association", js: true do
     let!(:employee_with_skills) { FactoryGirl.create(:employee_with_skills)  }
-    
+
     before(:each) do
       RailsAdmin.config Employee do
         edit do
@@ -162,28 +162,28 @@ describe "Basepack basic update" do
       add_select2 "Skills", with: skill.to_label
       click_on "Save"
 
-      employee1.reload      
-      expect(employee1.skill_ids).to include(skill.id) 
+      employee1.reload
+      expect(employee1.skill_ids).to include(skill.id)
     end
 
     it "removes all skills", js:true do
       visit edit_employee_path(id: employee_with_skills)
-      
+
       remove_all_select2 "Skills"
       click_on "Save"
 
-      employee_with_skills.reload      
+      employee_with_skills.reload
       expect(employee_with_skills.skill_ids).to be_empty
     end
 
     it "removes 1 skill", js:true do
       visit edit_employee_path(id: employee_with_skills)
-      
+
       remove_select2 "Skills", with: employee_with_skills.skills.first.to_label
       skill = employee_with_skills.skills.last
       click_on "Save"
 
-      employee_with_skills.reload      
+      employee_with_skills.reload
       expect(employee_with_skills.skills).to eq([skill])
     end
   end
@@ -208,10 +208,10 @@ describe "Basepack basic update" do
       add_select2 "Tasks", with: task.to_label
       click_on "Save"
 
-      employee1.reload      
-      expect(employee1.task_ids).to include(task.id) 
+      employee1.reload
+      expect(employee1.task_ids).to include(task.id)
     end
-    
+
   end
 
   let(:ability) { Object.new.extend(CanCan::Ability) }
@@ -230,19 +230,19 @@ describe "Basepack basic update" do
   end
 
   context "without accepts_nested_attributes_for" do
-    it "igonres nested attributes id and _destroy" do      
+    it "igonres nested attributes id and _destroy" do
       employee_with_projects
 
-      page.driver.submit :put, "/employees/#{employee_with_projects.id}", { 
-        employee: { 
-          name: "updated name", 
+      page.driver.submit :put, "/employees/#{employee_with_projects.id}", {
+        employee: {
+          name: "updated name",
           projects_attributes: {
-            "0" => { id: employee_with_projects.projects[0].id, name: "great first project", "_destroy" => true }, 
-            "1" => { id: employee_with_projects.projects[1].id, name: "destroy project", "_destroy" => true } 
+            "0" => { id: employee_with_projects.projects[0].id, name: "great first project", "_destroy" => true },
+            "1" => { id: employee_with_projects.projects[1].id, name: "destroy project", "_destroy" => true }
           }
-        } 
+        }
       }
-      
+
       employee_with_projects.reload
       expect(page.driver.status_code).to eq 200
       expect(employee_with_projects.name).to eq "updated name"
@@ -256,11 +256,11 @@ describe "Basepack basic update" do
       it "igonres _destroy" do
         employee_with_projects
 
-        page.driver.submit :put, "/employee_with_nesteds/#{employee_with_projects.id}", { 
+        page.driver.submit :put, "/employee_with_nesteds/#{employee_with_projects.id}", {
           employee_with_nested: {
             name: "updated name",
             projects_attributes: {
-              "1" => { id: employee_with_projects.projects[1].id, name: "destroy project", "_destroy" => true } 
+              "1" => { id: employee_with_projects.projects[1].id, name: "destroy project", "_destroy" => true }
             }
           }
         }
@@ -298,18 +298,18 @@ describe "Basepack basic update" do
     end
 
     context 'with allow_destroy' do
-      it "destroys when _destroy param present" do      
+      it "destroys when _destroy param present" do
         employee_with_projects
 
-        page.driver.submit :put, "/employee_with_destroyable_nesteds/#{employee_with_projects.id}", { 
-          employee_with_destroyable_nested: { 
-            name: "updated name", 
+        page.driver.submit :put, "/employee_with_destroyable_nesteds/#{employee_with_projects.id}", {
+          employee_with_destroyable_nested: {
+            name: "updated name",
             projects_attributes: {
-              "1" => { id: employee_with_projects.projects[1].id, name: "destroy project", "_destroy" => true } 
+              "1" => { id: employee_with_projects.projects[1].id, name: "destroy project", "_destroy" => true }
             }
-          } 
+          }
         }
-        
+
         employee_with_projects.reload
         expect(page.driver.status_code).to eq 200
         expect(employee_with_projects.name).to eq "updated name"

data/spec/spec_helper.rb

@@ -3,7 +3,6 @@ ENV['SKIP_RAILS_ADMIN_INITIALIZER'] = 'false'
 
 require File.expand_path("../dummy_app/config/environment.rb",  __FILE__)
 require 'rspec/rails'
-require 'rspec/autorun'
 require 'factory_girl_rails'
 require 'faker'
 require 'capybara/rspec'