basecrm 1.3.5 → 1.3.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3edd2e23d1f92a60d78428691fec6a7d7496b306
-  data.tar.gz: c3b879f523fc99539e444a6f50a16fc484152205
+  metadata.gz: 86f63585ec16cb19ffaa8f4e646cbe24838e589f
+  data.tar.gz: d0d6d66eeae6ee89c502dbb2b76c5cb3c4f85bbe
 SHA512:
-  metadata.gz: 0e3009c58a14482b185a2359a68f90c90e6754c6babcf3db2077c0a491244c25443aba8b96659097e9ff5224de555378af9a7685c5d6118f146afe992901e223
-  data.tar.gz: 40a6886b9e548e7e6fe1fa69d4893bef923a07a101b66aae5aa1dba79430990d791741bce19f8a1361358aa8b9b7dfd336cbee04681df9a109dfb6a83cc2485d
+  metadata.gz: 48b579f1744c409b3c8eee14e50985b875614334964d13dcecf50c3f8fbc69d02dcaabf186e351c39864e77c7aa769ea1f9df3aacc18fc1813dd62fcaa3a18f1
+  data.tar.gz: 8249e1c323f38018d6459e5c0c452c74c79a07bf857c23825171730a854a9c7e1ca09e293662ba308e0694f6d34d465530009a104e0e98a46077884580f34369

data/lib/basecrm/models/contact.rb

@@ -22,7 +22,7 @@ module BaseCRM
     #   @return [Integer] The unique identifier of the organization the contact belongs to. The field will be set only if the contact is an individual.
     # attr_accessor :contact_id
     # @!attribute [rw] custom_fields
-    #   @return [Hash] Custom fields are a key-value pair attached to a contact. See more at [Custom Fields](/docs/rest/articles/requests#custom_fields).
+    #   @return [Hash] Custom fields are a key-value pair attached to a contact. See more at [Custom Fields](/docs/rest/articles/requests#custom_fields). Note! You need to set Filterable on from Settings -> Contacts to be able to search by custom fields
     # attr_accessor :custom_fields
     # @!attribute [rw] customer_status
     #   @return [String] The customer status of the contact.

data/lib/basecrm/utils/coercion.rb

@@ -3,7 +3,7 @@ require "bigdecimal"
 module BaseCRM
   class Coercion
     def self.to_decimal_value(value)
-      BigDecimal.new((value || 0), 15)
+      BigDecimal((value || 0), 15)
     end
 
     def self.to_string(value)

data/lib/basecrm/version.rb

@@ -1,3 +1,3 @@
 module BaseCRM
-  VERSION = "1.3.5"
+  VERSION = "1.3.6"
 end

data/spec/factories/associated_contact.rb

@@ -1,7 +1,7 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :associated_contact, class: BaseCRM::AssociatedContact do
     # transient attributes, required in url
-    deal_id nil
+    deal_id { nil }
 
     role { "involved" }
 

data/spec/factories/call.rb

@@ -1,6 +1,6 @@
 require 'securerandom'
 
-FactoryGirl.define do
+FactoryBot.define do
   factory :call, class: BaseCRM::Call do
 
     summary { "Schedule another call." }

data/spec/factories/contact.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :contact, class: BaseCRM::Contact do
 
     description { "I know him via Tom" }

data/spec/factories/deal.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :deal, class: BaseCRM::Deal do
 
     currency { "EUR" }

data/spec/factories/deal_source.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :deal_source, class: BaseCRM::DealSource do
 
     name { Faker::Name.name }

data/spec/factories/deal_unqualified_reason.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :deal_unqualified_reason, class: BaseCRM::DealUnqualifiedReason do
 
     name { Faker::Name.name }

data/spec/factories/lead.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :lead, class: BaseCRM::Lead do
 
     description { "I know him via Tom" }

data/spec/factories/lead_source.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :lead_source, class: BaseCRM::LeadSource do
 
     name { Faker::Name.name }

data/spec/factories/line_item.rb

@@ -1,7 +1,7 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :line_item, class: BaseCRM::LineItem do
     # transient attributes, required in url
-    order_id nil
+    order_id { nil }
 
     product_id { 5 }
     value { 1599.99 }

data/spec/factories/loss_reason.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :loss_reason, class: BaseCRM::LossReason do
 
     name { Faker::Name.name }

data/spec/factories/note.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :note, class: BaseCRM::Note do
 
     content { "Highly important." }

data/spec/factories/order.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :order, class: BaseCRM::Order do
 
     deal_id { 5 }

data/spec/factories/product.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :product, class: BaseCRM::Product do
 
     name { Faker::Name.name }

data/spec/factories/source.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :source, class: BaseCRM::Source do
 
     name { Faker::Name.name }

data/spec/factories/tag.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :tag, class: BaseCRM::Tag do
 
     name { Faker::Name.name }

data/spec/factories/task.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :task, class: BaseCRM::Task do
 
     content { "Contact Tom" }

data/spec/factories/text_message.rb

@@ -1,4 +1,4 @@
-FactoryGirl.define do
+FactoryBot.define do
   factory :text_message, class: BaseCRM::TextMessage do
 
 

data/spec/spec_helper.rb

@@ -1,10 +1,10 @@
 require 'rspec/collection_matchers'
-require 'factory_girl'
+require 'factory_bot'
 require 'faker'
 
 require 'basecrm'
 
-module FactoryGirl
+module FactoryBot
   module Strategy
     class Create
       def result(evaluation)
@@ -15,10 +15,10 @@ module FactoryGirl
 end
 
 Dir[File.join(__dir__, "/support/**/*.rb")].each { |f| require f }
-FactoryGirl.find_definitions
+FactoryBot.find_definitions
 
 RSpec.configure do |config|
-  config.include FactoryGirl::Syntax::Methods
+  config.include FactoryBot::Syntax::Methods
 
   config.expect_with :rspec do |expectations|
     # It makes the `description` and `failure_message` of custom matchers include text for helper methods

data/spec/support/client_helpers.rb

@@ -12,7 +12,7 @@ module ClientHelpers
   end
 
   def contact
-    @contact ||= FactoryGirl.create(:contact)
+    @contact ||= FactoryBot.create(:contact)
   end
 end
 
@@ -20,4 +20,4 @@ RSpec.configure do |config|
   include ClientHelpers
 end
 
-FactoryGirl::SyntaxRunner.send(:include, ClientHelpers)
+FactoryBot::SyntaxRunner.send(:include, ClientHelpers)

data/spec/utils/coercion.rb

@@ -5,7 +5,7 @@ describe BaseCRM::Coercion do
     it { expect(BaseCRM::Coercion.to_decimal_value(0)).to eql(0) }
     it { expect(BaseCRM::Coercion.to_decimal_value("0")).to eql(0) }
     it { expect(BaseCRM::Coercion.to_decimal_value(nil)).to eql(0) }
-    it { expect(BaseCRM::Coercion.to_decimal_value(1.1)).to eql(BigDecimal.new("1.1", 15)) }
-    it { expect(BaseCRM::Coercion.to_decimal_value("1.11")).to eql(BigDecimal.new("1.11", 15)) }
+    it { expect(BaseCRM::Coercion.to_decimal_value(1.1)).to eql(BigDecimal("1.1", 15)) }
+    it { expect(BaseCRM::Coercion.to_decimal_value("1.11")).to eql(BigDecimal("1.11", 15)) }
   end
 end

data/spec/utils/coercion_spec.rb

@@ -6,8 +6,8 @@ describe BaseCRM::Coercion do
     it { expect(BaseCRM::Coercion.to_decimal_value(0)).to eql(0) }
     it { expect(BaseCRM::Coercion.to_decimal_value("0")).to eql(0) }
     it { expect(BaseCRM::Coercion.to_decimal_value(nil)).to eql(0) }
-    it { expect(BaseCRM::Coercion.to_decimal_value(1.1)).to eql(BigDecimal.new("1.1", 15)) }
-    it { expect(BaseCRM::Coercion.to_decimal_value("1.11")).to eql(BigDecimal.new("1.11", 15)) }
+    it { expect(BaseCRM::Coercion.to_decimal_value(1.1)).to eql(BigDecimal("1.1", 15)) }
+    it { expect(BaseCRM::Coercion.to_decimal_value("1.11")).to eql(BigDecimal("1.11", 15)) }
   end
 
   describe "to_string" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: basecrm
 version: !ruby/object:Gem::Version
-  version: 1.3.5
+  version: 1.3.6
 platform: ruby
 authors:
 - BaseCRM developers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-09 00:00:00.000000000 Z
+date: 2019-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -87,19 +87,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.8'
+        version: '4.11'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.8'
+        version: '4.11'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
@@ -263,7 +263,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: BaseCRM Official API V2 library client for ruby