basecrm 0.0.3 → 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 5944afdba7dc0d91c937ab939bb6e1fb019e058f
+  data.tar.gz: a1939878b665013a2a9591beea66f448e0b17a78
+SHA512:
+  metadata.gz: 2d5710f54131a3461b6c7ae51fda0bf8e1f83bc8366e0406a2b901acb1853a6520b903b3c2cdfd24feea9c6362d520bbca213abb55cdc9c0f6a3b914e0d429b9
+  data.tar.gz: 1e537e6befde7c148eb1c570cd602bc1abcd067c2594b06c45a374e516cacb56b19eab9443438f3ec716a0f1832341b6db67d46b631d5120fdcefeb765f69594

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - rbx-18mode
+  - rbx-19mode
+script: "bundle exec rspec"

data/Gemfile

@@ -1,8 +1,9 @@
-source 'http://rubygems.org'
+source 'https://rubygems.org'
 
 # Specify your gem's dependencies in base_crm.gemspec
 gemspec
 
 gem "rspec"
 gem "simplecov"
+gem "rake"
 

data/README.md

@@ -1,5 +1,7 @@
 # Base CRM API client
 
+[![Build Status](https://travis-ci.org/basecrm/basecrm.png?branch=master)](https://travis-ci.org/basecrm/basecrm)
+
 New and shiny client for the Base CRM API
 
 NOTE: This is still a very early release. There might be a lot of

data/Rakefile

@@ -1,2 +1,8 @@
 #!/usr/bin/env rake
 require "bundler/gem_tasks"
+
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/basecrm.gemspec

@@ -3,7 +3,7 @@ require File.expand_path('../lib/base_crm/version', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.authors       = ["Marcin Bunsch"]
-  gem.email         = ["marcin@futuresimple.com"]
+  gem.email         = ["marcin@getbase.com"]
   gem.description   = %q{Base CRM API Client}
   gem.summary       = %q{Base CRM API Client}
   gem.homepage      = "https://github.com/basecrm/basecrm"

data/lib/base_crm.rb

@@ -5,19 +5,20 @@ require "base_crm/api_client_ext"
 
 module BaseCrm
 
-  autoload :Account,         "base_crm/account"
-  autoload :Contact,         "base_crm/contact"
-  autoload :Session,         "base_crm/session"
-  autoload :Deal,            "base_crm/deal"
-  autoload :Forecasting,     "base_crm/forecasting"
-  autoload :Source,          "base_crm/source"
-  autoload :Resource,        "base_crm/resource"
-  autoload :Note,            "base_crm/note"
-  autoload :Noteable,        "base_crm/noteable"
-  autoload :Task,            "base_crm/task"
-  autoload :Taskable,        "base_crm/taskable"
-  autoload :Lead,            "base_crm/lead"
-  autoload :CustomFieldable, "base_crm/custom_fieldable"
+  autoload :RelatedObjectScope, "base_crm/related_object_scope"
+  autoload :Account,            "base_crm/account"
+  autoload :Contact,            "base_crm/contact"
+  autoload :Session,            "base_crm/session"
+  autoload :Deal,               "base_crm/deal"
+  autoload :Forecasting,        "base_crm/forecasting"
+  autoload :Source,             "base_crm/source"
+  autoload :Resource,           "base_crm/resource"
+  autoload :Note,               "base_crm/note"
+  autoload :Noteable,           "base_crm/noteable"
+  autoload :Task,               "base_crm/task"
+  autoload :Taskable,           "base_crm/taskable"
+  autoload :Lead,               "base_crm/lead"
+  autoload :CustomFieldable,    "base_crm/custom_fieldable"
 
 end
 

data/lib/base_crm/noteable.rb

@@ -2,18 +2,12 @@ module BaseCrm
   module Noteable
 
     def notes
-      pass_headers(Note).params({
-        :noteable_type => self.noteable_type,
-        :noteable_id => self.id
-      })
+      @notes ||= BaseCrm::RelatedObjectScope.new(self, Note, :noteable)
     end
 
+    # Keeping it for legacy purposes
     def create_note(message)
-      pass_headers(Note).create({
-        :content => message,
-        :noteable_type => self.noteable_type,
-        :noteable_id => self.id
-      })
+      notes.create(:content => message)
     end
 
   end

data/lib/base_crm/related_object_scope.rb

@@ -0,0 +1,35 @@
+require "delegate"
+module BaseCrm
+
+  class RelatedObjectScope < SimpleDelegator
+
+    attr_accessor :object, :subobject, :type
+
+    def initialize(object, subobject, key, type = nil)
+      @object = object
+      @subobject = subobject
+      @type = type || object.class.name.split('::').last
+      @type_key = "#{key}_type".to_sym
+      @id_key = "#{key}_id".to_sym
+      super(subobject_scope)
+    end
+
+    def subobject_scope
+      @subobject_scope ||= object.pass_headers(subobject).params(type_and_id_scope)
+    end
+
+    def create(params)
+      subobject_scope.create(type_and_id_scope.merge(params))
+    end
+
+    def type_and_id_scope
+      {
+        @type_key => type,
+        @id_key => object.id
+      }
+    end
+
+  end
+
+end
+

data/lib/base_crm/taskable.rb

@@ -2,17 +2,12 @@ module BaseCrm
   module Taskable
 
     def tasks
-      pass_headers(Task).params({
-        :taskable_type => self.taskable_type,
-        :taskable_id => self.id
-      })
+      @tasks ||= BaseCrm::RelatedObjectScope.new(self, Task, :taskable)
     end
 
+    # Keeping it for legacy purposes
     def create_task(params)
-      pass_headers(Task).create({
-        :taskable_type => self.taskable_type,
-        :taskable_id => self.id
-      }.merge(params))
+      tasks.create(params)
     end
 
   end

data/lib/base_crm/version.rb

@@ -1,3 +1,3 @@
 module BaseCrm
-  VERSION = "0.0.3"
+  VERSION = "0.1.0"
 end

data/spec/base_crm/contact_spec.rb

@@ -42,8 +42,8 @@ describe BaseCrm::Contact do
   end
 
   describe ".fetch_for_deal" do
-    let(:scope) { mock }
-    let(:deal) { mock(:id => 444) }
+    let(:scope) { double }
+    let(:deal) { double(:id => 444) }
 
     it "returns the scope" do
       BaseCrm::Contact.should_receive(:scope).and_return(scope)
@@ -58,8 +58,8 @@ describe BaseCrm::Contact do
   end
 
   describe "#notes" do
-    let(:scope) { mock }
-    let(:fetch_scope) { mock }
+    let(:scope) { double }
+    let(:fetch_scope) { double }
 
     it "passes the token and applies the params" do
       subject.

data/spec/base_crm/deal_spec.rb

@@ -43,9 +43,9 @@ describe BaseCrm::Deal do
 
   describe "#source" do
 
-    let(:source) { mock }
+    let(:source) { double }
     let(:source_id) { 444 }
-    let(:scope) { mock }
+    let(:scope) { double }
 
     before do
       subject.source_id = source_id
@@ -87,9 +87,9 @@ describe BaseCrm::Deal do
 
   describe "#contact" do
 
-    let(:contact) { mock }
-    let(:entity_id) { mock }
-    let(:scope) { mock }
+    let(:contact) { double }
+    let(:entity_id) { double }
+    let(:scope) { double }
 
     before do
       subject.entity_id = entity_id
@@ -120,8 +120,8 @@ describe BaseCrm::Deal do
   end
 
   describe "#contacts" do
-    let(:scope) { mock }
-    let(:fetch_scope) { mock }
+    let(:scope) { double }
+    let(:fetch_scope) { double }
 
     it "passes the token and users fetch_for_deal" do
       subject.should_receive(:pass_headers).with(BaseCrm::Contact).and_return(scope)
@@ -131,8 +131,8 @@ describe BaseCrm::Deal do
   end
 
   describe "#forecasting" do
-    let(:scope) { mock }
-    let(:fetch_scope) { mock }
+    let(:scope) { double }
+    let(:fetch_scope) { double }
 
     it "passes the token and uses fetch_for_deal" do
       subject.should_receive(:pass_headers).with(BaseCrm::Forecasting).and_return(scope)

data/spec/base_crm/forecasting_spec.rb

@@ -17,9 +17,9 @@ describe BaseCrm::Forecasting do
   end
 
   describe ".fetch_for_deal" do
-    let(:scope) { mock }
-    let(:deal) { mock(:id => 444) }
-    let(:result) { mock }
+    let(:scope) { double }
+    let(:deal) { double(:id => 444) }
+    let(:result) { double }
 
     it "returns the scope" do
       BaseCrm::Forecasting.should_receive(:scope).and_return(scope)

data/spec/base_crm/lead_spec.rb

@@ -36,7 +36,7 @@ describe BaseCrm::Lead do
     end
 
     context "collection" do
-      let(:items) { mock }
+      let(:items) { double }
       let(:response) do
         { "items" => items }
       end

data/spec/base_crm/resource_mixin_spec.rb

@@ -9,11 +9,11 @@ describe BaseCrm::Resource do
   describe "#pass_headers" do
     let(:instance) { ResourceMixinTestClass.headers(headers).build_one({}) }
     let(:token_name) { BaseCrm.config.token_name }
-    let(:token) { mock }
+    let(:token) { double }
     let(:headers) do
       { token_name => token }
     end
-    let(:other_klass) { mock }
+    let(:other_klass) { double }
 
     it "copies the token header from the original scope" do
       other_klass.should_receive(:headers).with(token_name => token)

data/spec/base_crm/session_spec.rb

@@ -9,8 +9,8 @@ describe BaseCrm::Session do
   end
 
   describe "passing of headers" do
-    let(:scope) { mock }
-    let(:scope_class) { mock }
+    let(:scope) { double }
+    let(:scope_class) { double }
 
     before do
       scope_class.should_receive(:headers).with({

data/spec/support/noteable_shared_examples.rb

@@ -1,9 +1,9 @@
 shared_examples "noteable" do |noteable_type|
 
-  let(:scope) { mock }
+  let(:scope) { double }
 
   describe "#notes" do
-    let(:fetch_scope) { mock }
+    let(:fetch_scope) { double }
 
     it "passes the token and applies the params" do
       subject.
@@ -20,20 +20,41 @@ shared_examples "noteable" do |noteable_type|
 
   end
 
-  describe "#create_note" do
+  describe "#notes.create" do
     let(:message) { mock }
     let(:note) { mock }
+    let(:fetch_scope) { mock }
 
-    it "creates a new note" do
+    it "passes the token and applies the params" do
       subject.
         should_receive(:pass_headers).
         with(BaseCrm::Note).
         and_return(scope)
+      scope.should_receive(:params).
+        with({
+          :noteable_type => noteable_type,
+          :noteable_id => subject.id
+        }).and_return(scope)
       scope.should_receive(:create).with({
         :content => message,
         :noteable_type => noteable_type,
         :noteable_id => subject.id
       }).and_return(note)
+      subject.notes.create(:content => message).should == note
+    end
+
+  end
+
+  describe "#create_note" do
+    let(:message) { mock }
+    let(:notes) { mock }
+    let(:note) { mock }
+
+    it "creates a new note" do
+      subject.should_receive(:notes).and_return(notes)
+      notes.should_receive(:create).with({
+        :content => message
+      }).and_return(note)
       subject.create_note(message).should == note
     end
 

data/spec/support/taskable_shared_examples.rb

@@ -1,9 +1,9 @@
 shared_examples "taskable" do |taskable_type|
 
-  let(:scope) { mock }
+  let(:scope) { double }
 
   describe "#tasks" do
-    let(:fetch_scope) { mock }
+    let(:fetch_scope) { double }
 
     it "passes the token and applies the params" do
       subject.
@@ -20,18 +20,23 @@ shared_examples "taskable" do |taskable_type|
 
   end
 
-  describe "#create_task" do
+  describe "#tasks.create" do
     let(:params) do
       { :content => task_content }
     end
-    let(:task_content) { mock }
-    let(:task) { mock }
+    let(:task_content) { double }
+    let(:task) { double }
 
     it "creates a new task" do
       subject.
         should_receive(:pass_headers).
         with(BaseCrm::Task).
         and_return(scope)
+      scope.should_receive(:params).
+        with({
+          :taskable_type => taskable_type,
+          :taskable_id => subject.id
+        }).and_return(scope)
       scope.should_receive(:create).with({
         :content => task_content,
         :taskable_type => taskable_type,
@@ -39,6 +44,23 @@ shared_examples "taskable" do |taskable_type|
       }).and_return(task)
       subject.create_task(params).should == task
     end
+  end
+
+  describe "#create_task" do
+    let(:params) do
+      { :content => task_content }
+    end
+    let(:task_content) { mock }
+    let(:tasks) { mock }
+    let(:task) { mock }
+
+    it "creates a new task" do
+      subject.should_receive(:tasks).and_return(tasks)
+      tasks.should_receive(:create).with({
+        :content => task_content
+      }).and_return(task)
+      subject.create_task(params).should == task
+    end
 
   end
 

metadata

@@ -1,41 +1,39 @@
 --- !ruby/object:Gem::Specification
 name: basecrm
 version: !ruby/object:Gem::Version
-  version: 0.0.3
-  prerelease: 
+  version: 0.1.0
 platform: ruby
 authors:
 - Marcin Bunsch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-20 00:00:00.000000000 Z
+date: 2013-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: api_client
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.4.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.4.2
 description: Base CRM API Client
 email:
-- marcin@futuresimple.com
+- marcin@getbase.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
 - LICENSE
 - README.md
@@ -52,6 +50,7 @@ files:
 - lib/base_crm/lead.rb
 - lib/base_crm/note.rb
 - lib/base_crm/noteable.rb
+- lib/base_crm/related_object_scope.rb
 - lib/base_crm/resource.rb
 - lib/base_crm/session.rb
 - lib/base_crm/source.rb
@@ -74,27 +73,26 @@ files:
 - spec/support/taskable_shared_examples.rb
 homepage: https://github.com/basecrm/basecrm
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.5
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Base CRM API Client
 test_files:
 - spec/base_crm/account_spec.rb
@@ -110,4 +108,3 @@ test_files:
 - spec/spec_helper.rb
 - spec/support/noteable_shared_examples.rb
 - spec/support/taskable_shared_examples.rb
-has_rdoc: