basecomm_sdk 1.1.4 → 1.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: cd06ef7476c4ae5bd31583ba41b194e0ffebdf2e
-  data.tar.gz: 75a78fd86571e7ebe514e03fdf1a520f6dc64be9
+  metadata.gz: 7077053c37e3bff20c17dcf43fad28ba7a69259a
+  data.tar.gz: 9e96e414ff8d23ae43e76b6248a309f37b28179b
 SHA512:
-  metadata.gz: dbed7bca8113b239ff8c951f34c12caaa785442c999659a2465057ba8bcf3a66284a1ec890c2da7990d9226e5e0bec6ebf1a60078659d5301a180341011ca7c0
-  data.tar.gz: 9b2ee34f908fc4aa208326d085c30af3e49da2116018c0c92af996fe9e71f58e4b9972802fc459b273379c64d551e3537c7df3dda6fc7ad75d9139fc3653046c
+  metadata.gz: 854bb28168b558c648caa6dfa27920e304d10524e40720d26cc22f043a099b2f73b5e2f8277c9db237e20b3c381dabc36e0e1b3cdcdeb5d1764fc9b75fddb1e6
+  data.tar.gz: 0f4f3aac087d73c938bc51f04f80268c3d1c04cf3a7dcd30a5fc03de0f7e78edc453e452722ec10935dcc11d488eb44d5f649a718099ffa12da7c8e6930984b9

data/CHANGELOG

@@ -1,3 +1,7 @@
+*1.1.5* (March 25, 2015)
+
+* Status date defaults to current time and set status date correctly for initiated.
+
 *1.1.4* (March 25, 2015)
 
 * Account for JSON format changes for failures

data/README.md

@@ -1,6 +1,6 @@
 # Base Commerce SDK
 
-**Version: 1.1.4**
+**Version: 1.1.5**
 
 A gem for interfacing with the [Base Commerce](http://www.basecommerce.com/) API. This gem was developed with their help and serves to provide a Gem wrapper around their own Ruby SDK. Please contact them for more information about the Ruby SDK.
 

data/basecomm_sdk.gemspec

@@ -37,4 +37,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'guard-rspec'
   spec.add_development_dependency 'guard-bundler'
   spec.add_development_dependency 'guard-rubocop'
+  spec.add_development_dependency 'timecop'
 end

data/lib/basecomm_sdk/bank_account_transaction.rb

@@ -64,10 +64,15 @@ module BasecommSdk
     end
 
     def status_date
-      if status_name == STATUS[:xs_bat_status_returned]
-        return_date
-      else
-        settlement_date
+      case status_name
+        when STATUS[:xs_bat_status_returned]
+          return_date
+        when STATUS[:xs_bat_status_settled]
+          settlement_date
+        when STATUS[:xs_bat_status_initiated]
+          effective_date
+        else
+          Time.now.strftime('%m/%d/%Y %H:%M:%S')
       end
     end
 

data/lib/basecomm_sdk/version.rb

@@ -1,3 +1,3 @@
 module BasecommSdk
-VERSION = "1.1.4"
+VERSION = "1.1.5"
 end

data/spec/lib/basecomm_sdk/bank_account_transaction_spec.rb

@@ -132,9 +132,16 @@ module BasecommSdk
         expect(bat.status_date).to eq(bat.return_date)
       end
 
-      it 'returns settlement_date by default' do
+      it 'returns effective_date for initiated' do
+        Timecop.freeze(Time.now)
         bat = described_class.from_json(bat_initiated_json)
-        expect(bat.status_date).to eq(bat.settlement_date)
+        expect(bat.status_date).to eq(bat.effective_date)
+      end
+
+      it 'returns now by default' do
+        Timecop.freeze(Time.now)
+        bat = described_class.from_json(bat_created_json)
+        expect(bat.status_date).to eq(Time.now.strftime('%m/%d/%Y %H:%M:%S'))
       end
     end
 

data/spec/spec_helper.rb

@@ -37,6 +37,7 @@ FactoryGirl.define do
   skip_create
 end
 require_relative 'factories'
+require 'timecop'
 
 RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods

data/spec/support/shared_responses.rb

@@ -80,5 +80,12 @@ shared_context 'bat_response_methods' do
       status_description: 'Initiated Transaction'
     ).to_json
   end
+
+  def bat_created_json(opts = {})
+    bat_hash(
+        status_name: 'CREATED',
+        status_description: 'Created Transaction'
+    ).to_json
+  end
 end
 # rubocop:enable all

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: basecomm_sdk
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.5
 platform: ruby
 authors:
 - Chris Blackburn
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-25 00:00:00.000000000 Z
+date: 2015-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dotenv
@@ -263,6 +263,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby client gem for Base Commerce ACH provider
 email:
 - chris@gosimplefin.com