basecomm_sdk 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eb7fbc4f03ddbf7dbfd5172c005d062990caf5b8
-  data.tar.gz: 81a7b91b8f0731c03276d1a2cd04f5733ce523d5
+  metadata.gz: 8afd7b3fe8ef4b23d769c1fe94ff7d95bf37077f
+  data.tar.gz: 1ca37570d8850f4c5265347d708c373a206a2a8d
 SHA512:
-  metadata.gz: 0510ac6aab1b1926f7dbc280a8b3890c80acef885cfa8ff9f3155b12a55e596ccee069c8ffb6d6690ccb13d566d9959725402193e1e13f642fb3d29137dc73f8
-  data.tar.gz: c4d9344d9469b935aff39116bbe9b418dfca0e8ad148ce033870987832643cd6673d7863f1d4ca6837b525816579954e47beffab9d7d89338f12776065d4b496
+  metadata.gz: f3b0a5b7f7f0ea9c1e8086c6838412227fb4de81c32eab8426ac93586f6a8d6b1e500f553fcae4a864fe79d4cc15d6178ca97c353ee846efafdddcc077bef0d1
+  data.tar.gz: 1f7a1f6f3b46e81d86e99ac49e3f9408f011747930811a8202ea1ec63659db96872133c448cde32efa2500ae81d1aba5a1c8049f0a80b56a41edf3743e37de2f

data/CHANGELOG

@@ -1,3 +1,7 @@
+*1.1.3* (March 24, 2015)
+
+* Truncate when setting account name and truncate to 32 chars
+
 *1.1.2* (March 24, 2015)
 
 * Truncate to 31 characters instead of 32.  Basecommerce documentation was incorrect.

data/README.md

@@ -1,6 +1,6 @@
 # Base Commerce SDK
 
-**Version: 1.1.2**
+**Version: 1.1.3**
 
 A gem for interfacing with the [Base Commerce](http://www.basecommerce.com/) API. This gem was developed with their help and serves to provide a Gem wrapper around their own Ruby SDK. Please contact them for more information about the Ruby SDK.
 

data/lib/basecomm_sdk/bank_account_transaction.rb

@@ -71,8 +71,8 @@ module BasecommSdk
       end
     end
 
-    def account_name
-      @account_name.to_s.slice(0, 31).strip
+    def account_name=(name)
+      @account_name = name.to_s.slice(0, 32).strip
     end
   end
 end

data/lib/basecomm_sdk/version.rb

@@ -1,3 +1,3 @@
 module BasecommSdk
-VERSION = "1.1.2"
+VERSION = "1.1.3"
 end

data/spec/lib/basecomm_sdk/bank_account_transaction_spec.rb

@@ -137,11 +137,11 @@ module BasecommSdk
     end
 
     context '.account_name' do
-      it 'truncates to 31 characters' do
+      it 'truncates to 32 characters' do
         account_name = '0123456789012345678901234567890123456789'
         expect(account_name.size).to eq(40)
         bat = create(:bank_account_transaction, account_name: account_name)
-        expect(bat.account_name.size).to eq(31)
+        expect(bat.account_name.size).to eq(32)
       end
 
       it 'truncates and trims' do
@@ -151,8 +151,8 @@ module BasecommSdk
         expect(bat.account_name.size).to eq(30)
       end
 
-      it 'retains the first 31 characters' do
-        account_name = 'exactly as I f0und it_________!'
+      it 'retains the first 32 characters' do
+        account_name = 'exactly as I f0und it__________!'
         bat = create(:bank_account_transaction, account_name: account_name)
         expect(bat.account_name).to eq(account_name)
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: basecomm_sdk
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Chris Blackburn