baseball 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89ba7861f9a4ff6ab8eb9e593ce96fd98d6ad93ff6fecf95d18ef755bfeeac51
-  data.tar.gz: e397f50bca09a4954b1eca3b7111dd5d0445712d37608633a92240e80f3b7cc3
+  metadata.gz: aa54caafe28d80c5f1d5bfd3fb52d58d3e0b5dd84b787c90b7eeb97208be8439
+  data.tar.gz: 82ac54c8286efde8e7874d55932f45a5e51cf1936b18baf61aa0c6c5737cef5a
 SHA512:
-  metadata.gz: ebaaad7c2bf243d2fb2a0fed2cceb220ce6f89ca778b0c2d49b481f979c8ffbc2d429005cbfba187eb16fd4fcb14a923ad6d205667af62c6d1d1a5e49a546f85
-  data.tar.gz: aafd95eee82921c51f340a03191b74b19e7441c0d8c71d3564ffe5365fc5020b0cf8e96fd48e3a7f891ecdf33d59d31ae7ea543afd3514736f75015cc2769aa8
+  metadata.gz: '038b299268c4e9914c98ca2a57e1fa363edb906f57c3743f3f47cd04297e1751be12ef85f8712aeb82c355660688ba92b5002b07c59b60c5245a490fdf1605f5'
+  data.tar.gz: 64f7aa0f21c737b3b3e3b2e97ca1497831a68ce371ad9413dbbaae52a32800310209bb0f2ad525942d757cb618688d75d1f37461791f5fe631667d9232058807

data/lib/baseball/batting.rb

@@ -7,8 +7,7 @@ module Batting
     def batting_average
       avg = @player[:hits].to_f / @player[:at_bats].to_f
       player_average = avg.round(3)
-      batting_average_string = player_average.to_s.sub!("0", "")
-      figure_trailing_zeroes(batting_average_string)
+      figure_lead_and_trailing_zeroes(player_average)
     end
 
     def obp
@@ -16,16 +15,14 @@ module Batting
       times_at_plate = @player[:at_bats].to_f + @player[:walks].to_f + @player[:hbp].to_f + @player[:sac_flies]
       obp = times_on_base.to_f / times_at_plate.to_f
       player_obp = obp.round(3)
-      player_obp_string = player_obp.to_s.sub!("0", "")
-      figure_trailing_zeroes(player_obp_string)
+      figure_lead_and_trailing_zeroes(player_obp)
     end
 
     def slugging_percentage
       total_bases = @player[:singles] + (@player[:doubles] * 2) + (@player[:triples] * 3) + @player[:hr] * 4
       slg = total_bases.to_f / @player[:at_bats].to_f
       slg = slg.round(3)
-      slg_string = slg.to_s.sub!("0", "")
-      figure_trailing_zeroes(slg_string)
+      figure_lead_and_trailing_zeroes(slg)
     end
 
     def ops
@@ -33,22 +30,11 @@ module Batting
       player_ops_string = player_ops.round(3)
       player_ops_string = player_ops_string.to_s
       if player_ops_string[0] === "0"
-        player_ops_string.to_s.sub!("0", "")
+        remove_leading_zero(player_ops_string)
       else
-        return player_ops_string
+        player_ops_string
       end
     end
-
-    def base_runs
-      # a = hits + walks - hr
-      # b = (1.4 * totalbases - .6 * hits - 3 * HR + .1 * BB) * 1.02
-      # c = AB - Hits
-      # D = HR
-
-      # x = (A * B) / (B + C)
-      # x + D
-    end
-
   end
 
 end

data/lib/baseball/fielding.rb

@@ -9,8 +9,7 @@ module Fielding
       plays_plus_errors = plays + @player[:errors]
       player_avg = plays.to_f / plays_plus_errors.to_f
       avg = player_avg.round(3)
-      fielding_percentage = avg.to_s.sub!("0", "")
-      figure_trailing_zeroes(fielding_percentage)
+      figure_lead_and_trailing_zeroes(avg)
     end
   end
 

data/lib/baseball/pitching.rb

@@ -12,7 +12,7 @@ module Pitching
     end
 
     def whip
-      corrected_innings = third_inning_handler(@player[:ip]).to_f
+      corrected_innings = third_of_an_inning_handler(@player[:ip]).to_f
       walks_plus_hits = @player[:walks] + @player[:hits]
       figured_whip = walks_plus_hits / corrected_innings
       figured_whip = figured_whip.round(3)

data/lib/baseball/player.rb

@@ -6,8 +6,8 @@ module Player
       @player = player
     end
 
-    def figure_trailing_zeroes(arg)
-      revised_number = arg
+    def figure_lead_and_trailing_zeroes(arg)
+      revised_number = self.remove_leading_zero(arg)
 
       if revised_number.length === 3
         revised_number = "#{revised_number}0"
@@ -18,24 +18,26 @@ module Player
       end
     end
 
-    def third_inning_handler(innings)
+    def third_of_an_inning_handler(innings)
       innings_string = innings.to_s
       final_fig = innings_string[0..(innings_string.length - 2)]
       final_num = innings_string[(innings_string.length - 2)..innings_string.length].to_f
-
+      returnable_innings = final_fig.to_f
       if final_num == 0.1
-  	    returnable_innings = final_fig.to_f
         returnable_innings += 0.33
         returnable_innings.to_s
       elsif final_num == 0.2
-        returnable_innings = final_fig.to_f
         returnable_innings += 0.66
         returnable_innings.to_s
       else
-        return innings
+        innings
       end
     end
 
+    def remove_leading_zero(arg)
+      arg.to_s.sub("0", "")
+    end
+
   end
 
 end

data/lib/baseball/running.rb

@@ -7,8 +7,8 @@ module Running
     def stolen_base_percentage
       player_stolen_base_percentage = @player[:stolen_bases].to_f / (@player[:stolen_bases ].to_f + @player[:caught_stealing].to_f)
       stealing_average = player_stolen_base_percentage.round(3)
-      average_string = stealing_average.to_s.sub!("0", "")
-      figure_trailing_zeroes(average_string)
+      average_string = remove_leading_zero(stealing_average)
+      figure_lead_and_trailing_zeroes(average_string)
     end
 
     def stolen_base_runs
@@ -17,8 +17,6 @@ module Running
       adjusted_stolen_base_runs = stolen_base_adjustment - caught_stealing_adjustment
       base_runs = adjusted_stolen_base_runs.round(3)
       return base_runs.to_s
-      #Created by Total baseball
-      # (.3 x stolen bases) - (.6 x caught stealing)
     end
   end
 

data/lib/baseball/version.rb

@@ -1,3 +1,3 @@
 module Baseball
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: baseball
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Brent Busby
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-20 00:00:00.000000000 Z
+date: 2018-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler