base_indexer 4.0.0 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9044a8dc8006eb311f4a709b071fd22bdc635115
-  data.tar.gz: d89c940569d6c4003e3fc6f2a9a68b4971e98c66
+  metadata.gz: c8f6c9fe93cdb8c749639fd26bfe007dcc246231
+  data.tar.gz: 887ba6c804e3c76781349b152769ea85d4bfa923
 SHA512:
-  metadata.gz: 364f6a44ea77b4470279180a0b35f0124ab68dca3c5a77389dc6a6283d9ed5b81b0c6455e1f4bdc03abef2a7f9f9380209dcc99119c0a6e30a97e365f906e32f
-  data.tar.gz: 65b5a40a35a4cd47f65d990e30cd94554ae4ab9cd2ad77539e9bced88f56653f4e04b639c4722cdbafa7787deae45cffe02edab10c0d49a99f19f988ab716f6e
+  metadata.gz: df9803e1db13503ace967895f80af1bc5174990c2411527a6fe874692dcd2de02478dad5f0e7f637642b66e765d621767e1b9e00e708ecde8f5395090888cc42
+  data.tar.gz: a3433db07d6f23d68638e7b095472d4baf6783230538beccab8d8fd217cf9f4b64710b57e912de7a3378e2c9655125be3df03537f6aafda8c97c76922eb62f45

data/.travis.yml

@@ -2,8 +2,8 @@ notifications:
   email: false
 
 rvm:
+  - 2.4.3
   - 2.3.1
-  - 2.2.5
 
 env:
   global:

data/app/controllers/base_indexer/collections_controller.rb

@@ -28,13 +28,13 @@ module BaseIndexer
       end
 
       @status = report_success
-      render nothing: true, status: 200
+      head :ok
       Rails.logger.debug "Completing indexing of collection #{druid}"
 
     rescue Exception => e
       @status = report_failure request.method_symbol, params, e
       Rails.logger.error @status
-      render nothing: true, status: 500
+      head :internal_server_error
     end
   end
 end

data/app/controllers/base_indexer/items_controller.rb

@@ -7,11 +7,11 @@ module BaseIndexer
 
       indexer = BaseIndexer.indexer_class.constantize.new
       indexer.index druid, { subtarget_params => true }
-      render nothing: true, status: 200
+      head :ok
       Rails.logger.debug "Completing indexing #{druid}"
     rescue StandardError => e
       Rails.logger.error report_failure request.method_symbol, params, e
-      render nothing: true, status: 500
+      head :internal_server_error
     end
 
     def destroy
@@ -25,11 +25,11 @@ module BaseIndexer
         # Only delete from specified subtarget
         indexer.index druid, { subtarget_params => false }
       end
-      render nothing: true, status: 200
+      head :ok
       Rails.logger.debug "Completing deleting #{druid}"
     rescue StandardError => e
       Rails.logger.error report_failure request.method_symbol, params, e
-      render nothing: true, status: 500
+      head :internal_server_error
     end
 
     private

data/base_indexer.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |s|
   s.executables   = s.files.grep(%r{^exe/}) { |f| File.basename(f) }
   s.require_paths = ["lib"]
   
-  s.add_dependency 'rails', '>= 4', '< 6'
+  s.add_dependency 'rails', '~> 5'
   s.add_dependency 'discovery-indexer', '>= 2', '< 4'
   s.add_dependency 'retries'
   s.add_dependency 'dor-fetcher'

data/lib/base_indexer/version.rb

@@ -1,3 +1,3 @@
 module BaseIndexer
-  VERSION = '4.0.0'
+  VERSION = '4.1.0'
 end

data/spec/controllers/base_indexer/items_controller_spec.rb

@@ -8,12 +8,12 @@ describe BaseIndexer::ItemsController, type: :controller do
   describe 'PATCH/PUT update' do
     it 'creates an indexing job' do
       expect(my_instance).to receive(:index).with('bb1111cc2222', 'SEARCHWORKS' => true)
-      patch :update, druid: 'druid:bb1111cc2222', subtarget: 'SEARCHWORKS', use_route: :base_indexer
+      patch :update, params: { druid: 'druid:bb1111cc2222', subtarget: 'SEARCHWORKS', use_route: :base_indexer }
       expect(response.status).to eq 200
     end
     it 'when something bad happens return a 500' do
       expect(my_instance).to receive(:index).with('bb1111cc2222', 'SEARCHWORKS' => true).and_raise(StandardError)
-      patch :update, druid: 'druid:bb1111cc2222', subtarget: 'SEARCHWORKS', use_route: :base_indexer
+      patch :update, params: { druid: 'druid:bb1111cc2222', subtarget: 'SEARCHWORKS', use_route: :base_indexer }
       expect(response.status).to eq 500
     end
   end
@@ -21,14 +21,14 @@ describe BaseIndexer::ItemsController, type: :controller do
     context 'with a subtarget' do
       it 'sends an "#index" with a false to the IndexerEngine' do
         expect(my_instance).to receive(:index).with('bb1111cc2222', 'SEARCHWORKS' => false)
-        delete :destroy, druid: 'druid:bb1111cc2222', subtarget: 'SEARCHWORKS', use_route: :base_indexer
+        delete :destroy, params: { druid: 'druid:bb1111cc2222', subtarget: 'SEARCHWORKS', use_route: :base_indexer }
         expect(response.status).to eq 200
       end
     end
     context 'without a subtarget' do
       it 'sends a "#delete" to the IndexerEngine' do
         expect(my_instance).to receive(:delete).with('bb1111cc2222')
-        delete :destroy, druid: 'druid:bb1111cc2222', use_route: :base_indexer
+        delete :destroy, params: { druid: 'druid:bb1111cc2222', use_route: :base_indexer }
         expect(response.status).to eq 200
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: base_indexer
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.1.0
 platform: ruby
 authors:
 - Ahmed Alsum
@@ -9,28 +9,22 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-01-10 00:00:00.000000000 Z
+date: 2018-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '4'
-    - - "<"
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '6'
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: discovery-indexer
   requirement: !ruby/object:Gem::Requirement
@@ -306,7 +300,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Summary of BaseIndexer.