base_editing_bootstrap 1.8.1 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40690c34bdbdecebbcf083394fefe5ea626b958a085ce695fe4a039b17c8cfa9
-  data.tar.gz: a087acc3bda536ea0451af2e3818cc2c07c20a3a6a5e549bb74e96d7abcd6dd5
+  metadata.gz: e3e85aa56464a6efc36c36170a8d8473b8c6c97107f62ba9a3d9599232c0d30b
+  data.tar.gz: 48c8890bba4d8740cfb1a210a93a9743b658fa3ef505f0c39db5b6b621504a35
 SHA512:
-  metadata.gz: f85bc8f2ed0aa273b2e59258ace609e711dbcb088bf9420a5eaf5a48aa7a48c0907f7d6eb75ac9614cfcf0f536f1124a7bd9ee9541c68c3f4d29908e739a280d
-  data.tar.gz: 5565e435135fd2bae6a1a6e1907a6d150cb6be69d5b82c52d91095a3637efa811322519ae6f696578760b961339cd986b036f508a06d08532311f88d53209508
+  metadata.gz: 9716d018b278998444613dec959a1cf70938d17b02828ff3c5b4bd1efa3ef5ec94e46fefcc06de6f8329f04201f12a2a57ad3375867d5e9f693f0c18a16db4e3
+  data.tar.gz: 6236f739ce354a526bbab9664337dccecc6b54f39976c7491cbc3bc15b8d8d4f310714bb0df6c08b5815d37343563da1dfc1528d6b865cf7eaadcd6c235bad5d

data/CHANGELOG.md

@@ -2,6 +2,25 @@
 All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.
 
 - - -
+## 1.9.0 - 2025-07-30
+#### Bug Fixes
+- Correct add is-invalid class on relation fields - (21e4a92) - Marino Bonetti
+- Correct path generator for namespaced resources - (a4f72c8) - Marino Bonetti
+- Migliore formattazione generatore - (1ceda4d) - Marino Bonetti
+- Creazione dei nested attributi necessari con belongs to - (564f61b) - Marino Bonetti
+- Correct Shared Specs - (1994128) - Marino Bonetti
+- Authentication Model configurable (#19) - (cef424f) - Marino Bonetti
+- Errore Traduzione di test - (95ff702) - Marino Bonetti
+#### Documentation
+- Add info on test matrix - (b097a01) - Marino Bonetti
+#### Features
+- Configurable test controller requests - (327163e) - Marino Bonetti
+- In caso di molti attributi struttura multilinea - (21dfe09) - Marino Bonetti
+- Add customizable title New and Edit - (d484e23) - Marino Bonetti
+- Check model inheritance for partial search (#18) - (14f081f) - Marino Bonetti
+
+- - -
+
 ## 1.8.1 - 2025-03-24
 #### Bug Fixes
 - Correct generator install multiple gems - (73948f5) - Marino Bonetti

data/README.md

@@ -1,7 +1,9 @@
 # BaseEditingBootstrap
 [![Gem Version](https://badge.fury.io/rb/base_editing_bootstrap.svg)](https://badge.fury.io/rb/base_editing_bootstrap)
 
-WIP
+### Active tested on:
+* rails: 7.x,8.x
+* ruby: 3.x
 
 ## Installation
 Add this line to your application's Gemfile:

data/app/helpers/utilities/page_helper.rb

@@ -1,13 +1,22 @@
 module Utilities::PageHelper
   include Utilities::IconHelper
+
+  ##
+  # Traduzione del titolo EDIT con possibilità di modificare intestazione rispetto a modello
+  # - Il default è quello di Utilizzare la chiave .edit
+  # - Viene cercato la traduzione con la chiave titles.CHIAVE_I18N_MODELLO.edit
   # @param [BaseModel] base_class
   def title_mod_g(base_class)
-    "#{t("edit")} #{base_class.model_name.human}"
+    "#{t("titles.#{base_class.model_name.i18n_key}.edit", default: :edit)} #{base_class.model_name.human}"
   end
 
+  ##
+  # Traduzione del titolo NUOVO con possibilità di modificare intestazione rispetto a modello
+  # - Il default è quello di Utilizzare la chiave .new
+  # - Viene cercato la traduzione con la chiave titles.CHIAVE_I18N_MODELLO.new
   # @param [BaseModel] base_class
   def title_new_g(base_class)
-    "#{t("new")} #{base_class.model_name.human}"
+    "#{t("titles.#{base_class.model_name.i18n_key}.new", default: :new)} #{base_class.model_name.human}"
   end
 
   # Quando e se servirà verrà testato:

data/app/helpers/utilities/template_helper.rb

@@ -15,20 +15,34 @@ module Utilities::TemplateHelper
   def find_template_with_fallbacks(obj, field, base_path, generic_field)
     # nei casi in cui passiamo la classe e non l'oggetto, dobbiamo utilizzare un metodo interno a rails per
     # avere la partial_path
+
+    obj_base_paths = []
+    # Primo livello in cui troviamo la partial path rispetto ad istanza o classe
     partial_path = (obj.respond_to? :to_partial_path) ? obj.to_partial_path : obj._to_partial_path
-    obj_base_path = "#{partial_path}/#{base_path}"
+    obj_base_paths << "#{partial_path}/#{base_path}"
+
+    # Cerchiamo anche tutti i livelli di inheritance del modello
+    start_class = ((obj.respond_to? :to_partial_path) ? obj.class : obj).superclass
+
+    while start_class < ApplicationRecord
+      partial_path = start_class._to_partial_path
+      obj_base_paths << "#{partial_path}/#{base_path}"
+      start_class = start_class.superclass
+    end
 
     [
       # Precedenza modello e campo specifico
-      [field, [obj_base_path]],
+      ["Campo SPECIFICO + inheritance tra modelli", field, obj_base_paths],
       # cerco tramite nome modello semplice, con namespace della risorsa (cell_field,header_field,form_field) e nome del campo specifico
-      ["#{obj.model_name.element}/#{base_path}/#{field}", lookup_context.prefixes],
+      ["Campo specifico con nome modello + inheritance controllers", "#{obj.model_name.element}/#{base_path}/#{field}", lookup_context.prefixes],
+      # cerco struttura senza il livello del nome del modello
+      ["Campo specifico senza nome modello + inheritance controllers", "#{base_path}/#{field}", lookup_context.prefixes],
       # Ricerca tramite campo generico e prefissi di contesto che contiene anche controller e namespace di controller
-      ["#{base_path}/#{generic_field}", lookup_context.prefixes],
-      [generic_field, [obj_base_path]],
-      ["base_editing/#{base_path}/#{generic_field}", []],
-    ].each do |partial, prefixes|
-      Rails.logger.debug { "[BASE EDITING BOOTSTRAP] Cerco partial:`#{partial}` in #{prefixes.inspect}" }
+      ["Campo GENERICO + inheritance controllers", "#{base_path}/#{generic_field}", lookup_context.prefixes],
+      ["Campo GENERICO + inheritance tra modelli", generic_field, obj_base_paths],
+      ["Default BaseEditingController", "base_editing/#{base_path}/#{generic_field}", []],
+    ].each do |desc,partial, prefixes|
+      Rails.logger.debug { "[BASE EDITING BOOTSTRAP] #{desc} - partial:`#{partial}` in #{prefixes.inspect}" }
       if lookup_context.exists?(partial, prefixes, true)
         return lookup_context.find(partial, prefixes, true)
       end

data/config/locales/it.yml

@@ -78,8 +78,4 @@ it:
       i_cont: "contiene"
   base_editing:
     form_base_errors:
-      title: Presenti errori generici
-  post:
-    base_editing:
-      form_base_errors:
-        title: Presenti errori per il modello POST
+      title: Presenti errori generici

data/lib/base_editing_bootstrap/VERSION

@@ -1 +1 @@
-1.8.1
+1.9.0

data/lib/base_editing_bootstrap/base_model.rb

@@ -25,7 +25,7 @@ module BaseEditingBootstrap
         if auth_object
           Pundit.policy(auth_object, self.new).permitted_attributes_for_ransack.map(&:to_s)
         else
-          Pundit.policy(User.new, self.new).permitted_attributes_for_ransack.map(&:to_s)
+          Pundit.policy(BaseEditingBootstrap.authentication_model.new, self.new).permitted_attributes_for_ransack.map(&:to_s)
         end
       end
 
@@ -33,7 +33,7 @@ module BaseEditingBootstrap
         if auth_object
           Pundit.policy(auth_object, self.new).permitted_associations_for_ransack.map(&:to_s)
         else
-          Pundit.policy(User.new, self.new).permitted_associations_for_ransack.map(&:to_s)
+          Pundit.policy(BaseEditingBootstrap.authentication_model.new, self.new).permitted_associations_for_ransack.map(&:to_s)
         end
       end
 
@@ -41,7 +41,7 @@ module BaseEditingBootstrap
         if auth_object
           Pundit.policy(auth_object, self.new).permitted_scopes_for_ransack.map(&:to_s)
         else
-          Pundit.policy(User.new, self.new).permitted_scopes_for_ransack.map(&:to_s)
+          Pundit.policy(BaseEditingBootstrap.authentication_model.new, self.new).permitted_scopes_for_ransack.map(&:to_s)
         end
       end
     end

data/lib/base_editing_bootstrap/forms/base.rb

@@ -26,7 +26,13 @@ module BaseEditingBootstrap::Forms
     #
     def form_style_class_for(method, options = {}, base_classes: ["form-control"])
       classes = base_classes
-      classes << "is-invalid" if object.errors && object.errors.include?(method)
+      if object.errors
+        classes << "is-invalid" if object.errors.include?(method)
+        # caso in cui il metodo è una relazione
+        if method.to_s.match(/(.*)_id\z/)
+          classes << "is-invalid" if object.errors.include?(Regexp.last_match(1))
+        end
+      end
       classes << options[:class].split(" ") if options[:class]
       classes.flatten.compact.uniq.join(" ")
     end
@@ -47,7 +53,7 @@ module BaseEditingBootstrap::Forms
 
     def select(method, choices = nil, options = {}, html_options = {}, &block)
       html_options.merge!(class: form_style_class_for(method, html_options, base_classes: ["form-control", "form-select"]))
-      super(method, choices, options,html_options , &block)
+      super(method, choices, options, html_options, &block)
     end
 
     def check_box(method, options = {}, checked_value = "1", unchecked_value = "0")

data/lib/base_editing_bootstrap/generators_helpers.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'active_support/concern'
+
+module BaseEditingBootstrap::GeneratorsHelpers
+  extend ActiveSupport::Concern
+
+  included do
+
+    private
+    def class_to_view_path(class_name)
+      base_path = ["app/views"]
+
+      base_path << class_name.deconstantize.then { |c| c.underscore.downcase }
+      singular_name = class_name.demodulize.underscore.downcase.singularize
+      base_path << singular_name.pluralize
+      base_path << singular_name
+      base_path.compact_blank!
+    end
+
+  end
+
+end
+

data/lib/base_editing_bootstrap.rb

@@ -36,8 +36,20 @@ module BaseEditingBootstrap
   # possibili valori :edit , :index  
   config_accessor :after_success_create_redirect, default: :edit
 
+  ##
+  # Classe che rappresenta l'utente, solitamente User
+  config_accessor :authentication_model_class, default: "User"
+
+  def self.authentication_model
+    self.authentication_model_class.constantize
+  end
+
+  ##
+  # Factory per la creazione del modello che rappresenta l'auteticazione
+  config_accessor :authentication_model_factory, default: :user
+
   def self.deprecator
-    @deprecator ||= ActiveSupport::Deprecation.new("1.0", "BaseEditingBootstrap")
+    @deprecator ||= ActiveSupport::Deprecation.new("2.0", "BaseEditingBootstrap")
   end
 
 end

data/lib/generators/base_editing_bootstrap/cell_override/cell_override_generator.rb

@@ -3,6 +3,7 @@
 module BaseEditingBootstrap
   module Generators
     class CellOverrideGenerator < ::Rails::Generators::Base
+      include BaseEditingBootstrap::GeneratorsHelpers
       source_root File.expand_path("../../../../app/views/base_editing", __dir__)
       argument :name, type: :string, banner: "Post", required: true
       argument :attributes, type: :array, default: [], banner: "field field:type"
@@ -20,15 +21,15 @@ module BaseEditingBootstrap
         if attributes.empty?
           say "Need one field"
         else
-          singular_name = name.underscore.downcase.singularize
-          plural_name = singular_name.pluralize
+          base_path = class_to_view_path(name)
+
           attributes.each do |a|
             attr_name, type = a.split(":")
 
             type = :base if type.nil?
             type = type.to_sym
             raise "Type #{type} not found in #{TYPES}" unless TYPES.include?(type)
-            copy_file "cell_field/_#{type}.html.erb", File.join("app/views", plural_name, singular_name, 'cell_field', "_#{attr_name}.html.erb")
+            copy_file "cell_field/_#{type}.html.erb", File.join(*base_path, 'cell_field', "_#{attr_name}.html.erb")
           end
         end
 

data/lib/generators/base_editing_bootstrap/field_override/field_override_generator.rb

@@ -3,6 +3,7 @@
 module BaseEditingBootstrap
   module Generators
     class FieldOverrideGenerator < ::Rails::Generators::Base
+      include BaseEditingBootstrap::GeneratorsHelpers
       source_root File.expand_path("../../../../app/views/base_editing", __dir__)
       argument :name, type: :string, banner: "Post", required: true
       argument :attributes, type: :array, default: [], banner: "field field:type"
@@ -20,15 +21,16 @@ module BaseEditingBootstrap
         if attributes.empty?
           say "Need one field"
         else
-          singular_name = name.underscore.downcase.singularize
-          plural_name = singular_name.pluralize
+
+          base_path = class_to_view_path(name)
+
           attributes.each do |a|
             attr_name, type = a.split(":")
 
             type = :base if type.nil?
             type = type.to_sym
             raise "Type #{type} not found in #{TYPES}" unless TYPES.include?(type)
-            copy_file "form_field/_#{type}.html.erb", File.join("app/views", plural_name, singular_name, 'form_field', "_#{attr_name}.html.erb")
+            copy_file "form_field/_#{type}.html.erb", File.join(*base_path,"form_field", "_#{attr_name}.html.erb")
           end
         end
 

data/lib/generators/base_editing_bootstrap/header_override/header_override_generator.rb

@@ -3,6 +3,8 @@
 module BaseEditingBootstrap
   module Generators
     class HeaderOverrideGenerator < ::Rails::Generators::Base
+      include BaseEditingBootstrap::GeneratorsHelpers
+
       source_root File.expand_path("../../../../app/views/base_editing", __dir__)
       argument :name, type: :string, banner: "Post", required: true
       argument :attributes, type: :array, default: [], banner: "field field:type"
@@ -20,15 +22,15 @@ module BaseEditingBootstrap
         if attributes.empty?
           say "Need one field"
         else
-          singular_name = name.underscore.downcase.singularize
-          plural_name = singular_name.pluralize
+          base_path = class_to_view_path(name)
+
           attributes.each do |a|
             attr_name, type = a.split(":")
 
             type = :base if type.nil?
             type = type.to_sym
             raise "Type #{type} not found in #{TYPES}" unless TYPES.include?(type)
-            copy_file "header_field/_#{type}.html.erb", File.join("app/views", plural_name, singular_name, 'header_field', "_#{attr_name}.html.erb")
+            copy_file "header_field/_#{type}.html.erb", File.join(*base_path, 'header_field', "_#{attr_name}.html.erb")
           end
         end
 

data/lib/generators/base_editing_bootstrap/install/templates/initializer.rb

@@ -19,4 +19,12 @@ BaseEditingBootstrap.configure do |config|
   # possibili valori :edit , :index
   # config.after_success_create_redirect = :edit
 
+  ##
+  # Classe che rappresenta l'utente, solitamente User
+  # config.authentication_model_class= "User"
+
+  ##
+  # Factory per la creazione del modello che rappresenta l'auteticazione
+  # config.authentication_model_factory= :user
+
 end

data/lib/generators/base_editing_bootstrap/scaffold/templates/policy.rb.tt

@@ -1,17 +1,33 @@
 class <%= class_name %>Policy < BaseModelPolicy
 
-  def editable_attributes = %i[<%= attributes_names.join(" ") %>]
-  def permitted_attributes = %i[<%= attributes_names.join(" ") %>]
-  def search_result_fields = %i[<%= attributes_names.join(" ") %>]
+<%- if attributes_names.size > 3 -%>
+  <%- ["permitted_attributes","editable_attributes","search_result_fields"].each do |meth| -%>
+  def <%= meth %>
+    [
+      <%- attributes_names.each do |m| -%>
+        :<%= m %>,
+      <%- end -%>
+    ]
+  end
+
+  <%- end -%>
+<%- else -%>
+  <%- ["permitted_attributes  ","editable_attributes","search_result_fields"].each do |meth| -%>
+  def <%= meth %> = %i[<%= attributes_names.join(" ") %>]
+  <%- end -%>
+<%- end -%>
 <%- if @search_attrs.any? -%>
+
   def search_fields
     %i[<%= @search_attrs.join(" ") %>]
   end
 <%- end -%>
 <%- if @permitted_attributes.any? -%>
+
   # TODO check if correct with search_fields
   def permitted_attributes_for_ransack
     %i[<%= @permitted_attributes.join(" ") %>]
   end
 <%- end -%>
+
 end

data/spec/support/external_shared/base_editing_controller_helpers.rb

@@ -30,6 +30,8 @@ end
 # :url_for_create
 # :url_for_succ_delete
 # :url_for_fail_delete
+# :url_for_succ_create
+# :url_for_succ_update
 # :url_for_edit             ->  Rispetto  agli altri questo risulta essere pià complicato in quanto
 #                               deve ritornare una proc a cui passiamo il valore dell'istanza persistente
 #                               che nei casi del after create non abbiamo a priori.
@@ -57,6 +59,27 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
   let(:url_for_create) { url_for(model.new) }
   let(:url_for_succ_delete) { url_for(model) }
   let(:url_for_fail_delete) { url_for_succ_delete }
+
+  let(:url_for_succ_create) {
+    case BaseEditingBootstrap.after_success_create_redirect
+    when :index
+      url_for_index
+    else
+      # edit
+      url_for_edit.call(assigns[:object])
+    end
+  }
+
+  let(:url_for_succ_update) {
+    case BaseEditingBootstrap.after_success_update_redirect
+    when :index
+      url_for_index
+    else
+      # edit
+      url_for_edit.call(assigns[:object])
+    end
+  }
+
   let(:url_for_edit) { ->(p = persisted_instance) {
     url_for([p, action: :edit])
   } }
@@ -128,13 +151,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
         put url_for_update, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
         expect(response).to have_http_status(303)
-        case BaseEditingBootstrap.after_success_update_redirect
-        when :index
-          expect(response).to redirect_to(url_for_index)
-        else
-          # edit
-          expect(response).to redirect_to(url_for_edit.call(assigns[:object]))
-        end
+        expect(response).to redirect_to(url_for_succ_update)
         expect(flash.to_hash).to include("notice" => be_present)
       end
 
@@ -153,13 +170,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
         post url_for_create, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
         expect(response).to have_http_status(303)
-        case BaseEditingBootstrap.after_success_create_redirect
-        when :index
-          expect(response).to redirect_to(url_for_index)
-        else
-          # edit
-          expect(response).to redirect_to(url_for_edit.call(assigns[:object]))
-        end
+        expect(response).to redirect_to(url_for_succ_create)
         expect(flash.to_hash).to include("notice" => be_present)
       end
 

data/spec/support/external_shared/base_model.rb

@@ -27,7 +27,7 @@ RSpec.shared_examples "a base model" do |ransack_permitted_attributes: [],
 
   ##
   # Oggetto solitamente di classe User che identifichi l'utente a cui eseguire il check dei permessi
-  let(:auth_object) { :auth_object }
+  let(:auth_object) { BaseEditingBootstrap.authentication_model }
   let(:new_user_ransack_permitted_attributes) { ransack_permitted_attributes }
   let(:new_user_ransack_permitted_associations) { ransack_permitted_associations }
   let(:new_user_ransack_permitted_scopes) { ransack_permitted_scopes }
@@ -52,7 +52,7 @@ RSpec.shared_examples "a base model" do |ransack_permitted_attributes: [],
 
       let(:inner_auth_object) { nil }
       it "new user" do
-        expect(Pundit).to receive(:policy).with(an_instance_of(User),
+        expect(Pundit).to receive(:policy).with(an_instance_of(BaseEditingBootstrap.authentication_model),
                                                 an_instance_of(described_class)).and_call_original
 
         is_expected.to match_array(new_user_result)

data/spec/support/external_shared/factory_bot.rb

@@ -13,6 +13,7 @@ module FactoryBot::Syntax::Methods
     klass = FactoryBot::Internal.factory_by_name(args.first).build_class
 
     klass.reflect_on_all_associations(:belongs_to).each do |r|
+      next if r.options.fetch(:optional, false)
       association = FactoryBot.create(r.class_name.underscore)
       attributes[:"#{r.name}_id"] = association.id
       attributes[:"#{r.name}_type"] = association.class.name if r.options[:polymorphic]

data/spec/support/external_shared/pundit.rb

@@ -14,7 +14,7 @@ RSpec::Matchers.define :permit_editable_attributes do |*expected_attributes|
 end
 
 RSpec.shared_examples "a standard base model policy" do |factory, check_default_responses: false|
-  let(:user) { create(:user) }
+  let(:user) { create(BaseEditingBootstrap.authentication_model_factory) }
   let(:instance) { described_class.new(user, build(factory)) }
 
   describe "response to all necessary methods" do
@@ -68,10 +68,10 @@ RSpec.shared_examples "a standard base model policy" do |factory, check_default_
         end
       end.flatten(1).compact.uniq
 
-      elenco_campi_ordinabili_in_relazione.each do |relation,field|
+      elenco_campi_ordinabili_in_relazione.each do |relation, field|
         reflection = klass.reflect_on_association(relation.to_s)
         policy = Pundit.policy(instance.user, reflection.class_name.constantize.new)
-        expect(policy.permitted_attributes_for_ransack.collect(&:to_sym).include?(field.to_sym)).to be_truthy, lambda{
+        expect(policy.permitted_attributes_for_ransack.collect(&:to_sym).include?(field.to_sym)).to be_truthy, lambda {
           "Mi aspetto che `#{policy.class.name}#permitted_attributes_for_ransack` includa `#{field}` per permettere l'ordinamento del campo tramite relazione"
         }
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: base_editing_bootstrap
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.9.0
 platform: ruby
 authors:
 - Marino Bonetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-03-24 00:00:00.000000000 Z
+date: 2025-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -394,6 +394,7 @@ files:
 - lib/base_editing_bootstrap/base_model.rb
 - lib/base_editing_bootstrap/engine.rb
 - lib/base_editing_bootstrap/forms/base.rb
+- lib/base_editing_bootstrap/generators_helpers.rb
 - lib/base_editing_bootstrap/is_validated.rb
 - lib/base_editing_bootstrap/resource_finder.rb
 - lib/base_editing_bootstrap/searches/base.rb