base_editing_bootstrap 0.9.0 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 678f9ed5e165bf715f6e9523c7b9a29cd2d06ee4da800723a76b1efa61a5d747
-  data.tar.gz: 9a7e3297a6e03130d8cb2d1b769b91a37d20010a070fdab81dd0a029ddadfc65
+  metadata.gz: ae3826e47810ce15c5ddb8c1e4abacb4af039cec40b2f2b835170691250357d0
+  data.tar.gz: '03069a335d73eaa8d449635c544315a154a66e18758f5d3e774f804e8fbf7d9b'
 SHA512:
-  metadata.gz: 86c848f6f307910302465e1a7840f0046ab855ee60f7545f9ac68f004041d4176cff5370e02dd32d02b253a754756f0d2416de2783a1b47395d6d3ebac8cbc24
-  data.tar.gz: 7259712a03b75b24489ef7b459ac137eb7101d7e045e4bec175640b24509bcf875bc979a9bb91e23e7ecb1f977dfce14b40c6779be2fda2f39ebca587a14d328
+  metadata.gz: 036470dfdaab3d46b054539d3a958bfed2138f443248f245917a1c258f420cf2a63174ff945ff164df62a001ad343814c48f87cf31c9cab696a9995b34d0b8ee
+  data.tar.gz: 2845c50faabf84b474f57c0144876e35661c22e38b042a4386f5c9f2eef01ba4f47b516cf6fff39cd051047920a1ac0de9da26978a5d0227952f8d201601a461

data/CHANGELOG.md

@@ -2,6 +2,20 @@
 All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.
 
 - - -
+## 0.10.0 - 2024-06-26
+#### Features
+- Add sort configuration per controller - (0cca665) - Marino Bonetti
+#### Miscellaneous Chores
+- Add ignore to assets - (aff4ac6) - Marino Bonetti
+
+- - -
+
+## 0.9.1 - 2024-06-17
+#### Bug Fixes
+- Change http status check from symbol to number - (1ecd63d) - Marino Bonetti
+
+- - -
+
 ## 0.9.0 - 2024-06-16
 #### Features
 - Change default and docs for show - (f320698) - Marino Bonetti

data/README.md

@@ -86,6 +86,9 @@ Utilizzo per modello base, in questo esempio prendiamo come modello Post come es
 - Creare Controller:
   ```ruby
     class PostsController < BaseEditingController
+      ##
+      # Set default sort order for ransack
+      # self.default_sort= ["id"] 
     end
   ```
 - Aggiungere la rotta: `resources :posts`

data/app/controllers/base_editing_controller.rb

@@ -9,12 +9,19 @@ class BaseEditingController < RestrictedAreaController
                 :new_custom_polymorphic_path,
                 :show_custom_polymorphic_path
 
+  ##
+  # Configure default sort in the index query.
+  # Works like documented in https://activerecord-hackery.github.io/ransack/getting-started/sorting/#sorting-in-the-controller
+  class_attribute :default_sorts, default: ["id"]
+
   def index
     authorize base_class
 
     q = policy_scope(base_scope)
-
-    @search_instance = search_class.new(q, current_user, params: params.permit(:page, :q => {})) # FIXME trovare modo per essere più "STRONG"
+    @search_instance = search_class.new(q, current_user,
+                                        params: params.permit(:page, :q => {}), # FIXME trovare modo per essere più "STRONG"
+                                        sorts: default_sorts
+    )
     @search_instance = yield(@search_instance) if block_given?
   end
 

data/lib/base_editing_bootstrap/VERSION

@@ -1 +1 @@
-0.9.0
+0.10.0

data/lib/base_editing_bootstrap/searches/base.rb

@@ -7,24 +7,26 @@ module BaseEditingBootstrap::Searches
     include ActiveModel::Naming
     include ActiveModel::Conversion
 
-    attr_reader :model_klass, :user, :params, :scope
+    attr_reader :model_klass, :user, :params, :scope, :sorts
 
     # @param [User] user
     # @param [ActiveRecord::Associations::CollectionProxy] scope
-    def initialize(scope, user, params: {page: nil})
+    # @param [Array<String (frozen)>] sort
+    def initialize(scope, user, params: {page: nil}, sorts: ["id"])
       @model_klass = scope.klass
       @user = user
       @scope = scope
       @params = params
+      @sorts = sorts
     end
 
     ##
     # Risultato della ricerca, fa da pipeline verso ransack
+    # Impostando il sort nel caso in cui non sia già stato impostato da ransack
     def results
-      ransack_query
-        .result(distinct: true)
-        .order(:id)
-        .page(params[:page])
+      ransack_query.tap { |r|
+        r.sorts = @sorts if r.sorts.empty?
+      }.result(distinct: true).page(params[:page])
     end
 
     def ransack_query

data/lib/generators/base_editing_bootstrap/scaffold/scaffold_generator.rb

@@ -22,7 +22,7 @@ module BaseEditingBootstrap
         opts = ["--no-helper", "--parent=BaseEditingController"]
         opts << "--force" if options.force?
         generate "controller", controller_class_name, *opts
-
+        # TODO usare i template ed aggiungere l'esempio della ricerca
         route "resources :#{plural_name}"
 
         template "spec/request.rb", File.join("spec/requests", "#{plural_file_name}_spec.rb")

data/spec/support/external_shared/base_editing_controller_helpers.rb

@@ -88,7 +88,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       it "response" do
         params = {q: {"foo_eq": "foo"}}
         get url_for_index, params: params
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(200)
         expect(assigns[:search_instance]).to be_an_instance_of(BaseEditingBootstrap::Searches::Base).and(have_attributes(
                                                                                                            user: user,
                                                                                                            params: ActionController::Parameters.new(params).permit!
@@ -101,7 +101,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
     describe "new" do
       it "response" do
         get url_for_new
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(200)
         expect(assigns[:object]).to be_an_instance_of(model)
       end
     end
@@ -111,7 +111,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
     describe "edit" do
       it "response" do
         get url_for_edit.call
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(200)
         expect(assigns[:object]).to be_an_instance_of(model)
       end
     end
@@ -122,7 +122,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       it "response" do
         put url_for_update, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
-        expect(response).to have_http_status(:see_other)
+        expect(response).to have_http_status(303)
         case BaseEditingBootstrap.after_success_update_redirect
         when :index
           expect(response).to redirect_to(url_for_index)
@@ -135,7 +135,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       unless skip_invalid_checks
         it "not valid" do
           put url_for_update, params: {param_key => invalid_attributes}
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(422)
         end
       end
     end
@@ -146,7 +146,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       it "response" do
         post url_for_create, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
-        expect(response).to have_http_status(:see_other)
+        expect(response).to have_http_status(303)
         case BaseEditingBootstrap.after_success_create_redirect
         when :index
           expect(response).to redirect_to(url_for_index)
@@ -159,7 +159,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       unless skip_invalid_checks
         it "not valid" do
           post url_for_create, params: {param_key => invalid_attributes}
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(422)
         end
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: base_editing_bootstrap
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.10.0
 platform: ruby
 authors:
 - Marino Bonetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-16 00:00:00.000000000 Z
+date: 2024-06-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails