base_editing_bootstrap 0.8.0 → 0.9.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b1619def3100d40ea9c0af463dae74782d4a1a66b6b01fd823fb8a6fb4a7be0
-  data.tar.gz: 81fb33920d91b1273f7055f6522552de71c0cb0098bae8b9af2e896fcbd21695
+  metadata.gz: 0c6c6f28177733d11676c8d4a02244cc35ecd6bdcd781810f5b8684e4d437740
+  data.tar.gz: e74338339bd8cbb23c41c3ab297305b0808bc7330e28d5007b7b333e1aa04273
 SHA512:
-  metadata.gz: a22d5a35dfc17ff26c47373ee4815d8706f53dcf164f6fb9701c5855bfaa83b99f20be9e9e62c94f6acbcb6df36076b38d53a2d6589e6837271a7a4169daae3a
-  data.tar.gz: dacc99dbc960c9e98170ce249238343036fdae23d7de23c4c439d3b0c80765168f6d0ad27a9de47b707663a130d865d5fd04100186f5440ca6573b3f28221aef
+  metadata.gz: 97129ae0001d5db7495a0f6001c6aeca698e226aeb78931296e0e14766f3fb4f11d8f138b881232668cc1703a76e6806ce0fd30f578d0764fd6bbb3cdf2cc661
+  data.tar.gz: d0925d777f781941e8951e34d8d83710f2459da0cbba0f9354902cd4a5498bd3da49ceb978cf99bb1bd440f603593e6bec63a1d5d5f6fa1fa439ac465dcb3fe3

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.
 
 - - -
+## 0.9.1 - 2024-06-17
+#### Bug Fixes
+- Change http status check from symbol to number - (1ecd63d) - Marino Bonetti
+
+- - -
+
+## 0.9.0 - 2024-06-16
+#### Features
+- Change default and docs for show - (f320698) - Marino Bonetti
+
+- - -
+
 ## 0.8.0 - 2024-06-12
 #### Documentation
 - Update Documentation - (1c7c723) - Marino Bonetti

data/README.md

@@ -190,12 +190,20 @@ Policy
 require 'rails_helper'
 ##
 # - check_default_responses default false, to check default responses
-#    TODO should be configurable
-#    [:show?, false], 
+#    
+#    on true all are true
+#    [:show?, true], 
 #    [:destroy?, true],
 #    [:update?, true],
 #    [:create?, true],
 #    [:index?, true],
+#
+#    when hash keys are:
+#    - show
+#    - destroy
+#    - update
+#    - create
+#    - index
 # 
 RSpec.describe ServicePolicy, type: :policy do
   it_behaves_like "a standard base model policy", :service, check_default_responses: false

data/app/policies/base_model_policy.rb

@@ -7,7 +7,7 @@ class BaseModelPolicy < ApplicationPolicy
 
   def destroy? = general_rule
 
-  def show? = false
+  def show? = general_rule
 
   # Questo metodo può essere anche scritto specifico per azione:
   # - permitted_attributes_for_create

data/lib/base_editing_bootstrap/VERSION

@@ -1 +1 @@
-0.8.0
+0.9.1

data/spec/support/external_shared/base_editing_controller_helpers.rb

@@ -88,7 +88,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       it "response" do
         params = {q: {"foo_eq": "foo"}}
         get url_for_index, params: params
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(200)
         expect(assigns[:search_instance]).to be_an_instance_of(BaseEditingBootstrap::Searches::Base).and(have_attributes(
                                                                                                            user: user,
                                                                                                            params: ActionController::Parameters.new(params).permit!
@@ -101,7 +101,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
     describe "new" do
       it "response" do
         get url_for_new
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(200)
         expect(assigns[:object]).to be_an_instance_of(model)
       end
     end
@@ -111,7 +111,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
     describe "edit" do
       it "response" do
         get url_for_edit.call
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(200)
         expect(assigns[:object]).to be_an_instance_of(model)
       end
     end
@@ -122,7 +122,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       it "response" do
         put url_for_update, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
-        expect(response).to have_http_status(:see_other)
+        expect(response).to have_http_status(303)
         case BaseEditingBootstrap.after_success_update_redirect
         when :index
           expect(response).to redirect_to(url_for_index)
@@ -135,7 +135,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       unless skip_invalid_checks
         it "not valid" do
           put url_for_update, params: {param_key => invalid_attributes}
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(422)
         end
       end
     end
@@ -146,7 +146,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       it "response" do
         post url_for_create, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
-        expect(response).to have_http_status(:see_other)
+        expect(response).to have_http_status(303)
         case BaseEditingBootstrap.after_success_create_redirect
         when :index
           expect(response).to redirect_to(url_for_index)
@@ -159,7 +159,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
       unless skip_invalid_checks
         it "not valid" do
           post url_for_create, params: {param_key => invalid_attributes}
-          expect(response).to have_http_status(:unprocessable_entity)
+          expect(response).to have_http_status(422)
         end
       end
     end

data/spec/support/external_shared/pundit.rb

@@ -19,12 +19,47 @@ RSpec.shared_examples "a standard base model policy" do |factory, check_default_
 
   describe "standard_methods" do
     where(:method, :response) do
+
+      if check_default_responses == true
+        checks = {
+          show: true,
+          destroy: true,
+          update: true,
+          create: true,
+          index: true
+        }
+      elsif check_default_responses.is_a? Hash
+        checks = check_default_responses
+      elsif check_default_responses == false
+        checks = {}
+      else
+        raise <<-MESSAGE.strip_heredoc
+         Acceptable values for check_default_responses are: 
+           - true
+           - false
+           - Hash with:  
+              show
+              destroy
+              update
+              create
+              index
+        MESSAGE
+      end
+
+      checks.reverse_merge!(
+        show: true,
+        destroy: true,
+        update: true,
+        create: true,
+        index: true
+      )
+
       [
-        [:show?, false],
-        [:destroy?, true],
-        [:update?, true],
-        [:create?, true],
-        [:index?, true],
+        [:show?, checks[:show]],
+        [:destroy?, checks[:destroy]],
+        [:update?, checks[:update]],
+        [:create?, checks[:create]],
+        [:index?, checks[:index]],
       ]
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: base_editing_bootstrap
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.1
 platform: ruby
 authors:
 - Marino Bonetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-12 00:00:00.000000000 Z
+date: 2024-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails