base_editing_bootstrap 0.4.2 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 77c13adc91ffb0336f044c8679f8594896f0488217c2a794440346f950cb13c1
-  data.tar.gz: c41c9312226e37ff2f244612abe2168e3aecf9bd6cadc79015faa1939e3f7eeb
+  metadata.gz: 3f75c92251f46045d20902120b1796ad0804dbfd632b0ddd77669a6f4f7ab35c
+  data.tar.gz: 9e87df84d2fc30d8f981095cc3304479c1629b25cf0daa14746a78d83dba5245
 SHA512:
-  metadata.gz: 4bda28795ec6bb33c7dcfc043f51da88c54b4055b014f223d0ccad0d2d5ba72423db87134f08317f2b6153da9bc0c5713ded3772a4949b0f165285c2aae3cf1b
-  data.tar.gz: 6ef88c451560bf050e497c559f19bc1e96cf87b02e83b5fe6dd42010e3baea5e30f94e6ceac57963eb89d7ce16d21a2e88e6358a80bcf8237fe8e04558324e39
+  metadata.gz: 3ded9cc6fbff9ae4515f98530596a444f3b18760dc5677b0ae9f5c9b96056287d08500f5a691fb2bcf926709151e79d7af7d4da235dbcd129aa7db4d3d4f520d
+  data.tar.gz: 6d22f81c4ecf3db3a7413f0fa42ac35b01ffa1e36a570d9cbc412e5daa5a49c9abc3659f63613e7c194cac8b3a417b52de0e5dc2d243799b7faf9dfc5d255213

data/CHANGELOG.md

@@ -2,6 +2,29 @@
 All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.
 
 - - -
+## 0.6.0 - 2024-05-29
+#### Bug Fixes
+- Add dependency in generator - (b911b1a) - Marino Bonetti
+#### Documentation
+- Add documentation for specs - (42a88ca) - Marino Bonetti
+#### Features
+- Add Capacity to skip un-authorization - (c83c51c) - Marino Bonetti
+#### Tests
+- Add spec for test env - (b8611d7) - Marino Bonetti
+
+- - -
+
+## 0.5.0 - 2024-05-22
+#### Bug Fixes
+- Correct initializer commented examples - (ba90fba) - Marino Bonetti
+#### Features
+- Action for Show enabled - (d364ed3) - Marino Bonetti
+- Enums with Integer identified - (4fa9e87) - Marino Bonetti
+#### Tests
+- Save example_status_persistence_file_path - (235939d) - Marino Bonetti
+
+- - -
+
 ## 0.4.2 - 2024-05-08
 #### Bug Fixes
 - Rename shared example for cluck with apps - (41638f8) - Marino Bonetti

data/README.md

@@ -170,6 +170,50 @@ Utilizzo per modello base, in questo esempio prendiamo come modello Post come es
   #...
   ```
 
+## Testing helpers
+
+### Requirements(installed with generators)
+```ruby
+group :test do
+  gem 'rails-controller-testing'
+end
+```
+### Usage 
+Controllers:
+```ruby
+require 'rails_helper'
+RSpec.describe "ServiceControllers", type: :request do
+  it_behaves_like "as logged in user" do
+    it_behaves_like "base editing controller", factory: :service
+  end
+end
+```
+Model:
+```ruby
+require 'rails_helper'
+RSpec.describe Service, type: :model do
+  it_behaves_like "a base model",
+                  ransack_permitted_attributes: %w[created_at id last_status name stack_id updated_at],
+                  ransack_permitted_associations: []
+end
+```
+Policy
+```ruby
+require 'rails_helper'
+##
+# - check_default_responses default false, to check default responses
+#    TODO should be configurable
+#    [:show?, false], 
+#    [:destroy?, true],
+#    [:update?, true],
+#    [:create?, true],
+#    [:index?, true],
+# 
+RSpec.describe ServicePolicy, type: :policy do
+  it_behaves_like "a standard base model policy", :service, check_default_responses: false
+end
+```
+
 
 ## Contributing
 Contribution directions go here.

data/app/controllers/base_editing_controller.rb

@@ -1,5 +1,5 @@
 class BaseEditingController < RestrictedAreaController
-  before_action :load_object, only: [:edit, :update, :destroy]
+  before_action :load_object, only: [:edit, :show, :update, :destroy]
   helper_method :base_class,
                 :destroy_custom_polymorphic_path,
                 :edit_custom_polymorphic_path,
@@ -32,6 +32,10 @@ class BaseEditingController < RestrictedAreaController
     @object = yield(@object) if block_given?
   end
 
+  def show
+    @object = yield(@object) if block_given?
+  end
+
   def update
     @object = yield(@object) if block_given?
     respond_to do |format|

data/app/helpers/utilities/form_helper.rb

@@ -18,23 +18,23 @@ module Utilities
     # @param [Symbol] field
     def form_print_field(form, field)
       locals = {form:, field:}
-      type = form.object.class.type_for_attribute(field).type
-      case type
-      when :datetime
-        generic_field = "datetime"
-      when :date
-        generic_field = "date"
-      when :decimal
-        locals[:scale] = form.object.class.type_for_attribute(field).scale || 2
-        generic_field = "decimal"
-      when :float
-        locals[:scale] = 2 # usiamo il default dato che non abbiamo questa informazione negli attributes di rails
-        generic_field = "decimal"
-      when :integer
-        generic_field = "integer"
+      if form.object.class.defined_enums.key?(field.to_s)
+        generic_field = "enum"
       else
-        if form.object.class.defined_enums.key?(field.to_s)
-          generic_field = "enum"
+        type = form.object.class.type_for_attribute(field).type
+        case type
+        when :datetime
+          generic_field = "datetime"
+        when :date
+          generic_field = "date"
+        when :decimal
+          locals[:scale] = form.object.class.type_for_attribute(field).scale || 2
+          generic_field = "decimal"
+        when :float
+          locals[:scale] = 2 # usiamo il default dato che non abbiamo questa informazione negli attributes di rails
+          generic_field = "decimal"
+        when :integer
+          generic_field = "integer"
         else
           generic_field = "base"
         end

data/lib/base_editing_bootstrap/VERSION

@@ -1 +1 @@
-0.4.2
+0.6.0

data/lib/generators/base_editing_bootstrap/install/install_generator.rb

@@ -18,6 +18,7 @@ module BaseEditingBootstrap
 
       def prepare_test_environment
         gem "factory_bot_rails", group: :test, version: '~> 6.4', comment: "Necessary for spec"
+        gem 'rails-controller-testing',group: :test,comment:"Required if used with controllers spec"
         inject_into_class "config/application.rb", "Application", <<~RUBY
           config.generators do |g|
             g.test_framework :rspec

data/lib/generators/base_editing_bootstrap/install/templates/initializer.rb

@@ -5,18 +5,18 @@ BaseEditingBootstrap.configure do |config|
   # Controller da cui derivare poi il BaseEditingController da cui derivano
   # tutti i controller sottostanti
   # @default "ApplicationController"
-  # config_accessor :inherited_controller, default: "ApplicationController"
+  #  config.inherited_controller = "ApplicationController"
 
   ##
   # Configurazione per alterare lo standard di azione post aggiornamento record
   # il default è andare nella pagina di editing del record
   # possibili valori :edit , :index
-  # config_accessor :after_success_update_redirect, default: :edit
+  # config.inherited_controller = :edit
 
   ##
   # Configurazione per alterare lo standard di azione post creazione record
   # il default è andare nella pagina di editing del record
   # possibili valori :edit , :index
-  # config_accessor :after_success_create_redirect, default: :edit
+  # config.inherited_controller = :edit
 
 end

data/spec/support/external_shared/base_editing_controller_helpers.rb

@@ -20,6 +20,7 @@ end
 #         - index
 # @!attribute expect [Array[Symbol]] -> nome delle action da non controllare
 # @!attribute skip_invalid_checks [Boolean] -> se serve saltare il check delle azioni con dati non validi
+# @!attribute skip_authorization_check [Boolean] -> se skippare controllo delle autorizzazioni nel caso non siano azioni non autorizzabili
 #
 # Sono poi disponibili diversi let per poter fare l'override arbitrario degli url,
 # tutti abbastanza auto-descrittivi
@@ -36,7 +37,7 @@ end
 # :url_for_update
 #
 #
-RSpec.shared_examples "base editing controller" do |factory: nil, only: [], except: [], skip_invalid_checks: false|
+RSpec.shared_examples "base editing controller" do |factory: nil, only: [], except: [], skip_invalid_checks: false, skip_authorization_check: false|
   if factory
     let(:inside_factory) { factory }
   else
@@ -78,7 +79,9 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
     nested_attributes_for(inside_factory)
   }
 
-  it_behaves_like "fail with unauthorized", request: -> { get url_for(url_for_unauthorized) }
+  unless skip_authorization_check
+    it_behaves_like "fail with unauthorized", request: -> { get url_for(url_for_unauthorized) }
+  end
 
   if check_if_should_execute(only, except, :index)
     describe "index" do
@@ -186,7 +189,7 @@ end
 default_unathorized_failure = -> { raise "TODO - passare proc con richiesta che dovrà fallire" }
 
 RSpec.shared_examples "fail with unauthorized" do |request: default_unathorized_failure|
-  it "expect to redirect to root" do
+  it "is expected to redirect to root" do
     expect(Pundit).to receive(:authorize).with(user, any_args).and_raise(Pundit::NotAuthorizedError)
     instance_exec(&request)
     expect(response).to redirect_to(root_path)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: base_editing_bootstrap
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.6.0
 platform: ruby
 authors:
 - Marino Bonetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-08 00:00:00.000000000 Z
+date: 2024-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails