base_editing_bootstrap 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f935f929fda6d975ddd3d969fe03d639e0c523a19824733227bec64865e982e
-  data.tar.gz: 12448bdc9765b31fe9660d9116092cd5ff3e61bd160b8d0cfc0d699b56a85212
+  metadata.gz: 7468c063d06ad4be7aea4786ffe79b06e7aea328286d1f3db23a9c8155e16112
+  data.tar.gz: 495f2835ef4de6c905cf39b8ed886d1187231dd566d3e005437c951f8fb6723c
 SHA512:
-  metadata.gz: f86e276eb409edff874465dfdea52e44f581d5db4ab47d0d44bd33f0b7b24c0a871125f4807371eb0f199b5bf8a56edd6768f1787d66f8fae314e4d77fc1b16b
-  data.tar.gz: cbb77961f4f3df339a474472a6669039505ffbe2e31aa37abea4a7eae02481ea02e459f2f47fe0e802a6ef579d4bbcb81c3058c84ad9e12636462b3a28617f22
+  metadata.gz: 31e7c1be7578adc8f78cd3f10f2b09a0f66f359eb6a62719857f76bddbcf53e77d321835b0a060ed161df0d1182f87d279b2e19bcafe5cb25d4b7b612e92a771
+  data.tar.gz: 1fdd1a212e2be5888561827980fc74d2c3916b7ef6210fc7cc541d5ee2d436c6f6bf320eb4ea570043869a084ec8d43bd2a4341c2f5ddd47523971ff235df7fd

data/CHANGELOG.md

@@ -2,6 +2,23 @@
 All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.
 
 - - -
+## 0.3.0 - 2024-04-27
+#### Bug Fixes
+- Remove files from gem - (660cb3d) - Marino Bonetti
+#### Documentation
+- Update documentation - (42472ff) - Marino Bonetti
+- Add documentation for spec helper - (170dd5a) - Marino Bonetti
+#### Features
+- Add configurations to change redirect after edit/create - (f8f3048) - Marino Bonetti
+#### Refactoring
+- Gem dependency organization - (7fb8caf) - Marino Bonetti
+- Gem dependency organization - (f997fd9) - Marino Bonetti
+#### Tests
+- Aggiunta test per controllo redirect post success o update - (4c28e38) - Marino Bonetti
+- Add Seed for generating multiple post in dummy - (bcbe986) - Marino Bonetti
+
+- - -
+
 ## 0.2.0 - 2024-04-23
 #### Documentation
 - Add documntation for installation - (b528daa) - Marino Bonetti

data/README.md

@@ -53,6 +53,19 @@ E' possibile configurare BaseEditingBootstrap con alcune impostazioni:
     # tutti i controller sottostanti
     # @default "ApplicationController"
     # config.inherited_controller = 'ApplicationController'
+
+    ##
+    # Configurazione per alterare lo standard di azione post aggiornamento record
+    # il default è andare nella pagina di editing del record
+    # possibili valori :edit , :index
+    # config_accessor :after_success_update_redirect, default: :edit
+
+    ##
+    # Configurazione per alterare lo standard di azione post creazione record
+    # il default è andare nella pagina di editing del record
+    # possibili valori :edit , :index  
+    # config_accessor :after_success_create_redirect, default: :edit
+  
   end
 
 ```
@@ -64,6 +77,13 @@ Utilizzo per modello base, in questo esempio prendiamo come modello Post come es
   ```ruby
    include BaseEditingBootstrap::BaseModel
   ```
+- La factory nelle spec deve contenere il trait `with_invalid_attributes` per definire la situazione di dati per record
+  non valido. ES:  
+  ```ruby
+  trait :with_invalid_attributes do
+   name {nil} # name dovrebbe essere obbligatorio nel modello
+  end
+  ```
 - Creare Controller:
   ```ruby
     class PostsController < BaseEditingController

data/app/controllers/base_editing_controller.rb

@@ -186,7 +186,13 @@ class BaseEditingController < RestrictedAreaController
 
   def _successful_create(format)
     format.all do
-      redirect_to edit_custom_polymorphic_path(@object),
+      path = case BaseEditingBootstrap.after_success_create_redirect
+             when :index
+               index_custom_polymorphic_path(@object.class)
+             else
+               edit_custom_polymorphic_path(@object)
+             end
+      redirect_to path,
                   status: :see_other,
                   notice: t('activerecord.successful.messages.created', model: base_class.model_name.human)
     end
@@ -201,7 +207,13 @@ class BaseEditingController < RestrictedAreaController
 
   def _successful_update(format)
     format.all do
-      redirect_to edit_custom_polymorphic_path(@object),
+      path = case BaseEditingBootstrap.after_success_update_redirect
+             when :index
+               index_custom_polymorphic_path(@object.class)
+             else
+               edit_custom_polymorphic_path(@object)
+             end
+      redirect_to path,
                   status: :see_other,
                   notice: t('activerecord.successful.messages.updated', model: base_class.model_name.human)
     end

data/base_editing_bootstrap.gemspec

@@ -20,20 +20,35 @@ Gem::Specification.new do |spec|
   spec.files = Dir.chdir(__dir__) do
     `git ls-files -z`.split("\x0").reject do |f|
       (File.expand_path(f) == __FILE__) ||
-        f.start_with?(*%w[bin/ test/ spec/ features/ .git .gitlab-ci.yml appveyor Gemfile])
+        f.start_with?(*[
+          "bin/", "test/", "spec/", "features/",
+          ".git", ".gitlab-ci.yml", "appveyor", "Gemfile",
+          "cog.toml", "docker-compose.yml", "Dockerfile",
+          ".rspec", ".rubocop.yml"
+        ])
     end
   end
   spec.files += Dir['spec/support/external_shared/*.rb']
 
-  spec.add_dependency "rails", ">= 7.0"
-  spec.add_dependency "pundit", ">= 2.3.1"
-
+  spec.add_dependency "rails", [">= 7.0", "< 8.0"]
+  # Policy
+  spec.add_dependency "pundit", ["~> 2.3", ">= 2.3.1"]
   # Search
-  spec.add_dependency 'ransack', '>= 4.0.0'
+  spec.add_dependency 'ransack', ['~> 4.0', '>= 4.0.0']
   # Pagination
-  spec.add_dependency 'kaminari', '>= 1.2.2'
+  spec.add_dependency 'kaminari', ['~> 1.2', '>= 1.2.2']
 
-  spec.add_development_dependency "rspec-rails"
-  spec.add_development_dependency "factory_bot_rails"
+  spec.add_development_dependency "rspec-rails", '~> 6.0'
+  spec.add_development_dependency "factory_bot_rails", '~> 6.4'
+  spec.add_development_dependency 'faker'
+  spec.add_development_dependency "puma"
+  spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "sprockets-rails"
+  spec.add_development_dependency 'rails-i18n', '~> 7.0.0' # For 7.0.0
+  spec.add_development_dependency "i18n-debug"
+  spec.add_development_dependency "cssbundling-rails"
+  spec.add_development_dependency "rspec-parameterized", ">= 1.0.0" # https://github.com/tomykaira/rspec-parameterized
+  spec.add_development_dependency 'rspec-html-matchers' # https://github.com/kucaahbe/rspec-html-matchers
+  spec.add_development_dependency 'rails-controller-testing'
 
 end

data/lib/base_editing_bootstrap/VERSION

@@ -1 +1 @@
-0.2.0
+0.3.0

data/lib/base_editing_bootstrap.rb

@@ -21,6 +21,18 @@ module BaseEditingBootstrap
   # tutti i controller sottostanti
   # @default "ApplicationController"
   config_accessor :inherited_controller, default: "ApplicationController"
+  
+  ##
+  # Configurazione per alterare lo standard di azione post aggiornamento record
+  # il default è andare nella pagina di editing del record
+  # possibili valori :edit , :index
+  config_accessor :after_success_update_redirect, default: :edit
+
+  ##
+  # Configurazione per alterare lo standard di azione post creazione record
+  # il default è andare nella pagina di editing del record
+  # possibili valori :edit , :index  
+  config_accessor :after_success_create_redirect, default: :edit
 
   def self.deprecator
     @deprecator ||= ActiveSupport::Deprecation.new("1.0", "BaseEditingBootstrap")

data/spec/support/external_shared/base_editing_controller_helpers.rb

@@ -10,6 +10,32 @@ end
 ##
 # Helper per testare controller derivanti da base editing
 # only e except servono per filtrare o escludere determinate actions
+# @!attribute factory [Symbol] -> nome della factory da usare per il modello
+# @!attribute only [Array[Symbol]] -> nome delle sole action da controllare
+#         - delete
+#         - create
+#         - update
+#         - edit
+#         - new
+#         - index
+# @!attribute expect [Array[Symbol]] -> nome delle action da non controllare
+# @!attribute skip_invalid_checks [Boolean] -> se serve saltare il check delle azioni con dati non validi
+#
+# Sono poi disponibili diversi let per poter fare l'override arbitrario degli url,
+# tutti abbastanza auto-descrittivi
+# 
+# :url_for_new
+# :url_for_index
+# :url_for_create
+# :url_for_succ_delete
+# :url_for_fail_delete
+# :url_for_edit             ->  Rispetto  agli altri questo risulta essere pià complicato in quanto
+#                               deve ritornare una proc a cui passiamo il valore dell'istanza persistente
+#                               che nei casi del after create non abbiamo a priori.
+# :url_for_unauthorized
+# :url_for_update
+#
+#
 RSpec.shared_examples "base editing controller" do |factory: nil, only: [], except: [], skip_invalid_checks: false|
   if factory
     let(:inside_factory) { factory }
@@ -28,7 +54,9 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
   let(:url_for_create) { url_for(model.new) }
   let(:url_for_succ_delete) { url_for(model) }
   let(:url_for_fail_delete) { url_for_succ_delete }
-  let(:url_for_edit) { url_for([persisted_instance, action: :edit]) }
+  let(:url_for_edit) { ->(p = persisted_instance) {
+    url_for([p, action: :edit])
+  } }
   let(:url_for_update) { url_for(persisted_instance) }
   ## non sempre abbiamo l'index nelle action disponibili, dobbiamo quindi avere modo di eseguire un override
   let(:url_for_unauthorized) { url_for_index }
@@ -79,7 +107,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
   if check_if_should_execute(only, except, :edit)
     describe "edit" do
       it "response" do
-        get url_for_edit
+        get url_for_edit.call
         expect(response).to have_http_status(:ok)
         expect(assigns[:object]).to be_an_instance_of(model)
       end
@@ -92,6 +120,13 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
         put url_for_update, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
         expect(response).to have_http_status(:see_other)
+        case BaseEditingBootstrap.after_success_update_redirect
+        when :index
+          expect(response).to redirect_to(url_for_index)
+        else
+          # edit
+          expect(response).to redirect_to(url_for_edit.call(assigns[:object]))
+        end
       end
 
       unless skip_invalid_checks
@@ -109,6 +144,13 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
         post url_for_create, params: {param_key => valid_attributes}
         expect(assigns[:object]).to be_an_instance_of(model)
         expect(response).to have_http_status(:see_other)
+        case BaseEditingBootstrap.after_success_create_redirect
+        when :index
+          expect(response).to redirect_to(url_for_index)
+        else
+          # edit
+          expect(response).to redirect_to(url_for_edit.call(assigns[:object]))
+        end
       end
 
       unless skip_invalid_checks

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: base_editing_bootstrap
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Marino Bonetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-23 00:00:00.000000000 Z
+date: 2024-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -17,6 +17,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,10 +27,16 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '7.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: pundit
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.1
@@ -35,6 +44,9 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.1
@@ -42,6 +54,9 @@ dependencies:
   name: ransack
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
@@ -49,6 +64,9 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
@@ -56,6 +74,9 @@ dependencies:
   name: kaminari
   requirement: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.2
@@ -63,11 +84,42 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.2
 - !ruby/object:Gem::Dependency
   name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+- !ruby/object:Gem::Dependency
+  name: factory_bot_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.4'
+- !ruby/object:Gem::Dependency
+  name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +133,119 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_bot_rails
+  name: puma
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sprockets-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails-i18n
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 7.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 7.0.0
+- !ruby/object:Gem::Dependency
+  name: i18n-debug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: cssbundling-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-parameterized
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: rspec-html-matchers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails-controller-testing
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -101,11 +265,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".rspec"
-- ".rubocop.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
-- Dockerfile
 - LICENSE.txt
 - MIT-LICENSE
 - README.md
@@ -167,11 +328,9 @@ files:
 - app/views/kaminari/_paginator.html.erb
 - app/views/kaminari/_prev_page.html.erb
 - base_editing_bootstrap.gemspec
-- cog.toml
 - config/initializers/base_field_error_proc.rb
 - config/locales/it.yml
 - config/routes.rb
-- docker-compose.yml
 - lib/base_editing_bootstrap.rb
 - lib/base_editing_bootstrap/VERSION
 - lib/base_editing_bootstrap/base_model.rb

data/.rspec

@@ -1,3 +0,0 @@
---format documentation
---color
---require rails_helper

data/.rubocop.yml

@@ -1,13 +0,0 @@
-AllCops:
-  TargetRubyVersion: 3.0
-
-Style/StringLiterals:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-Style/StringLiteralsInInterpolation:
-  Enabled: true
-  EnforcedStyle: double_quotes
-
-Layout/LineLength:
-  Max: 120

data/Dockerfile

@@ -1,57 +0,0 @@
-# syntax = docker/dockerfile:1
-
-# Make sure RUBY_VERSION matches the Ruby version in .ruby-version and Gemfile
-ARG RUBY_VERSION=3.3.0
-FROM registry.docker.com/library/ruby:$RUBY_VERSION-slim as base
-
-# Rails app lives here
-WORKDIR /app
-
-# Set production environment
-ENV RAILS_ENV="production"
-
-
-# Throw-away build stage to reduce size of final image
-FROM base as build_dev_image
-
-# Install packages needed to build gems and node modules
-RUN apt-get update -qq && \
-    apt-get install --no-install-recommends -y build-essential curl git libvips node-gyp pkg-config python-is-python3
-
-# Install JavaScript dependencies
-ARG NODE_VERSION=20.11.1
-ARG YARN_VERSION=1.22.22
-ENV PATH=/usr/local/node/bin:$PATH
-RUN curl -sL https://github.com/nodenv/node-build/archive/master.tar.gz | tar xz -C /tmp/ && \
-    /tmp/node-build-master/bin/node-build "${NODE_VERSION}" /usr/local/node && \
-    npm install -g yarn@$YARN_VERSION && \
-    rm -rf /tmp/node-build-master
-
-#------------------------------------------------------------
-# IMMAGINE DI SVILUPPO
-FROM build_dev_image as development_image
-
-ARG default_editor
-RUN apt-get install -y nano gpg gpg-agent git-lfs git ssh
-#questo serve per editare le credentials
-ENV EDITOR='nano' \
-    BUNDLE_PATH="/bundle"
-# helper per webpacker
-RUN touch /.yarnrc && chmod 777  /.yarnrc
-RUN mkdir /.cache && chmod 777 /.cache
-RUN adduser --system -D --uid 1000  -h /home/nobody  --shell /bin/bash rails rails
-
-
-RUN mkdir /bundle && chmod -R ugo+rwt /bundle
-VOLUME /bundle
-
-RUN gem install foreman
-##
-# Installiamo:
-# bundle-audit  : gemma per controllo di sicurezza https://github.com/rubysec/bundler-audit
-# bummr         : gemma per upgrade automatizzato delle gemme con singoli commit per gemma
-RUN gem install bundle-audit bummr
-
-RUN mkdir -p /home/nobody && chmod 777 /home/nobody
-ENV HOME="/home/nobody"
-

data/cog.toml

@@ -1,32 +0,0 @@
-from_latest_tag = false
-ignore_merge_commits = false
-disable_changelog = false
-generate_mono_repository_global_tag = true
-branch_whitelist = []
-skip_ci = "[skip ci]"
-skip_untracked = false
-pre_bump_hooks = [
-    "echo '{{version}}' > lib/base_editing_bootstrap/VERSION",
-    "docker compose run app bundle"
-]
-post_bump_hooks = [
-    "git push",
-    "git push origin {{version}}",
-    "docker compose run app gem build base_editing_bootstrap.gemspec",
-    "docker compose run app gem push base_editing_bootstrap-{{version}}.gem",
-    "rm -fr base_editing_bootstrap-{{version}}.gem"
-]
-pre_package_bump_hooks = []
-post_package_bump_hooks = []
-
-[git_hooks]
-
-[commit_types]
-
-[changelog]
-path = "CHANGELOG.md"
-authors = []
-
-[bump_profiles]
-
-[packages]

data/docker-compose.yml

@@ -1,20 +0,0 @@
-services:
-  app:
-    command: /app/spec/dummy/bin/dev
-    build:
-      context: .
-    user: ${CMPS_UID_GID}
-    volumes:
-      - '.:/app'
-      - 'bundle:/bundle'
-      - '~/.gitconfig:/home/nobody/.gitconfig'
-      - '~/.gnupg:/home/nobody/.gnupg'
-      - '~/.gem:/home/nobody/.gem'
-      - '~/.ssh:/home/nobody/.ssh'
-    environment:
-      RAILS_ENV: development
-    ports:
-      - 3000:3000
-
-volumes:
-  bundle: