base_editing_bootstrap 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1f4da39d416d3107b6e4f40d63a33c136eed02e5d5c8cb6b2e91423be99460c1
-  data.tar.gz: f71d9cfd3efeef8edbd20ee5da7ec9b98f198ce6a9fc99ed7b8cc0af7038983c
+  metadata.gz: 6aef652b3fc0651d54b2a217bbb32a6e750135ffc1216faa82dee66ad788e5b4
+  data.tar.gz: b9cf8df48a6c26bb2e67b7d65d9059e4fa974defb7e58ef1863f8e065e75af7a
 SHA512:
-  metadata.gz: c93f3d73d379b66d37a039064ac5f6cb8638f32e9785d2998c7d3353f060dde6c6be02db38d8ac6f1e2ef29e3e0a1ab4e265b73959bbd3dacbff5ecc367d87e1
-  data.tar.gz: ef9c876ff6628cdbc7b200240b3785952e58d951a610bd8275a587d2d6c9b6ea03724bd03c5f6def17c81c04b268a79c5330a7288931418ace32062356c214df
+  metadata.gz: 0d639657a9314a263c38b30e390af56f21b94071f835f4d59ccea7818f7799a3899081c534e2183349122968bd81347904ea1eb46996fa9190521039785b881d
+  data.tar.gz: b87959282627c61dc5b8f233503a3932cc0cb0a53ba25a192065a9ee765b95a754b55efc5998e4ec1032ca9ecdee0db334edce0f19563621c0026d97d873be2e

data/CHANGELOG.md

@@ -2,6 +2,21 @@
 All notable changes to this project will be documented in this file. See [conventional commits](https://www.conventionalcommits.org/) for commit guidelines.
 
 - - -
+## 0.15.0 - 2024-11-11
+#### Bug Fixes
+- Add Password for in standard fields - (593c8c2) - Marino Bonetti
+- Form helper for non ActiveRecords - (9e124de) - Marino Bonetti
+- Removed old code - (cbf1cd0) - Marino Bonetti
+- Add translations for actionmodel - (3be05ca) - Marino Bonetti
+#### Features
+- Add debug helper logger for PunditNotAuthorized - (a9b30d6) - Marino Bonetti
+- Human action messages (#10) - (63f9de9) - Marino Bonetti
+#### Tests
+- Add check for human_action_message method - (38af466) - Marino Bonetti
+- Better tests messages - (cda150e) - Marino Bonetti
+
+- - -
+
 ## 0.14.0 - 2024-10-14
 #### Bug Fixes
 - Namespaced resources (#7) - (e85f926) - Marino Bonetti

data/README.md

@@ -221,6 +221,29 @@ RSpec.describe ServicePolicy, type: :policy do
 end
 ```
 
+## Message translations
+I messaggi di generati per il flash provengono dal metodo BaseEditingBootstrap::ActionTranslation.human_action_message  
+e seguono una logica simile ad human_attribute_name.  
+Sono già presenti i messaggi di default, a cui viene passato il nome del modello,  
+ma è possibile fare override del messaggio con la classe: 
+
+```yaml
+LANG:
+  activerecord:
+    successful:
+      messages:
+        created: "example %{model}"
+        updated:
+        destroyed:
+        CLASS_NAME:
+          created: "customized %{model} created"
+    unsuccessful:
+      messages:
+        created: 
+        updated: 
+```
+
+
 
 ## Contributing
 1. Setup env with:  

data/app/controllers/base_editing_controller.rb

@@ -186,13 +186,13 @@ class BaseEditingController < RestrictedAreaController
     format.all do
       redirect_to index_custom_polymorphic_path(base_class),
                   status: :see_other,
-                  notice: t('activerecord.successful.messages.destroyed', model: base_class.model_name.human)
+                  notice: human_action_message(action: :destroyed)
     end
   end
 
   def _failed_create(format)
     format.html do
-      flash.now.alert = t('activerecord.unsuccessful.messages.created', model: base_class.model_name.human)
+      flash.now.alert = human_action_message(action: :created, successful: false)
       render action: :new, status: :unprocessable_entity
     end
   end
@@ -207,13 +207,13 @@ class BaseEditingController < RestrictedAreaController
              end
       redirect_to path,
                   status: :see_other,
-                  notice: t('activerecord.successful.messages.created', model: base_class.model_name.human)
+                  notice: human_action_message(action: :created)
     end
   end
 
   def _failed_update(format)
     format.html do
-      flash.now.alert = t('activerecord.unsuccessful.messages.updated', model: base_class.model_name.human)
+      flash.now.alert = human_action_message(action: :updated, successful: false)
       render action: :edit, status: :unprocessable_entity
     end
   end
@@ -228,7 +228,10 @@ class BaseEditingController < RestrictedAreaController
              end
       redirect_to path,
                   status: :see_other,
-                  notice: t('activerecord.successful.messages.updated', model: base_class.model_name.human)
+                  notice: human_action_message(action: :updated)
     end
   end
+
+  delegate :human_action_message, to: :base_class
+
 end

data/app/controllers/restricted_area_controller.rb

@@ -18,6 +18,7 @@ class RestrictedAreaController < BaseEditingBootstrap.inherited_controller.const
   private
 
   def user_not_authorized(exception)
+    Rails.logger.debug{"Pundit::NotAuthorizedError [#{exception.message}]"}
     policy_name = exception.policy.class.to_s.underscore
 
     flash[:error] = t "#{policy_name}.#{exception.query}", scope: "pundit", default: :default

data/app/helpers/utilities/form_helper.rb

@@ -18,10 +18,14 @@ module Utilities
     # @param [Symbol] field
     def form_print_field(form, field)
       locals = {form:, field:}
-      if form.object.class.defined_enums.key?(field.to_s)
+      if form.object.class.respond_to?(:defined_enums) && form.object.class.defined_enums.key?(field.to_s)
         generic_field = "enum"
       else
-        type = form.object.class.type_for_attribute(field).type
+        if form.object.class.respond_to?(:type_for_attribute)
+          type = form.object.class.type_for_attribute(field).type
+        else
+          type = :string
+        end
         case type
         when :datetime
           generic_field = "datetime"

data/config/locales/it.yml

@@ -40,6 +40,16 @@ it:
 #    post_policy:
 #      update?: 'You cannot edit this post!'
 #      create?: 'You cannot create posts!'
+  activemodel:
+    successful:
+      messages:
+        created: "%{model} creato correttamente."
+        updated: "%{model} aggiornato correttamente."
+        destroyed: "%{model} è stato correttamente cancellato."
+    unsuccessful:
+      messages:
+        created: "Ci sono errori che impediscono la creazione di %{model}"
+        updated: "Ci sono errori che impediscono l'aggiornamento di %{model}"
   activerecord:
     successful:
       messages:

data/lib/base_editing_bootstrap/VERSION

@@ -1 +1 @@
-0.14.0
+0.15.0

data/lib/base_editing_bootstrap/action_translation.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+require 'active_support/concern'
+
+module BaseEditingBootstrap
+  module ActionTranslation
+
+    extend ActiveSupport::Concern
+
+    class_methods do
+
+      ##
+      # Viene generato un messaggio rispetto all'azione nel caso di successo o fallimento
+      # i messaggi seguono la stessa logica del human_attribute_name con inheritance delle classi`
+      #
+      # {i18n_scope della classe}.{successful|unsuccessful}.messages.{class_name}.{action}
+      # {i18n_scope della classe}.{successful|unsuccessful}.messages.{class_ancestors}.{action}
+      # {i18n_scope della classe}.{successful|unsuccessful}.messages.{action}
+      def human_action_message(action:, successful: true, **options)
+
+        successful_string = successful ? "successful" : "unsuccessful"
+
+        defaults = lookup_ancestors.map do |klass|
+          :"#{i18n_scope}.#{successful_string}.messages.#{klass.model_name.i18n_key}.#{action}"
+        end
+
+        defaults << options[:default] if options[:default]
+        defaults << :"#{i18n_scope}.#{successful_string}.messages.#{action}"
+
+        options.reverse_merge!(model: model_name.human)
+
+        I18n.t(
+          defaults.shift,
+          default: defaults,
+          **options
+        )
+      end
+    end
+  end
+end

data/lib/base_editing_bootstrap/base_model.rb

@@ -6,6 +6,7 @@ module BaseEditingBootstrap
 
     included do
       include IsValidated
+      include ActionTranslation
       delegate :ransackable_attributes, :ransackable_associations, to: :@class
     end
 
@@ -16,8 +17,8 @@ module BaseEditingBootstrap
         else
           Pundit.policy(User.new, self.new).permitted_attributes_for_ransack.map(&:to_s)
         end
-      end 
-      
+      end
+
       def ransackable_associations(auth_object = nil)
         if auth_object
           Pundit.policy(auth_object, self.new).permitted_associations_for_ransack.map(&:to_s)

data/lib/base_editing_bootstrap/forms/base.rb

@@ -4,6 +4,7 @@ module BaseEditingBootstrap::Forms
   class Base < ActionView::Helpers::FormBuilder
     [
       :text_field,
+      :password_field,
       :text_area,
       :date_field,
       :datetime_field,

data/spec/support/external_shared/base_editing_controller_helpers.rb

@@ -130,6 +130,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
           # edit
           expect(response).to redirect_to(url_for_edit.call(assigns[:object]))
         end
+        expect(flash.to_hash).to include("notice" => be_present)
       end
 
       unless skip_invalid_checks
@@ -154,6 +155,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
           # edit
           expect(response).to redirect_to(url_for_edit.call(assigns[:object]))
         end
+        expect(flash.to_hash).to include("notice" => be_present)
       end
 
       unless skip_invalid_checks
@@ -171,6 +173,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
         delete url_for(persisted_instance)
         expect(assigns[:object]).to be_an_instance_of(model)
         expect(response).to redirect_to(url_for_succ_delete)
+        expect(flash.to_hash).to include("notice" => be_present)
       end
 
       it "not valid" do
@@ -180,7 +183,7 @@ RSpec.shared_examples "base editing controller" do |factory: nil, only: [], exce
         end
         delete url_for(persisted_instance)
         expect(response).to redirect_to(url_for_fail_delete)
-        expect(flash[:error]).not_to be_blank
+        expect(flash.to_hash).to include("error" => be_present)
       end
     end
   end
@@ -199,7 +202,7 @@ RSpec.shared_examples "fail with unauthorized" do |request: default_unathorized_
 
     instance_exec(&request)
     expect(response).to redirect_to(root_path)
-    expect(flash[:error]).not_to be_nil
+    expect(flash.to_hash).to include("error" => be_present)
   end
 end
 

data/spec/support/external_shared/base_model.rb

@@ -2,6 +2,10 @@ RSpec.shared_examples "a base model" do |ransack_permitted_attributes: [], ransa
 
   it_behaves_like "a validated? object"
 
+  it "human_action_message" do
+    expect(described_class).to respond_to(:human_action_message)
+  end
+
   describe "with ransackables" do
     where(:base_model_method, :policy_method, :policy_output, :result) do
       [
@@ -54,7 +58,6 @@ end
 
 RSpec.shared_examples "a validated? object" do
   subject {
-    # prendiamo un modello a caso per testare questa  cosa
     described_class.new
   }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: base_editing_bootstrap
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Marino Bonetti
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-10-14 00:00:00.000000000 Z
+date: 2024-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -358,6 +358,7 @@ files:
 - config/routes.rb
 - lib/base_editing_bootstrap.rb
 - lib/base_editing_bootstrap/VERSION
+- lib/base_editing_bootstrap/action_translation.rb
 - lib/base_editing_bootstrap/base_model.rb
 - lib/base_editing_bootstrap/engine.rb
 - lib/base_editing_bootstrap/forms/base.rb