barsoom_utils 0.2.0.77 → 0.3.0.79

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a689d68093a31c8481296dfbf97d19a683637dca75178cb142164b4ce11260a5
-  data.tar.gz: 8477a0ab5a7700c7bf0897c7a239ec8b48d155f934b81ffaef0c93d75c42faf9
+  metadata.gz: d567d7a3ae76f80b86ad642cf590526cb3bc2a2be5b95c94abf8944142a40b15
+  data.tar.gz: 0fd5468990225ed9d0faf43d860b6afe2ccb5b24fb5786077cde7054445ea832
 SHA512:
-  metadata.gz: bb2a240db5388ccb1634a17fd3820aa3f6dbc161ec953be78ed03ceb111e1832b0d5350adec45bd81eb1ea6133d32507243811ab106e306c1342a6d3bdfea766
-  data.tar.gz: 7f45fde4df510c8f92895eda05b97300dc6e3f272bb4f9220f50cb516b9748a2d1c89277f60bc1e2d24789354423bc8360d7e6992508f2831fa364943e7feb30
+  metadata.gz: ce1a9a7ef20a8f445b8974a3e63b471c1b20ca952f2608e2fb6e35a9f502a8ef961f4d9087dd02cc6e41a6ba9e234df7ba812f6cac42d057d49a3cc00ba02abd
+  data.tar.gz: 787e53e219778ea27306a49758ce0220fbfa1be5e57743f0b5a14a14fe56288d07f914ae885cacf996e2c02dc9ed35151907457b0a0f1f7e4b2fc2bc818c2483

data/Gemfile

@@ -8,7 +8,6 @@ group :development, :test do
   gem "attr_extras"
   gem "bundler"
   gem "fixme"
-  gem "honeybadger"
   gem "httparty"
   gem "lolcat"
   gem "rake"

data/VERSION

@@ -1 +1 @@
-0.2.0.77
+0.3.0.79

data/lib/barsoom_utils/exception_notifier.rb

@@ -11,12 +11,14 @@ module BarsoomUtils
         raise "Expected an exception but got: #{exception.inspect}"
       end
 
-      result = Honeybadger.notify(exception, context: context)
-      Sentry.capture_exception(exception, extra: context) if defined?(Sentry)
-      result
+      ensure_notifier!
+
+      Sentry.capture_exception(exception, extra: context)
     end
 
     def self.message(message, details_or_context = nil, context_or_nothing = nil)
+      ensure_notifier!
+
       if context_or_nothing
         details = details_or_context
         context = context_or_nothing
@@ -28,18 +30,17 @@ module BarsoomUtils
         context = {}
       end
 
-      result = Honeybadger.notify(
-        error_class: message,
-        error_message: (details || "(no message)").to_s,
-        context: context.to_h,
-      )
+      title = details ? "#{message}: #{details}" : message.to_s
+      Sentry.capture_message(title, extra: context.to_h)
+    end
 
-      if defined?(Sentry)
-        title = details ? "#{message}: #{details}" : message.to_s
-        Sentry.capture_message(title, extra: context.to_h)
-      end
+    private
+
+    private_class_method \
+    def self.ensure_notifier!
+      return if defined?(Sentry)
 
-      result
+      raise "Cannot notify: Sentry is not available."
     end
   end
 end

data/spec/exception_notifier_spec.rb

@@ -1,12 +1,10 @@
 # frozen_string_literal: true
 require "barsoom_utils/exception_notifier"
-require "honeybadger"
 require "sentry-ruby"
 require "fixme"
 
 RSpec.describe BarsoomUtils::ExceptionNotifier do
   before do
-    allow(Honeybadger).to receive(:notify)
     allow(Sentry).to receive(:capture_exception)
     allow(Sentry).to receive(:capture_message)
   end
@@ -14,17 +12,15 @@ RSpec.describe BarsoomUtils::ExceptionNotifier do
   describe ".notify" do
     let(:ex) { StandardError.new("boom") }
 
-    it "passes an exception to Honeybadger and Sentry" do
+    it "passes an exception to Sentry" do
       BarsoomUtils::ExceptionNotifier.notify(ex)
 
-      expect(Honeybadger).to have_received(:notify).with(ex, context: {})
       expect(Sentry).to have_received(:capture_exception).with(ex, extra: {})
     end
 
     it "can pass through context info" do
       BarsoomUtils::ExceptionNotifier.notify(ex, context: { foo: "bar" })
 
-      expect(Honeybadger).to have_received(:notify).with(ex, context: { foo: "bar" })
       expect(Sentry).to have_received(:capture_exception).with(ex, extra: { foo: "bar" })
     end
 
@@ -33,51 +29,38 @@ RSpec.describe BarsoomUtils::ExceptionNotifier do
         BarsoomUtils::ExceptionNotifier.notify({ foo: "bar" })
       }.to raise_error(/Expected an exception but got:.*foo.*bar/)
 
-      expect(Honeybadger).not_to have_received(:notify)
       expect(Sentry).not_to have_received(:capture_exception)
     end
 
-    it "returns Honeybadger's result" do
-      allow(Honeybadger).to receive(:notify).and_return(:sentinel)
+    it "returns Sentry's result" do
+      allow(Sentry).to receive(:capture_exception).and_return(:sentinel)
 
       expect(BarsoomUtils::ExceptionNotifier.notify(ex)).to eq(:sentinel)
     end
 
-    context "without Sentry" do
-      before { hide_const("Sentry") }
+    it "raises without Sentry" do
+      hide_const("Sentry")
 
-      it "still notifies Honeybadger and raises nothing" do
-        BarsoomUtils::ExceptionNotifier.notify(ex, context: { foo: "bar" })
-
-        expect(Honeybadger).to have_received(:notify).with(ex, context: { foo: "bar" })
-      end
+      expect {
+        BarsoomUtils::ExceptionNotifier.notify(ex)
+      }.to raise_error(/Sentry is not available/)
     end
   end
 
   describe ".message" do
-    it "passes a message to Honeybadger and Sentry" do
+    it "passes a message to Sentry" do
       BarsoomUtils::ExceptionNotifier.message("Boom!")
 
-      expect(Honeybadger).to have_received(:notify).with(
-        error_class: "Boom!",
-        error_message: "(no message)",
-        context: {},
-      )
       expect(Sentry).to have_received(:capture_message).with("Boom!", extra: {})
     end
 
     it "can take a custom details string" do
       BarsoomUtils::ExceptionNotifier.message("Boom!", "Details!")
 
-      expect(Honeybadger).to have_received(:notify).with(
-        error_class: "Boom!",
-        error_message: "Details!",
-        context: {},
-      )
       expect(Sentry).to have_received(:capture_message).with("Boom!: Details!", extra: {})
     end
 
-    it "coerces the message to a string for Sentry" do
+    it "coerces the message to a string" do
       BarsoomUtils::ExceptionNotifier.message(:boom)
 
       expect(Sentry).to have_received(:capture_message).with("boom", extra: {})
@@ -86,43 +69,27 @@ RSpec.describe BarsoomUtils::ExceptionNotifier do
     it "can take a context hash" do
       BarsoomUtils::ExceptionNotifier.message("Boom!", foo: "bar")
 
-      expect(Honeybadger).to have_received(:notify).with(
-        error_class: "Boom!",
-        error_message: "(no message)",
-        context: { foo: "bar" },
-      )
       expect(Sentry).to have_received(:capture_message).with("Boom!", extra: { foo: "bar" })
     end
 
     it "can take a custom details string and a context hash" do
       BarsoomUtils::ExceptionNotifier.message("Boom!", "Details!", foo: "bar")
 
-      expect(Honeybadger).to have_received(:notify).with(
-        error_class: "Boom!",
-        error_message: "Details!",
-        context: { foo: "bar" },
-      )
       expect(Sentry).to have_received(:capture_message).with("Boom!: Details!", extra: { foo: "bar" })
     end
 
-    it "returns Honeybadger's result" do
-      allow(Honeybadger).to receive(:notify).and_return(:sentinel)
+    it "returns Sentry's result" do
+      allow(Sentry).to receive(:capture_message).and_return(:sentinel)
 
       expect(BarsoomUtils::ExceptionNotifier.message("Boom!")).to eq(:sentinel)
     end
 
-    context "without Sentry" do
-      before { hide_const("Sentry") }
+    it "raises without Sentry" do
+      hide_const("Sentry")
 
-      it "still notifies Honeybadger and raises nothing" do
-        BarsoomUtils::ExceptionNotifier.message("Boom!", "Details!", foo: "bar")
-
-        expect(Honeybadger).to have_received(:notify).with(
-          error_class: "Boom!",
-          error_message: "Details!",
-          context: { foo: "bar" },
-        )
-      end
+      expect {
+        BarsoomUtils::ExceptionNotifier.message("Boom!")
+      }.to raise_error(/Sentry is not available/)
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: barsoom_utils
 version: !ruby/object:Gem::Version
-  version: 0.2.0.77
+  version: 0.3.0.79
 platform: ruby
 authors:
 - Tomas Skogberg