barometer 0.5.0 → 0.6.1

data/spec/weather_services/weather_bug_spec.rb

@@ -0,0 +1,274 @@
+require 'spec_helper'
+include Barometer
+
+describe "WeatherBug" do
+  
+  before(:each) do
+    @accepted_formats = [:short_zipcode, :coordinates]
+  end
+  
+  describe "the class methods" do
+    
+    it "defines accepted_formats" do
+      WeatherService::WeatherBug._accepted_formats.should == @accepted_formats
+    end
+    
+    it "defines source_name" do
+      WeatherService::WeatherBug._source_name.should == :weather_bug
+    end
+    
+    it "defines fetch_current" do
+      WeatherService::WeatherBug.respond_to?("_fetch_current").should be_true
+    end
+    
+    it "defines fetch_forecast" do
+      WeatherService::WeatherBug.respond_to?("_fetch_forecast").should be_true
+    end
+    
+    it "defines _requires_keys?" do
+      WeatherService::WeatherBug.respond_to?("_requires_keys?").should be_true
+      WeatherService::WeatherBug._requires_keys?.should be_true
+    end
+    
+    it "defines _has_keys?" do
+      WeatherService::WeatherBug.respond_to?("_has_keys?").should be_true
+      WeatherService::WeatherBug._has_keys?.should be_false
+      WeatherService::WeatherBug.keys = { :code => WEATHERBUG_CODE }
+      WeatherService::WeatherBug._has_keys?.should be_true
+    end
+
+  end
+  
+  describe "building the current data" do
+    
+    it "defines the build method" do
+      WeatherService::WeatherBug.respond_to?("_build_current").should be_true
+    end
+    
+    it "requires Hash input" do
+      lambda { WeatherService::WeatherBug._build_current }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherBug._build_current({}) }.should_not raise_error(ArgumentError)
+    end
+    
+    it "returns Measurement::Current object" do
+      current = WeatherService::WeatherBug._build_current({})
+      current.is_a?(Measurement::Current).should be_true
+    end
+    
+  end
+  
+  describe "building the forecast data" do
+    
+    it "defines the build method" do
+      WeatherService::WeatherBug.respond_to?("_build_forecast").should be_true
+    end
+    
+    it "requires Hash input" do
+      lambda { WeatherService::WeatherBug._build_forecast }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherBug._build_forecast({}) }.should_not raise_error(ArgumentError)
+    end
+    
+    it "returns Array object" do
+      current = WeatherService::WeatherBug._build_forecast({})
+      current.is_a?(Array).should be_true
+    end
+    
+  end
+  
+  describe "building the location data" do
+    
+    it "defines the build method" do
+      WeatherService::WeatherBug.respond_to?("_build_location").should be_true
+    end
+    
+    it "requires Hash input" do
+      lambda { WeatherService::WeatherBug._build_location }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherBug._build_location({}) }.should_not raise_error(ArgumentError)
+    end
+    
+    it "requires Barometer::Geo input" do
+      geo = Data::Geo.new({})
+      lambda { WeatherService::WeatherBug._build_location({}, {}) }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherBug._build_location({}, geo) }.should_not raise_error(ArgumentError)
+    end
+    
+    it "returns Barometer::Location object" do
+      location = WeatherService::WeatherBug._build_location({})
+      location.is_a?(Data::Location).should be_true
+    end
+    
+  end
+  
+  describe "building the sun data" do
+    
+    it "defines the build method" do
+      WeatherService::WeatherBug.respond_to?("_build_sun").should be_true
+    end
+    
+    it "requires Hash input" do
+      lambda { WeatherService::WeatherBug._build_sun }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherBug._build_sun({}) }.should_not raise_error(ArgumentError)
+    end
+    
+    it "returns Barometer::Sun object" do
+      sun = WeatherService::WeatherBug._build_sun({})
+      sun.is_a?(Data::Sun).should be_true
+    end
+    
+  end
+  
+  describe "builds other data" do
+    
+    it "defines _build_extra" do
+      WeatherService::WeatherBug.respond_to?("_build_extra").should be_true
+    end
+    
+    it "defines _parse_local_time" do
+      WeatherService::WeatherBug.respond_to?("_parse_local_time").should be_true
+    end
+    
+    it "defines _build_timezone" do
+      WeatherService::WeatherBug.respond_to?("_build_timezone").should be_true
+    end
+    
+  end
+
+  describe "when measuring" do
+  
+    before(:each) do
+      @query = Barometer::Query.new("90210")
+      @measurement = Barometer::Measurement.new
+      
+      url = "http://#{WEATHERBUG_CODE}.api.wxbug.net:80/getLiveWeatherRSS.aspx?"
+      FakeWeb.register_uri(:get, 
+        "#{url}ACode=#{WEATHERBUG_CODE}&OutputType=1&UnitType=1&zipCode=90210",
+        :string => File.read(File.join(File.dirname(__FILE__), 
+          '../fixtures/services/weather_bug', 
+          '90210_current.xml')
+        )
+      )
+      
+      url2 = "http://#{WEATHERBUG_CODE}.api.wxbug.net:80/getForecastRSS.aspx?"
+      FakeWeb.register_uri(:get, 
+        "#{url2}ACode=#{WEATHERBUG_CODE}&OutputType=1&UnitType=1&zipCode=90210",
+        :string => File.read(File.join(File.dirname(__FILE__), 
+          '../fixtures/services/weather_bug', 
+          '90210_forecast.xml')
+        )
+      )
+    end
+  
+    describe "all" do
+      
+      it "responds to _measure" do
+        WeatherService::WeatherBug.respond_to?("_measure").should be_true
+      end
+      
+      it "requires a Barometer::Measurement object" do
+        lambda { WeatherService::WeatherBug._measure(nil, @query) }.should raise_error(ArgumentError)
+        lambda { WeatherService::WeatherBug._measure("invalid", @query) }.should raise_error(ArgumentError)
+  
+        lambda { WeatherService::WeatherBug._measure(@measurement, @query) }.should_not raise_error(ArgumentError)
+      end
+  
+      it "requires a Barometer::Query query" do
+        lambda { WeatherService::WeatherBug._measure }.should raise_error(ArgumentError)
+        lambda { WeatherService::WeatherBug._measure(@measurement, 1) }.should raise_error(ArgumentError)
+        
+        lambda { WeatherService::WeatherBug._measure(@measurement, @query) }.should_not raise_error(ArgumentError)
+      end
+      
+      it "returns a Barometer::Measurement object" do
+        result = WeatherService::WeatherBug._measure(@measurement, @query)
+        result.is_a?(Barometer::Measurement).should be_true
+        result.current.is_a?(Measurement::Current).should be_true
+        result.forecast.is_a?(Measurement::ForecastArray).should be_true
+      end
+      
+    end
+  
+  end
+  
+  describe "overall data correctness" do
+
+    before(:each) do
+      @query = Barometer::Query.new("90210")
+      @measurement = Barometer::Measurement.new
+
+      url = "http://#{WEATHERBUG_CODE}.api.wxbug.net:80/getLiveWeatherRSS.aspx?"
+      FakeWeb.register_uri(:get, 
+        "#{url}ACode=#{WEATHERBUG_CODE}&OutputType=1&UnitType=1&zipCode=90210",
+        :string => File.read(File.join(File.dirname(__FILE__), 
+          '../fixtures/services/weather_bug', 
+          '90210_current.xml')
+        )
+      )
+      
+      url2 = "http://#{WEATHERBUG_CODE}.api.wxbug.net:80/getForecastRSS.aspx?"
+      FakeWeb.register_uri(:get, 
+        "#{url2}ACode=#{WEATHERBUG_CODE}&OutputType=1&UnitType=1&zipCode=90210",
+        :string => File.read(File.join(File.dirname(__FILE__), 
+          '../fixtures/services/weather_bug', 
+          '90210_forecast.xml')
+        )
+      )
+    end
+
+    it "should correctly build the data" do
+      result = WeatherService::WeatherBug._measure(@measurement, @query)
+
+      # build current
+      @measurement.current.humidity.to_i.should == 62
+      @measurement.current.condition.should == "Hazy"
+      @measurement.current.icon.should == "23"
+      @measurement.current.temperature.to_i.should == 22
+      @measurement.current.dew_point.to_i.should == 14
+      @measurement.current.wind_chill.to_i.should == 22
+      @measurement.current.wind.to_i.should == 11
+      @measurement.current.wind.direction.should == "SE"
+      @measurement.current.pressure.to_f.should == 1011.31
+
+      # build sun
+      @measurement.current.sun.rise.to_s.should == "05:52 am"
+      @measurement.current.sun.set.to_s.should == "07:48 pm"
+      
+      # build station
+      @measurement.station.id.should == "LSNGH"
+      @measurement.station.name.should == "Milken Community HS"
+      @measurement.station.city.should == "Los Angeles"
+      @measurement.station.state_code.should == "CA"
+      @measurement.station.country.should == "USA"
+      @measurement.station.zip_code.should == "90049"
+      @measurement.station.latitude.to_f.should == 34.1258316040039
+      @measurement.station.longitude.to_f.should == -118.478332519531
+  
+      # builds location
+      @measurement.location.city.should == "Beverly Hills"
+      @measurement.location.state_code.should == "CA"
+      @measurement.location.zip_code.should == "90210"
+
+      # builds forecasts
+      @measurement.forecast.size.should == 7
+
+      @measurement.forecast[0].date.should == Date.parse("May 15")
+      @measurement.forecast[0].condition.should == "Partly Cloudy"
+      @measurement.forecast[0].icon.should == "3"
+      @measurement.forecast[0].high.to_i.should == 27
+      @measurement.forecast[0].low.to_i.should == 17
+
+      @measurement.forecast[0].sun.rise.to_s.should == "05:52 am"
+      @measurement.forecast[0].sun.set.to_s.should == "07:48 pm"
+      
+      # builds local time
+      @measurement.measured_at.to_s.should == "11:00 am"
+      @measurement.current.current_at.to_s.should == "11:00 am"
+      
+      # builds timezone
+      @measurement.timezone.code.should == Data::Zone.new("PDT").code
+      @measurement.timezone.offset.should == Data::Zone.new("PDT").offset
+      @measurement.timezone.today.should == Data::Zone.new("PDT").today
+    end
+
+  end
+  
+end

data/spec/weather_services/weather_dot_com_spec.rb

@@ -5,18 +5,32 @@ describe "WeatherDotCom" do
   
   before(:each) do
     @accepted_formats = [:short_zipcode, :weather_id]
-    #Barometer.config = { 1 => { :weather => { :keys => { :partner => WEATHER_PARTNER_KEY, :license => WEATHER_LICENSE_KEY }}}}
-    WeatherService::WeatherDotCom.keys = { :partner => WEATHER_PARTNER_KEY, :license => WEATHER_LICENSE_KEY }
   end
   
   describe "the class methods" do
     
     it "defines accepted_formats" do
-      WeatherService::WeatherDotCom.accepted_formats.should == @accepted_formats
+      WeatherService::WeatherDotCom._accepted_formats.should == @accepted_formats
+    end
+    
+    it "defines source_name" do
+      WeatherService::WeatherDotCom._source_name.should == :weather_dot_com
     end
     
     it "defines get_all" do
-      WeatherService::WeatherDotCom.respond_to?("fetch").should be_true
+      WeatherService::WeatherDotCom.respond_to?("_fetch").should be_true
+    end
+    
+    it "defines _requires_keys?" do
+      WeatherService::WeatherDotCom.respond_to?("_requires_keys?").should be_true
+      WeatherService::WeatherDotCom._requires_keys?.should be_true
+    end
+    
+    it "defines _has_keys?" do
+      WeatherService::WeatherDotCom.respond_to?("_has_keys?").should be_true
+      WeatherService::WeatherDotCom._has_keys?.should be_false
+      WeatherService::WeatherDotCom.keys = { :partner => WEATHER_PARTNER_KEY, :license => WEATHER_LICENSE_KEY }
+      WeatherService::WeatherDotCom._has_keys?.should be_true
     end
     
   end
@@ -24,17 +38,17 @@ describe "WeatherDotCom" do
   describe "building the current data" do
     
     it "defines the build method" do
-      WeatherService::WeatherDotCom.respond_to?("build_current").should be_true
+      WeatherService::WeatherDotCom.respond_to?("_build_current").should be_true
     end
     
     it "requires Hash input" do
-      lambda { WeatherService::WeatherDotCom.build_current }.should raise_error(ArgumentError)
-      lambda { WeatherService::WeatherDotCom.build_current({}) }.should_not raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_current }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_current({}) }.should_not raise_error(ArgumentError)
     end
     
-    it "returns Data::CurrentMeasurement object" do
-      current = WeatherService::WeatherDotCom.build_current({})
-      current.is_a?(Data::CurrentMeasurement).should be_true
+    it "returns Measurement::Current object" do
+      current = WeatherService::WeatherDotCom._build_current({})
+      current.is_a?(Measurement::Current).should be_true
     end
     
   end
@@ -42,16 +56,16 @@ describe "WeatherDotCom" do
   describe "building the forecast data" do
     
     it "defines the build method" do
-      WeatherService::WeatherDotCom.respond_to?("build_forecast").should be_true
+      WeatherService::WeatherDotCom.respond_to?("_build_forecast").should be_true
     end
     
     it "requires Hash input" do
-      lambda { WeatherService::WeatherDotCom.build_forecast }.should raise_error(ArgumentError)
-      lambda { WeatherService::WeatherDotCom.build_forecast({}) }.should_not raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_forecast }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_forecast({}) }.should_not raise_error(ArgumentError)
     end
     
     it "returns Array object" do
-      current = WeatherService::WeatherDotCom.build_forecast({})
+      current = WeatherService::WeatherDotCom._build_forecast({})
       current.is_a?(Array).should be_true
     end
     
@@ -60,22 +74,22 @@ describe "WeatherDotCom" do
   describe "building the location data" do
     
     it "defines the build method" do
-      WeatherService::WeatherDotCom.respond_to?("build_location").should be_true
+      WeatherService::WeatherDotCom.respond_to?("_build_location").should be_true
     end
     
     it "requires Hash input" do
-      lambda { WeatherService::WeatherDotCom.build_location }.should raise_error(ArgumentError)
-      lambda { WeatherService::WeatherDotCom.build_location({}) }.should_not raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_location }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_location({}) }.should_not raise_error(ArgumentError)
     end
     
     it "requires Barometer::Geo input" do
       geo = Data::Geo.new({})
-      lambda { WeatherService::WeatherDotCom.build_location({}, {}) }.should raise_error(ArgumentError)
-      lambda { WeatherService::WeatherDotCom.build_location({}, geo) }.should_not raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_location({}, {}) }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_location({}, geo) }.should_not raise_error(ArgumentError)
     end
     
     it "returns Barometer::Location object" do
-      location = WeatherService::WeatherDotCom.build_location({})
+      location = WeatherService::WeatherDotCom._build_location({})
       location.is_a?(Data::Location).should be_true
     end
     
@@ -84,16 +98,16 @@ describe "WeatherDotCom" do
   describe "building the sun data" do
     
     it "defines the build method" do
-      WeatherService::WeatherDotCom.respond_to?("build_sun").should be_true
+      WeatherService::WeatherDotCom.respond_to?("_build_sun").should be_true
     end
     
     it "requires Hash input" do
-      lambda { WeatherService::WeatherDotCom.build_sun }.should raise_error(ArgumentError)
-      lambda { WeatherService::WeatherDotCom.build_sun({}) }.should_not raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_sun }.should raise_error(ArgumentError)
+      lambda { WeatherService::WeatherDotCom._build_sun({}) }.should_not raise_error(ArgumentError)
     end
     
     it "returns Barometer::Sun object" do
-      sun = WeatherService::WeatherDotCom.build_sun({})
+      sun = WeatherService::WeatherDotCom._build_sun({})
       sun.is_a?(Data::Sun).should be_true
     end
     
@@ -103,7 +117,7 @@ describe "WeatherDotCom" do
 
     before(:each) do
       @query = Barometer::Query.new("90210")
-      @measurement = Data::Measurement.new
+      @measurement = Barometer::Measurement.new
       
       url = "http://xoap.weather.com:80/weather/local/"
   
@@ -124,8 +138,8 @@ describe "WeatherDotCom" do
       
       it "requires a Barometer::Measurement object" do
         lambda { WeatherService::WeatherDotCom._measure(nil, @query) }.should raise_error(ArgumentError)
-        lambda { WeatherService::WeatherDotCom._measure("invlaid", @query) }.should raise_error(ArgumentError)
-  
+        lambda { WeatherService::WeatherDotCom._measure("invalid", @query) }.should raise_error(ArgumentError)
+
         lambda { WeatherService::WeatherDotCom._measure(@measurement, @query) }.should_not raise_error(ArgumentError)
       end
   
@@ -138,114 +152,20 @@ describe "WeatherDotCom" do
       
       it "returns a Barometer::Measurement object" do
         result = WeatherService::WeatherDotCom._measure(@measurement, @query)
-        result.is_a?(Data::Measurement).should be_true
-        result.current.is_a?(Data::CurrentMeasurement).should be_true
-        result.forecast.is_a?(Array).should be_true
-        
-        result.source.should == :weather_dot_com
+        result.is_a?(Barometer::Measurement).should be_true
+        result.current.is_a?(Measurement::Current).should be_true
+        result.forecast.is_a?(Measurement::ForecastArray).should be_true
       end
       
     end
 
   end
   
-  describe "when answering the simple questions," do
-    
-    before(:each) do
-      @measurement = Data::Measurement.new
-    end
-    
-    describe "currently_wet_by_icon?" do
-      
-      before(:each) do
-        @measurement.current = Data::CurrentMeasurement.new
-      end
-  
-      it "returns true if matching icon code" do
-        @measurement.current.icon = "4"
-        @measurement.current.icon?.should be_true
-        WeatherService::WeatherDotCom.currently_wet_by_icon?(@measurement.current).should be_true
-      end
-      
-      it "returns false if NO matching icon code" do
-        @measurement.current.icon = "32"
-        @measurement.current.icon?.should be_true
-        WeatherService::WeatherDotCom.currently_wet_by_icon?(@measurement.current).should be_false
-      end
-      
-    end
-    
-    describe "forecasted_wet_by_icon?" do
-      
-      before(:each) do
-        @measurement.forecast = [Data::ForecastMeasurement.new]
-        @measurement.forecast.first.date = Date.today
-        @measurement.forecast.size.should == 1
-      end
-      
-      it "returns true if matching icon code" do
-        @measurement.forecast.first.icon = "4"
-        @measurement.forecast.first.icon?.should be_true
-        WeatherService::WeatherDotCom.forecasted_wet_by_icon?(@measurement.forecast.first).should be_true
-      end
-      
-      it "returns false if NO matching icon code" do
-        @measurement.forecast.first.icon = "32"
-        @measurement.forecast.first.icon?.should be_true
-        WeatherService::WeatherDotCom.forecasted_wet_by_icon?(@measurement.forecast.first).should be_false
-      end
-      
-    end
-    
-    describe "currently_sunny_by_icon?" do
-      
-      before(:each) do
-        @measurement.current = Data::CurrentMeasurement.new
-      end
-      
-      it "returns true if matching icon code" do
-        @measurement.current.icon = "32"
-        @measurement.current.icon?.should be_true
-        WeatherService::WeatherDotCom.currently_sunny_by_icon?(@measurement.current).should be_true
-      end
-      
-      it "returns false if NO matching icon code" do
-        @measurement.current.icon = "4"
-        @measurement.current.icon?.should be_true
-        WeatherService::WeatherDotCom.currently_sunny_by_icon?(@measurement.current).should be_false
-      end
-      
-    end
-    
-    describe "forecasted_sunny_by_icon?" do
-      
-      before(:each) do
-        @measurement.forecast = [Data::ForecastMeasurement.new]
-        @measurement.forecast.first.date = Date.today
-        @measurement.forecast.size.should == 1
-      end
-      
-      it "returns true if matching icon code" do
-        @measurement.forecast.first.icon = "32"
-        @measurement.forecast.first.icon?.should be_true
-        WeatherService::WeatherDotCom.forecasted_sunny_by_icon?(@measurement.forecast.first).should be_true
-      end
-      
-      it "returns false if NO matching icon code" do
-        @measurement.forecast.first.icon = "4"
-        @measurement.forecast.first.icon?.should be_true
-        WeatherService::WeatherDotCom.forecasted_sunny_by_icon?(@measurement.forecast.first).should be_false
-      end
-      
-    end
-    
-  end
-  
   describe "overall data correctness" do
     
     before(:each) do
       @query = Barometer::Query.new("90210")
-      @measurement = Data::Measurement.new
+      @measurement = Barometer::Measurement.new
       
       url = "http://xoap.weather.com:80/weather/local/"