barnie 0.3.0 → 0.3.1

data/barnie.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
 
   s.rubyforge_project = 'barnie'
 
-  s.add_dependency('kosher', '~> 0.2.10')
+  s.add_dependency('kosher', '~> 0.2.18')
   s.add_dependency('mechanize', '~> 1.0.0')
   s.add_development_dependency('launchy', '~> 0.3.7')
   s.add_development_dependency('rspec', '~> 2.5.0')

data/lib/barnie/response.rb

@@ -4,6 +4,7 @@ require 'barnie/helpers'
 module Barnie
   class Response
     include Helpers
+    include Enumerable
 
     attr_reader :page
 
@@ -13,24 +14,12 @@ module Barnie
       @page = page
     end
 
-    # Yields each snapshot to given block.
-    #
-    def each
-      container.each { |html| yield parse(html) }
-    end
-
-    # Returns an array of snapshots.
-    #
-    def to_a
-      container.map { |html| parse(html) }
+    def each(&block)
+      page.search('#prod-container').each { |html| block.call(parse(html)) }
     end
 
     private
 
-    def container
-      page.search('#prod-container')
-    end
-
     def parse(html)
       price = extract_price(html.search('.price strong').text)
       hours = extract_ships_in(html.search('.availability').text) || 999
@@ -38,7 +27,7 @@ module Barnie
       link  = extract_link(title)
       isbn  = extract_isbn(link)
 
-      Kosher::Snapshot.new(
+      Kosher::Book.new(
         'bn.com',
         isbn,
         nil,
@@ -52,7 +41,6 @@ module Barnie
             Kosher::Shipping.new(0, 'USD', Kosher::Availability.new(hours))
           )] :
           [])
-
     end
   end
 end

data/lib/barnie/version.rb

@@ -1,3 +1,3 @@
-module Barnie #:nodoc:
-  VERSION = '0.3.0'
+module Barnie
+  VERSION = '0.3.1'
 end

data/spec/barnie/response_spec.rb

@@ -19,73 +19,73 @@ module Barnie
       VCR.eject_cassette
     end
 
-    it "includes Helpers" do
+    it "includes the Helpers module" do
       Response.ancestors.should include Helpers
     end
 
-    describe "#to_a" do
-      it "returns snapshots" do
-        snapshots = response.to_a
-
-        snapshots.should be_an_instance_of Array
-        snapshots.first.should be_a Kosher::Snapshot
-      end
-
-      it "returns a result for a single ISBN" do
-        request << [isbns.first]
-        response = request.get
+    it "includes the Enumerable module" do
+      Response.ancestors.should include Enumerable
+    end
 
-        response.to_a.size.should eql 1
+    context "when page does not include #prod-container element" do
+      let(:mock_page) do
+        page = mock('response')
+        page.stub!(:search).and_return(nil)
+        page
       end
 
-      context "when page does not include #prod-container element" do
-
-        let(:mock_page) do
-          page = mock('response')
-          page.stub!(:search).and_return(nil)
-          page
+      context "when page body is empty and HTTP is OK" do
+        before do
+          mock_page.stub!(:body).and_return('')
+          mock_page.stub!(:code).and_return(200)
         end
 
-        context "when page body is empty and HTTP is OK" do
-          before do
-            mock_page.stub!(:body).and_return("")
-            mock_page.stub!(:code).and_return(200)
-          end
-
-          it "throws a Barnie error" do
-            expect do
-              Response.new(mock_page)
-            end.to raise_error Barnie::Error, 'Blank page'
-          end
+        it "throws a Barnie error" do
+          expect do
+            Response.new(mock_page)
+          end.to raise_error Barnie::Error, 'Blank page'
         end
       end
+    end
 
-      it "returns a book that is available for sale" do
-        request << ['9780816614028']
-        response = request.get
-        snapshot = response.to_a.first
-        snapshot.offers_count.should eql 1
+    it "yields books" do
+      response.each do |book|
+        book.should be_a Kosher::Book
       end
+    end
 
-      it "returns an ebook" do
-        request << ["9781400826094", "9780203029923"]
-        request.get.each do |snapshot|
-          snapshot.isbn.should be_an_instance_of String
-          snapshot.offers.first.price.cents.should > 0
-          snapshot.offers.first.shipping.should_not be_kosher
-        end
-      end
+    it "returns a result for a single ISBN" do
+      request << [isbns.first]
+      response = request.get
 
-      it "returns a book that is not available for sale" do
-        request << ["9780002189347"]
-        snapshot = request.get.to_a.first
-        snapshot.offers_count.should eql 0
-      end
+      response.to_a.size.should eql 1
+    end
+
+    it "returns a book that is available for sale" do
+      request << ['9780816614028']
+      response = request.get
+      book = response.to_a.first
+      book.offers_total.should eql 1
+    end
 
-      it "does not return a book that is not in the Barnes & Noble catalogue" do
-        request << ["9780002196642"]
-        request.get.to_a.should be_empty
+    it "returns an ebook" do
+      request << ["9781400826094", "9780203029923"]
+      request.get.each do |book|
+        book.isbn.should be_an_instance_of String
+        book.offers.first.price.cents.should > 0
+        book.offers.first.shipping.should_not be_kosher
       end
     end
+
+    it "returns a book that is not available for sale" do
+      request << ["9780002189347"]
+      book = request.get.to_a.first
+      book.offers_total.should eql 0
+    end
+
+    it "does not return a book that is not in the Barnes & Noble catalogue" do
+      request << ["9780002196642"]
+      request.get.to_a.should be_empty
+    end
   end
 end

metadata

@@ -2,7 +2,7 @@
 name: barnie
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-15 00:00:00 +00:00
+date: 2011-03-17 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -21,7 +21,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 0.2.10
+        version: 0.2.18
   type: :runtime
   version_requirements: *id001
 - !ruby/object:Gem::Dependency