barnie 0.2.0 → 0.3.0

data/lib/barnie/response.rb

@@ -5,39 +5,54 @@ module Barnie
   class Response
     include Helpers
 
-    attr_accessor :page
+    attr_reader :page
 
     def initialize(page)
-      self.page = page
+      raise Error.new('Blank page') if page.body.empty? && page.code == 200
+
+      @page = page
+    end
+
+    # Yields each snapshot to given block.
+    #
+    def each
+      container.each { |html| yield parse(html) }
+    end
+
+    # Returns an array of snapshots.
+    #
+    def to_a
+      container.map { |html| parse(html) }
     end
 
-    def snapshots
-      raise Error.new('Blank page') if page.body == '' && page.code == 200
-
-      container = page.search('#prod-container')
-      container.map do |html|
-
-        price = extract_price(html.search('.price strong').text)
-        hours = extract_ships_in(html.search('.availability').text) || 999
-        title = title(html)
-        link  = extract_link(title)
-        isbn  = extract_isbn(link)
-
-        Kosher::Snapshot.new(
-          'bn.com',
-          isbn,
-          nil,
-          nil,
-          price > 0 ? 1 : 0,
-          price > 0 ?
-            [Kosher::Offer.new(
-              nil,
-              Kosher::Item.new(price, 'USD', 1, Kosher::Condition.new(1), Kosher::Description.new('')),
-              Kosher::Seller.new(nil, 'Barnes & Noble.com', nil, Kosher::Location.new('US')),
-              Kosher::Shipping.new(0, 'USD', Kosher::Availability.new(hours))
-            )] :
-            [])
-      end
+    private
+
+    def container
+      page.search('#prod-container')
+    end
+
+    def parse(html)
+      price = extract_price(html.search('.price strong').text)
+      hours = extract_ships_in(html.search('.availability').text) || 999
+      title = title(html)
+      link  = extract_link(title)
+      isbn  = extract_isbn(link)
+
+      Kosher::Snapshot.new(
+        'bn.com',
+        isbn,
+        nil,
+        nil,
+        price > 0 ? 1 : 0,
+        price > 0 ?
+          [Kosher::Offer.new(
+            nil,
+            Kosher::Item.new(price, 'USD', 1, Kosher::Condition.new(1), Kosher::Description.new('')),
+            Kosher::Seller.new(nil, 'Barnes & Noble.com', nil, Kosher::Location.new('US')),
+            Kosher::Shipping.new(0, 'USD', Kosher::Availability.new(hours))
+          )] :
+          [])
+
     end
   end
 end

data/lib/barnie/version.rb

@@ -1,3 +1,3 @@
 module Barnie #:nodoc:
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/spec/barnie/helpers_spec.rb

@@ -3,42 +3,50 @@ require "spec_helper"
 
 module Barnie
   describe Helpers do
+    let(:mock_page) do
+      page = mock('response')
+      page.stub!(:body).and_return('foo')
+      page.stub!(:code)
+
+      page
+    end
+
     before do
-      @client = Response.new(nil)
+      @response = Response.new(mock_page)
     end
 
     it "sanitizes string" do
-      @client.sanitize_string('"I am" a book \r\n         "').should eql 'I am" a book'
+      @response.sanitize_string('"I am" a book \r\n         "').should eql 'I am" a book'
     end
 
     it "extract price" do
-      @client.extract_price('$14.95 abc').should eql 1495
-      @client.extract_price(nil).should eql 0
-      @client.extract_price('').should eql 0
+      @response.extract_price('$14.95 abc').should eql 1495
+      @response.extract_price(nil).should eql 0
+      @response.extract_price('').should eql 0
     end
 
     it "extracts ISBN" do
-      @client.extract_isbn('http://search.barnesandnoble.com/Best-of-Waffles-Pancakes/Jane-Stacey/e/9780002554756/?itm=1').should eql "9780002554756"
-      @client.extract_isbn('http://music.barnesandnoble.com/Live/Brian-Regan/e/706442377723/?itm=1').should eql "0706442377723"
-      @client.extract_isbn('"http://music.barnesandnoble.com/Getting-a-Good-Nights-Sleep/John-Selby/e/52296602529/?itm=1"').should eql "0052296602529"
-      @client.extract_isbn(nil).should be_nil
-      @client.extract_isbn('').should be_nil
+      @response.extract_isbn('http://search.barnesandnoble.com/Best-of-Waffles-Pancakes/Jane-Stacey/e/9780002554756/?itm=1').should eql "9780002554756"
+      @response.extract_isbn('http://music.barnesandnoble.com/Live/Brian-Regan/e/706442377723/?itm=1').should eql "0706442377723"
+      @response.extract_isbn('"http://music.barnesandnoble.com/Getting-a-Good-Nights-Sleep/John-Selby/e/52296602529/?itm=1"').should eql "0052296602529"
+      @response.extract_isbn(nil).should be_nil
+      @response.extract_isbn('').should be_nil
     end
 
     it "extracts binding" do
-      @client.extract_binding(' Paperback  ').should eql "Paperback"
-      @client.extract_binding(nil).should be_nil
-      @client.extract_binding('').should be_nil
+      @response.extract_binding(' Paperback  ').should eql "Paperback"
+      @response.extract_binding(nil).should be_nil
+      @response.extract_binding('').should be_nil
     end
 
     it "extracts maximum shipping hours" do
-      @client.extract_ships_in('Usually ships within 24 hours').should eql 24
-      @client.extract_ships_in('Usually ships within 2-3 days').should eql 3 * 24
-      @client.extract_ships_in('Usually ships within 7 days').should eql 7 * 24
-      @client.extract_ships_in('Usually ships within 7 days').should eql 7 * 24
-      @client.extract_ships_in('A new copy is not available from Barnes & Noble.com at this time.').should be_nil
-      @client.extract_ships_in(nil).should be_nil
-      @client.extract_ships_in('').should be_nil
+      @response.extract_ships_in('Usually ships within 24 hours').should eql 24
+      @response.extract_ships_in('Usually ships within 2-3 days').should eql 3 * 24
+      @response.extract_ships_in('Usually ships within 7 days').should eql 7 * 24
+      @response.extract_ships_in('Usually ships within 7 days').should eql 7 * 24
+      @response.extract_ships_in('A new copy is not available from Barnes & Noble.com at this time.').should be_nil
+      @response.extract_ships_in(nil).should be_nil
+      @response.extract_ships_in('').should be_nil
     end
 
     context "requiring real HTML objects" do
@@ -57,48 +65,48 @@ module Barnie
       context "ebook" do
         before do
           request << ["9781400826094"]
-          @client = request.get
-          @html = @client.page.search("#prod-container").first
+          @response = request.get
+          @html = @response.page.search("#prod-container").first
         end
 
         it "returns title as XML NodeSet" do
-          @client.title(@html).should be_an_instance_of Nokogiri::XML::NodeSet
+          @response.title(@html).should be_an_instance_of Nokogiri::XML::NodeSet
         end
 
         it "extracts title" do
-          @client.extract_title(@client.title(@html)).should eql "Birth of the Symbol : Ancient Readers at the Limits of Their Texts"
+          @response.extract_title(@response.title(@html)).should eql "Birth of the Symbol : Ancient Readers at the Limits of Their Texts"
         end
 
         it "extracts link" do
-          @client.extract_link(@client.title(@html)).should eql "http://search.barnesandnoble.com/Birth-of-the-Symbol/Peter-T-Struck/e/9781400826094/?itm=1"
+          @response.extract_link(@response.title(@html)).should eql "http://search.barnesandnoble.com/Birth-of-the-Symbol/Peter-T-Struck/e/9781400826094/?itm=1"
         end
 
         it "extracts authors" do
-          @client.extract_authors(@html).should =~ ["Peter T. Struck"]
+          @response.extract_authors(@html).should =~ ["Peter T. Struck"]
         end
       end
 
       context "paperback" do
         before do
           request << ["9780816614028"]
-          @client = request.get
-          @html = @client.page.search("#prod-container").first
+          @response = request.get
+          @html = @response.page.search("#prod-container").first
         end
 
         it "returns title as XML NodeSet" do
-          @client.title(@html).should be_an_instance_of Nokogiri::XML::NodeSet
+          @response.title(@html).should be_an_instance_of Nokogiri::XML::NodeSet
         end
 
         it "extracts title" do
-          @client.extract_title(@client.title(@html)).should eql "A Thousand Plateaus : Capitalism and Schizophrenia"
+          @response.extract_title(@response.title(@html)).should eql "A Thousand Plateaus : Capitalism and Schizophrenia"
         end
 
         it "extracts link" do
-          @client.extract_link(@client.title(@html)).should eql "http://search.barnesandnoble.com/A-Thousand-Plateaus/Gilles-Deleuze/e/9780816614028/?itm=1"
+          @response.extract_link(@response.title(@html)).should eql "http://search.barnesandnoble.com/A-Thousand-Plateaus/Gilles-Deleuze/e/9780816614028/?itm=1"
         end
 
         it "extracts authors" do
-          @client.extract_authors(@html).should =~ ["Brian Massumi", "Gilles Deleuze"]
+          @response.extract_authors(@html).should =~ ["Brian Massumi", "Gilles Deleuze"]
         end
       end
     end

data/spec/barnie/response_spec.rb

@@ -23,9 +23,9 @@ module Barnie
       Response.ancestors.should include Helpers
     end
 
-    describe "#snapshots" do
+    describe "#to_a" do
       it "returns snapshots" do
-        snapshots = response.snapshots
+        snapshots = response.to_a
 
         snapshots.should be_an_instance_of Array
         snapshots.first.should be_a Kosher::Snapshot
@@ -35,13 +35,13 @@ module Barnie
         request << [isbns.first]
         response = request.get
 
-        response.snapshots.size.should eql 1
+        response.to_a.size.should eql 1
       end
 
       context "when page does not include #prod-container element" do
 
         let(:mock_page) do
-          page = mock("response")
+          page = mock('response')
           page.stub!(:search).and_return(nil)
           page
         end
@@ -54,7 +54,7 @@ module Barnie
 
           it "throws a Barnie error" do
             expect do
-              Response.new(mock_page).snapshots
+              Response.new(mock_page)
             end.to raise_error Barnie::Error, 'Blank page'
           end
         end
@@ -63,13 +63,13 @@ module Barnie
       it "returns a book that is available for sale" do
         request << ['9780816614028']
         response = request.get
-        snapshot = response.snapshots.first
+        snapshot = response.to_a.first
         snapshot.offers_count.should eql 1
       end
 
       it "returns an ebook" do
         request << ["9781400826094", "9780203029923"]
-        request.get.snapshots.each do |snapshot|
+        request.get.each do |snapshot|
           snapshot.isbn.should be_an_instance_of String
           snapshot.offers.first.price.cents.should > 0
           snapshot.offers.first.shipping.should_not be_kosher
@@ -78,13 +78,13 @@ module Barnie
 
       it "returns a book that is not available for sale" do
         request << ["9780002189347"]
-        snapshot = request.get.snapshots.first
+        snapshot = request.get.to_a.first
         snapshot.offers_count.should eql 0
       end
 
       it "does not return a book that is not in the Barnes & Noble catalogue" do
         request << ["9780002196642"]
-        request.get.snapshots.should be_empty
+        request.get.to_a.should be_empty
       end
     end
   end

metadata

@@ -2,7 +2,7 @@
 name: barnie
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors: 
 - Paper Cavalier
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-10 00:00:00 +00:00
+date: 2011-03-15 00:00:00 +00:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency