barney 0.8.0 → 0.8.1

data/ChangeLog

@@ -1,3 +1,8 @@
+2011-04-19  Robert Gleeson <rob@flowof.info> v0.8.1
+
+* Don't call #to_sym when it isn't required.
+* Don't allow @variables be populated with duplicates. (bugfix)
+
 2011-04-19  Robert Gleeson <rob@flowof.info> v0.8.0
 
 * Remove "seq" attribute from StreamPair.

data/README.md

@@ -43,10 +43,12 @@ Okay, now that we've got that out of the way, let's see what using Barney is lik
 
 ## Install
 
-RubyGems.org
+RubyGems.org  
+
       gem install barney
 
-Github
+Github  
+
       git clone git://github.com/robgleeson/barney.git
       cd barney
       gem build *.gemspec
@@ -59,11 +61,13 @@ I'm following the [Semantic Versioning](http://www.semver.org) policy.
 **API**  
 
 * [master (git)](http://rubydoc.info/github/robgleeson/Barney/master/)
+* [0.8.1](http://rubydoc.info/gems/barney/0.8.1/)
+* [0.8.0](http://rubydoc.info/gems/barney/0.8.0/)
 * [0.7.0](http://rubydoc.info/gems/barney/0.7.0)
 * [0.6.0](http://rubydoc.info/gems/barney/0.6.0)
 * [0.5.0](http://rubydoc.info/gems/barney/0.5.0)
 * [0.4.1](http://rubydoc.info/gems/barney/0.4.1)
-* [0.4.0](http://rubydoc.info/gems/barney/0.4.0)
+* [0.4.0](http://rubydoc.info/gems/barney/0.4.0)  
 * …
 
 

data/lib/barney/share.rb

@@ -51,6 +51,7 @@ module Barney
     # @return [Array<Symbol>]     Returns a list of all variables that are being shared.
     def share *variables
       @variables.push *variables.map(&:to_sym)
+      @variables.uniq!
     end
 
     # Serves as a method to remove a variable or constant from being shared between two processes.
@@ -99,7 +100,7 @@ module Barney
             Barney::Share.value = Marshal.load stream.in.read
             stream.in.close
             value = eval "#{variable} = Barney::Share.value", @context 
-            @history.push HistoryItem.new variable.to_sym, value
+            @history.push HistoryItem.new variable, value
           end
         end
       end

data/lib/barney.rb

@@ -1,6 +1,6 @@
 require 'barney/share' 
 
 module Barney 
-  VERSION = '0.8.0'
+  VERSION = '0.8.1'
 end
 

data/test/suite/lib/barney/share#fork.rb

@@ -1,4 +1,5 @@
 describe Barney::Share do
+  
   describe '#fork' do
 
     it 'should return the Process ID(PID) on success.' do
@@ -14,5 +15,6 @@ describe Barney::Share do
     end
     
   end
+
 end
 

data/test/suite/lib/barney/share#history.rb

@@ -1,22 +1,24 @@
 describe Barney::Share do
+  
   describe '#history' do
 
     it 'should provide the correct history.' do     
       object = Barney::Share.new
-      object.share :shared
-      shared = ""
+      object.share :message
+      message = ""
 
-      %w(a b c).each do |e|
-        pid = object.fork { shared << e }
+      %w(a b c).each do |letter|
+        pid = object.fork { message << letter }
         Process.wait pid
       end
 
       object.sync
 
       history = object.history
-      assert_equal true, history.all? { |item| item.variable == :shared }
+      assert_equal true, history.all? { |item| item.variable == :message }
       assert_equal "abc", history.map { |item| item.value }.join 
     end
 
   end
+
 end

data/test/suite/lib/barney/share#initialize.rb

@@ -1,11 +1,17 @@
 describe Barney::Share do
+  
   describe '#initialize' do
   
     it 'should take a block' do
-      actual = false
-      Barney::Share.new { |obj| actual = true }
-      assert_equal true, actual
+      called = false
+      
+      Barney::Share.new do |obj| 
+        called = true 
+      end
+
+      assert_equal true, called
     end
 
   end
+
 end

data/test/suite/lib/barney/share#shared.rb

@@ -0,0 +1,19 @@
+describe Barney::Share do
+
+  describe '#share' do
+  
+    it "should assert duplicates aren't stored." do
+      instance = Barney::Share.new
+      instance.share :a, :a, :a, :a
+      instance.variables == [:a]
+    end
+
+    it "should assert variable names are stored as Symbols" do
+      instance = Barney::Share.new
+      instance.share "a", "b"
+      instance.variables == [:a, :b]
+    end
+
+  end
+
+end

data/test/suite/lib/barney/share#synchronize.rb

@@ -1,51 +1,63 @@
 describe Barney::Share do
+  
   describe '#sync' do
     
     before do 
-      @object = Barney::Share.new
+      @instance = Barney::Share.new
     end
 
-    it 'should confirm a variable can be synced.' do
-      a = 5
-      @object.share :a
-      pid = @object.fork { a = 6 }
+    it 'should assert a variable can be synced.' do
+      x = 5
+
+      @instance.share :x
+      pid = @instance.fork do
+        x = 6 
+      end
       Process.wait pid
-      @object.sync 
-      assert_equal 6, a
+      @instance.sync 
+      
+      assert_equal 6, x
     end
 
-    it 'should confirm a variable can  be synced after mutation' do  
-      a = 'abc'
-      @object.share :a
-      pid = @object.fork { a.sub! 'a','b' }
+    it 'should assert a variable can  be synced after mutation' do  
+      message = 'foo'
+
+      @instance.share :message
+      pid = @instance.fork { message.sub! 'foo','bar' }
       Process.wait pid
-      @object.sync
-      assert_equal 'bbc', a
+      @instance.sync
+
+      assert_equal 'bar', message
     end
 
-    it 'should confirm two variables can be synced.' do      
-      a,b = 10,20
-      @object.share :a,:b
-      pid = @object.fork { a,b = 4,5 }
+    it 'should assert two variables can be synced.' do      
+      x = 10
+      y = 20
+
+      @instance.share :x, :y
+      pid = @instance.fork do
+        x -= 1
+        y -= 1
+      end
       Process.wait pid
-      @object.sync
+      @instance.sync
 
-      assert_equal 4, a
-      assert_equal 5, b
+      assert_equal 9 , x
+      assert_equal 19, y
     end
 
     it 'should fix Github Issue #1' do
       $times  = 2
-      @object.share :$times
+      @instance.share :$times
 
-      pid = @object.fork  { $times = 4 }
-      pid2 = @object.fork { $times = 5 }
-      pid3 = @object.fork { $times = 6 }
+      pid  = @instance.fork { $times = 4 }
+      pid2 = @instance.fork { $times = 5 }
+      pid3 = @instance.fork { $times = 6 }
 
       Process.wait pid
       Process.wait pid2
       Process.wait pid3
-      @object.sync
+      @instance.sync
 
       assert_equal 6, $times
     end
@@ -54,30 +66,31 @@ describe Barney::Share do
       x = 4
       y = 5
 
-      @object.share :x
-      @object.fork { }
-      Process.wait @object.pid
+      @instance.share :x
+      @instance.fork { }
+      Process.wait @instance.pid
 
-      @object.share :y 
-      @object.fork { b = 6 }
-      Process.wait @object.pid
+      @instance.share :y 
+      @instance.fork { b = 6 }
+      Process.wait @instance.pid
 
-      @object.sync # will raise NoMethodError if fails. 
+      @instance.sync # will raise NoMethodError if fails. 
     end
 
     it 'should fix GitHub Issue #3' do
       x = 4
       y = 5
 
-      @object.share :x, :y
-      @object.fork { }
-      Process.wait @object.pid
-      @object.sync
+      @instance.share :x, :y
+      @instance.fork { }
+      Process.wait @instance.pid
+      @instance.sync
 
-      assert_equal 4, @object.history[0].value
-      assert_equal 5, @object.history[1].value
+      assert_equal 4, @instance.history[0].value
+      assert_equal 5, @instance.history[1].value
     end
 
   end
+
 end
   

data/test/suite/lib/barney/share#unshare.rb

@@ -1,27 +1,44 @@
 describe Barney::Share do
+  
   describe '#unshare' do
 
     before do
-      @a      = 5
-      @object = Barney::Share.new
+      @instance = Barney::Share.new
     end
 
-    it 'should confirm a variable can be unshared before a subprocess is spawned.' do
-      @object.share :@a
-      @object.unshare :@a 
-      pid = @object.fork { @a = 6 }
+    it 'should assert a variable can be unshared before a subprocess is spawned.' do
+      x = 5
+
+      @instance.share :x
+      @instance.unshare :x 
+      pid = @instance.fork do 
+        x = 6 
+      end
       Process.wait pid
-      @object.sync
+      @instance.sync
       
-      assert_equal 5, @a
+      assert_equal 5, x
     end
     
-    it 'should confirm a shared variable is removed from #variables.' do
-      @object.share :@a
-      @object.unshare :@a
-      assert_equal true, @object.variables.empty?
+    it 'should assert a shared variable is removed from #variables.' do
+      x = 5
+      @instance.share :x
+      @instance.unshare :x
+      assert_equal true, @instance.variables.empty?
+    end
+
+    it 'should assert a shared variable is removed from @shared' do
+      x = 5
+      @instance.share :x 
+      @instance.fork { }
+      assert true, @instance.instance_variable_get(:@shared).has_key?(:x)
+      
+      @instance.unshare :x
+      @instance.fork { }
+      assert true, @instance.instance_variable_get(:@shared).empty?
     end
 
  end
+
 end
 

metadata

@@ -2,7 +2,7 @@
 name: barney
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.8.0
+  version: 0.8.1
 platform: ruby
 authors: 
 - Robert Gleeson
@@ -55,6 +55,7 @@ files:
 - test/suite/lib/barney/share#fork.rb
 - test/suite/lib/barney/share#history.rb
 - test/suite/lib/barney/share#initialize.rb
+- test/suite/lib/barney/share#shared.rb
 - test/suite/lib/barney/share#synchronize.rb
 - test/suite/lib/barney/share#unshare.rb
 has_rdoc: true
@@ -89,5 +90,6 @@ test_files:
 - test/suite/lib/barney/share#fork.rb
 - test/suite/lib/barney/share#history.rb
 - test/suite/lib/barney/share#initialize.rb
+- test/suite/lib/barney/share#shared.rb
 - test/suite/lib/barney/share#synchronize.rb
 - test/suite/lib/barney/share#unshare.rb