barnesandnoble 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1cc2f0b5a0447a44bae1e893748b26a0ee9d635a
-  data.tar.gz: 7041259521e6cbe055e7aae5a9472412a17a2d2b
+SHA256:
+  metadata.gz: 844e3e17adb55bc5205785195d3f5c747d2b23ae610a68fdcd6612562c947e14
+  data.tar.gz: f42906761a5855573c8118bc0288bc1ba0232380a9592636c4bd1bc5f16c8fe2
 SHA512:
-  metadata.gz: 09bbf24da68e256f3b587ff0fc16e03b9936f83b029155b598195f0abe91b13f8e70a6a5ea50af4d75ed0f61caabe1fe03df5ab9ff693b796de106925ce6ffe4
-  data.tar.gz: 1e7dd5a7aed443de6b6403408c2c31f21a1f576e5e6c19f6fcf1e6b714f382ce4c7aafcc01461e74f0148148700c655bbdac4f556d56a96d6a549a16a7a65ff5
+  metadata.gz: '0943217a0d1ff028fa566e7a1065077876706602894989f036bd3df562056234398ec700b955365a37082c3f69a0aaa4159d272c7fc020265c8d39a9540cfa45'
+  data.tar.gz: e816303077bf041614cf076b4a85f449bf806507f3edc6ea01264ff1290d61431f8a8a2d14402f0e87bb15da096fa65144e56588387beaa27c7ae3a5901051a0

data/lib/barnesandnoble.rb

@@ -1,5 +1,7 @@
-require "forwardable"
-require "barnesandnoble/request"
+# frozen_string_literal: true
+
+require 'forwardable'
+require 'barnesandnoble/request'
 
 module Barnesandnoble
   class << self

data/lib/barnesandnoble/request.rb

@@ -1,52 +1,53 @@
-require "excon"
-require "barnesandnoble/response"
+# frozen_string_literal: true
+
+require 'excon'
+require 'barnesandnoble/response'
 
 module Barnesandnoble
   class Request
-    def initialize(app_id = ENV["BN_API_KEY"])
+    def initialize(app_id = ENV['BN_API_KEY'])
       @app_id = app_id
     end
 
-    underscore = ->(str) {
-      str.gsub(/(.)([A-Z\d])/,'\1_\2').downcase
+    underscore = lambda { |str|
+      str.gsub(/(.)([A-Z\d])/, '\1_\2').downcase
     }
 
-    %w(ProductLookup ProductSearch Top10 GetCategories GetPwbab)
+    %w[ProductLookup ProductSearch Top10 GetCategories GetPwbab]
       .each do |operation|
-        define_method(underscore.(operation)) do |options|
-          get_product(operation, options)
+        define_method(underscore.call(operation)) do |options|
+          request_product(operation, options)
         end
       end
 
-    %w(GetTextBookRentalInfo)
+    %w[GetTextBookRentalInfo]
       .each do |operation|
-        define_method(underscore.(operation)) do |options|
-          get_textbook(operation, options)
+        define_method(underscore.call(operation)) do |options|
+          request_textbook(operation, options)
         end
       end
 
     private
 
-    def get_textbook(operation, options)
+    def request_textbook(operation, options)
       request(operation, options.merge(
-        path: "/TextBookService/v01_00/#{operation}"
-      ))
+                           path: "/TextBookService/v01_00/#{operation}"
+                         ))
     end
 
-
-    def get_product(operation, options)
+    def request_product(operation, options)
       request(operation, options.merge(
-        path: "/v03_00/#{operation}"
-      ))
+                           path: "/v03_00/#{operation}"
+                         ))
     end
 
-    def request(operation, options)
-      options[:query]["AppId"] ||= @app_id
+    def request(_operation, options)
+      options[:query]['AppId'] ||= @app_id
       Response.new(http.get(options))
     end
 
     def http
-      Excon.new("http://services.barnesandnoble.com", expects: 200)
+      Excon.new('http://services.barnesandnoble.com', expects: 200)
     end
   end
 end

data/lib/barnesandnoble/response.rb

@@ -1,10 +1,12 @@
-require "delegate"
-require "multi_xml"
+# frozen_string_literal: true
+
+require 'delegate'
+require 'multi_xml'
 
 module Barnesandnoble
   class Response < SimpleDelegator
     def body
-      __getobj__.body.force_encoding("ISO8859-1").encode("UTF-8")
+      __getobj__.body.force_encoding('ISO8859-1').encode('UTF-8')
     end
 
     def to_h

data/lib/barnesandnoble/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Barnesandnoble
-  VERSION = "0.2.0"
+  VERSION = '0.3.0'
 end

data/test/test_barnesandnoble.rb

@@ -1,8 +1,7 @@
-require "minitest/autorun"
-require "minitest/pride"
-require "pry"
+# frozen_string_literal: true
 
-require_relative "../lib/barnesandnoble"
+require 'minitest/autorun'
+require_relative '../lib/barnesandnoble'
 
 class TestBarnesandnoble < Minitest::Test
   def setup
@@ -11,59 +10,59 @@ class TestBarnesandnoble < Minitest::Test
 
   def test_product_lookup
     res = @req.product_lookup(query: {
-      "Ean" => "9781593083342",
-      "ProductCode" => "Book"
-    })
+                                'Ean' => '9781593083342',
+                                'ProductCode' => 'Book'
+                              })
     refute_empty res.to_h
   end
 
   def test_get_categories
     res = @req.get_categories(query: {
-      "Ean" => "9781593083342",
-      "ProductCode" => "Book"
-    })
+                                'Ean' => '9781593083342',
+                                'ProductCode' => 'Book'
+                              })
     refute_empty res.to_h
   end
 
   def test_people_who_bought_also_bought
-    skip("Does not work")
+    skip('Does not work')
     res = @req.get_pwbab(query: {
-      "Ean" => "9780345546883",
-      "ProductCode" => "Book"
-    })
+                           'Ean' => '9780345546883',
+                           'ProductCode' => 'Book'
+                         })
     refute_empty res.to_h
   end
 
   def test_top_10
     res = @req.top_10(query: {
-      "Top10SearchDomain" => "Book"
-    })
+                        'Top10SearchDomain' => 'Book'
+                      })
     refute_empty res.to_h
   end
 
   def test_product_search
     res = @req.product_search(query: {
-      "SearchType" => "Book",
-      "Start" => 1,
-      "Size" => 5,
-      "ProductSort" => "Bestselling",
-      "Keyword" => "Deleuze"
-    })
+                                'SearchType' => 'Book',
+                                'Start' => 1,
+                                'Size' => 5,
+                                'ProductSort' => 'Bestselling',
+                                'Keyword' => 'Deleuze'
+                              })
     refute_empty res.to_h
   end
 
   def test_get_text_book_rental_info
     res = @req.get_text_book_rental_info(query: {
-      "Ean" => "9781118230718"
-    })
+                                           'Ean' => '9781118230718'
+                                         })
     refute_empty res.to_h
   end
 
   def test_handles_unicode_characters
     res = @req.product_lookup(query: {
-      "ProductCode" => "Book",
-      "Ean" => "0942299663"
-    })
-    assert_equal "La Jetée", res.to_h["ProductLookupResponse"]["ProductLookupResult"]["Product"]["Titles"]["Title"]["title"]
+                                'ProductCode' => 'Book',
+                                'Ean' => '0942299663'
+                              })
+    assert_equal 'La Jetée', res.to_h['ProductLookupResponse']['ProductLookupResult']['Product']['Titles']['Title']['title']
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: barnesandnoble
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Diego Marquez
@@ -9,22 +9,8 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-23 00:00:00.000000000 Z
+date: 2020-03-05 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: multi_xml
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.5
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.5
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
@@ -40,13 +26,13 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
+  name: multi_xml
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -54,7 +40,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -68,7 +54,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -107,18 +93,16 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '1.9'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.3.0
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A Ruby wrapper for Barnes and Noble Product Web Services
 test_files:
 - test/test_barnesandnoble.rb
-has_rdoc: