barnesandnoble 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a4991de82e91c44e37e5d91313334fe9dd421944
-  data.tar.gz: 5db04af870e29db42b7cb005ced205bd7d198ced
+  metadata.gz: 1cc2f0b5a0447a44bae1e893748b26a0ee9d635a
+  data.tar.gz: 7041259521e6cbe055e7aae5a9472412a17a2d2b
 SHA512:
-  metadata.gz: 5339753b11efab7306d4138d1eeee5dd02caf848a18685c2c4d25c866531d89dbe147bbd6ab6a4e86516452a608a59f4bbf3811efe6ba315db32e38d237a6366
-  data.tar.gz: 48958577590bfb177a74f37d2cf5d35ab01e0991d40633e3249b0126e656e969282f75fe208634ff72cef88e93ee2c942d4f073ac6bb6f36d7ac1f53722a3b5b
+  metadata.gz: 09bbf24da68e256f3b587ff0fc16e03b9936f83b029155b598195f0abe91b13f8e70a6a5ea50af4d75ed0f61caabe1fe03df5ab9ff693b796de106925ce6ffe4
+  data.tar.gz: 1e7dd5a7aed443de6b6403408c2c31f21a1f576e5e6c19f6fcf1e6b714f382ce4c7aafcc01461e74f0148148700c655bbdac4f556d56a96d6a549a16a7a65ff5

data/README.md

@@ -1,74 +1,35 @@
-**BarnesAndNoble** is a Ruby wrapper to the Barnes and Noble Product Web Services
+# Barnesandnoble
 
-## Usage
-
-Set your API key in the environment variable BN_API_KEY
-
-### Create a request:
-
-```ruby
-req = BarnesAndNoble.new
-```
-#### Run a product lookup:
-
-```ruby
-params = {
-  'Ean' => 9781593083342,
-  'ProductCode' => 'Book'
-}
-res = req.get('ProductLookup', params)
-```
-
-#### Get categories for a product:
+**Barnesandnoble** is a Ruby wrapper to the Barnes and Noble Product Web Services.
 
-```ruby
-params = {
-  'Ean' => 9781593083342,
-  'ProductCode' => 'Book'
-}
-res = req.get('GetCategories', params)
-```
-
-#### Get related bought products:
+## Usage
 
-```ruby
-params = {
-  'Ean' => 9781593083342,
-  'ProductCode' => 'Book'
-}
-res = req.get('GetPwbab', params)
-```
+Set your API key with the environment variable `BN_API_KEY`.
 
-#### Get Top10 :
+Create a request:
 
 ```ruby
-params = {
-  'Top10SearchDomain' => 'Book',
-}
-res = req.get('Top10', params)
+request = Barnesandnoble.new
 ```
 
-#### Run a products search by keywords:
+Run a query:
 
 ```ruby
 params = {
-  'SearchType': 'Book',
-  'Start': 1,
-  'Size': 5,
-  'ProductSort': 'BestSelling'
-  'Keyword': 'Foucault'
+  "Ean" => 9781593083342,
+  "ProductCode" => "Book"
 }
-res = req.get('ProductSearch', params)
+response = request.product_lookup(query: params)
 ```
 
-Parse the response into a Ruby Hash:
+Parse the response into a Hash:
 
 ```ruby
-res.to_h
+response.to_h
 ```
 
-Or pass its body into a custom parser:
+Or pass it to a custom parser:
 
 ```ruby
-MyParser.new(res.body)
+MyParser.new(response.body)
 ```

data/lib/barnesandnoble.rb

@@ -1,7 +1,7 @@
-require 'forwardable'
-require 'barnesandnoble/request'
+require "forwardable"
+require "barnesandnoble/request"
 
-module BarnesAndNoble
+module Barnesandnoble
   class << self
     extend Forwardable
 

data/lib/barnesandnoble/request.rb

@@ -1,27 +1,52 @@
-require 'excon'
-require 'barnesandnoble/response'
-require 'uri'
+require "excon"
+require "barnesandnoble/response"
 
-module BarnesAndNoble
+module Barnesandnoble
   class Request
-    def initialize(app_id = ENV['BN_API_KEY'])
+    def initialize(app_id = ENV["BN_API_KEY"])
       @app_id = app_id
     end
 
-    def get(method, query, excon_options = {})
-      query['AppId'] = @app_id
+    underscore = ->(str) {
+      str.gsub(/(.)([A-Z\d])/,'\1_\2').downcase
+    }
 
-      Response.new(connection(method, query).get(excon_options))
-    end
+    %w(ProductLookup ProductSearch Top10 GetCategories GetPwbab)
+      .each do |operation|
+        define_method(underscore.(operation)) do |options|
+          get_product(operation, options)
+        end
+      end
+
+    %w(GetTextBookRentalInfo)
+      .each do |operation|
+        define_method(underscore.(operation)) do |options|
+          get_textbook(operation, options)
+        end
+      end
 
     private
 
-    def hash_to_query(hash)
-      '?' + URI.encode(hash.map{|k,v| "#{k}=#{v}"}.join("&"))
+    def get_textbook(operation, options)
+      request(operation, options.merge(
+        path: "/TextBookService/v01_00/#{operation}"
+      ))
+    end
+
+
+    def get_product(operation, options)
+      request(operation, options.merge(
+        path: "/v03_00/#{operation}"
+      ))
+    end
+
+    def request(operation, options)
+      options[:query]["AppId"] ||= @app_id
+      Response.new(http.get(options))
     end
 
-    def connection(request_type, query)
-      Excon.new("http://services.barnesandnoble.com/v03_00/#{request_type}#{hash_to_query(query)}", expects: 200)
+    def http
+      Excon.new("http://services.barnesandnoble.com", expects: 200)
     end
   end
 end

data/lib/barnesandnoble/response.rb

@@ -1,10 +1,10 @@
-require 'delegate'
-require 'multi_xml'
+require "delegate"
+require "multi_xml"
 
-module BarnesAndNoble
+module Barnesandnoble
   class Response < SimpleDelegator
     def body
-      __getobj__.body.force_encoding('ISO8859-1').encode('UTF-8')
+      __getobj__.body.force_encoding("ISO8859-1").encode("UTF-8")
     end
 
     def to_h

data/lib/barnesandnoble/version.rb

@@ -1,3 +1,3 @@
-module BarnesAndNoble
-  VERSION = '0.1.1'
+module Barnesandnoble
+  VERSION = "0.2.0"
 end

data/test/test_barnesandnoble.rb

@@ -1,71 +1,69 @@
-require 'minitest/autorun'
-require 'minitest/pride'
-require 'pry'
+require "minitest/autorun"
+require "minitest/pride"
+require "pry"
 
-require_relative '../lib/barnesandnoble'
+require_relative "../lib/barnesandnoble"
 
-class TestBarnesAndNoble < Minitest::Unit::TestCase
+class TestBarnesandnoble < Minitest::Test
   def setup
-    @req = BarnesAndNoble::Request.new
+    @req = Barnesandnoble.new
   end
 
   def test_product_lookup
-    res = @req.get('ProductLookup', {
-      'Ean' => '9781593083342',
-      'ProductCode' => 'Book'
+    res = @req.product_lookup(query: {
+      "Ean" => "9781593083342",
+      "ProductCode" => "Book"
     })
-
     refute_empty res.to_h
   end
 
   def test_get_categories
-    res = @req.get('GetCategories', {
-      'Ean' => '9781593083342',
-      'ProductCode' => 'Book'
+    res = @req.get_categories(query: {
+      "Ean" => "9781593083342",
+      "ProductCode" => "Book"
     })
-
     refute_empty res.to_h
   end
 
   def test_people_who_bought_also_bought
-    skip
-
-    # The query is correct, but this method doesn't seem to be working
-
-    res = @req.get('GetPwbab', {
-      'Ean' => '9780345546883',
-      'ProductCode' => 'Book'
+    skip("Does not work")
+    res = @req.get_pwbab(query: {
+      "Ean" => "9780345546883",
+      "ProductCode" => "Book"
     })
-
     refute_empty res.to_h
   end
 
   def test_top_10
-    res = @req.get('Top10', {
-      'Top10SearchDomain' => 'Book'
+    res = @req.top_10(query: {
+      "Top10SearchDomain" => "Book"
     })
-
     refute_empty res.to_h
   end
 
   def test_product_search
-    res = @req.get('ProductSearch', {
-      'SearchType' => 'Book',
-      'Start' => 1,
-      'Size' => 5,
-      'ProductSort' => 'Bestselling',
-      'Keyword' => 'Deleuze'
+    res = @req.product_search(query: {
+      "SearchType" => "Book",
+      "Start" => 1,
+      "Size" => 5,
+      "ProductSort" => "Bestselling",
+      "Keyword" => "Deleuze"
     })
+    refute_empty res.to_h
+  end
 
+  def test_get_text_book_rental_info
+    res = @req.get_text_book_rental_info(query: {
+      "Ean" => "9781118230718"
+    })
     refute_empty res.to_h
   end
 
   def test_handles_unicode_characters
-    res = @req.get('ProductLookup', {
-      'ProductCode' => 'Book',
-      'Ean' => '0942299663'
+    res = @req.product_lookup(query: {
+      "ProductCode" => "Book",
+      "Ean" => "0942299663"
     })
-
-    assert_equal 'La Jetée', res.to_h['ProductLookupResponse']['ProductLookupResult']['Product']['Titles']['Title']['title']
+    assert_equal "La Jetée", res.to_h["ProductLookupResponse"]["ProductLookupResult"]["Product"]["Titles"]["Title"]["title"]
   end
 end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: barnesandnoble
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Diego Marquez
+- Hakan Ensari
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-09 00:00:00.000000000 Z
+date: 2014-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_xml
@@ -16,82 +17,68 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.5.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: 0.5.5
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: dotenv-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.11'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.11'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -128,7 +115,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.3.0
 signing_key: 
 specification_version: 4
 summary: A Ruby wrapper for Barnes and Noble Product Web Services