barion 0.3.3 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aeb71eb691ad4f09c11b3f5246ad237236276876b06cc35889a48e8689f6a03c
-  data.tar.gz: 0eb0087ca813923da627c2bea6f9b8fc5d4e990aaf751d134c7077d578602b4b
+  metadata.gz: 575b950187d8de272065169bce30d830c4731761b4b25b9d7533e8899b2674dd
+  data.tar.gz: 4465db2681c4da8f1b8b4b01b6ef34158be8d7bacb02302eae779cd1fcff7985
 SHA512:
-  metadata.gz: f46e09f30aa52d8228347bf832dc8653f96fd14194dcc78e456f4ece99c02bde9496e0923829296e4b205f612bf20edc754a8d10419075f0cfed109b590f34e3
-  data.tar.gz: 798eec6a3fc31cded9b55ac1225855d918e522ec44272d956be3865f64effb0fd121110dd0bdef6250dfbfc0ae417c432b9a53f4be2cca1fc03956d9a70cd4d1
+  metadata.gz: ca9acdf451e26ab69a247b8098be1db3f8f43ffada9229a9f5e0378a6db5b8c8afcf720751de5117708d2372eefd3242fbe874d2abaed5c3cf1da7930a2c15b2
+  data.tar.gz: 5b708506775ecb6ecb647ceeafd1fcd0fb707447f78b77d922c91a1e66c9532d73b373376ec72a34c2db38e2a579166eb8ac1339ada8ee97809044484ad3e829

data/README.md

@@ -1,4 +1,5 @@
 # Barion
+
 ![Barion](https://github.com/Meter-reader/Barion/workflows/Ruby/badge.svg)
 [![codecov](https://codecov.io/gh/Meter-Reader/barion/branch/main/graph/badge.svg?token=DCOKCM7B2J)](https://codecov.io/gh/Meter-Reader/barion)
 [![Gem Version](https://badge.fury.io/rb/barion.svg)](https://badge.fury.io/rb/barion)
@@ -6,6 +7,7 @@
 This is a Ruby-on-Rails engine to use the Barion Payment Gateway in any RoR application.
 
 ## Installation
+
 Add this line to your application's Gemfile:
 
 ```ruby
@@ -13,42 +15,61 @@ gem 'barion'
 ```
 
 And then execute:
+
 ```bash
-$ bundle
+bundle
 ```
 
 Or install it yourself as:
+
 ```bash
-$ gem install barion
+gem install barion
 ```
+
 ## Usage
+
 ### Initalization
+
 After installing the gem you have to initalize it.
 Just create a file in `config/initializers/barion.rb` with the below content:
+
 ```ruby
 ::Barion.config do |shop|
   shop.poskey = ''
   shop.publickey = ''
+  shop.pixel_id = ''
   shop.sandbox = true
   shop.acronym = ''
   shop.default_payee = ''
 end
 ```
+
 #### POSKey and PublicKey (default: empty)
+
 You can find your `POSKey` and `PublicKey` at the  Barion Shop website:
 
-Test : https://secure.test.barion.com/Shop/
+Test : <https://secure.test.barion.com/Shop/>
 
-Production : https://secure.barion.com/Shop/
+Production : <https://secure.barion.com/Shop/>
 
 ![POSKey and PublicKey at Barion Shop](https://docs.barion.com/images/2/2b/Poskey.jpg "POSKey and PublicKey at Barion Shop")
 
 You have to open the shop Details from the `Action` dropdown of your shop. Please be aware that these values are different for Test and Production shops.
 
+#### Pixel ID (default: '')
+
+[Implementing the Base Barion Pixel](https://docs.barion.com/Implementing_the_Base_Barion_Pixel)
+
+Your Barion Pixel ID can be found in the Details page of your Barion shop. Every webshop (with a unique POSKey) has a different Barion Pixel ID. You can find your Barion Pixel ID in your Barion wallet: click `Manage my shops` menu, `Actions` next to your shop and then `Details`.
+
+
+
 #### Sandbox (default: true)
+
 It is **highly recommended** to use a Test shop first to tune the code first. That's why `sandbox` is set to **true** by default.
 
-#### Acronym (default: empyty)
+#### Acronym (default: empty)
+
 Acronym is used to generate the `payment_request_id` Barion requires to identify every payment request as the below code snippets shows. You can change this by overriding/decorating this method in your code.
 
 ```ruby
@@ -56,39 +77,49 @@ def create_payment_request_id
   self.payment_request_id = "#{::Barion.acronym}#{::Time.now.to_f.to_s.gsub('.', '')}" if payment_request_id.nil?
 end
 ```
+
 #### Default payee (Default: empty)
+
 Barion requires an e-mail address in every transaction to identify the recipient user of the transaction. The Barion wallet which has this e-mail address registeres will receives the money when the payment is completed by the payer.
 
 You can see this address in the Barion Shop interface below your shop icon on the top left corner.
 
 ### Set up your database
+
 This gem comes with predefined models. To use them, you have to copy the migrations into your application and migrate them using:
+
 ```bash
 bundle exec rails barion:install:migrations
 bundle exec rails db:migrate SCOPE=barion
 ```
 
 ### Mounting the engine
+
 You have to mount the Barion engine to be able to receive callback(s) from Barion Gateway like:
+
 ```ruby
 mount ::Barion::Engine, at: "/barion"
 ```
 
 ### Creating payment
+
 Once initialized you can create payments like below:
+
 ```ruby
 payment = ::Barion:Payment.new
 transaction = payment.transactions.build
 item = transaction.items.build
 ```
-* You can find the properties of Payment here: https://docs.barion.com/Payment-Start-v2,
 
-* for the properties of Transaction see here: https://docs.barion.com/PaymentTransaction
+* You can find the properties of Payment here: <https://docs.barion.com/Payment-Start-v2>,
+
+* for the properties of Transaction see here: <https://docs.barion.com/PaymentTransaction>
 (*Note*: Transaction is used not just for starting the payment but to collect transaction details during the payment lifecycle.)
 
-* and for Item properties: https://docs.barion.com/Item
+* and for Item properties: <https://docs.barion.com/Item>
 
 To check if all required properties are filled out you can use Rails built in validation:
+
 ```ruby
 unless payment.valid?
 payment.errors.object.each { |error|
@@ -97,9 +128,11 @@ payment.errors.object.each { |error|
 ```
 
 Once the payment is prepared you can start it by issuing
+
 ```ruby
 payment.execute
 ```
+
 This will send the required API requests to the Barion Gateway, depending on the `::Barion.sandbox` value either to the Test or the Production environment.
 
 When the payment started you will receive callback(s) from Barion Gateway when the state of your payment has been changed. There are several routes defined by this gem:
@@ -108,6 +141,7 @@ When the payment started you will receive callback(s) from Barion Gateway when t
 post 'callback', to: 'main#callback', as: :gateway_callback
 get 'land', to: 'main#land', as: :gateway_back
 ```
+
 The `gateway_callback` route will receive these callbacks from Barion Gateway. Every such message contains a `PaymentId` to identify which Payment has a state change. The gem is automatically tries to call a state refresh and get all the data of the payment from the Gateway.
 
 You can call this manually too by issuing:
@@ -115,23 +149,28 @@ You can call this manually too by issuing:
 ```ruby
 payment.refresh_state
 ```
-You can read more about this callback mechanism at https://docs.barion.com/Callback_mechanism.
+
+You can read more about this callback mechanism at <https://docs.barion.com/Callback_mechanism>.
 
 #### Payment successful
+
 When a payment is completed at the Barion Gateway it will automatically redirect the user back to your application. By default every payment request will held this redirect URL, which points to this gem's `:gateway_back` route.
 You can change this however by setting the URL in the actual payment when creating it.
 
 #### Payment failed
+
 When a payment hasn't been completed if will eventually timeout at the Gateway. But if there was an issue of
 
 ### Error handling
+
 The gem has a lightweight wrapper for errors that the Barion API reports.
 
 When executing a payment (or in fact any other method which has an API call behind) an error can happen which the Barion API returns.
 
 The gem will raise a ``::Barion::Error`` type exception when receives such error(s). If multiple errors are returned, the exception will have an `errors` property which will contains all errors in an array also wrapped by ``::Barion::Error``.
 
-``::Barion::Error`` has the folowinf properties:
+``::Barion::Error`` has the following properties:
+
 ```ruby
 error = ::Barion::Error.new
 error.title # Holds the value of Title attribute of the API error
@@ -143,14 +182,37 @@ error.endpoint # Holds the value of Endpoint attribute of the API error
 ```
 
 ### Security
+
 When a payment has been sent to the gateway it will become readonly for Rails. Only the Gateway is allowed to change its state trough the callbacks.
 
 To achieve this, a has is calculated for every payment when validating it. This hash will be stored in the DB and when a record is loaded in Rails it will be checked against the stored hash. If the hash does not match with the stored data a `::Barion::TamperedData` exception will be raised and the record will not be loaded. This basically mean that the data in the DB has been tampered outside this gem and cannot be considered financially safe.
 
 ## Contributing
-We encourage you to contribute to Barion gem!
+
+We encourage you to contribute to this Barion gem!
+To run tests:
+
+1. Fork the repository
+2. Check out your fork of this repo
+3. Set up rbenv and add rbenv-vars as plugin
+4. Set up your variables in .rbenv-vars like this:
+
+    ```ruby
+    CODECOV_TOKEN=<your token from Codecov.io>
+    TEST_PAYEE=<your registered test shop email address at Barion>
+    TEST_PIXEL_ID=<your test pixel id from Barion>
+    TEST_POSKEY=<your test poskey from Barion>
+    TEST_PUBKEY=<your test pubkey from Barion>
+    ```
+
+5. Run ``rails t`` to see if tests are working.
+6. start modifying the code and run tests all the time.
+7. Submit pull-request when done.
+
 ### Reporting issues or requesting features
+
 This gem uses [GitHub Issue Tracking](https://github.com/meter-reader/barion/issues) to track issues (primarily bugs and contributions of new code). If you've found a bug  or have a good idea of a cool feature, this is the place to start. You'll need to create a (free) GitHub account in order to submit an issue, to comment on them, or to create pull requests.
 
 ## License
+
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/app/helpers/barion/pixel_helper.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+# Barion related functions
+module Barion
+  # Adds Barion Pixel javascript to views
+  require 'action_view'
+  # Provides functions for Barion Pixel implementations in views
+  module PixelHelper
+    include ActionView::Helpers::TagHelper
+    def pixel_basic_js
+      javascript_tag %(
+      window["bp"] = window["bp"] || function () {(window["bp"].q = window["bp"].q || []).push(arguments);};
+      window["bp"].l = 1 * new Date();
+      scriptElement = document.createElement("script");
+      firstScript = document.getElementsByTagName("script")[0];
+      scriptElement.async = true;
+      scriptElement.src = 'https://pixel.barion.com/bp.js';
+      firstScript.parentNode.insertBefore(scriptElement, firstScript);
+      window['barion_pixel_id'] = '#{::Barion.pixel_id}';
+      // Send init event
+      bp('init', 'addBarionPixelId', window['barion_pixel_id']);'
+).gsub!(/^#{[/\A\s*/]}/, '')
+    end
+
+    def pixel_basic_noscript
+      tag.noscript do
+        tag.img height: 1, width: 1,
+                style: 'display:none',
+                alt: 'Barion Pixel',
+                src: "https://pixel.barion.com/a.gif?ba_pixel_id='#{::Barion.pixel_id}'&ev=contentView&noscript=1"
+      end
+    end
+
+    def pixel_basic_tags
+      pixel_basic_js + pixel_basic_noscript
+    end
+  end
+end

data/config/initializers/barion.rb

@@ -5,5 +5,6 @@
 #  shop.publickey = 'test2'
 #  shop.sandbox = true
 #  shop.acronym = ''
+#  shop.pixel_id = ''
 #  shop.default_payee = 'me@example.org'
 # end

data/config/routes.rb

@@ -1,8 +1,5 @@
 # frozen_string_literal: true
 
-# == Route Map
-#
-
 Barion::Engine.routes.draw do
   root to: 'main#land'
   post 'callback', to: 'main#callback', as: :gateway_callback

data/lib/barion/engine.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+# Module enclosing all Barion related functionality
 module Barion
   # Barion engine main class
   class Engine < ::Rails::Engine
@@ -11,4 +12,10 @@ module Barion
       g.factory_bot dir: 'test/factories'
     end
   end
+
+  ActiveSupport.on_load(:action_view) do
+    # self refers to ActiveRecord::Base here,
+    # so we can call .include
+    include ::Barion::PixelHelper
+  end
 end

data/lib/barion/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Barion
-  VERSION = '0.3.3'
+  VERSION = '0.4.0'
 end

data/lib/barion.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'barion/engine'
+require 'barion/engine' if defined?(Rails::Engine)
 
 # Main module of Barion engine
 module Barion
@@ -9,21 +9,42 @@ module Barion
     prod: 'https://api.barion.com'
   }.freeze
 
+  PIXELID_PATTERN = ::Regexp.new('BP-\d{10}-\d{2}').freeze
+
+  # rubocop:disable Style/ClassVars
   mattr_accessor :poskey, default: nil
   mattr_accessor :publickey, default: nil
   mattr_accessor :acronym, default: ''
+  mattr_accessor :pixel_id, default: ''
   mattr_accessor :sandbox, default: true
   mattr_accessor :default_payee
   mattr_accessor :user_class
   mattr_accessor :item_class
   mattr_accessor :rest_client_class, default: '::RestClient::Resource'
 
+  def self.poskey=(key)
+    raise ArgumentError, "::Barion.poskey must be set to a String, got #{key.inspect}" unless key.is_a?(String)
+
+    @@poskey = key
+  end
+
   def self.sandbox?
-    !!sandbox
+    sandbox
   end
 
-  def sandbox=(val)
-    super(!!val)
+  def self.sandbox=(val)
+    @@sandbox = !!val
+  end
+
+  def self.pixel_id=(id)
+    raise ArgumentError, "::Barion.pixel_id must be set to a String, got #{id.inspect}" unless id.is_a?(String)
+
+    if PIXELID_PATTERN.match(id).nil?
+      raise ::ArgumentError,
+            "String:'#{id}' is not in Barion Pixel ID format: 'BP-0000000000-00'"
+    end
+
+    @@pixel_id = id
   end
 
   def self.endpoint
@@ -31,7 +52,6 @@ module Barion
     rest_client_class.new BASE_URL[env]
   end
 
-  # rubocop:disable Style/ClassVars
   def self.user_class=(class_name)
     unless class_name.is_a?(String)
       raise ArgumentError, "Barion.user_class must be set to a String, got #{class_name.inspect}"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: barion
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.0
 platform: ruby
 authors:
 - Péter Nagy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-02-13 00:00:00.000000000 Z
+date: 2024-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -38,118 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.1'
-- !ruby/object:Gem::Dependency
-  name: faker
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '5.0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: solargraph
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.44'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.44'
-- !ruby/object:Gem::Dependency
-  name: sqlite3
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.4'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '6.0'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.12'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.9'
 description: "  This is a Ruby-on-Rails engine to use the Barion Payment Gateway in
   any RoR application.\n"
 email:
@@ -168,6 +56,7 @@ files:
 - app/controllers/barion/main_controller.rb
 - app/helpers/barion/application_helper.rb
 - app/helpers/barion/main_helper.rb
+- app/helpers/barion/pixel_helper.rb
 - app/models/barion/address.rb
 - app/models/barion/application_record.rb
 - app/models/barion/gift_card_purchase.rb
@@ -207,14 +96,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.7.0
+      version: 3.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
+rubygems_version: 3.5.3
 signing_key: 
 specification_version: 4
 summary: Barion payment engine for Ruby on Rails