barefoot_js 0.39.7 → 0.39.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f2dee751fa656f2231c7d6cee7f3ab165f508ad988a58c0930419dbc3de1132e
-  data.tar.gz: 5ecd00ba7237eac6ef23a9172e53c9b7968077d6097080ba86c0759c8b9dfc64
+  metadata.gz: 727248cd6dcc7a533846854d5a8d4675ac946390d5750df49b03e25dad8cd3e5
+  data.tar.gz: 508a38a3a2d56d99af75875be59b6989103ab3adf3fe6e42bae3e040cd69d608
 SHA512:
-  metadata.gz: 8c781e4df474f753e1c58fe3c1e2e25ca7cf1af53fdae23909e98cc5382d3156103abac6ca4d97ce78a180d64213c52aec0e2674cc56f5e7250ced001843ef6f
-  data.tar.gz: 7e96d3a6a087381bce7afcb51f746f82bc6276b465cce68b57f8ac978dd32c960ada3b846fb0e11652a7c79c0511de41068fb5b831f229ba672fc0ae62f5a790
+  metadata.gz: e91debd9fe87d53e154cd53a7be218efd5c3dec07e64f3b57cb3c4cd0d2406f1a5846f84bde2d9cb49f73a5236c6979649e89f50879f2511e31dda9191ed060b
+  data.tar.gz: 5b617131eebba68e976d362993fba1f85e8cadd86fff1258ab029d44a4bdbdf64013aa3b8d739229deff1497c411af7205e016b05ff1bfbf877cf85b2ab27e22

data/lib/barefoot_js/evaluator.rb

@@ -286,6 +286,26 @@ module BarefootJS
       to_number(l).to_f / to_number(r).to_f
     end
 
+    # JS `%`: the truncated remainder, which takes the dividend's sign
+    # (`-7 % 2` -> -1) and keeps a fraction (`7.5 % 2` -> 1.5); Ruby's `%`
+    # floors instead (`-7 % 2` -> 1). A zero divisor, or a NaN / infinite
+    # dividend, gives NaN. Two Integer operands keep an Integer result, as
+    # Ruby's own `%` did, except for a zero remainder of a negative dividend:
+    # JS gives -0 there (`-4 % 2`), which only shows through later
+    # arithmetic (`1 / (-4 % 2)` is -Infinity), so it is the Float -0.0. An
+    # Array still takes it as index 0 and `number_to_string` spells it "0".
+    # Shared by callback-body evaluation (`binary`) and the template-emitted
+    # remainder (`Context#mod`, #3474).
+    def remainder(l, r)
+      ln = to_number(l)
+      rn = to_number(r)
+      return Float::NAN if rn.zero?
+      return ln.to_f.remainder(rn.to_f) unless ln.is_a?(Integer) && rn.is_a?(Integer)
+
+      m = ln.remainder(rn)
+      m.zero? && ln.negative? ? -0.0 : m
+    end
+
     def binary(op, l, r)
       case op
       when '+'
@@ -297,9 +317,7 @@ module BarefootJS
       when '-' then to_number(l) - to_number(r)
       when '*' then to_number(l) * to_number(r)
       when '/' then divide(l, r)
-      when '%'
-        rn = to_number(r).to_f
-        rn.zero? ? Float::NAN : to_number(l).to_f.remainder(rn)
+      when '%' then remainder(l, r)
       when '<', '<=', '>', '>=' then relational(op, l, r)
       when '===' then strict_eq(l, r)
       when '!==' then !strict_eq(l, r)

data/lib/barefoot_js.rb

@@ -530,6 +530,15 @@ module BarefootJS
       Evaluator.divide(left, right)
     end
 
+    # JS `%`: the truncated remainder, which takes the dividend's sign
+    # (`-7 % 2` -> -1). Ruby's `%` floors (`-7 % 2` -> 1), so
+    # template-emitted remainders go through the shared evaluator's JS
+    # remainder instead: a fraction is kept, and a zero divisor gives NaN
+    # rather than raising (#3474).
+    def mod(left, right)
+      Evaluator.remainder(left, right)
+    end
+
     # JS truthiness (falsy: false, nil, 0, NaN, ""). Delegates to the
     # shared evaluator so template-emitted conditionals
     # (`if bf.truthy?(x)`) and callback-body evaluation agree byte-for-byte.

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: barefoot_js
 version: !ruby/object:Gem::Version
-  version: 0.39.7
+  version: 0.39.8
 platform: ruby
 authors:
 - kobaken