bard-attachment_field 0.6.1 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6bef7d86b4bd8938fe4944c96dde471a868af65c72817f254bad2ef989840eb3
-  data.tar.gz: b40d5ad52b14aa85e4a695dbc7f2aaa58cf2ae6d75b11860100a7818805a1e51
+  metadata.gz: edba1eefd3a08f4e68003f8fdb54f1c56d182c7fa7861a3a776a0bc03b144720
+  data.tar.gz: fe58cfe7d8528cb324bcce8b2b5dc5c786a9ab25e8f05cf24673a6f87e6b8542
 SHA512:
-  metadata.gz: 8907713c89cfab1718f7a812a23c49b604abe65e4a613669760f63d8a22790ffaed0ac19af0682262237a9557d3c45221f7c5f4ede50255cbec48564e412418f
-  data.tar.gz: cf825d567f49628992b93247ac2668b6adf35204dda72c0aa1701fe537bf247d9214bfb14d688e64d2e4593e70b4720dc449d3a345c1d4451ccaf62b48243395
+  metadata.gz: d3d9fc5faa9d0d7b195e7c15dce24fc9484644da25df67adb254362927d397ddd409de1a0a8e023f9e91c060633219a9bd3456a20c146973947ebcd38d8deba7
+  data.tar.gz: 134d8975835697d189f17da80a3aaa1832b115b0b7d632245acd5d29f9ae24a05de4cef61110097dae50bbbbee25465ef6aebc89de74b7dbbb784121792a62f3

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [0.6.2] - 2026-07-23
+
+### Bug Fixes
+
+- Clicking a `<video>` preview to play/pause no longer opens the file picker.
+  The click handler now stops propagation so it doesn't bubble to the
+  `<file-drop>` wrapper, which opens the upload dialog on click.
+
 ## [0.6.1] - 2026-06-24
 
 ### Bug Fixes

data/app/assets/javascripts/input-attachment.js

@@ -4087,7 +4087,7 @@ var a = proxyCustomElement(class extends H {
   src;
   filetype;
   render() {
-    return h(Host, { key: "429f17fda03ded975255da6335ba23a663ee662e", class: this.computeClass() }, this.isImage() && h("img", { key: "daa4e38cb1375db7d8852ab1cb401f048efbbdc7", src: this.src }), this.isVideo() && h("video", { key: "1b7860bc3edf2f4ba4951dd0bd8a88f14db078a0", src: this.src, onClick: n }), this.isOther() && "This file does not offer a preview", h("slot", { key: "b8a894bcc9ae11619d543b20f2bd2ee9167616d8" }));
+    return h(Host, { key: "429f17fda03ded975255da6335ba23a663ee662e", class: this.computeClass() }, this.isImage() && h("img", { key: "daa4e38cb1375db7d8852ab1cb401f048efbbdc7", src: this.src }), this.isVideo() && h("video", { key: "1b7860bc3edf2f4ba4951dd0bd8a88f14db078a0", src: this.src, onClick: c }), this.isOther() && "This file does not offer a preview", h("slot", { key: "b8a894bcc9ae11619d543b20f2bd2ee9167616d8" }));
   }
   computeClass() {
     return this.isImage() ? "image" : this.isVideo() ? "video" : "other";
@@ -4105,8 +4105,8 @@ var a = proxyCustomElement(class extends H {
     return ":host{display:block;font-size:13px}img,video{max-width:100%;margin-top:10px}";
   }
 }, [769, "attachment-preview", { src: [513], filetype: [513] }]);
-var n = function() {
-  return this.paused ? this.play() : this.pause(), false;
+var c = function(e3) {
+  e3.stopPropagation(), this.paused ? this.play() : this.pause();
 };
 
 // dist/components/attachment-file2.js

data/input-attachment/src/components/attachment-preview/attachment-preview.e2e.ts

@@ -8,4 +8,31 @@ describe('attachment-preview', () => {
     const element = await page.find('attachment-preview');
     expect(element).toHaveClass('hydrated');
   });
+
+  it('does not bubble video preview clicks to ancestor upload handlers', async () => {
+    const page = await newE2EPage();
+    await page.setContent(`
+      <div id="drop">
+        <attachment-preview filetype="video" src="data:video/mp4;base64,AAAA"></attachment-preview>
+      </div>
+    `);
+    await page.evaluate(() => {
+      (window as any).ancestorClicked = false;
+      document
+        .getElementById('drop')
+        .addEventListener('click', () => { (window as any).ancestorClicked = true; });
+      const video = document
+        .querySelector('attachment-preview')
+        .shadowRoot.querySelector('video') as any;
+      video.play = () => Promise.resolve();
+      video.pause = () => {};
+    });
+
+    const video = await page.find('attachment-preview >>> video');
+    await video.click();
+    await page.waitForChanges();
+
+    const ancestorClicked = await page.evaluate(() => (window as any).ancestorClicked);
+    expect(ancestorClicked).toBe(false);
+  });
 });

data/input-attachment/src/components/attachment-preview/attachment-preview.tsx

@@ -39,4 +39,7 @@ export class AttachmentPreview {
   }
 }
 
-const toggle = function() { this.paused ? this.play() : this.pause(); return false }
+const toggle = function(event) {
+  event.stopPropagation()
+  this.paused ? this.play() : this.pause()
+}

data/lib/bard/attachment_field/cucumber.rb

@@ -92,7 +92,7 @@ module Bard::AttachmentField::TestHelper
   end
 
   def get_files(field)
-    field.all("attachment-file").map { |e| e[:filename] }
+    field.all("attachment-file", minimum: 0).map { |e| e[:filename] }
   end
 
   def validation_messages(session, element)

data/lib/bard/attachment_field/version.rb

@@ -2,6 +2,6 @@
 
 module Bard
   module AttachmentField
-    VERSION = "0.6.1"
+    VERSION = "0.6.3"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bard-attachment_field
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.3
 platform: ruby
 authors:
 - Micah Geisel
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-06-24 00:00:00.000000000 Z
+date: 2026-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activestorage