bard-attachment_field 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b56542b6ac4750d33522c0dc996d1ae7f1bb772c29d455a04202f8c2a980a5b2
-  data.tar.gz: c114839ed9845fe0dd49f72498964bc6f5f88a8fee27c96ba9a77366087bfc84
+  metadata.gz: 32a9e349c2ce7715b8a5732e730bbd96efb6c50f542b0f39fd470a1b39b2952e
+  data.tar.gz: 1da2861ccab4b81ffc92f0dc6b933c9266b07ba2b96747469d3030de9f44f9f2
 SHA512:
-  metadata.gz: 15d3778a7d97bea1e1433e42ceee7df8c31be1b2d1cd2879de577d5468592ead3fe142822a28de716870493bc9bfb869f21dc0ddfc99faa545b62f7a6b9e6323
-  data.tar.gz: 8d304feeaf8a31f2ef5b3731c58f9e683be9bd9a42039b40dd95c7f573cf969878fd35e8b1b17388b415fca6ccf737c0fe2a1bd9ac6bf2eca2ad6db3b9f542e5
+  metadata.gz: 26808a1afc2c0156726a2fb3443a600efb194bdf87ad4d9a284896e0a53ed24ba3cae9170875fa7bb27cc933de8eafa71fc5116669531ab3431329c59ec6c323
+  data.tar.gz: 0f48786c5c1eea01995a6e8d04e41f3cb24c5866456b99068d1a4cf6bbedf41e5879df2d02b4f28b02bb5b939f454a9230e2f7bf7e0a49c5a09ef618b200a2cd

data/lib/bard/attachment_field/cucumber.rb

@@ -62,6 +62,17 @@ module Bard::AttachmentField::TestHelper
     end
   end
 
+  def wait_for_no_files(session, element_id, selector = "attachment-file", timeout: 10)
+    start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+    loop do
+      count = session.evaluate_script("document.getElementById('#{element_id}').querySelectorAll('#{selector}').length")
+      break if count == 0
+      elapsed = Process.clock_gettime(Process::CLOCK_MONOTONIC) - start
+      raise "Expected no #{selector} in ##{element_id}, found #{count} after #{timeout}s" if elapsed > timeout
+      sleep 0.1
+    end
+  end
+
   def wait_for_upload(session, element_id, timeout: 30)
     start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
     loop do
@@ -189,11 +200,7 @@ When "I remove the file from {string}" do |field|
       removeLink.click();
     })(arguments[0])
   JS
-  # Wait for the file to be removed (refetch element to avoid stale reference)
-  page.document.synchronize(5, errors: [Capybara::ElementNotFound]) do
-    fresh_element = page.find("##{element_id}")
-    expect(fresh_element).to have_no_css("attachment-file")
-  end
+  Bard::AttachmentField::TestHelper.wait_for_no_files(page, element_id)
 end
 
 When "I remove {string} from {string}" do |filename, field|
@@ -208,11 +215,7 @@ When "I remove {string} from {string}" do |filename, field|
       removeLink.click();
     })(arguments[0], arguments[1])
   JS
-  # Wait for the file to be removed (refetch element to avoid stale reference)
-  page.document.synchronize(5, errors: [Capybara::ElementNotFound]) do
-    fresh_element = page.find("##{element_id}")
-    expect(fresh_element).to have_no_css("attachment-file[filename='#{filename}']")
-  end
+  Bard::AttachmentField::TestHelper.wait_for_no_files(page, element_id, "attachment-file[filename='#{filename}']")
 end
 
 When "I remove {string} from the {string} field" do |filename, field|
@@ -226,10 +229,7 @@ When "I remove {string} from the {string} field" do |filename, field|
       removeLink.click();
     })(arguments[0], arguments[1])
   JS
-  page.document.synchronize(5, errors: [Capybara::ElementNotFound]) do
-    fresh_element = page.find("##{element_id}")
-    expect(fresh_element).to have_no_css("attachment-file[filename='#{filename}']")
-  end
+  Bard::AttachmentField::TestHelper.wait_for_no_files(page, element_id, "attachment-file[filename='#{filename}']")
 end
 
 When "I drag the file {string} onto the {string} attachment field" do |path, field|

data/lib/bard/attachment_field/version.rb

@@ -2,6 +2,6 @@
 
 module Bard
   module AttachmentField
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bard-attachment_field
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Micah Geisel