barcodevalidation 2.6.0 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba3b5afd4aee1020e30233ec636f17390d4ce3b0683f485e26811d84afe9e7e5
-  data.tar.gz: 1c533193d00fad326a78342876b42f15b5a4534d0cd4c47451962687c2dce95e
+  metadata.gz: b6949efb809df8a20b1d2816bd27f5fada9ed3273f5ed52e1008c85169a29151
+  data.tar.gz: 120483828346597e8e418737d8bba2f7348104117008caf2e69245720f4f9eaa
 SHA512:
-  metadata.gz: f295608b02b3ce172d58b45572db6f1c0d566d55fa9277b59c1ba34098503d1bc9513cbb00c785169ff342a242c29c5398771bc578d23ce348c69984c90e84fe
-  data.tar.gz: 5784a212986f8973bd2e7d5bcfc473c0b61c9c92c194d966f554e86dedbf92943cf7766a89debe4ee0428967ab6e138b87b8b309a79c85b0fbdcc3b766ae31ac
+  metadata.gz: 451437593aad8dbf1ccd2c180be239c5b87c7503760cccae4e37583e1fdde899ddcbd8b3a3ab5eb4b53a1e1c6e6f7c3ae7c5155bfab6bd2ea83839c6da092a47
+  data.tar.gz: 84024a6d521aa3dbe7a205d37fbb3f7c5efaec448fb2ab6d43a8b4e58b2d9ccae349ba91020cec18f2d02a4806a8ff646a6eb33e1494dd5f2476d50335a6675a

data/README.md

@@ -134,11 +134,10 @@ bin/rake
 
 #### Code Quality Checks
 
-Rubocop is used to enforce coding standards.
+[StandardRB](https://github.com/standardrb/standard) is used to enforce coding standards.
 
 ```
-bin/rubocop
-bin/rubocop --help
+bin/standardrb
 ```
 
 
@@ -163,7 +162,7 @@ Gem, created using `bundler gem barcodevalidation`.
     * `bundle`: Runs Bundler, in the correct way
     * `console`: development console (equiv. to `bin/bundle exec pry`)
     * `rake`: Runs Rake (equivalent to `bin/bundle exec rake`)
-    * `rubocop`: Runs Rubocop (equivalent to `bin/bundle exec rubocop`)
+    * `standardrb`: Runs standardrb (equivalent to `bin/bundle exec standardrb`)
     * `setup`: Sets up the project to be ready for development
 * `config/boot.rb`: Prepares dependencies before loading the library
 * `lib/`: Source files; this directory is added to Ruby's load path

data/barcodevalidation.gemspec

@@ -5,23 +5,23 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "barcodevalidation/version"
 
 Gem::Specification.new do |spec|
-  spec.required_ruby_version = ">= 2.5"
-  spec.name          = "barcodevalidation"
-  spec.version       = BarcodeValidation::VERSION
-  spec.authors       = ["Marketplacer"]
-  spec.email         = ["it@marketplacer.com"]
+  spec.required_ruby_version = ">= 3.1"
+  spec.name = "barcodevalidation"
+  spec.version = BarcodeValidation::VERSION
+  spec.authors = ["Marketplacer"]
+  spec.email = ["it@marketplacer.com"]
 
-  spec.summary       = "Parses and validates barcodes"
-  spec.description   = "A RubyGem to parse and validate barcodes"
-  spec.homepage      = "https://github.com/marketplacer/#{spec.name}"
-  spec.license       = "MIT"
+  spec.summary = "Parses and validates barcodes"
+  spec.description = "A RubyGem to parse and validate barcodes"
+  spec.homepage = "https://github.com/marketplacer/#{spec.name}"
+  spec.license = "MIT"
 
-  spec.files         = %w[LICENSE.md README.md barcodevalidation.gemspec
-                          config/*.rb lib/**/*.rb]
-                       .flat_map { |pattern| Dir.glob(pattern) }
-                       .reject { |f| File.directory?(f) }
-  spec.bindir        = "exe"
-  spec.executables   = spec.files
-                           .grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.files = %w[LICENSE.md README.md barcodevalidation.gemspec
+    config/*.rb lib/**/*.rb]
+    .flat_map { |pattern| Dir.glob(pattern) }
+    .reject { |f| File.directory?(f) }
+  spec.bindir = "exe"
+  spec.executables = spec.files
+    .grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 end

data/config/boot.rb

@@ -24,9 +24,9 @@ require "pathname"
 project_root = Pathname.new(__FILE__).parent.parent
 
 # Add lib directory to load path
-lib = project_root + "lib"
+lib = project_root / "lib"
 $LOAD_PATH.unshift(lib.to_s) unless $LOAD_PATH.include?(lib.to_s)
 
 # Tell Bundler explicitly which Gemfile to use
-ENV["BUNDLE_GEMFILE"] ||= (project_root + "Gemfile").to_s
+ENV["BUNDLE_GEMFILE"] ||= (project_root / "Gemfile").to_s
 require "bundler"

data/lib/barcodevalidation/digit.rb

@@ -18,7 +18,7 @@ module BarcodeValidation
       raise Digit::ArgumentError, input
     end
 
-    alias to_i __getobj__
+    alias_method :to_i, :__getobj__
 
     ArgumentError = Error::ArgumentErrorClass.new(self)
   end

data/lib/barcodevalidation/digit_sequence.rb

@@ -31,6 +31,10 @@ module BarcodeValidation
       end
     end
 
+    def all_zeros?
+      all? { |digit| digit.to_i.zero? }
+    end
+
     def *(other)
       self.class.new(super)
     end

data/lib/barcodevalidation/error/argument_error_class.rb

@@ -15,7 +15,7 @@ module BarcodeValidation
       end
 
       def initialize(input)
-        super "invalid value for #{klass}(): #{input.inspect}"
+        super("invalid value for #{klass}(): #{input.inspect}")
       end
     end
   end

data/lib/barcodevalidation/gtin/base.rb

@@ -30,11 +30,15 @@ module BarcodeValidation
       # Upon inheritance, register the subclass so users of the library can dynamically add more GTINs in their own code.
       def self.inherited(subclass)
         BarcodeValidation::GTIN.append_gtin_class(subclass)
+        super
       end
 
       # Ensure this class is earlier in the GTIN classes list than +other_gtin_class+ and thus will get asked earlier if it handles a GTIN.
       def self.prioritize_before(other_gtin_class)
-        raise ArgumentError, "The class you want to prioritize before is not a registered prioritized GTIN class." unless GTIN.gtin_class?(other_gtin_class)
+        unless GTIN.gtin_class?(other_gtin_class)
+          raise ArgumentError,
+            "The class you want to prioritize before is not a registered prioritized GTIN class."
+        end
 
         GTIN.reprioritize_before(self, other_gtin_class)
       end
@@ -48,11 +52,16 @@ module BarcodeValidation
       abstract_class
 
       def valid?
-        valid_length == length && check_digit.valid?
+        valid_length == length && !all_zeros? && check_digit.valid?
       end
 
       def valid_length
-        raise(AbstractMethodError, "Concrete classes must define the VALID_LENGTH constant") unless self.class.const_defined?(:VALID_LENGTH)
+        unless self.class.const_defined?(:VALID_LENGTH)
+          raise(
+            AbstractMethodError,
+            "Concrete classes must define the VALID_LENGTH constant"
+          )
+        end
 
         self.class::VALID_LENGTH
       end
@@ -64,7 +73,7 @@ module BarcodeValidation
           to_gtin_8,
           to_gtin_12,
           to_gtin_13,
-          to_gtin_14,
+          to_gtin_14
         ].select(&:valid?)
       end
 
@@ -112,14 +121,14 @@ module BarcodeValidation
       # BarcodeValidation::InvalidGTIN with valid? = false and a meaningful
       # error message.
       def transcode_to(klass)
-        gtin = klass.new(format("%0#{klass::VALID_LENGTH}d", to_s.gsub(/^0+/, "")))
+        gtin = klass.new(format("%0#{klass::VALID_LENGTH}d", to_s.gsub(/^0+(?=.)/, "")))
 
         if gtin.valid?
           gtin
         else
           BarcodeValidation::InvalidGTIN.new(
             input,
-            error: klass::ConversionError.new(klass).exception(input),
+            error: klass::ConversionError.new(klass).exception(input)
           )
         end
       end

data/lib/barcodevalidation/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BarcodeValidation
-  VERSION = "2.6.0"
+  VERSION = "2.7.0"
 end

data/lib/barcodevalidation.rb

@@ -34,7 +34,7 @@ module BarcodeValidation
     include Error
 
     def initialize(input)
-      super "Invalid GTIN #{input.inspect}"
+      super("Invalid GTIN #{input.inspect}")
     end
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: barcodevalidation
 version: !ruby/object:Gem::Version
-  version: 2.6.0
+  version: 2.7.0
 platform: ruby
 authors:
 - Marketplacer
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-29 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies: []
 description: A RubyGem to parse and validate barcodes
 email:
@@ -42,7 +41,6 @@ homepage: https://github.com/marketplacer/barcodevalidation
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -50,15 +48,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '3.1'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.33
-signing_key:
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Parses and validates barcodes
 test_files: []